From nobody Mon Feb 9 11:42:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1748590087; cv=none; d=zohomail.com; s=zohoarc; b=dvRDFG/bLi/wOvwPwbxz23ZlVH+yyGABIQ9356JNHsiXocuUsH0BKYmxEDyqywvkWdFx+t1vrNzAhwNPo3PPgaI4gJHqj6RgRp3K0EXFsqPtWOroH70GqYmAnStpjaBOo06Kh5cw6gqY7Z7dkXhSlAENLPnC7cnmEQgx9VxHDiE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748590087; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Y8JL4a/QH+idHUyhD5rOXKxxtpM2ciU8EHs2uhh+XJs=; b=a8aYN/eMNfEyfeLfh6SntZhkNxKnr1ZnpfYnoUb5nr4CyHvPU6mQz1No/uopgcHzrwCPcdeNRvbkiD59NYMmbarby2iHYhj5+E6Vs/PypnyGGHEPr2y7j2DTiw3xz1ibAQZIeq+safCG5U3zqqPzv+YkkcBcnqL7qXSNNQgZn8M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1748590087074877.5216655710182; Fri, 30 May 2025 00:28:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uKtxI-0003EL-JG; Fri, 30 May 2025 03:15:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKtwt-0002VW-45 for qemu-devel@nongnu.org; Fri, 30 May 2025 03:14:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKtwr-0006zI-8s for qemu-devel@nongnu.org; Fri, 30 May 2025 03:14:38 -0400 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-s9Znqwq6OnWQK2yL5Gaf-g-1; Fri, 30 May 2025 03:14:34 -0400 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-604bc87037fso2083150a12.2 for ; Fri, 30 May 2025 00:14:34 -0700 (PDT) Received: from [192.168.122.1] ([151.49.64.79]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60566c74edcsm1191057a12.39.2025.05.30.00.14.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 May 2025 00:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748589276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y8JL4a/QH+idHUyhD5rOXKxxtpM2ciU8EHs2uhh+XJs=; b=W/fMXh/cR/4FykXd59vENlcE6raU+MvItlS4I4JeIWw6bwhOk+a/tOM4jIqZ78/HN9RAG3 j9syQ/Io8ayOx6mvL7+uAJHHNimBz0+lTrTlVR7IhtfIa3TlK5xQ+8urAMozBp09iBYdmO rElvV63g7uJwgFaIBInbeJzY1jthw3E= X-MC-Unique: s9Znqwq6OnWQK2yL5Gaf-g-1 X-Mimecast-MFC-AGG-ID: s9Znqwq6OnWQK2yL5Gaf-g_1748589273 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748589273; x=1749194073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y8JL4a/QH+idHUyhD5rOXKxxtpM2ciU8EHs2uhh+XJs=; b=MtbDdg635UUNeLGM7uAqUxAqwujuAObSksq0/WFMrfan7cToq1hjGEPvNkwxiKeUau N9bAPtC1Hi/U7HJvv1UXA+J2mzk8aoDbka5V3dSnSyo91O4d7FyF3JlIhfWE3pqYMvtY QgLUMsgcBkmW/uaoBRAMPT533rRKQRMtXy6WTXexYThchUO9pxdHLG8BRTxtLms7R+b0 e3g7FezJiq3pz4Ao7p9swLAlAE+Gn+JqciVuhc7ba5K34oQSpj/6cra91YYb11IBUszP sQznEh0PySUgzfxlIl1MPOdUFT3I7H9aztm7cBNpzv83GXvRtuBb90xbPrc+akpJhQ1i D01w== X-Gm-Message-State: AOJu0YyFFbbP6jiJxKB7XAvXYmRbkiMMNCamtxSl5TEDm/GxU6agQRSn N0OkmiMhmDCZRvq69y2C7bMVozb7UeC1MSsvIS4alTjQE47mxt7XVwwARJf9UNsthz2TuJuzczc yzpwkwpTznh/Kit1KNTCCHZH2Q4tau873fVQ6k2kTYL6CZrQTEE9Dr8ES/B5iyvURFAHP5WnJES RIknK0V1hhwzZ60avop/CewP4Cr21/Gshhfp+6XetV X-Gm-Gg: ASbGncsHGIRpKl/7K6sMOJUW7pXw9qW4/TCzJX1T3qeGYSE7sMTsVvbXpiiKFwlFTpm hmp+9iZnOUc/4L1PvaRwVMhRXFiRV0p0Mvpl/XyArjDzXSbVkcfO7BvxO9536zYR61QT8Mlq/u7 VPfJbwOFKduwCGuJpr8eCFCs9ijbxZbGVjb1WGLEVKGnFKlcwc2l4srKHJWn90Oy7Nvk2Cyd4Ha FUxwZvdrTnXghjeHVZ05wPjeKpodAVW3Q7iYOkK6VroBGlUe+jSyDeOjGY6T4zoEKSnxU30hFfC DpOjI3zgwNcnIg== X-Received: by 2002:a05:6402:2113:b0:605:3251:a503 with SMTP id 4fb4d7f45d1cf-6057c60464amr1024212a12.20.1748589272689; Fri, 30 May 2025 00:14:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZFexz0DQgTq1g0nLJbgUH+NXblh+XnxqhMfCCOVZatMiKfHu+Jai0H9TnfHYo+a0Od7LQIQ== X-Received: by 2002:a05:6402:2113:b0:605:3251:a503 with SMTP id 4fb4d7f45d1cf-6057c60464amr1024198a12.20.1748589272212; Fri, 30 May 2025 00:14:32 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Xiaoyao Li , Zhao Liu Subject: [PULL 40/77] i386/tdx: Handle KVM_SYSTEM_EVENT_TDX_FATAL Date: Fri, 30 May 2025 09:12:10 +0200 Message-ID: <20250530071250.2050910-41-pbonzini@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250530071250.2050910-1-pbonzini@redhat.com> References: <20250530071250.2050910-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -49 X-Spam_score: -5.0 X-Spam_bar: ----- X-Spam_report: (-5.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.902, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1748590087963116600 Content-Type: text/plain; charset="utf-8" From: Xiaoyao Li TD guest can use TDG.VP.VMCALL to request termination. KVM translates such request into KVM_EXIT_SYSTEM_EVENT with type of KVM_SYSTEM_EVENT_TDX_FATAL. Add hanlder for such exit. Parse and print the error message, and terminate the TD guest in the handler. Signed-off-by: Xiaoyao Li Reviewed-by: Zhao Liu Link: https://lore.kernel.org/r/20250508150002.689633-29-xiaoyao.li@intel.c= om Signed-off-by: Paolo Bonzini --- target/i386/kvm/tdx.h | 2 ++ target/i386/kvm/kvm.c | 10 +++++++++ target/i386/kvm/tdx-stub.c | 5 +++++ target/i386/kvm/tdx.c | 46 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 63 insertions(+) diff --git a/target/i386/kvm/tdx.h b/target/i386/kvm/tdx.h index 36a7400e748..04b5afe199f 100644 --- a/target/i386/kvm/tdx.h +++ b/target/i386/kvm/tdx.h @@ -8,6 +8,7 @@ #endif =20 #include "confidential-guest.h" +#include "cpu.h" #include "hw/i386/tdvf.h" =20 #define TYPE_TDX_GUEST "tdx-guest" @@ -59,5 +60,6 @@ bool is_tdx_vm(void); int tdx_pre_create_vcpu(CPUState *cpu, Error **errp); void tdx_set_tdvf_region(MemoryRegion *tdvf_mr); int tdx_parse_tdvf(void *flash_ptr, int size); +int tdx_handle_report_fatal_error(X86CPU *cpu, struct kvm_run *run); =20 #endif /* QEMU_I386_TDX_H */ diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index fd1817fc5ea..c5c692a0345 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -6129,6 +6129,16 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_ru= n *run) case KVM_EXIT_HYPERCALL: ret =3D kvm_handle_hypercall(run); break; + case KVM_EXIT_SYSTEM_EVENT: + switch (run->system_event.type) { + case KVM_SYSTEM_EVENT_TDX_FATAL: + ret =3D tdx_handle_report_fatal_error(cpu, run); + break; + default: + ret =3D -1; + break; + } + break; default: fprintf(stderr, "KVM: unknown exit reason %d\n", run->exit_reason); ret =3D -1; diff --git a/target/i386/kvm/tdx-stub.c b/target/i386/kvm/tdx-stub.c index 7748b6d0a44..720a4ff046e 100644 --- a/target/i386/kvm/tdx-stub.c +++ b/target/i386/kvm/tdx-stub.c @@ -13,3 +13,8 @@ int tdx_parse_tdvf(void *flash_ptr, int size) { return -EINVAL; } + +int tdx_handle_report_fatal_error(X86CPU *cpu, struct kvm_run *run) +{ + return -EINVAL; +} diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index 971f4becfa4..16ad1af3c5a 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -615,6 +615,52 @@ int tdx_parse_tdvf(void *flash_ptr, int size) return tdvf_parse_metadata(&tdx_guest->tdvf, flash_ptr, size); } =20 +/* + * Only 8 registers can contain valid ASCII byte stream to form the fatal + * message, and their sequence is: R14, R15, RBX, RDI, RSI, R8, R9, RDX + */ +#define TDX_FATAL_MESSAGE_MAX 64 + +int tdx_handle_report_fatal_error(X86CPU *cpu, struct kvm_run *run) +{ + uint64_t error_code =3D run->system_event.data[R_R12]; + uint64_t reg_mask =3D run->system_event.data[R_ECX]; + char *message =3D NULL; + uint64_t *tmp; + + if (error_code & 0xffff) { + error_report("TDX: REPORT_FATAL_ERROR: invalid error code: 0x%lx", + error_code); + return -1; + } + + if (reg_mask) { + message =3D g_malloc0(TDX_FATAL_MESSAGE_MAX + 1); + tmp =3D (uint64_t *)message; + +#define COPY_REG(REG) \ + do { \ + if (reg_mask & BIT_ULL(REG)) { \ + *(tmp++) =3D run->system_event.data[REG]; \ + } \ + } while (0) + + COPY_REG(R_R14); + COPY_REG(R_R15); + COPY_REG(R_EBX); + COPY_REG(R_EDI); + COPY_REG(R_ESI); + COPY_REG(R_R8); + COPY_REG(R_R9); + COPY_REG(R_EDX); + *((char *)tmp) =3D '\0'; + } +#undef COPY_REG + + error_report("TD guest reports fatal error. %s", message ? : ""); + return -1; +} + static bool tdx_guest_get_sept_ve_disable(Object *obj, Error **errp) { TdxGuest *tdx =3D TDX_GUEST(obj); --=20 2.49.0