From nobody Sat Nov 15 19:34:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1748550274; cv=none; d=zohomail.com; s=zohoarc; b=SZBYzkOkuSqcNTAPN+eMf/PW4yOeSAdXZT/2afZkfBUIRPV6wQnIwb0y62RRvEc5C4kZeqBit9PaIvANzWVCXkxhMKSq0tTcsPOsj50iOKQkJxRhWm/WxB/thxeIGvQ4MDsvdfpc7nbzBSRQtnDhEOB2T7gUfflFb6GQHlY2l94= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748550274; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BNlbZtbtSL7iYylNYXYC2+eeOLfQcdGt27SfxMLdp4k=; b=UbiGhG91d/zLVx30+8Qv46CuYhsw5t+g5ZJy6DMTqTsMzFSyymaGfbTKK56rKL3VokEMXFBuRIrngZFjsI+9DIRs/UbooytN2kSBpa/atJO9llHLvjNrXNw28m45qrTwLAEaHj3hnw9LMMyinXkcADVeQxZUS9Tae6xm9NqvLsI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1748550274146727.3793600658095; Thu, 29 May 2025 13:24:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uKjmq-00047m-9O; Thu, 29 May 2025 16:23:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKjmn-00046V-Vf for qemu-devel@nongnu.org; Thu, 29 May 2025 16:23:34 -0400 Received: from mail-vs1-xe36.google.com ([2607:f8b0:4864:20::e36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uKjmm-000679-87 for qemu-devel@nongnu.org; Thu, 29 May 2025 16:23:33 -0400 Received: by mail-vs1-xe36.google.com with SMTP id ada2fe7eead31-4c6cf5e4cd5so859836137.2 for ; Thu, 29 May 2025 13:23:31 -0700 (PDT) Received: from grind.dc1.ventanamicro.com ([191.255.35.190]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-87e2a2c774asm1647137241.20.2025.05.29.13.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 13:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1748550210; x=1749155010; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BNlbZtbtSL7iYylNYXYC2+eeOLfQcdGt27SfxMLdp4k=; b=m/0xac08O3PxiV7gpHnoVWtXhuL6ed0CRDNqc3hDsxhFB8AQGFllhtsDFVe6WGk7yQ N4VBp9dm6yreoggyLHrL5+3vvwEFlvuh+hVYd2+TEqd8rmg4wTxe0nmycR+ySsKcC9B/ /HXTtR7bi+buf/X9jOZGKUVqZZED6Y/imn9A8Kxnj228KyncGYzX9TduFp/fHjQvCm1S EA3DR0lkhIjqX9SkexNy1fn9tm12fLyPafUVcC+GlN4POhFEBbM0dqNvssKhg4NCtlz/ WoBp7RUMRRSXHt0E2pm9Zb2ffj5Uidn7sXgMYSPQPmKP4U43FoPUqiuQ9sefHWcYPjSk X46g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748550210; x=1749155010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BNlbZtbtSL7iYylNYXYC2+eeOLfQcdGt27SfxMLdp4k=; b=iJ5aqeNrfpg7c2DB6B+EJDTdUvv9Y+z8dwomtjp0PYCMTkfcSMot23ghUoRg/atosC lCTFGd0eStyPaHm0qYFzeexWieGJKchLCxSD3qyw6MKrzm1VYnpTIJ3eIeUvVuZO1eDr ki/80/P3/SGGX1uXU/nIXJh22+cMbTxuZkeF9yJfWDzo09wKCF7D66yLBAehZrmvXKvh ej4eqSJS/mENdchq0+UUD2e0EtPUOFfvLZ7QZMu5cm4/XlK+DstBjkM/hH964QFeeDSq p2kc8t8vYD65l2zPhe0TlmRZGarLJgiyAbCwxlRDqIwfBqnY/GUwAY1HfpB1n5pfLpPw XQYQ== X-Gm-Message-State: AOJu0YxxJ5Uvr/mEEh6hXMEM7GsBMZtTPTz7eQQ6bFJ8TcPcguegVMdt vFwkdIl/8YxOnoqYO4klcTr1SAjRVe3FVV3xQX6iy7ulcmVAJXhek4oOw7PHSlmpSzDJpBGsuTO ZELYV X-Gm-Gg: ASbGnctx3BN9z5T5Tumnzu0ZLxT2qDBAcKz4r7uR/kpOoyhdSexxXV3nFCsyw7KiQ/g WA5wuzhnTkzvLp66ik0rQaB/5K1M5zbXgA1u/e+OD6FEJjm87CEg01JCOr++3JWIAb7TbGWqUcc WTSYNK1Fnx6H8aa7aIuf9vzF3Uq39XctmIX1030m06gEZ1xML8zBdYjixiHV1uutMOPOhZgeEya O8Vc4X5TFrbtZil8pfPMTa7ZN6Hm71jNfxE5YQ30SforaBwGhkJ8zBud6wKe286ff7uoE0t59rD Mb+07jlyIVPphptdLKorcCNR5HWXYZ8LpGS7IwQI/zZMVg2qlVGJfk8XuEvJvlA9Pr+WB8VFf0L 4TTw= X-Google-Smtp-Source: AGHT+IHPgUqaSTaLxsIkMjy0Ud2gogbx62ROefjsg4Rr9DFh48WFhektb0YazKe7J4SAz1K01y/4rg== X-Received: by 2002:a05:6102:304f:b0:4bf:fb80:9429 with SMTP id ada2fe7eead31-4e6e40d93a4mr1349890137.4.1748550210325; Thu, 29 May 2025 13:23:30 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, palmer@dabbelt.com, Daniel Henrique Barboza Subject: [qemu PATCH 3/3] target/riscv/cpu.c: do better with 'named features' doc Date: Thu, 29 May 2025 17:23:15 -0300 Message-ID: <20250529202315.1684198-4-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529202315.1684198-1-dbarboza@ventanamicro.com> References: <20250529202315.1684198-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::e36; envelope-from=dbarboza@ventanamicro.com; helo=mail-vs1-xe36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ventanamicro.com) X-ZM-MESSAGEID: 1748550275196116600 Content-Type: text/plain; charset="utf-8" Most of the named features are added directly in isa_edata_arr[], some of them are also added in riscv_cpu_named_features(). There is a reason for that, and the existing docs can do better explaining it. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index cd0b159ed5..fdf2eb2b1c 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -1377,13 +1377,23 @@ const RISCVCPUMultiExtConfig riscv_cpu_experimental= _exts[] =3D { * 'Named features' is the name we give to extensions that we * don't want to expose to users. They are either immutable * (always enabled/disable) or they'll vary depending on - * the resulting CPU state. They have riscv,isa strings - * and priv_ver like regular extensions. + * the resulting CPU state. + * + * Some of them are always enabled depending on priv version + * of the CPU and are declared directly in isa_edata_arr[]. + * The ones listed here have special checks during finalize() + * time and require their own flags like regular extensions. + * See riscv_cpu_update_named_features() for more info. */ const RISCVCPUMultiExtConfig riscv_cpu_named_features[] =3D { MULTI_EXT_CFG_BOOL("zic64b", ext_zic64b, true), MULTI_EXT_CFG_BOOL("ssstateen", ext_ssstateen, true), MULTI_EXT_CFG_BOOL("sha", ext_sha, true), + + /* + * 'ziccrse' has its own flag because the KVM driver + * wants to enable/disable it on its own accord. + */ MULTI_EXT_CFG_BOOL("ziccrse", ext_ziccrse, true), =20 { }, --=20 2.49.0