From nobody Sun Feb 8 05:47:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1748523201; cv=none; d=zohomail.com; s=zohoarc; b=cqAAaOlfnN3JJY3x2DJ+t9kGneo4cVt8dF47UoaDmwTG/skA/TtzcNyKVstVMVyEi89FDou1t3XsPnEBILdvpXkKXFFP7eKNHH9mRAzBfXjHCvz5kojpAFcvRxhG+VxhScdv5dYtQJRg8SAOp3ZGUnmCNou7BXRFp/0dRAlX8+w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748523201; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cfUuzY8O5t9PwOW0P7Ys3TjZf/rdbS8I8bh0pKYOtWQ=; b=KYNuv81HCoR0qIJxJlCJycsi+hK/j3s+jVFfk6u7AZRrf6gHj3sroozERCBqtE+NmSF0LJeKO1SFpLzL1oNP9yJbAeqXTkfeYOjXQKh1DNynUu4p4oSQKPOuWPWO/27MqcRN6FtCobUyjzf+TgzJNUFzxKSYORmYkEnR6QEVozU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1748523201518722.7160925139232; Thu, 29 May 2025 05:53:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uKckA-0004ie-HZ; Thu, 29 May 2025 08:52:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKZXr-0003R9-Hc for qemu-devel@nongnu.org; Thu, 29 May 2025 05:27:27 -0400 Received: from sg-1-30.ptr.blmpb.com ([118.26.132.30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uKZXn-0002jz-A9 for qemu-devel@nongnu.org; Thu, 29 May 2025 05:27:27 -0400 Received: from localhost.localdomain ([180.165.20.212]) by smtp.feishu.cn with ESMTP; Thu, 29 May 2025 17:27:04 +0800 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=lanxincomputing-com.20200927.dkim.feishu.cn; t=1748510828; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=cfUuzY8O5t9PwOW0P7Ys3TjZf/rdbS8I8bh0pKYOtWQ=; b=A1QF8N8vRsuUMI+WemKSZkqJZDyIYxcxTwJC3YB7cUeT0rCdjuFsiHSt/6FqLXvg15hCm7 bZWREa4hIiSJ+IPhjXVYgBGNH8xeOrFJCEXIt0we7UBsEZiE+lvrnd799iRJnwmav1oi4x +v5PNlD+15NaV8eBy9iMGYkH9WnOi870qrS878AQoRCl+T6jbONRMo+56w5qi64L3jPfUk 7lpcK0tgvsV4sBvrJbDErVXal4BTKymHgYfCY3on+Z5mcVV9TWvBH2PwC4D9CPvXxqHHFQ ALctWqV9gtkSfUw0Q6MtzieTyyA0chbD24YL9+z4uSHNPsG4wssxbYrHgstsQQ== Content-Transfer-Encoding: quoted-printable To: "Palmer Dabbelt" , "Alistair Francis" , "Weiwei Li" , "Daniel Henrique Barboza" , "Liu Zhiwei" , "Tomasz Jeznach" , "Richard Henderson" , , Message-Id: <20250529092632.4367-1-liujingqi@lanxincomputing.com> X-Lms-Return-Path: Cc: "Nutty Liu" X-Mailer: git-send-email 2.49.0.windows.1 Subject: [PATCH] hw/riscv/riscv-iommu: Fix PPN field of Translation-reponse register Mime-Version: 1.0 X-Original-From: Nutty Liu From: "Nutty Liu" Date: Thu, 29 May 2025 17:26:32 +0800 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=118.26.132.30; envelope-from=liujingqi@lanxincomputing.com; helo=sg-1-30.ptr.blmpb.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 29 May 2025 08:52:18 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @lanxincomputing-com.20200927.dkim.feishu.cn) X-ZM-MESSAGEID: 1748523203663116600 Content-Type: text/plain; charset="utf-8" The original implementation incorrectly performed a bitwise AND operation between the PPN of iova and PPN Mask, leading to an incorrect PPN field in Translation-reponse register. The PPN of iova should be set entirely in the PPN field of Translation-reponse register. Signed-off-by: Nutty Liu --- hw/riscv/riscv-iommu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c index a877e5da84..f529a6a3d7 100644 --- a/hw/riscv/riscv-iommu.c +++ b/hw/riscv/riscv-iommu.c @@ -1935,8 +1935,7 @@ static void riscv_iommu_process_dbg(RISCVIOMMUState *= s) iova =3D RISCV_IOMMU_TR_RESPONSE_FAULT | (((uint64_t) fault) <= < 10); } else { iova =3D iotlb.translated_addr & ~iotlb.addr_mask; - iova >>=3D TARGET_PAGE_BITS; - iova &=3D RISCV_IOMMU_TR_RESPONSE_PPN; + iova =3D set_field(0, RISCV_IOMMU_TR_RESPONSE_PPN, PPN_DOWN(io= va)); =20 /* We do not support superpages (> 4kbs) for now */ iova &=3D ~RISCV_IOMMU_TR_RESPONSE_S; --=20 2.49.0.windows.1