From nobody Sat Nov 15 20:33:55 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1748435688; cv=none; d=zohomail.com; s=zohoarc; b=R6Dfo+skKvt6YS7NLydrjQFJtIzIjt3yK1yrAfjQA8IqqSFkqNAQEyVtY+HArvXkprPsDCsTb9pqaY6CrUZc4lr0L1wDsK9OUDE2DHFzoB8mXihas3YBoyCD8pxEpGC5AxssLyROPO9+FUdqx+GELgNx0BkflTuFtqwZaEmL0y8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748435688; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BbV18E4aMISl1yjTK1F2SwsHUP74MmOPlj2EWDtSWjY=; b=TY6duPKAQEkAxLfag4ByYmXfUPzrsqV+sVXWLduqByo9G+CHCEtFAnG63DlWiaEWO38tbGmBNvCZJ7A1MEBNFM7e2KPpepuOvb4d1/+UkkK7sH2DrcHdO2HzzhKFJISNJJ5E01zt1sM6obBsrj3hzzoZ3l1DlZE+uewHHye7al4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1748435688857854.8550569398213; Wed, 28 May 2025 05:34:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uKFzB-0003wL-7p; Wed, 28 May 2025 08:34:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKFyt-0003pi-Qg for qemu-devel@nongnu.org; Wed, 28 May 2025 08:34:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKFyr-0006Xd-6M for qemu-devel@nongnu.org; Wed, 28 May 2025 08:34:03 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-uR62UVymPoCEOlJeW7TiKA-1; Wed, 28 May 2025 08:18:16 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AC3C11800373; Wed, 28 May 2025 12:18:15 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.38]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 576A430001B0; Wed, 28 May 2025 12:18:15 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E03F621E66BB; Wed, 28 May 2025 14:11:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748435637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BbV18E4aMISl1yjTK1F2SwsHUP74MmOPlj2EWDtSWjY=; b=M5NQ8ZjvkKPh4+j9TB6lRetlyPwXciHq45KPGScFa2gFAcmdn2leu3Qe0ks60eX8fzHa6Q +51AejgdycxkAQR/nR+Nnh436dHC3NJG8DUEF5I3CIS4YwM216tPSka8dNCxIOqyycDONB Ry8KVqqkQlrX7kg46kav4QO6z4LusOo= X-MC-Unique: uR62UVymPoCEOlJeW7TiKA-1 X-Mimecast-MFC-AGG-ID: uR62UVymPoCEOlJeW7TiKA_1748434695 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, Peter Xu , Fabiano Rosas , Peter Krempa Subject: [PULL 2/4] qapi/migration: Deprecate migrate argument @detach Date: Wed, 28 May 2025 14:11:41 +0200 Message-ID: <20250528121143.2208075-3-armbru@redhat.com> In-Reply-To: <20250528121143.2208075-1-armbru@redhat.com> References: <20250528121143.2208075-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -49 X-Spam_score: -5.0 X-Spam_bar: ----- X-Spam_report: (-5.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.904, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1748435690314116600 Content-Type: text/plain; charset="utf-8" Argument @detach has always been ignored. Start the clock to get rid of it. Cc: Peter Xu Cc: Fabiano Rosas Signed-off-by: Markus Armbruster Message-ID: <20250521063711.29840-3-armbru@redhat.com> ACKed-by: Peter Krempa Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu --- docs/about/deprecated.rst | 5 +++++ qapi/migration.json | 18 +++++++++--------- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 9665bc6fcf..ef4ea84e69 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -179,6 +179,11 @@ Use ``job-dismiss`` instead. =20 Use ``job-finalize`` instead. =20 +``migrate`` argument ``detach`` (since 10.1) +'''''''''''''''''''''''''''''''''''''''''''' + +This argument has always been ignored. + ``query-migrationthreads`` (since 9.2) '''''''''''''''''''''''''''''''''''''' =20 diff --git a/qapi/migration.json b/qapi/migration.json index 8b9c53595c..ecd266f98e 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1660,6 +1660,10 @@ # # @resume: resume one paused migration, default "off". (since 3.0) # +# Features: +# +# @deprecated: Argument @detach is deprecated. +# # Since: 0.14 # # .. admonition:: Notes @@ -1668,19 +1672,14 @@ # migration's progress and final result (this information is # provided by the 'status' member). # -# 2. All boolean arguments default to false. -# -# 3. The user Monitor's "detach" argument is invalid in QMP and -# should not be used. -# -# 4. The uri argument should have the Uniform Resource Identifier +# 2. The uri argument should have the Uniform Resource Identifier # of default destination VM. This connection will be bound to # default network. # -# 5. For now, number of migration streams is restricted to one, +# 3. For now, number of migration streams is restricted to one, # i.e. number of items in 'channels' list is just 1. # -# 6. The 'uri' and 'channels' arguments are mutually exclusive; +# 4. The 'uri' and 'channels' arguments are mutually exclusive; # exactly one of the two should be present. # # .. qmp-example:: @@ -1724,7 +1723,8 @@ { 'command': 'migrate', 'data': {'*uri': 'str', '*channels': [ 'MigrationChannel' ], - '*detach': 'bool', '*resume': 'bool' } } + '*detach': { 'type': 'bool', 'features': [ 'deprecated' ] }, + '*resume': 'bool' } } =20 ## # @migrate-incoming: --=20 2.48.1