From nobody Sat Nov 15 20:49:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1748434076; cv=none; d=zohomail.com; s=zohoarc; b=TN8/hfwcscBP6HPCDr5WDTe01ZniryhX1AArqicg361qVE96ero4vGpIrnusaSXkBg0Y9DQLTERWPhIVrNXrY6rcuYGvHLONXGm9kT0XrJw/+qefJ9HqIeyb+xYsfrA74aVNoB3BOmfUNM9MRAjB3nkA8sj9YO5uiDo7hVEUHJg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748434076; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Spwsr1E7bLQ+jndVnA0Z64bidGeH7q1eDXuXKKT2GJI=; b=Jc4gHtwU4j0gnhrpW2/TjAoIM+o2hPjpxvttOAA3lc1JH1LXQHHuo8VnO4bnWyTJvLE99UqFkEOfXdHVJQ6rREXq+6Fg8Ma20OwvWhlCdur5TRY2QjDVLiKrkKqm/VY6nl+AvmQBuEM0oamwQfvqliQhGlAWSWyRKsd0lAT8xxI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1748434076956563.2962823136018; Wed, 28 May 2025 05:07:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uKFYk-0006yy-PV; Wed, 28 May 2025 08:07:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKFXw-0006uW-KS for qemu-devel@nongnu.org; Wed, 28 May 2025 08:06:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKFXr-0002kY-W9 for qemu-devel@nongnu.org; Wed, 28 May 2025 08:06:12 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-7Z2BMTJGNv6qJ3npqr_RWw-1; Wed, 28 May 2025 07:59:35 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AD14C180035C; Wed, 28 May 2025 11:59:34 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.34.110]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1A6B4180049D; Wed, 28 May 2025 11:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748433963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Spwsr1E7bLQ+jndVnA0Z64bidGeH7q1eDXuXKKT2GJI=; b=ZK3t38BfgY1aNvI6B80CUCT4pAw4Ok12B6EWBWhth7nIr3zUS6O/BMjMcQnJdzfl64Lvt8 3CCq6hi+ZvhD+Afyo8ZaGgS57zfmQfWoSoFBInE3ykyGeVg2R5sDk6JJOtthnCNOunm41d FF1BcYmSFp+7p1kKdixLc1cGKHWwDWg= X-MC-Unique: 7Z2BMTJGNv6qJ3npqr_RWw-1 X-Mimecast-MFC-AGG-ID: 7Z2BMTJGNv6qJ3npqr_RWw_1748433574 From: Thomas Huth To: qemu-devel@nongnu.org, Fabiano Rosas , Peter Xu Subject: [PATCH v3 4/4] tests/functional/test_vmstate: Test whether the checker script works as expected Date: Wed, 28 May 2025 13:59:14 +0200 Message-ID: <20250528115914.330994-5-thuth@redhat.com> In-Reply-To: <20250528115914.330994-1-thuth@redhat.com> References: <20250528115914.330994-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -49 X-Spam_score: -5.0 X-Spam_bar: ----- X-Spam_report: (-5.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.904, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1748434077899116600 Content-Type: text/plain; charset="utf-8" From: Thomas Huth We've got two vmstate dump files in the repository which are meant for verifying whether the vmstate-static-checker.py works as expected. Since running this manually is a cumbersome job, let's add an automated test for this instead that runs the script with the two dump files and checks for the expected output. Signed-off-by: Thomas Huth --- tests/functional/test_vmstate.py | 37 ++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/tests/functional/test_vmstate.py b/tests/functional/test_vmsta= te.py index 212d854d17c..366ae431c6e 100755 --- a/tests/functional/test_vmstate.py +++ b/tests/functional/test_vmstate.py @@ -9,6 +9,22 @@ from qemu_test import QemuSystemTest, skipFlakyTest =20 =20 +expected_output=3D'''Warning: checking incompatible machine types: "pc-i44= 0fx-2.1", "pc-i440fx-2.2" +Section "fw_cfg" does not exist in dest +Section "fusbh200-ehci-usb" version error: 2 > 1 +Section "fusbh200-ehci-usb", Description "ehci-core": expected field "usbs= ts", got "usbsts_pending"; skipping rest +Section "pci-serial-4x" Description "pci-serial-multi": Entry "Fields" mis= sing +Section "intel-hda-generic", Description "intel-hda", Field "pci": missing= description +Section "cfi.pflash01": Entry "Description" missing +Section "megasas", Description "PCIDevice": expected field "irq_state", wh= ile dest has no further fields +Section "PIIX3-xen" Description "PIIX3": minimum version error: 1 < 2 +Section "PIIX3-xen" Description "PIIX3": Entry "Subsections" missing +Section "tpci200": Description "tpci200" missing, got "tpci2002" instead; = skipping +Section "sun-fdtwo" Description "fdc": version error: 2 > 1 +Section "sun-fdtwo", Description "fdrive": Subsection "fdrive/media_rate" = not found +Section "usb-kbd" Description "usb-kbd" Field "kbd.keycodes" size mismatch= : 4 , 2 +''' + @skipFlakyTest("vmstate-static-checker can produce false positives") class VmStateTest(QemuSystemTest): =20 @@ -20,6 +36,27 @@ def run_vmstate_checker(self, src_json, dst_json): stderr=3Dsubprocess.STDOUT, text=3DTrue) =20 + def test_checker(self): + """ + Test whether the checker script correctly detects the changes + between dump1.json and dump2.json. + """ + if self.arch !=3D 'x86_64': + self.skipTest('for x86 only') + src_json =3D self.data_file('..', 'data', 'vmstate-static-checker', + 'dump1.json') + dst_json =3D self.data_file('..', 'data', 'vmstate-static-checker', + 'dump2.json') + self.log.info(f'Comparing {src_json} with {dst_json}') + cp =3D self.run_vmstate_checker(src_json, dst_json) + if cp.returncode !=3D 13: + self.fail('Unexpected return code of vmstate-static-checker: '= + + cp.returncode) + if cp.stdout !=3D expected_output: + self.log.info('vmstate-static-checker output:\n' + cp.stdout) + self.log.info('expected output:\n' + expected_output) + self.fail('Unexpected vmstate-static-checker output!') + def test_vmstate_7_2(self): target_machine =3D { 'aarch64': 'virt-7.2', --=20 2.49.0