From nobody Tue Oct 28 04:05:36 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1748427065; cv=none; d=zohomail.com; s=zohoarc; b=HgKEFGZotEgiPwxj4MuFQmU10dBCDmUZdEhonNS9yX7ky0fmSDtmqjUPsFvHtQV7k8mHBUwEMS6ZDQ8mNL6zdsdNoXQj/Tg0V41qdPbgcGw9h20n11Zyfu7FQaiDGEYbEqFrH1RNaoisbiz2o5WbTAzjFmzRi8gZJgpl9wy1Cgo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748427065; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=syN9efIB0hNvD8iCymDl24Tj7OZV+bCEsnzxf8NWRq8=; b=Cbw3P3whb0e++r/E6ur6PNXXnKqRzbLq1r0FIKMpteO0zx8Rp8cO9mfRd7GH4Sh5ehN7YSuTYcPOMGkhnUFa3grvYzY8o6Zcb1QFcc2KxwWCErHQHBBvGbT4eRpzScWJZ+ajZBP6o5wSwU7iZpU6LiCyUFgnIpuMU85b28abpnc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1748427065129479.0874808281884; Wed, 28 May 2025 03:11:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uKDhe-0000a1-Mo; Wed, 28 May 2025 06:08:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKDhV-0000H7-9n for qemu-devel@nongnu.org; Wed, 28 May 2025 06:08:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKDhR-0007QT-Vj for qemu-devel@nongnu.org; Wed, 28 May 2025 06:07:56 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-29m2Hoe8PBSBrOA6R8DIyA-1; Wed, 28 May 2025 06:06:45 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F37C41800446; Wed, 28 May 2025 10:06:44 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.34.110]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2C775180049D; Wed, 28 May 2025 10:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748426872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=syN9efIB0hNvD8iCymDl24Tj7OZV+bCEsnzxf8NWRq8=; b=ITmfqU2hqIk7mIBxbyEdYWfeHIztR+qjcoX+pO6ZbefGPHwjirAMBbw8i6YNypwaVCajEk vzUlmva9RpMQCnaudjnzLtwjVozLNy4O22Gj+cvDv8vBOc/cD8zYOad6kmCP63QyF06eWJ xcYF1X/uprPzr7JLPEDM0rT8ZtBnL8s= X-MC-Unique: 29m2Hoe8PBSBrOA6R8DIyA-1 X-Mimecast-MFC-AGG-ID: 29m2Hoe8PBSBrOA6R8DIyA_1748426805 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Matheus Tavares Bernardino , Juraj Marcin Subject: [PULL 27/27] tests/unit/test-util-sockets: fix mem-leak on error object Date: Wed, 28 May 2025 12:05:07 +0200 Message-ID: <20250528100507.313906-28-thuth@redhat.com> In-Reply-To: <20250528100507.313906-1-thuth@redhat.com> References: <20250528100507.313906-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) DKIMWL_WL_HIGH=-2.907, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1748427071311116600 Content-Type: text/plain; charset="utf-8" From: Matheus Tavares Bernardino The test fails with --enable-asan as the error struct is never freed. In the case where the test expects a success but it fails, let's also report the error for debugging (it will be freed internally). Fixes 316e8ee8d6 ("util/qemu-sockets: Refactor inet_parse() to use QemuOpts= ") Signed-off-by: Matheus Tavares Bernardino Reviewed-by: Juraj Marcin Message-ID: <518d94c7db20060b2a086cf55ee9bffab992a907.1748280011.git.matheu= s.bernardino@oss.qualcomm.com> Signed-off-by: Thomas Huth --- tests/unit/test-util-sockets.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c index 8492f4d68f2..ee66d727c38 100644 --- a/tests/unit/test-util-sockets.c +++ b/tests/unit/test-util-sockets.c @@ -341,8 +341,12 @@ static void inet_parse_test_helper(const char *str, int rc =3D inet_parse(&addr, str, &error); =20 if (success) { + if (error) { + error_report_err(error); + } g_assert_cmpint(rc, =3D=3D, 0); } else { + error_free(error); g_assert_cmpint(rc, <, 0); } if (exp_addr !=3D NULL) { --=20 2.49.0