From nobody Sat Nov 15 19:33:08 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1748108287; cv=none; d=zohomail.com; s=zohoarc; b=VB3rEFcuI3qx1ePkqcUDw+yWbvByAP0WgjLK2K/NbbYZhZ0YvDSlzLRxQklhrKz/qKKmugJD3MWY5MmA45eVpIgZFHzr5sdWR5PkrUm0QF5O4B4QV6uR8xVCzqqdfWCYgG7IHO40heF3a6rkfJVO0eVdt5Rloe29dJ1cOyq3GaA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748108287; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wRJ+lxAG6BwZurQNM17kJYNnc6LLjMdGBSuT8AZQBgI=; b=AP/F1+cOyi+4/FzX5ZfULbrIxT4uDIYD32C0TILqWAy0miOuA/0rIYKo8xPp7fz54hMWI6ceV0SKihEOF3Pe1yvHqH/JqaX9pW6hg2GiC5UI53DAeuitXfcn7tbr9OHhz7IMRfg7L75bOhxW7WK+QSkwQ6qCv2OZQggvqsWd41c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1748108287106972.1326969625196; Sat, 24 May 2025 10:38:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uIsmu-0008S3-98; Sat, 24 May 2025 13:36:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIsmd-0008AZ-D4 for qemu-devel@nongnu.org; Sat, 24 May 2025 13:35:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIsmZ-0000iF-B7 for qemu-devel@nongnu.org; Sat, 24 May 2025 13:35:41 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-TowhQawqMROCceSkYGaJ3g-1; Sat, 24 May 2025 13:35:36 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 52497195608A for ; Sat, 24 May 2025 17:35:35 +0000 (UTC) Received: from localhost (unknown [10.45.242.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0F3D730001A1; Sat, 24 May 2025 17:35:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748108138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wRJ+lxAG6BwZurQNM17kJYNnc6LLjMdGBSuT8AZQBgI=; b=HGW81cuRXL89yOkS8V/v0Ycx60JKx+4UoHylexxec6BgXyH55UhVVYtFlF8zerkbStDwwr 1OCcZEY/ljCbHEOL/CE0a1M0Tt/trg0Y4JntiUPjEGvFwJYu4HTN6g6v6WHkvSqea0bzWT 3gNuMreTcQkB4KayJ1sve44T9DxXuEk= X-MC-Unique: TowhQawqMROCceSkYGaJ3g-1 X-Mimecast-MFC-AGG-ID: TowhQawqMROCceSkYGaJ3g_1748108135 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , stefanha@redhat.com Subject: [PULL 05/19] ui/clipboard: delay clipboard update when not running Date: Sat, 24 May 2025 19:34:58 +0200 Message-ID: <20250524173514.317886-6-marcandre.lureau@redhat.com> In-Reply-To: <20250524173514.317886-1-marcandre.lureau@redhat.com> References: <20250524173514.317886-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.298, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1748108287740116600 From: Marc-Andr=C3=A9 Lureau When VM is paused, we shouldn't notify of clipboard changes, similar to how input are being treated. On unsuspend, notify of the current state. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 --- ui/clipboard.c | 40 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/ui/clipboard.c b/ui/clipboard.c index f5db60c63d..ec00a0b8ec 100644 --- a/ui/clipboard.c +++ b/ui/clipboard.c @@ -1,4 +1,5 @@ #include "qemu/osdep.h" +#include "system/runstate.h" #include "ui/clipboard.h" #include "trace.h" =20 @@ -7,6 +8,10 @@ static NotifierList clipboard_notifiers =3D =20 static QemuClipboardInfo *cbinfo[QEMU_CLIPBOARD_SELECTION__COUNT]; =20 +static VMChangeStateEntry *cb_change_state_entry =3D NULL; + +static bool cb_reset_serial_on_resume =3D false; + static const VMStateDescription vmstate_cbcontent =3D { .name =3D "clipboard/content", .version_id =3D 0, @@ -33,8 +38,32 @@ const VMStateDescription vmstate_cbinfo =3D { } }; =20 +static void qemu_clipboard_change_state(void *opaque, bool running, RunSta= te state) +{ + int i; + + if (!running) { + return; + } + + if (cb_reset_serial_on_resume) { + qemu_clipboard_reset_serial(); + } + + for (i =3D 0; i < QEMU_CLIPBOARD_SELECTION__COUNT; i++) { + if (cbinfo[i]) { + qemu_clipboard_update(cbinfo[i]); + } + } + +} + void qemu_clipboard_peer_register(QemuClipboardPeer *peer) { + if (cb_change_state_entry =3D=3D NULL) { + cb_change_state_entry =3D qemu_add_vm_change_state_handler(qemu_cl= ipboard_change_state, NULL); + } + notifier_list_add(&clipboard_notifiers, &peer->notifier); } =20 @@ -109,7 +138,9 @@ void qemu_clipboard_update(QemuClipboardInfo *info) } } =20 - notifier_list_notify(&clipboard_notifiers, ¬ify); + if (runstate_is_running() || runstate_check(RUN_STATE_SUSPENDED)) { + notifier_list_notify(&clipboard_notifiers, ¬ify); + } =20 if (cbinfo[info->selection] !=3D info) { qemu_clipboard_info_unref(cbinfo[info->selection]); @@ -189,7 +220,12 @@ void qemu_clipboard_reset_serial(void) info->serial =3D 0; } } - notifier_list_notify(&clipboard_notifiers, ¬ify); + + if (runstate_is_running() || runstate_check(RUN_STATE_SUSPENDED)) { + notifier_list_notify(&clipboard_notifiers, ¬ify); + } else { + cb_reset_serial_on_resume =3D true; + } } =20 void qemu_clipboard_set_data(QemuClipboardPeer *peer, --=20 2.49.0