From nobody Sat Nov 15 17:58:29 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747983779345671.484787495746; Fri, 23 May 2025 00:02:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uIMQA-0003TM-Cf; Fri, 23 May 2025 03:02:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIMQ8-0003Sj-Gz; Fri, 23 May 2025 03:02:20 -0400 Received: from proxmox-new.maurer-it.com ([94.136.29.106]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIMQ5-0002i6-Qq; Fri, 23 May 2025 03:02:19 -0400 Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C420243E01; Fri, 23 May 2025 09:02:14 +0200 (CEST) From: Fiona Ebner To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, eduardo@habkost.net, berrange@redhat.com, pbonzini@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2] hw/core/qdev-properties-system: Add missing return in set_drive_helper() Date: Fri, 23 May 2025 09:02:11 +0200 Message-Id: <20250523070211.280498-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=94.136.29.106; envelope-from=f.ebner@proxmox.com; helo=proxmox-new.maurer-it.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1747983780991116600 Content-Type: text/plain; charset="utf-8" Currently, changing the 'drive' property of e.g. a scsi-hd object will result in an assertion failure if the aio context of the block node it's replaced with doesn't match the current aio context: > bdrv_replace_child_noperm: Assertion `bdrv_get_aio_context(old_bs) =3D=3D > bdrv_get_aio_context(new_bs)' failed. The problematic scenario is already detected, but a 'return' statement was missing. Cc: qemu-stable@nongnu.org Fixes: d1a58c176a ("qdev: allow setting drive property for realized device") Signed-off-by: Fiona Ebner Reviewed-by: Daniel P. Berrang=C3=A9 --- Changes in v2: * Add missing condition in commit message, sorry for the noise! Reproducer: #!/bin/bash rm /tmp/disk0.raw rm /tmp/disk1.raw ./qemu-img create -f raw /tmp/disk0.raw 1G ./qemu-img create -f raw /tmp/disk1.raw 1G ./qemu-system-x86_64 --qmp stdio \ --blockdev file,node-name=3Dnode0,filename=3D/tmp/disk0.raw \ --blockdev file,node-name=3Dnode1,filename=3D/tmp/disk1.raw \ --nodefaults \ --object 'iothread,id=3Diothread0' \ --device 'virtio-scsi-pci,id=3Dvirtioscsi0,bus=3Dpci.0,addr=3D0x3,iothread= =3Diothread0' \ --device 'scsi-hd,bus=3Dvirtioscsi0.0,scsi-id=3D1,drive=3Dnode0,id=3Dscsi0'= \ <