From nobody Sat Nov 15 22:33:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1747881267; cv=none; d=zohomail.com; s=zohoarc; b=MU8LR48cKGbvVWVrWd2zBXjuf+zcduOk4iuSs+SZSTwYAqN5iUpK39T8ZCqrcMC2Yo8325hkFFhWU9Tpc58GNjAh9e6e5N38ZNx5a2th/v6gtzrZrXlcL6GiE23WNdP0uUsBK6f5RRauMcr9FkeYXfqK8fDrqDipxsR3MLOJwZI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747881267; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=JIUwWoojE8GKsABD7MQuLGxqDCkGPBrJEtf+woUoHPo=; b=g+ZVsP6kR8Obn9yJUdH6/ZlvAZgQvaSrWufx+yN4uT5beGZn8xpeMrLeFhTuhyNuPBe/rG6VswJsBtpyub2nYNv42jTBvAEVAQ6DSDssSIrVcaDy73aJHgWn/Jo2R7Stn1aEBxOZO1v9GWX3/jD5R+zg+WGCEp3kGDzTlz3fWsM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747881266976513.0770983367956; Wed, 21 May 2025 19:34:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uHvkY-0003L3-Qp; Wed, 21 May 2025 22:33:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHvkF-0003J0-QG; Wed, 21 May 2025 22:33:21 -0400 Received: from mail.aspeedtech.com ([211.20.114.72] helo=TWMBX01.aspeed.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHvkD-00010W-Gl; Wed, 21 May 2025 22:33:19 -0400 Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Thu, 22 May 2025 10:33:05 +0800 Received: from mail.aspeedtech.com (192.168.10.10) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server id 15.2.1748.10 via Frontend Transport; Thu, 22 May 2025 10:33:05 +0800 To: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , "Joel Stanley" , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: , , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 1/3] hw/intc/aspeed: Set impl.min_access_size to 4 Date: Thu, 22 May 2025 10:33:02 +0800 Message-ID: <20250522023305.2486536-2-jamin_lin@aspeedtech.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250522023305.2486536-1-jamin_lin@aspeedtech.com> References: <20250522023305.2486536-1-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=211.20.114.72; envelope-from=jamin_lin@aspeedtech.com; helo=TWMBX01.aspeed.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_FAIL=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jamin Lin From: Jamin Lin via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1747881269220116600 This patch explicitly sets ".impl.min_access_size =3D 4" to match the declared ".valid.min_access_size =3D 4", enforcing stricter access size checking and preventing inconsistent partial accesses to the interrupt controller registers. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- hw/intc/aspeed_intc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/intc/aspeed_intc.c b/hw/intc/aspeed_intc.c index 33fcbe729c..19f88853d8 100644 --- a/hw/intc/aspeed_intc.c +++ b/hw/intc/aspeed_intc.c @@ -737,6 +737,7 @@ static const MemoryRegionOps aspeed_intc_ops =3D { .read =3D aspeed_intc_read, .write =3D aspeed_intc_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .impl.min_access_size =3D 4, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -747,6 +748,7 @@ static const MemoryRegionOps aspeed_intcio_ops =3D { .read =3D aspeed_intcio_read, .write =3D aspeed_intcio_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .impl.min_access_size =3D 4, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -757,6 +759,7 @@ static const MemoryRegionOps aspeed_ssp_intc_ops =3D { .read =3D aspeed_intc_read, .write =3D aspeed_ssp_intc_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .impl.min_access_size =3D 4, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -767,6 +770,7 @@ static const MemoryRegionOps aspeed_ssp_intcio_ops =3D { .read =3D aspeed_intcio_read, .write =3D aspeed_ssp_intcio_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .impl.min_access_size =3D 4, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -777,6 +781,7 @@ static const MemoryRegionOps aspeed_tsp_intc_ops =3D { .read =3D aspeed_intc_read, .write =3D aspeed_tsp_intc_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .impl.min_access_size =3D 4, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -787,6 +792,7 @@ static const MemoryRegionOps aspeed_tsp_intcio_ops =3D { .read =3D aspeed_intcio_read, .write =3D aspeed_tsp_intcio_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .impl.min_access_size =3D 4, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, --=20 2.43.0