From nobody Sat Nov 15 20:47:17 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747840481; cv=none; d=zohomail.com; s=zohoarc; b=aEic129mz3H1xbpxyJ4twSpTfHXpsm/ovjgGJwnoQZycS4XqKVjjYh010ZIWbQM3s9z2tO2lju2DiXc/i13rpU+rqbPbUM+Np3SJ1i8xeNX8WZrZH/oKKlKd7Jygso1II+vU9PmlwiSnCHXe7ZtfTocaCo58LMGurQo9takfItI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747840481; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XuEkYjKzDf6DVqioHgv3E9FZv9MeMmn9lH+ktcqBymA=; b=awRtwTqo/a0aN+1kg5xQ6m31Nad1jaGIBLoJwPtkbj4ggyNdG2uP0jmnBEJyjQEyw62n8xMt7cUkiS/KPeVwt0OG+V9XvLotrnL2V/1l0qIqSyoeUe6eUzUwOORLqPVoHb/baAl3RCffAZTL23JO20w2Gv19hmxVu92v7GxoGoA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747840481731602.9601822595365; Wed, 21 May 2025 08:14:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uHl8W-0004se-GR; Wed, 21 May 2025 11:13:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHl8V-0004sS-9R for qemu-devel@nongnu.org; Wed, 21 May 2025 11:13:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHl8R-00022c-VT for qemu-devel@nongnu.org; Wed, 21 May 2025 11:13:38 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-h9abPPUhNz-LWvTgqUYYgQ-1; Wed, 21 May 2025 11:13:29 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 417A31800771; Wed, 21 May 2025 15:13:28 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.199]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 26386195608F; Wed, 21 May 2025 15:13:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747840412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=XuEkYjKzDf6DVqioHgv3E9FZv9MeMmn9lH+ktcqBymA=; b=LbEu9U8yFXTa/A8z4vNgthg3GkLyvAMsTSkXgXYrLZGhoXpAhYdLhvg4xG2FCia7i+6w7M aizWS+8ik4J1fBehlbwp57jiubs9lte+ivVZjbE4ysd+65xYoN+E53SA6muhhdGObAIKUY 25tJ4W54OMb0ICltBxlUhUPB0w5I1fM= X-MC-Unique: h9abPPUhNz-LWvTgqUYYgQ-1 X-Mimecast-MFC-AGG-ID: h9abPPUhNz-LWvTgqUYYgQ_1747840408 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Subject: [PATCH] tests/functional: Set 'pc' machine type instead of relying on the default Date: Wed, 21 May 2025 17:13:23 +0200 Message-ID: <20250521151323.155232-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.184, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747840483195116600 Content-Type: text/plain; charset="utf-8" From: Thomas Huth In case the default machine has not been compiled into the QEMU binary, the vnc and the cpu_hotplug_props test are currently failing. Add a set_machine('pc') here to make sure that the tests are correctly skipped in case the machine is not available. Signed-off-by: Thomas Huth --- tests/functional/test_pc_cpu_hotplug_props.py | 1 + tests/functional/test_vnc.py | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/tests/functional/test_pc_cpu_hotplug_props.py b/tests/function= al/test_pc_cpu_hotplug_props.py index 9d5a37cb170..2bed8ada023 100755 --- a/tests/functional/test_pc_cpu_hotplug_props.py +++ b/tests/functional/test_pc_cpu_hotplug_props.py @@ -26,6 +26,7 @@ class OmittedCPUProps(QemuSystemTest): =20 def test_no_die_id(self): + self.set_machine('pc') self.vm.add_args('-nodefaults', '-S') self.vm.add_args('-smp', '1,sockets=3D2,cores=3D2,threads=3D2,maxc= pus=3D8') self.vm.add_args('-device', 'qemu64-x86_64-cpu,socket-id=3D1,core-= id=3D0,thread-id=3D0') diff --git a/tests/functional/test_vnc.py b/tests/functional/test_vnc.py index 5c0ee5f9272..cbb01f00c7b 100755 --- a/tests/functional/test_vnc.py +++ b/tests/functional/test_vnc.py @@ -31,6 +31,7 @@ def check_connect(port: int) -> bool: class Vnc(QemuSystemTest): =20 def test_no_vnc_change_password(self): + self.set_machine('pc') self.vm.add_args('-nodefaults', '-S') self.vm.launch() =20 @@ -62,6 +63,7 @@ def launch_guarded(self): raise excp =20 def test_change_password_requires_a_password(self): + self.set_machine('pc') self.vm.add_args('-nodefaults', '-S', '-vnc', ':1,to=3D999') self.launch_guarded() self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled']) @@ -74,6 +76,7 @@ def test_change_password_requires_a_password(self): 'Could not set password') =20 def test_change_password(self): + self.set_machine('pc') self.vm.add_args('-nodefaults', '-S', '-vnc', ':1,to=3D999,passwor= d=3Don') self.launch_guarded() self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled']) @@ -103,6 +106,7 @@ def do_test_change_listen(self, a, b, c): self.assertTrue(check_connect(c)) =20 def test_change_listen(self): + self.set_machine('pc') with Ports() as ports: a, b, c =3D ports.find_free_ports(3) self.do_test_change_listen(a, b, c) --=20 2.49.0