From nobody Sat Nov 15 22:33:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747810000; cv=none; d=zohomail.com; s=zohoarc; b=WBgHLTFC/l1j+SHP0bF9uBAqprCBdzTUhqe4D9SKFpY5tRJbkuL0aPNdKr2TqignTMfoW4tbqeRvBF0Hj6MXnr/TyD/BppepBVzCXa8nruR4gG+Xk0MnNeYom1FQjel54Kbj1SeDGZdvpu9rHVZRnk82tfUh7s8zr2lO6A86HbE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747810000; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=3BlJVPJgXtYjTXjTm8IffFrtiHqYCc0qm0BvCIgO0l4=; b=QemwSUCI58m0+xwHdRao4cvqDxKWy9P/O9geeZo1hPkhzltCqw26gO9EKHY9XIeLOiKXRUv9+BvOz5t9jz2Tuy8ZmOdaaoCd3rZ0+BhazMDXK08g55oeVlnrZ92Zodk94KxgQPbsEBwrdhUZkJyV+iR/EoBmOr00S4I5T6D1u04= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747810000899969.2448408830106; Tue, 20 May 2025 23:46:40 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D91A0121D; Wed, 21 May 2025 02:46:39 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B326D17C9; Wed, 21 May 2025 02:45:26 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 857221561; Wed, 21 May 2025 02:45:20 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0D9771439 for ; Wed, 21 May 2025 02:45:20 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-_v2KEIJtMBCadncfWfyGZw-1; Wed, 21 May 2025 02:45:14 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8422C19560A7; Wed, 21 May 2025 06:45:13 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.7]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 264C81956095; Wed, 21 May 2025 06:45:13 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9A2B121E65D0; Wed, 21 May 2025 08:37:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747809919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZN/ywnWRQxirZwjG+Hq28J1iTV7enZxRL7cjhSPRM4I=; b=Le6FkCLSyx7NWekrlG3ZSKD77MC6ybslyu3e3aBeYc05GdLBFLEOXkMIeNxQ1pg63Aaj2Q pPP7/uQxxk3LFIUjGyJMUblxlnGHqPTt7IcNwf+ECX+gfWYcOId46hhUv+39APUrJotLQj vUWQMDCfm+TMRFa9uisS6LEvRrBZ0cc= X-MC-Unique: _v2KEIJtMBCadncfWfyGZw-1 X-Mimecast-MFC-AGG-ID: _v2KEIJtMBCadncfWfyGZw_1747809913 To: qemu-devel@nongnu.org Subject: [PATCH 2/4] qapi/migration: Deprecate migrate argument @detach Date: Wed, 21 May 2025 08:37:09 +0200 Message-ID: <20250521063711.29840-3-armbru@redhat.com> In-Reply-To: <20250521063711.29840-1-armbru@redhat.com> References: <20250521063711.29840-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 62SM2GD7TTETGIOBELJS3AK4CV7ZTFKX X-Message-ID-Hash: 62SM2GD7TTETGIOBELJS3AK4CV7ZTFKX X-MailFrom: armbru@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@lists.libvirt.org, Peter Xu , Fabiano Rosas X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Markus Armbruster via Devel Reply-To: Markus Armbruster X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747810002736116600 Content-Type: text/plain; charset="utf-8" Argument @detach has always been ignored. Start the clock to get rid of it. Cc: Peter Xu Cc: Fabiano Rosas Signed-off-by: Markus Armbruster ACKed-by: Peter Krempa Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu --- docs/about/deprecated.rst | 5 +++++ qapi/migration.json | 18 +++++++++--------- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 9665bc6fcf..ef4ea84e69 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -179,6 +179,11 @@ Use ``job-dismiss`` instead. =20 Use ``job-finalize`` instead. =20 +``migrate`` argument ``detach`` (since 10.1) +'''''''''''''''''''''''''''''''''''''''''''' + +This argument has always been ignored. + ``query-migrationthreads`` (since 9.2) '''''''''''''''''''''''''''''''''''''' =20 diff --git a/qapi/migration.json b/qapi/migration.json index 8b9c53595c..ecd266f98e 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1660,6 +1660,10 @@ # # @resume: resume one paused migration, default "off". (since 3.0) # +# Features: +# +# @deprecated: Argument @detach is deprecated. +# # Since: 0.14 # # .. admonition:: Notes @@ -1668,19 +1672,14 @@ # migration's progress and final result (this information is # provided by the 'status' member). # -# 2. All boolean arguments default to false. -# -# 3. The user Monitor's "detach" argument is invalid in QMP and -# should not be used. -# -# 4. The uri argument should have the Uniform Resource Identifier +# 2. The uri argument should have the Uniform Resource Identifier # of default destination VM. This connection will be bound to # default network. # -# 5. For now, number of migration streams is restricted to one, +# 3. For now, number of migration streams is restricted to one, # i.e. number of items in 'channels' list is just 1. # -# 6. The 'uri' and 'channels' arguments are mutually exclusive; +# 4. The 'uri' and 'channels' arguments are mutually exclusive; # exactly one of the two should be present. # # .. qmp-example:: @@ -1724,7 +1723,8 @@ { 'command': 'migrate', 'data': {'*uri': 'str', '*channels': [ 'MigrationChannel' ], - '*detach': 'bool', '*resume': 'bool' } } + '*detach': { 'type': 'bool', 'features': [ 'deprecated' ] }, + '*resume': 'bool' } } =20 ## # @migrate-incoming: --=20 2.48.1