From nobody Sun Oct 19 03:36:30 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1747628205; cv=none; d=zohomail.com; s=zohoarc; b=d03hho65u/yaG9OZemAwa8XuxnLtWtvPCa9+HLwbxF6paDpubNpeoQgzFBMCmYhsb2dTndfBqkmVJfRw1LyyJMF3nGDLhZ+HD3KZDFUnsTBV/cVu6TDs1GQt6uoVzE9TFzaY4yjiXZhYEorTH6dUO4gNnviB1vx/kHz6RA4VRg0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747628205; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wY7mpEOJfCURI42HnRpTQwtH82i/7RJ4cmoo53i44Rk=; b=OFFCNI1L0uYx2anVTRY1HrlmjfY8SBMPDr+AkA4IFMCzIiYcyyPCNCYazHkud1NJwHUtTLuGdDtgJBfwlbYOojztmjrn405a0gLxTPKjXuIjIIrwWXFs1Zie8qUl6+6sD9WSn2+y79LD1AHZJ2FbvHFPRgbw44hvckX6Ti2PtUw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747628205453173.13151371480456; Sun, 18 May 2025 21:16:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uGrv0-0004TU-Aq; Mon, 19 May 2025 00:16:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uGroT-0007vZ-Bb; Mon, 19 May 2025 00:09:25 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uGroR-0004KH-Lw; Mon, 19 May 2025 00:09:17 -0400 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-2320d2a7852so8590995ad.3; Sun, 18 May 2025 21:09:14 -0700 (PDT) Received: from toolbx.alistair23.me (2403-580b-97e8-0-82ce-f179-8a79-69f4.ip6.aussiebb.net. [2403:580b:97e8:0:82ce:f179:8a79:69f4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-231ecd5ea41sm41750035ad.228.2025.05.18.21.09.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 May 2025 21:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747627753; x=1748232553; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wY7mpEOJfCURI42HnRpTQwtH82i/7RJ4cmoo53i44Rk=; b=Xqv1ZlRBNTbEJDdSjwo79ZBfbtL24+VafjaUrFFUq8Tu586EmEQXEVMgFMsm0IP3hy H/cXBEprFCnwxqQxN36c5WRP5SBq913hWtd9TV5me96MchP4Z7qhMwpeD+nr0niV8Jaz 6D1KKkSuyVFr+UH84/JBycFgpC/+qAenaiTvSsfPQWRxI9K7s1gtiAmvONT0ww8niYU7 v8rJ+3U5VAA5Y6jk8TUQh4r/iKRyZw9VXGG+IrIvv46rTnpifAxytj3+3CsSD7GitRSv /qlVLWyS5RYKdKpyeLwnm3jewcBMpAYgPyugo7GMRyXW7zr2NTfcAFm9d7M0C+hYUH/Q fr7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747627753; x=1748232553; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wY7mpEOJfCURI42HnRpTQwtH82i/7RJ4cmoo53i44Rk=; b=TEnsxF5PplpPbXGg8vqQhoinAzBA9DY423pRiYupNz5eXJWG3t4Zv8cgxfQzb2XGB/ Gw6Q59cSGtDoultFbdrysTyyzogxiZX0f6/6aGn/hfZOVxckkBq2eTuck4E2agJC8Byt uGWx51SDaq1kEB5eUtHhWPd2Eo8M9rBtUYtm0fChJoiXcJGDrOxzXKXyoyb0OxAViuWf 5MvGODSzpmFtQaCmsI7+bDz2xca7ItzfPZU8cLzL5/xNvCvy8Oh7MD5TT80wWiLRDulT sMraBWp8lNo19BAaUg814xriKWPPqFypd7UxEeYaYG4hpAqOynNqbb9MIUzSiuux3VR4 cEDA== X-Forwarded-Encrypted: i=1; AJvYcCUpQJ3lktYaQmvIchY5L1Z4bxSRowGKk96dsrpVwcMUiK3carIRxXPWflhqB9pLs42/vu5kzliUe8y3yg==@nongnu.org X-Gm-Message-State: AOJu0YwXv4LWmo897vmkYEsBnGrP8TwLwpDXcVA5+ka3OFf/biJJ1DSW cf8SF4Qmy3aTV/2IqMWIlwRGgT3pjSeGjSKPYVMkYX0XG82OPOdWPs6inZP6dg== X-Gm-Gg: ASbGncs1avUOO6fnkFtTEy40JOFtnVVmsvYF/Abij80lJC8xyKqYA9RQbr5WJDAcTYS rgS7M4ozkOW/ulbmcOFXjM0Uq3v0r0A+xNhXEQFA07bDL4aCmC8tRsKle6dwErJmh/vBf5uUPYY WuWHyNgFryQpsZcyZA6/xucqn9r5SOaAmNK4uHxHwExhZvkgW/MYCjdCjg0JBf4F5Kt+4z6CemO wrp1nHi/5J5CZ7+ntWBlzFvnzgwOC1pd241O+oRQtn2zZCTIcfue3lZNCjKQWp6Gvbf2MN9GTRY K/S6hxCFSAFuSKqK1Rynq1V199TQuftFHier7t+jhlGMPyzVXNjyHb/ux7MHko+FeOLcQ+UM9cF FGmheoHyBv0jQVFfi9GM+yT+weFB8fAKVr/bE/Xxg6vCu+H561F2gCA5/ X-Google-Smtp-Source: AGHT+IG791m1GQiVC7YqYmNHcrA83Ciz35E5QnfsgPs4XHea0ujTmkmY5QvCXp5UL6vLagZNqSotYQ== X-Received: by 2002:a17:902:c411:b0:224:1ec0:8a1d with SMTP id d9443c01a7336-231de376684mr139468955ad.30.1747627753043; Sun, 18 May 2025 21:09:13 -0700 (PDT) From: alistair23@gmail.com X-Google-Original-From: alistair.francis@wdc.com To: qemu-devel@nongnu.org Cc: alistair23@gmail.com, Daniel Henrique Barboza , Andrew Jones , Alistair Francis , qemu-stable@nongnu.org Subject: [PULL 39/56] target/riscv/kvm: minor fixes/tweaks Date: Mon, 19 May 2025 14:05:36 +1000 Message-ID: <20250519040555.3797167-40-alistair.francis@wdc.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250519040555.3797167-1-alistair.francis@wdc.com> References: <20250519040555.3797167-1-alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=alistair23@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1747628207084116600 Content-Type: text/plain; charset="utf-8" From: Daniel Henrique Barboza Remove an unused 'KVMScratchCPU' pointer argument in kvm_riscv_check_sbi_dbcn_support(). Put kvm_riscv_reset_regs_csr() after kvm_riscv_put_regs_csr(). This will make a future patch diff easier to read, when changes in kvm_riscv_reset_regs_csr() and kvm_riscv_get_regs_csr() will be made. Fixes: a6b53378f5 ("target/riscv/kvm: implement SBI debug console (DBCN) ca= lls") Signed-off-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones Reviewed-by: Alistair Francis Message-ID: <20250429124421.223883-2-dbarboza@ventanamicro.com> Signed-off-by: Alistair Francis Cc: qemu-stable@nongnu.org --- target/riscv/kvm/kvm-cpu.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index 75724b6af4..cad54b720a 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -613,19 +613,6 @@ static int kvm_riscv_put_regs_core(CPUState *cs) return ret; } =20 -static void kvm_riscv_reset_regs_csr(CPURISCVState *env) -{ - env->mstatus =3D 0; - env->mie =3D 0; - env->stvec =3D 0; - env->sscratch =3D 0; - env->sepc =3D 0; - env->scause =3D 0; - env->stval =3D 0; - env->mip =3D 0; - env->satp =3D 0; -} - static int kvm_riscv_get_regs_csr(CPUState *cs) { CPURISCVState *env =3D &RISCV_CPU(cs)->env; @@ -660,6 +647,19 @@ static int kvm_riscv_put_regs_csr(CPUState *cs) return 0; } =20 +static void kvm_riscv_reset_regs_csr(CPURISCVState *env) +{ + env->mstatus =3D 0; + env->mie =3D 0; + env->stvec =3D 0; + env->sscratch =3D 0; + env->sepc =3D 0; + env->scause =3D 0; + env->stval =3D 0; + env->mip =3D 0; + env->satp =3D 0; +} + static int kvm_riscv_get_regs_fp(CPUState *cs) { int ret =3D 0; @@ -1078,7 +1078,6 @@ static int uint64_cmp(const void *a, const void *b) } =20 static void kvm_riscv_check_sbi_dbcn_support(RISCVCPU *cpu, - KVMScratchCPU *kvmcpu, struct kvm_reg_list *reglist) { struct kvm_reg_list *reg_search; @@ -1197,7 +1196,7 @@ static void kvm_riscv_init_multiext_cfg(RISCVCPU *cpu= , KVMScratchCPU *kvmcpu) kvm_riscv_read_vlenb(cpu, kvmcpu, reglist); } =20 - kvm_riscv_check_sbi_dbcn_support(cpu, kvmcpu, reglist); + kvm_riscv_check_sbi_dbcn_support(cpu, reglist); } =20 static void riscv_init_kvm_registers(Object *cpu_obj) --=20 2.49.0