From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747078496; cv=none; d=zohomail.com; s=zohoarc; b=dQJTRioSEEQm0/YdF7IoEzAmwwWHBu+7B+eDFaRyBbh3lQ2KdQVl7WECBfxsrTvz3xmzvF2PNHun/sO/niTwxb5Uk2lDr65t8ctpDjkXiHNNAj4s9/EP1MvZDqlmpHIt0VA4aVmCykunPYwTVe3TORimNxD7on2lcx6QrvrIRxw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747078496; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5PDfmKs2FRYilFGSf9BHWC+dQMg43pD84g/qhAfepq4=; b=FQyMIISeHMNF6l3OtuLWcp9UVQ+3pTWuTGLgF7K4/Q9L4WIF9Ln6IyXKuK0jJepcdyLmSPi86kPUit60UFXpCD/WCMZOXF1GONIH5P21eC7N27mI//ovsr8XPi0hhpbjBIz6sgCAgLNQxIPA9BA1Y4KpuO2wc4ETiBjemdgoBds= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747078496193713.7545143134602; Mon, 12 May 2025 12:34:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uEYvC-0002uD-5l; Mon, 12 May 2025 15:34:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYuc-0002nU-TR for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYub-0002HJ-Em for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:06 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-VxXeQXNkMwuCUUljOpHHPw-1; Mon, 12 May 2025 15:34:01 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C70871956094; Mon, 12 May 2025 19:34:00 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.82.199]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BA72130001A1; Mon, 12 May 2025 19:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747078444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5PDfmKs2FRYilFGSf9BHWC+dQMg43pD84g/qhAfepq4=; b=F84ioxMoyKVfnyw/dp1Vb0MqHqfDrvczYVLk2HTYe/aQS3GZuitzH8UXjdEeqBBmTIcpgq Pk+ktWNRcbIkNvQ8zup4jKSH2LA+h3Mau+stpE4DrLRW+Ic6JdJVoMcdK16XFl3QWvyG7A 8gjplFAqyCbeT+AQ83df4zOI2DBM4fo= X-MC-Unique: VxXeQXNkMwuCUUljOpHHPw-1 X-Mimecast-MFC-AGG-ID: VxXeQXNkMwuCUUljOpHHPw_1747078440 From: John Snow To: qemu-devel@nongnu.org Cc: Michael Roth , John Snow , Markus Armbruster , Peter Maydell , Cleber Rosa Subject: [PATCH v4 1/6] qapi: Add some pylint ignores Date: Mon, 12 May 2025 15:33:52 -0400 Message-ID: <20250512193357.3388514-2-jsnow@redhat.com> In-Reply-To: <20250512193357.3388514-1-jsnow@redhat.com> References: <20250512193357.3388514-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.551, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747078498204019000 Content-Type: text/plain; charset="utf-8" This restores the linting baseline in QAPI. Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- scripts/qapi/backend.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/qapi/backend.py b/scripts/qapi/backend.py index 14e60aa67af..49ae6ecdd33 100644 --- a/scripts/qapi/backend.py +++ b/scripts/qapi/backend.py @@ -13,6 +13,7 @@ =20 =20 class QAPIBackend(ABC): + # pylint: disable=3Dtoo-few-public-methods =20 @abstractmethod def generate(self, @@ -36,6 +37,7 @@ def generate(self, =20 =20 class QAPICBackend(QAPIBackend): + # pylint: disable=3Dtoo-few-public-methods =20 def generate(self, schema: QAPISchema, --=20 2.48.1 From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747078594; cv=none; d=zohomail.com; s=zohoarc; b=ZuyoIRS2TQ/5fULN9UyPGWUas4j1oX918qtOTriBavipma5zh6mZjcKDt6WD+DODrydOn+t/AHXNKf2HzWJEBUUDsaJMgPBoae0sfnaTP57AQa76QGQXBVJ+TTjt4bUjENnuYwUtiXLSFFFmnnsBXf35WS6W0XX/H0S9hIBXWak= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747078594; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=f/b85gJL7xVHanuZJX/dXUtQRv8HVdyerj2fpryzRbk=; b=ZFj6k9K9YAXZ7w/QVoGmJ5vVb8abepKlzn6CKzp0yLLgHQqeCuiE6hfZpOrL6nIrPdpYPqI0nV/nuBbozbd0CBIqRpcJ+A9h1dnBFzrNvBjwAbZimtkXXDSYtFxmJiVegiFKVlKMawd+YdOtySaOWlgVC6JUTXfbzWVr0WrpAMA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747078594534928.8835924782682; Mon, 12 May 2025 12:36:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uEYw4-0004Ps-Pg; Mon, 12 May 2025 15:35:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYue-0002p6-WC for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYud-0002He-7X for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:08 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-fBapCcuHM825H78mvkPPjQ-1; Mon, 12 May 2025 15:34:03 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 17D74180036D; Mon, 12 May 2025 19:34:02 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.82.199]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 09E6F30001A1; Mon, 12 May 2025 19:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747078446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f/b85gJL7xVHanuZJX/dXUtQRv8HVdyerj2fpryzRbk=; b=RQlld/WSwsgEz60F3JgMMbIQ077OEp3XbaoZuBkaWYGNbsbWxv0CiO3USMmEvveQWyCFu1 c35mXUkAMPSlrTBO4ZLkxDMvmQ2q0ZONeOyXy5rGOIO1Swm8bhiaBso2KkXthxElxVUqej 2axJDjResEEYLJl6i9LFAZBGJmKzVjQ= X-MC-Unique: fBapCcuHM825H78mvkPPjQ-1 X-Mimecast-MFC-AGG-ID: fBapCcuHM825H78mvkPPjQ_1747078442 From: John Snow To: qemu-devel@nongnu.org Cc: Michael Roth , John Snow , Markus Armbruster , Peter Maydell , Cleber Rosa Subject: [PATCH v4 2/6] docs/qapidoc: linting fixes Date: Mon, 12 May 2025 15:33:53 -0400 Message-ID: <20250512193357.3388514-3-jsnow@redhat.com> In-Reply-To: <20250512193357.3388514-1-jsnow@redhat.com> References: <20250512193357.3388514-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.551, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747078596167116600 Content-Type: text/plain; charset="utf-8" This restores the linting baseline in qapidoc. The order of some imports change slightly here due to configuring isort a little better: previously, isort was having difficulty understanding that "compat" and "qapidoc_legacy" were local modules because docs/sphinx "isn't a python package". Configuring this manually, isort chooses a different import ordering, which _is_ intentional here. Also: extra ignores are added for pylint. The most recent versions of pylint don't require these ignores, but the oldest versions we support do, so in the extra ignores go. Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- docs/sphinx/qapi_domain.py | 25 ++++++++++++++----------- docs/sphinx/qapidoc.py | 5 +++-- 2 files changed, 17 insertions(+), 13 deletions(-) diff --git a/docs/sphinx/qapi_domain.py b/docs/sphinx/qapi_domain.py index c94af5719ca..ebc46a72c61 100644 --- a/docs/sphinx/qapi_domain.py +++ b/docs/sphinx/qapi_domain.py @@ -20,16 +20,6 @@ =20 from docutils import nodes from docutils.parsers.rst import directives - -from compat import ( - CompatField, - CompatGroupedField, - CompatTypedField, - KeywordNode, - ParserFix, - Signature, - SpaceNode, -) from sphinx import addnodes from sphinx.directives import ObjectDescription from sphinx.domains import ( @@ -44,6 +34,16 @@ from sphinx.util.docutils import SphinxDirective from sphinx.util.nodes import make_id, make_refnode =20 +from compat import ( + CompatField, + CompatGroupedField, + CompatTypedField, + KeywordNode, + ParserFix, + Signature, + SpaceNode, +) + =20 if TYPE_CHECKING: from typing import ( @@ -56,7 +56,6 @@ ) =20 from docutils.nodes import Element, Node - from sphinx.addnodes import desc_signature, pending_xref from sphinx.application import Sphinx from sphinx.builders import Builder @@ -168,6 +167,8 @@ class QAPIDescription(ParserFix): """ =20 def handle_signature(self, sig: str, signode: desc_signature) -> Signa= ture: + # pylint: disable=3Dunused-argument + # Do nothing. The return value here is the "name" of the entity # being documented; for QAPI, this is the same as the # "signature", which is just a name. @@ -210,6 +211,8 @@ def _get_fqn(self, name: Signature) -> str: def add_target_and_index( self, name: Signature, sig: str, signode: desc_signature ) -> None: + # pylint: disable=3Dunused-argument + # name is the return value of handle_signature. # sig is the original, raw text argument to handle_signature. # For QAPI, these are identical, currently. diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py index 661b2c4ed0e..8011ac9efaf 100644 --- a/docs/sphinx/qapidoc.py +++ b/docs/sphinx/qapidoc.py @@ -27,6 +27,7 @@ =20 from __future__ import annotations =20 + __version__ =3D "2.0" =20 from contextlib import contextmanager @@ -56,8 +57,6 @@ QAPISchemaVisitor, ) from qapi.source import QAPISourceInfo - -from qapidoc_legacy import QAPISchemaGenRSTVisitor # type: ignore from sphinx import addnodes from sphinx.directives.code import CodeBlock from sphinx.errors import ExtensionError @@ -65,6 +64,8 @@ from sphinx.util.docutils import SphinxDirective, switch_source_input from sphinx.util.nodes import nested_parse_with_titles =20 +from qapidoc_legacy import QAPISchemaGenRSTVisitor # type: ignore + =20 if TYPE_CHECKING: from typing import ( --=20 2.48.1 From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747078536; cv=none; d=zohomail.com; s=zohoarc; b=dsoxmaQrB8l0UFaV9qn3THBDiLAIRE5XuS3QUeUfSKl8/OuGA/kiLGzLAqx/2136naVXkqHmRE4PP8d9d6kGRXfWiUGYu0Ysz6D5O+ZcNDghxDWilveSzitZcFo2b5NL44UxlDu2J5Rm9dsfKjrljuaie92MFCETWlWgYRzONCI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747078536; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sXg3fBjBE4n/FATuJcJQaBV1j/Ab9gpYwgbOq5lnK8Q=; b=J9e9StWUAzb4jPhwqMpvDQVe6UmytPaP5fzgWsMiT+TxyKkSjenbG5Ar7b8ok5ROaRudzLIvxeKVxX28RTm0luw9v/6wXNzAbxzhKhZLiLOpOMnTsOKocz7e+/srezyiZZoz+YZyIpBzwDtMSklo+0XKpATBctnevYJuj8n/lNQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747078536425684.1534232628322; Mon, 12 May 2025 12:35:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uEYvE-0002wo-6O; Mon, 12 May 2025 15:34:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYug-0002pd-H7 for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYue-0002Hz-6C for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:09 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-s1bWWSElPUW5d6vCu_ltow-1; Mon, 12 May 2025 15:34:04 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5DED419560BC; Mon, 12 May 2025 19:34:03 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.82.199]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4BBAC30001A1; Mon, 12 May 2025 19:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747078447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sXg3fBjBE4n/FATuJcJQaBV1j/Ab9gpYwgbOq5lnK8Q=; b=UHVj5pPQvbc4boMr4JdW/9z5sXqRyV5KWCVLA+520uzsady6yY+YjMmsLePqA1OzAm5ngV CgF7c5myHA/8gqeH1t+Vi31z774FRvBCknkTij40yRMvHxr50zWNGcyUmQj8UU30BbRo+6 wXYW22JkOhLJZPAfektS9mWD3SuzXfQ= X-MC-Unique: s1bWWSElPUW5d6vCu_ltow-1 X-Mimecast-MFC-AGG-ID: s1bWWSElPUW5d6vCu_ltow_1747078443 From: John Snow To: qemu-devel@nongnu.org Cc: Michael Roth , John Snow , Markus Armbruster , Peter Maydell , Cleber Rosa Subject: [PATCH v4 3/6] python: update missing dependencies from minreqs Date: Mon, 12 May 2025 15:33:54 -0400 Message-ID: <20250512193357.3388514-4-jsnow@redhat.com> In-Reply-To: <20250512193357.3388514-1-jsnow@redhat.com> References: <20250512193357.3388514-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.551, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747078538533019000 Content-Type: text/plain; charset="utf-8" We pin all dependencies for the "check-minreqs" test because pip lacks a dependency resolver that installs "the oldest possible package that meets dependency criteria". So, in order to test our stated minimum requirements, we pin all of our dependencies (and their dependencies, transitively) at the oldest possible versions that still work and pass tests; proving that our minimum requirements are correct. (It also ensures no new features accidentally sneak in from developers on newer platforms.) A few transitive dependencies were omitted from the pinned dependency file by accident; as a result, pip's dependency solver can pull in newer dependencies, which we don't want. This patch corrects the previous oversight and pins the missing dependencies. Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- python/tests/minreqs.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/python/tests/minreqs.txt b/python/tests/minreqs.txt index 6445407ba87..d3d53e0da81 100644 --- a/python/tests/minreqs.txt +++ b/python/tests/minreqs.txt @@ -38,10 +38,14 @@ pyflakes=3D=3D2.5.0 =20 # Transitive mypy dependencies mypy-extensions=3D=3D1.0.0 +tomli=3D=3D1.1.0 typing-extensions=3D=3D4.7.1 =20 # Transitive pylint dependencies astroid=3D=3D2.15.4 +dill=3D=3D0.2 lazy-object-proxy=3D=3D1.4.0 +platformdirs=3D=3D2.2.0 toml=3D=3D0.10.0 +tomlkit=3D=3D0.10.1 wrapt=3D=3D1.14.0 --=20 2.48.1 From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747078538; cv=none; d=zohomail.com; s=zohoarc; b=WE63Nnr3PdjaVnYj3SaQf56kGGS4i2xCmWpImeLHQC/eQebgBIbWzLx8IYu3vSC3YuYVnxqyRxNUD1OY180HSW2OMIHXVDqb8+tXq2/lsRJs7SugKMuZsQi78Yrxc4XChxO44ousTd16GdAHcoQKtOpvuCbojKHOUbsI4F0aPOc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747078538; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sffrXpIQOKREmrA4jK+axi0tNjGsukbmZw1kLmSxv1k=; b=FiVXsIptyWlYUj+mWRm6D2MG+3ZFc4Dj3/kd3wPRLfBjdrb2tuIKtXvIF32p8i67+tZKtcAKDeNhNm3NfhLTpQRoe6326eMli+ogrLxwlWbxg0uaDdcJit1CVt6L0UI2gxcQtWzFOBvnxfDLgeNfK3+gzHbEkrT5MlFUinwZR9w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174707853823282.80778395859727; Mon, 12 May 2025 12:35:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uEYvx-0003l3-6V; Mon, 12 May 2025 15:35:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYug-0002pe-In for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYue-0002Hv-62 for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:09 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-EL4YU-4hNd6d7K5lCXe4bQ-1; Mon, 12 May 2025 15:34:05 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C86D51800366; Mon, 12 May 2025 19:34:04 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.82.199]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 939C230001A1; Mon, 12 May 2025 19:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747078447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sffrXpIQOKREmrA4jK+axi0tNjGsukbmZw1kLmSxv1k=; b=KncKBSOKqEQbZqAW3gBtOulVJPLiUCqvn+z/dw6hajAEZ8FifUNlWEoxL0OTPXBnVu1Lqc CQx0Ge2h8jJ/wn9QG7KHHrVBRzOpHPxQalnch1L0hv7SnEPAhidgbgZJvyf0zSnyZpnBCA DKaElvYCTDt4MJ+0zvSpc6bo4DT+0UY= X-MC-Unique: EL4YU-4hNd6d7K5lCXe4bQ-1 X-Mimecast-MFC-AGG-ID: EL4YU-4hNd6d7K5lCXe4bQ_1747078445 From: John Snow To: qemu-devel@nongnu.org Cc: Michael Roth , John Snow , Markus Armbruster , Peter Maydell , Cleber Rosa Subject: [PATCH v4 4/6] python: add qapi static analysis tests Date: Mon, 12 May 2025 15:33:55 -0400 Message-ID: <20250512193357.3388514-5-jsnow@redhat.com> In-Reply-To: <20250512193357.3388514-1-jsnow@redhat.com> References: <20250512193357.3388514-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.551, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747078539732116600 Content-Type: text/plain; charset="utf-8" Update the python tests to also check QAPI and the QAPI Sphinx extensions. The docs/sphinx/qapidoc_legacy.py file is not included in these checks, as it is destined for removal soon. mypy is also not called on the QAPI Sphinx extensions, owing to difficulties supporting Sphinx 3.x - 8.x while maintaining static type checking support. mypy *is* called on all of the QAPI tools themselves, though. flake8, isort and mypy use the tool configuration from the existing python directory (in setup.cfg). pylint continues to use the special configuration located in scripts/qapi/ - that configuration is more permissive. If we wish to unify the two configurations, that's a separate series and a discussion for a later date. The list of pylint ignores is also updated, owing again to the wide window of pylint version support: newer versions require pragmas to occasionally silence the "too many positional arguments" warning, but older versions do not have such a warning category and will instead yelp about an unrecognized option. Silence that warning, too. As a result of this patch, one would be able to run any of the following tests locally from the qemu.git/python directory and have it cover the QAPI tooling as well. All of the following options run the python tests, static analysis tests, and linter checks; but with different combinations of dependencies and interpreters. - "make check-minreqs" Run tests specifically under our oldest supported Python and our oldest supported dependencies. This is the test that runs on GitLab as "check-python-minreqs". This helps ensure we do not regress support on older platforms accidentally. - "make check-tox" Runs the tests under the newest supported dependencies, but under each supported version of Python in turn. At time of writing, this is Python 3.8 to 3.13 inclusive. This test helps catch bleeding-edge problems before they become problems for developer workstations. This is the GitLab test "check-python-tox" and is an optionally run, may-fail test due to the unpredictable nature of new dependencies being released into the ecosystem that may cause regressions. - "make check-dev" Runs the tests under the newest supported dependencies using whatever version of Python the user happens to have installed. This is a quick convenience check that does not map to any particular GitLab test. (Note! check-dev may be busted on Fedora 41 and bleeding edge versions of setuptools. That's unrelated to this patch and I'll address it separately and soon. Thank you for your patience, --mgmt) Finally, finally, finally: this means that QAPI tooling will be linted and type-checked from the GitLab pipelines. Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- python/setup.cfg | 1 + python/tests/minreqs.txt | 21 +++++++++++++++++++++ python/tests/qapi-flake8.sh | 4 ++++ python/tests/qapi-isort.sh | 6 ++++++ python/tests/qapi-mypy.sh | 2 ++ python/tests/qapi-pylint.sh | 6 ++++++ scripts/qapi/pylintrc | 1 + 7 files changed, 41 insertions(+) create mode 100755 python/tests/qapi-flake8.sh create mode 100755 python/tests/qapi-isort.sh create mode 100755 python/tests/qapi-mypy.sh create mode 100755 python/tests/qapi-pylint.sh diff --git a/python/setup.cfg b/python/setup.cfg index c48dff280a3..d21304cadd1 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -46,6 +46,7 @@ devel =3D urwid >=3D 2.1.2 urwid-readline >=3D 0.13 Pygments >=3D 2.9.0 + sphinx >=3D 3.4.3 =20 # Provides qom-fuse functionality fuse =3D diff --git a/python/tests/minreqs.txt b/python/tests/minreqs.txt index d3d53e0da81..3cc6f7bf4e3 100644 --- a/python/tests/minreqs.txt +++ b/python/tests/minreqs.txt @@ -11,6 +11,9 @@ # When adding new dependencies, pin the very oldest non-yanked version # on PyPI that allows the test suite to pass. =20 +# Dependencies for qapidoc/qapi_domain et al +sphinx=3D=3D3.4.3 + # Dependencies for the TUI addon (Required for successful linting) urwid=3D=3D2.1.2 urwid-readline=3D=3D0.13 @@ -49,3 +52,21 @@ platformdirs=3D=3D2.2.0 toml=3D=3D0.10.0 tomlkit=3D=3D0.10.1 wrapt=3D=3D1.14.0 + +# Transitive sphinx dependencies +Jinja2=3D=3D2.7 +MarkupSafe=3D=3D1.1.0 +alabaster=3D=3D0.7.1 +babel=3D=3D1.3 +docutils=3D=3D0.12 +imagesize=3D=3D0.5.0 +packaging=3D=3D14.0 +pytz=3D=3D2011b0 +requests=3D=3D2.5.0 +snowballstemmer=3D=3D1.1 +sphinxcontrib-applehelp=3D=3D1.0.0 +sphinxcontrib-devhelp=3D=3D1.0.0 +sphinxcontrib-htmlhelp=3D=3D1.0.0 +sphinxcontrib-jsmath=3D=3D1.0.0 +sphinxcontrib-qthelp=3D=3D1.0.0 +sphinxcontrib-serializinghtml=3D=3D1.0.0 diff --git a/python/tests/qapi-flake8.sh b/python/tests/qapi-flake8.sh new file mode 100755 index 00000000000..7b5983d64a9 --- /dev/null +++ b/python/tests/qapi-flake8.sh @@ -0,0 +1,4 @@ +#!/bin/sh -e +python3 -m flake8 ../scripts/qapi/ \ + ../docs/sphinx/qapidoc.py \ + ../docs/sphinx/qapi_domain.py diff --git a/python/tests/qapi-isort.sh b/python/tests/qapi-isort.sh new file mode 100755 index 00000000000..f31f12d3425 --- /dev/null +++ b/python/tests/qapi-isort.sh @@ -0,0 +1,6 @@ +#!/bin/sh -e +python3 -m isort --sp . -c ../scripts/qapi/ +# Force isort to recognize "compat" as a local module and not third-party +python3 -m isort --sp . -c -p compat -p qapidoc_legacy \ + ../docs/sphinx/qapi_domain.py \ + ../docs/sphinx/qapidoc.py diff --git a/python/tests/qapi-mypy.sh b/python/tests/qapi-mypy.sh new file mode 100755 index 00000000000..377b29b873b --- /dev/null +++ b/python/tests/qapi-mypy.sh @@ -0,0 +1,2 @@ +#!/bin/sh -e +python3 -m mypy ../scripts/qapi diff --git a/python/tests/qapi-pylint.sh b/python/tests/qapi-pylint.sh new file mode 100755 index 00000000000..f4bb7a5a795 --- /dev/null +++ b/python/tests/qapi-pylint.sh @@ -0,0 +1,6 @@ +#!/bin/sh -e +SETUPTOOLS_USE_DISTUTILS=3Dstdlib python3 -m pylint \ + --rcfile=3D../scripts/qapi/pylintrc \ + ../scripts/qapi/ \ + ../docs/sphinx/qapidoc.py \ + ../docs/sphinx/qapi_domain.py diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc index d24eece7411..e16283ada3d 100644 --- a/scripts/qapi/pylintrc +++ b/scripts/qapi/pylintrc @@ -19,6 +19,7 @@ disable=3Dconsider-using-f-string, too-many-instance-attributes, too-many-positional-arguments, too-many-statements, + unknown-option-value, useless-option-value, =20 [REPORTS] --=20 2.48.1 From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747078547; cv=none; d=zohomail.com; s=zohoarc; b=JvA4gLvdmczSZ30djGULKNOFlnF1TkNA1FV0+Hnv1XNBcy1lOil137wjxARleLHjebdX2VQMwPGqcGRcAmU5DRZiypRwdNsWe2ScSSQ7o/ODoF2MZBad8KT1FpqLR4MSGppX8HoQWcqKAZk3jYIwdSIR3/nd4LC0H1D6Ca3hoPc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747078547; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EWEipy4xgnVx6oo46sZjBn1tw/01qDdudlS+/bgqVq0=; b=a+LR8HyR4KoHLS3xXBqmIA21Q+pWecW2y6w3UlqFsH89Iehq3P40s2vzSgTOaE5hqYB4+Lf1Kev22sjf0RtceHC0s46G34cBul3cO8+AsUpJh65/HcOO3qLrk+I3IOKvY+QSsu4j/M8YfFL3kkm1KCU5c8GWXTqf3bZmKDYhyYo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747078547786489.495812807908; Mon, 12 May 2025 12:35:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uEYvz-0003vG-9w; Mon, 12 May 2025 15:35:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYuk-0002qG-6A for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYuh-0002Id-5J for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:12 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-iKZpnPKhO8C5-YhqyW5EwQ-1; Mon, 12 May 2025 15:34:07 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1ADAF180045B; Mon, 12 May 2025 19:34:06 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.82.199]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0A86A30002D4; Mon, 12 May 2025 19:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747078450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EWEipy4xgnVx6oo46sZjBn1tw/01qDdudlS+/bgqVq0=; b=HNP163NQX1GKjiR3MyDVfvx8V13N7Nau32KP4FyDff/9Ul7sU7q6jgO9zeOud2Urz5eNgZ FOJ2BjoQpKd+fYGa/IJwt1alcQSzaFTctU4yecRc+G9Thy8251lm5xXmqh1lsBL/QZAQq5 m9NV2AXRgGEaW2P+jLIE8vpb3xP1ibI= X-MC-Unique: iKZpnPKhO8C5-YhqyW5EwQ-1 X-Mimecast-MFC-AGG-ID: iKZpnPKhO8C5-YhqyW5EwQ_1747078446 From: John Snow To: qemu-devel@nongnu.org Cc: Michael Roth , John Snow , Markus Armbruster , Peter Maydell , Cleber Rosa Subject: [PATCH v4 5/6] python: Drop redundant warn_unused_configs = True Date: Mon, 12 May 2025 15:33:56 -0400 Message-ID: <20250512193357.3388514-6-jsnow@redhat.com> In-Reply-To: <20250512193357.3388514-1-jsnow@redhat.com> References: <20250512193357.3388514-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.551, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747078548353019000 Content-Type: text/plain; charset="utf-8" From: Markus Armbruster strict =3D True implies warn_unused_configs =3D True. Signed-off-by: Markus Armbruster Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- python/setup.cfg | 1 - 1 file changed, 1 deletion(-) diff --git a/python/setup.cfg b/python/setup.cfg index d21304cadd1..d7f5dc7bafe 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -79,7 +79,6 @@ exclude =3D __pycache__, [mypy] strict =3D True python_version =3D 3.9 -warn_unused_configs =3D True namespace_packages =3D True warn_unused_ignores =3D False =20 --=20 2.48.1 From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747078528; cv=none; d=zohomail.com; s=zohoarc; b=SJ0umiuoLuFjZp57sK3bp/lf7AqfIEnPybg6AQnoqnpyCpMnQVWUiJFkV6Bb6hmodoyRaGHSBxkxzyjFkCT4/as6dUCt6jxAim9k8SRgXRtZ1OrWcBJP6RFMqLhkLDP+nUreLNXMQrWMapNXqWD7rN1xS243KpSyjH01wEPN5aY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747078528; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=w8sSEigBL7p/evyVdd+xP8GV6W4BTwuO4t9tNrOTuxw=; b=mBPFrsFBgfMQAjljfgfJKtkn8/usTB2Mdkhc6ZVM1i0vjGMDlZkVLrExNoBIiaGBkDTx9lAzzfD1PtPrjO6Tjr3PMT2LYMQmuWH/dm4MyJyKoNDvTQ21iGETfNuwLoONHlLawcbtKZuAxYpmnrJ2aXpqTDGzxOe1xqE9YMFIFi8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747078528152742.6454214561589; Mon, 12 May 2025 12:35:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uEYvb-00035F-Iy; Mon, 12 May 2025 15:35:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYum-0002rP-8G for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEYuk-0002Iz-IV for qemu-devel@nongnu.org; Mon, 12 May 2025 15:34:15 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-355-i9W7C4hAPcOToKN_rY_0zQ-1; Mon, 12 May 2025 15:34:08 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 504761800ECA; Mon, 12 May 2025 19:34:07 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.82.199]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 508CE30001A1; Mon, 12 May 2025 19:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747078451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w8sSEigBL7p/evyVdd+xP8GV6W4BTwuO4t9tNrOTuxw=; b=O7gjQZj74lYO4RLnOW+yFbfrVps2ItqQGVZaxvCVBDT27MM3BnkhXbY0XH+CZZZI60GOyZ 0iT8Rl5uBlfX7SiakhA/xEjjnCcz+ky7tsXGICOXfdbTLC8XGN3VWczwsuQwPNc9CWEmw4 Hli9UW9MnQotXKhluZAGDCWSKTZlMUk= X-MC-Unique: i9W7C4hAPcOToKN_rY_0zQ-1 X-Mimecast-MFC-AGG-ID: i9W7C4hAPcOToKN_rY_0zQ_1747078447 From: John Snow To: qemu-devel@nongnu.org Cc: Michael Roth , John Snow , Markus Armbruster , Peter Maydell , Cleber Rosa Subject: [PATCH v4 6/6] qapi: delete un-needed python static analysis configs Date: Mon, 12 May 2025 15:33:57 -0400 Message-ID: <20250512193357.3388514-7-jsnow@redhat.com> In-Reply-To: <20250512193357.3388514-1-jsnow@redhat.com> References: <20250512193357.3388514-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.551, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747078529660116600 Content-Type: text/plain; charset="utf-8" Since the previous commit, python/setup.cfg applies to scripts/qapi/ as well. Configuration files in scripts/qapi/ override python/setup.cfg. scripts/qapi/.flake8 and scripts/qapi/.isort.cfg actually match python/setup.cfg exactly, and can go. The differences between scripts/qapi/mypy.ini and python/setup.cfg are harmless: namespace_packages being set to True is a requirement for the PEP420 nested package structure of QEMU but not for scripts/qapi, but has no effect on type checking the QAPI code. warn_unused_ignores is used in python/ to be able to target a wide variety of mypy versions; some of which that have added new ignore categories that are not present in older versions. Ultimately, scripts/qapi/mypy.ini can be removed without any real change in behavior to how mypy enforces type safety there. The pylint config is being left in place because the settings differ enough from the python/ directory settings that we need a chit-chat on how to merge them O:-) Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- scripts/qapi/.flake8 | 3 --- scripts/qapi/.isort.cfg | 7 ------- scripts/qapi/mypy.ini | 4 ---- 3 files changed, 14 deletions(-) delete mode 100644 scripts/qapi/.flake8 delete mode 100644 scripts/qapi/.isort.cfg delete mode 100644 scripts/qapi/mypy.ini diff --git a/scripts/qapi/.flake8 b/scripts/qapi/.flake8 deleted file mode 100644 index a873ff67309..00000000000 --- a/scripts/qapi/.flake8 +++ /dev/null @@ -1,3 +0,0 @@ -[flake8] -# Prefer pylint's bare-except checks to flake8's -extend-ignore =3D E722 diff --git a/scripts/qapi/.isort.cfg b/scripts/qapi/.isort.cfg deleted file mode 100644 index 643caa1fbd6..00000000000 --- a/scripts/qapi/.isort.cfg +++ /dev/null @@ -1,7 +0,0 @@ -[settings] -force_grid_wrap=3D4 -force_sort_within_sections=3DTrue -include_trailing_comma=3DTrue -line_length=3D72 -lines_after_imports=3D2 -multi_line_output=3D3 diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini deleted file mode 100644 index c9dbcec2db0..00000000000 --- a/scripts/qapi/mypy.ini +++ /dev/null @@ -1,4 +0,0 @@ -[mypy] -strict =3D True -disallow_untyped_calls =3D False -python_version =3D 3.9 --=20 2.48.1