From nobody Sat Nov 15 23:36:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1746212600; cv=none; d=zohomail.com; s=zohoarc; b=NK1q0uzT/vscV5FrcjrPaescGLqvcq4PJDKjMInZoZajVgt1QuviJ3DT/2Pm/PXva1z/K7PS+nI2ZnuBACKcdk0FoeYrQ7dyjbCdukPxdI/FfojbvKXyJybMghE0yrBbjEz19o76oQ1hv6f6p0w5MvUCtIUB0dm1bbKoWjIwyoA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1746212600; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OvirrR3TiqgBPme4BwNGSV4VqzG47GBw5DwB3TzFavY=; b=Aolxx7OY3Dchg1jS2PxnqB0PgE2g3FDh/YsfDApzPG1GP8MyzOpjkzDe8ATMicsbQnPQo8h7j2Bhl/JnU6OsSWNIgXGQOYSvd2jV0uHod/Ve/y8Aa2wy1LwZSU2hK6bGi1uz+httD5NbQpI39TmzwfdV9ywR3+XZm2dbPki64R8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1746212600091393.72475082962285; Fri, 2 May 2025 12:03:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uAvbb-00014E-V8; Fri, 02 May 2025 14:59:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAvao-00079b-9B for qemu-devel@nongnu.org; Fri, 02 May 2025 14:58:38 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uAval-0005go-E3 for qemu-devel@nongnu.org; Fri, 02 May 2025 14:58:37 -0400 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5e5deb6482cso6238450a12.1 for ; Fri, 02 May 2025 11:58:35 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad1891a311bsm88214366b.54.2025.05.02.11.58.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 02 May 2025 11:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746212313; x=1746817113; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OvirrR3TiqgBPme4BwNGSV4VqzG47GBw5DwB3TzFavY=; b=afZqr4MI3noG/qSTyUTCbppF3OXeyj01ByXbyxvhFCFT6XKWo2+q0XnaI+VMonWfFV JbeNsKCMWRhtPLc2OU4TgY14d5ra0hGMkVPGdB+mgvyFUhlx+0+l5cLLB4SV9XtouMCh lt7j+aX7KOiMyGGTCnS/l5ApkqOAqgc4MsrAIxi4zsnrbHkOnQBPubptp6h9T9LDuup0 3j7vv+U74vDjhLEoceHDptg/cQRzwfpr2e7USeiaM+UXVUsdMW67BmeqXM82/b7r0Ze7 vVUxGsSFkgjtIz2JU+kMieftADh7sFmJKvIcV3pGw3yPLZJZv40X5b50wqStKBlhcYTJ JwdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746212313; x=1746817113; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OvirrR3TiqgBPme4BwNGSV4VqzG47GBw5DwB3TzFavY=; b=Op+d4TvJU1/qaCBoHGD5ukD2d6XKtbbXOZmqZ/TaPmjFjb1ohXEB6d82MftgvT7Tw5 g1+td4ciBZnNMN0JtbSE/5B2q8zRybeEO/guun1LfvpIvx5p7DtMLRRGVr64wGVpckMo dcr4MhyoRbhizCTDn5MOuXN4N5qDltpPy8YEwxLRZpogaEFTzbzuT03P3xlTQfp10R24 0I0VRm421ipZet2OTUPtG8efC+SrEJFTEBJXAB5OcFmFIRJDgwpGEcKO8NIuDCgjXa0D NoO4OV2EoEegKGAUoBfUglHVz9heSHgnFG3A7I51t2aUoEBbsPWb/GAg8tVyaJAMZoKa Vc4w== X-Gm-Message-State: AOJu0Yxw1ytJvQvZYeCbg0OPrEpMnZL30prIpGFEEnDXz1Ypwncjr0nv /Cm3QOJPi2KlpFRFdiZFb1gYQ6k9j5JepYvF8fyLn6omu8rYGsEWPGew0G4WiaZFbLxgkHlXlxW 4 X-Gm-Gg: ASbGnct58kdvocslDh2jpShZ4BAelocux77/4pOMl6HEE5bHC+DSNZhh67H3FkVI7dp JAO8xY9Uh3OoObr/VQg7MlND00ojxDrzNbQR6USkdDWPKGVoXWtBHVAVQRRhFgl/6TjS0SaJg5A 8xHDtrx70finPvmet+DjppfQYWrH0siVs8jL0h67PwzYsA5jvbQtpP6MTn6m8GLp0MyBd9qAi/y wG/xXpEopLFzdF7MaJvoO34SjoAOnc7mVcBJpZpH0NdxfGavMfjWVgy+gL6RB0Sgx8i2N4jWAcC WEhLefDNBEW2QnUY+mqwPesqZ+utC+bLffDN7xPdFpef/n+imsgujJ/nCwbjszKTCc01cKFdi7y Js7MTbcBKNmwMq5C5G5uLuqfXH0GrSZQ= X-Google-Smtp-Source: AGHT+IGZ6wVeevyDsC+s4yACGzGUdWe3H7+qZMuHK+2rKbQWUFgefD64pbso4UAGgULjofY9yaR2gg== X-Received: by 2002:a17:906:4fc5:b0:aca:c67d:eac0 with SMTP id a640c23a62f3a-acefe63defemr673247266b.0.1746212313493; Fri, 02 May 2025 11:58:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Igor Mammedov , Huacai Chen , Amit Shah , Marcel Apfelbaum , Sergio Lopez , Ani Sinha , Paolo Bonzini , Eduardo Habkost , Jiaxun Yang , Jason Wang , Richard Henderson , Yanan Wang , Gerd Hoffmann , =?UTF-8?q?Cl=C3=A9ment=20Mathieu--Drif?= , Zhao Liu , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Yi Liu , "Michael S. Tsirkin" , Mark Cave-Ayland Subject: [PATCH v3 17/19] hw/virtio/virtio-pci: Remove VirtIOPCIProxy::ignore_backend_features field Date: Fri, 2 May 2025 20:56:49 +0200 Message-ID: <20250502185652.67370-18-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250502185652.67370-1-philmd@linaro.org> References: <20250502185652.67370-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=philmd@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1746212601199116600 The VirtIOPCIProxy::ignore_backend_features boolean was only set in the hw_compat_2_7[] array, via the 'x-ignore-backend-features=3Don' property. We removed all machines using that array, lets remove that property, simplify by only using the default version. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland --- include/hw/virtio/virtio-pci.h | 1 - hw/virtio/virtio-pci.c | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/include/hw/virtio/virtio-pci.h b/include/hw/virtio/virtio-pci.h index f962c9116c1..9838e8650a6 100644 --- a/include/hw/virtio/virtio-pci.h +++ b/include/hw/virtio/virtio-pci.h @@ -149,7 +149,6 @@ struct VirtIOPCIProxy { int config_cap; uint32_t flags; bool disable_modern; - bool ignore_backend_features; OnOffAuto disable_legacy; /* Transitional device id */ uint16_t trans_devid; diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 8d68e56641a..7c965771907 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1965,8 +1965,7 @@ static void virtio_pci_device_plugged(DeviceState *d,= Error **errp) * Virtio capabilities present without * VIRTIO_F_VERSION_1 confuses guests */ - if (!proxy->ignore_backend_features && - !virtio_has_feature(vdev->host_features, VIRTIO_F_VERSION_1)) { + if (!virtio_has_feature(vdev->host_features, VIRTIO_F_VERSION_1)) { virtio_pci_disable_modern(proxy); =20 if (!legacy) { @@ -2351,8 +2350,6 @@ static const Property virtio_pci_properties[] =3D { VIRTIO_PCI_FLAG_MODERN_PIO_NOTIFY_BIT, false), DEFINE_PROP_BIT("page-per-vq", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_PAGE_PER_VQ_BIT, false), - DEFINE_PROP_BOOL("x-ignore-backend-features", VirtIOPCIProxy, - ignore_backend_features, false), DEFINE_PROP_BIT("ats", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_ATS_BIT, false), DEFINE_PROP_BIT("x-ats-page-aligned", VirtIOPCIProxy, flags, --=20 2.47.1