From nobody Sat Nov 15 22:25:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1746187943; cv=none; d=zohomail.com; s=zohoarc; b=Bo6Ftj/r2F6WlvKB7ZjBM19i8lzLnTrj6jsAZhIDtekbZ1HJh264aewwEjpvI5M4xlGqcxyZrpfhG7fC9p4beZ5yty5mNd+FK93MrrGgJOY0IRCLeH+dZP/eLDMShnO6Lj9fcqdYoy+mWPksbERzfRTYomyqU8mIZ2lMaIoeU/E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1746187943; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O3qPRtwnLxImfqoM+SxwhbWkP6zG0zSzWQFszr9u6HM=; b=S6hLj4oWSzzGr9ZjfSoZXjBlConz5W6AtuG/B/KoB/L1ui+/92njI0irfwf/8rC4ewCdmPBMVIPkr7icRQLbzQAjf3AjyF74rMN5L/xBdjBNi1qMRJmJLOSbQ3F6zHd1g4oB/FImdD1uPokoCMItOXt11ZO07/MY9m5GiKRjxSY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174618794301148.13127423508615; Fri, 2 May 2025 05:12:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uApEx-0000Wp-OK; Fri, 02 May 2025 08:11:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uApEv-0000WP-Ns for qemu-devel@nongnu.org; Fri, 02 May 2025 08:11:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uApEq-0003Tv-8J for qemu-devel@nongnu.org; Fri, 02 May 2025 08:11:37 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-256-1xe2vXo2OKSIxoYhVSB09g-1; Fri, 02 May 2025 08:11:29 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 126501955E79; Fri, 2 May 2025 12:11:27 +0000 (UTC) Received: from desktop.redhat.com (unknown [10.45.224.121]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A25B41954B08; Fri, 2 May 2025 12:11:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746187891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3qPRtwnLxImfqoM+SxwhbWkP6zG0zSzWQFszr9u6HM=; b=AGEqr0D2OT7ylfz9PHWDq0tPF4pU2qykdauxdbhKdsz6PXaAzsGINOjgTMTnazcpXi9kXv gPzeVAVGSiOgNNO+VeaoPHdCQy56AwHvvziSREP9uofeFEV8qIOcdFlTrdCD3x9Kb98KDw 9sshTYwtLc5zT2SewFpsleOWzVqBZv0= X-MC-Unique: 1xe2vXo2OKSIxoYhVSB09g-1 X-Mimecast-MFC-AGG-ID: 1xe2vXo2OKSIxoYhVSB09g_1746187887 From: Alberto Faria To: qemu-devel@nongnu.org Cc: Yanan Wang , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , Marcel Apfelbaum , Eduardo Habkost , Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, Alberto Faria Subject: [PATCH v3 1/2] scsi-disk: Add native FUA write support Date: Fri, 2 May 2025 13:11:14 +0100 Message-ID: <20250502121115.3613717-2-afaria@redhat.com> In-Reply-To: <20250502121115.3613717-1-afaria@redhat.com> References: <20250502121115.3613717-1-afaria@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=afaria@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.644, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1746187946409019100 Content-Type: text/plain; charset="utf-8" Simply propagate the FUA flag on write requests to the driver. The block layer will emulate it if necessary. Signed-off-by: Alberto Faria --- hw/scsi/scsi-disk.c | 53 +++++++++++++-------------------------------- 1 file changed, 15 insertions(+), 38 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index cb4af1b715..738d8df8ec 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -74,7 +74,7 @@ struct SCSIDiskClass { */ DMAIOFunc *dma_readv; DMAIOFunc *dma_writev; - bool (*need_fua_emulation)(SCSICommand *cmd); + bool (*need_fua)(SCSICommand *cmd); void (*update_sense)(SCSIRequest *r); }; =20 @@ -85,7 +85,7 @@ typedef struct SCSIDiskReq { uint32_t sector_count; uint32_t buflen; bool started; - bool need_fua_emulation; + bool need_fua; struct iovec iov; QEMUIOVector qiov; BlockAcctCookie acct; @@ -389,24 +389,6 @@ static bool scsi_is_cmd_fua(SCSICommand *cmd) } } =20 -static void scsi_write_do_fua(SCSIDiskReq *r) -{ - SCSIDiskState *s =3D DO_UPCAST(SCSIDiskState, qdev, r->req.dev); - - assert(r->req.aiocb =3D=3D NULL); - assert(!r->req.io_canceled); - - if (r->need_fua_emulation) { - block_acct_start(blk_get_stats(s->qdev.conf.blk), &r->acct, 0, - BLOCK_ACCT_FLUSH); - r->req.aiocb =3D blk_aio_flush(s->qdev.conf.blk, scsi_aio_complete= , r); - return; - } - - scsi_req_complete(&r->req, GOOD); - scsi_req_unref(&r->req); -} - static void scsi_dma_complete_noio(SCSIDiskReq *r, int ret) { assert(r->req.aiocb =3D=3D NULL); @@ -416,12 +398,7 @@ static void scsi_dma_complete_noio(SCSIDiskReq *r, int= ret) =20 r->sector +=3D r->sector_count; r->sector_count =3D 0; - if (r->req.cmd.mode =3D=3D SCSI_XFER_TO_DEV) { - scsi_write_do_fua(r); - return; - } else { - scsi_req_complete(&r->req, GOOD); - } + scsi_req_complete(&r->req, GOOD); =20 done: scsi_req_unref(&r->req); @@ -564,7 +541,7 @@ static void scsi_read_data(SCSIRequest *req) =20 first =3D !r->started; r->started =3D true; - if (first && r->need_fua_emulation) { + if (first && r->need_fua) { block_acct_start(blk_get_stats(s->qdev.conf.blk), &r->acct, 0, BLOCK_ACCT_FLUSH); r->req.aiocb =3D blk_aio_flush(s->qdev.conf.blk, scsi_do_read_cb, = r); @@ -589,8 +566,7 @@ static void scsi_write_complete_noio(SCSIDiskReq *r, in= t ret) r->sector +=3D n; r->sector_count -=3D n; if (r->sector_count =3D=3D 0) { - scsi_write_do_fua(r); - return; + scsi_req_complete(&r->req, GOOD); } else { scsi_init_iovec(r, SCSI_DMA_BUF_SIZE); trace_scsi_disk_write_complete_noio(r->req.tag, r->qiov.size); @@ -623,6 +599,7 @@ static void scsi_write_data(SCSIRequest *req) SCSIDiskReq *r =3D DO_UPCAST(SCSIDiskReq, req, req); SCSIDiskState *s =3D DO_UPCAST(SCSIDiskState, qdev, r->req.dev); SCSIDiskClass *sdc =3D (SCSIDiskClass *) object_get_class(OBJECT(s)); + BlockCompletionFunc *cb; =20 /* No data transfer may already be in progress */ assert(r->req.aiocb =3D=3D NULL); @@ -648,11 +625,10 @@ static void scsi_write_data(SCSIRequest *req) =20 if (r->req.cmd.buf[0] =3D=3D VERIFY_10 || r->req.cmd.buf[0] =3D=3D VER= IFY_12 || r->req.cmd.buf[0] =3D=3D VERIFY_16) { - if (r->req.sg) { - scsi_dma_complete_noio(r, 0); - } else { - scsi_write_complete_noio(r, 0); - } + block_acct_start(blk_get_stats(s->qdev.conf.blk), &r->acct, 0, + BLOCK_ACCT_FLUSH); + cb =3D r->req.sg ? scsi_dma_complete : scsi_write_complete; + r->req.aiocb =3D blk_aio_flush(s->qdev.conf.blk, cb, r); return; } =20 @@ -2391,7 +2367,7 @@ static int32_t scsi_disk_dma_command(SCSIRequest *req= , uint8_t *buf) scsi_check_condition(r, SENSE_CODE(LBA_OUT_OF_RANGE)); return 0; } - r->need_fua_emulation =3D sdc->need_fua_emulation(&r->req.cmd); + r->need_fua =3D sdc->need_fua(&r->req.cmd); if (r->sector_count =3D=3D 0) { scsi_req_complete(&r->req, GOOD); } @@ -3137,7 +3113,8 @@ BlockAIOCB *scsi_dma_writev(int64_t offset, QEMUIOVec= tor *iov, { SCSIDiskReq *r =3D opaque; SCSIDiskState *s =3D DO_UPCAST(SCSIDiskState, qdev, r->req.dev); - return blk_aio_pwritev(s->qdev.conf.blk, offset, iov, 0, cb, cb_opaque= ); + int flags =3D r->need_fua ? BDRV_REQ_FUA : 0; + return blk_aio_pwritev(s->qdev.conf.blk, offset, iov, flags, cb, cb_op= aque); } =20 static char *scsi_property_get_loadparm(Object *obj, Error **errp) @@ -3186,7 +3163,7 @@ static void scsi_disk_base_class_initfn(ObjectClass *= klass, const void *data) device_class_set_legacy_reset(dc, scsi_disk_reset); sdc->dma_readv =3D scsi_dma_readv; sdc->dma_writev =3D scsi_dma_writev; - sdc->need_fua_emulation =3D scsi_is_cmd_fua; + sdc->need_fua =3D scsi_is_cmd_fua; } =20 static const TypeInfo scsi_disk_base_info =3D { @@ -3338,7 +3315,7 @@ static void scsi_block_class_initfn(ObjectClass *klas= s, const void *data) sdc->dma_readv =3D scsi_block_dma_readv; sdc->dma_writev =3D scsi_block_dma_writev; sdc->update_sense =3D scsi_block_update_sense; - sdc->need_fua_emulation =3D scsi_block_no_fua; + sdc->need_fua =3D scsi_block_no_fua; dc->desc =3D "SCSI block device passthrough"; device_class_set_props(dc, scsi_block_properties); dc->vmsd =3D &vmstate_scsi_disk_state; --=20 2.49.0 From nobody Sat Nov 15 22:25:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1746187956; cv=none; d=zohomail.com; s=zohoarc; b=JgVDyQqnILHW1lgu9fCMZO4EmgD1S6WlHFq957FTAKRGDvKOqzAY34jxWLH7Z6X906zXjSPiJ9TJEmD173G5OjJGuLdDPSk1qMCKno243TGTThzczDlc+989vvJIUEF2v3BQwSU8qh9DJAHi7e8Hj87tbnaECc2V3AyKdNKdhgg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1746187956; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WbbzFEws32g4Ez/DfzmRrlhSVB1xe9QAB5yX00nWHso=; b=GmI4q9G+sJyZ80HJ228NVGZ9LH74YVPd6ge3/60jfO9iGv77eFfQUpnMkB0lS5K/i3q2NzdtwHp1UQWkS+Vbm3oVIGkM9iHVHj3UIrw38n2PEsbQrM0KjbgkqciYLgEj2/kpMlqFWNBRLrOgLiSh+RBB+pKf1YIv3Gi1IA+3NEQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174618795599689.58860566365581; Fri, 2 May 2025 05:12:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uApEz-0000XU-MX; Fri, 02 May 2025 08:11:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uApEx-0000Wm-IG for qemu-devel@nongnu.org; Fri, 02 May 2025 08:11:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uApEv-0003VK-EC for qemu-devel@nongnu.org; Fri, 02 May 2025 08:11:39 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-52-8iujLoaMPFKq5NKw3jxCnQ-1; Fri, 02 May 2025 08:11:33 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B8198195608C; Fri, 2 May 2025 12:11:31 +0000 (UTC) Received: from desktop.redhat.com (unknown [10.45.224.121]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BBC4B19560A3; Fri, 2 May 2025 12:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746187896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WbbzFEws32g4Ez/DfzmRrlhSVB1xe9QAB5yX00nWHso=; b=GjUvLpJX8WHEy5pinOBYxS9ICbBGsMu5z+C4eNevAD9UYWgqiEGoAO9bEhCZ679MMRgqBy qrwGIhnaNlDmCY7hAzRvzmoS/LlyBvzquYyvlr6SmThMJ8z7sbYM62YffzJ/2FwtgtVwK3 3ufquROWjqzrwJPtshn+vKOaGioTr7c= X-MC-Unique: 8iujLoaMPFKq5NKw3jxCnQ-1 X-Mimecast-MFC-AGG-ID: 8iujLoaMPFKq5NKw3jxCnQ_1746187892 From: Alberto Faria To: qemu-devel@nongnu.org Cc: Yanan Wang , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , Marcel Apfelbaum , Eduardo Habkost , Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, Alberto Faria Subject: [PATCH v3 2/2] scsi-disk: Advertise FUA support by default Date: Fri, 2 May 2025 13:11:15 +0100 Message-ID: <20250502121115.3613717-3-afaria@redhat.com> In-Reply-To: <20250502121115.3613717-1-afaria@redhat.com> References: <20250502121115.3613717-1-afaria@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=afaria@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.644, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1746187957492019000 Content-Type: text/plain; charset="utf-8" Allow the guest to submit FUA requests directly, instead of forcing it to emulate them using a regular flush. Signed-off-by: Alberto Faria --- hw/core/machine.c | 4 +++- hw/scsi/scsi-disk.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index ed01798d37..0e3d8c4065 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -37,7 +37,9 @@ #include "hw/virtio/virtio-iommu.h" #include "audio/audio.h" =20 -GlobalProperty hw_compat_10_0[] =3D {}; +GlobalProperty hw_compat_10_0[] =3D { + { "scsi-hd", "dpofua", "off" }, +}; const size_t hw_compat_10_0_len =3D G_N_ELEMENTS(hw_compat_10_0); =20 GlobalProperty hw_compat_9_2[] =3D { diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 738d8df8ec..b4782c6248 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -3192,7 +3192,7 @@ static const Property scsi_hd_properties[] =3D { DEFINE_PROP_BIT("removable", SCSIDiskState, features, SCSI_DISK_F_REMOVABLE, false), DEFINE_PROP_BIT("dpofua", SCSIDiskState, features, - SCSI_DISK_F_DPOFUA, false), + SCSI_DISK_F_DPOFUA, true), DEFINE_PROP_UINT64("wwn", SCSIDiskState, qdev.wwn, 0), DEFINE_PROP_UINT64("port_wwn", SCSIDiskState, qdev.port_wwn, 0), DEFINE_PROP_UINT16("port_index", SCSIDiskState, port_index, 0), --=20 2.49.0