From nobody Sat Nov 15 23:36:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1745935778; cv=none; d=zohomail.com; s=zohoarc; b=gKfG24uc0VmNuRO3x+fAn57HAXHrzgTXhQyrJtNS80HChHDOBAgPNWDh1DtZUeG0OK/TigLIux3F/MIITG9zWNL2WNTT5qr4h2TjwV7to3OBFcxSxSx7cE5+uU8gqlWUURgmEGUJXLKvaRo1+D8A5rRKsq7UA19qTnX6/SrCpNA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745935778; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2TdK0KknkLOYwI+XSWuaAcvX7rG//eSaXjO5J4+I7ro=; b=Fd9RovAKcWocekYM1euqmh3Ol45tGcwZJO8dKdmm2zvyQmLLQN7AivwSHxQDU3RgWwrR9RdkGtObbt2a/O/lNjwVWPGtVssa1GQSm2x02NEKbd67/IHN3alaVeEM48vidD3YwWbuv4lBWIFKoZSWu294aO2CFqkSloZQWZYmymU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745935778920862.9177854062158; Tue, 29 Apr 2025 07:09:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9ldm-0000iv-S4; Tue, 29 Apr 2025 10:08:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9ldj-0000f1-QY for qemu-devel@nongnu.org; Tue, 29 Apr 2025 10:08:51 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9ldh-0006HM-Ox for qemu-devel@nongnu.org; Tue, 29 Apr 2025 10:08:51 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-43cf58eea0fso26814245e9.0 for ; Tue, 29 Apr 2025 07:08:48 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a5311403sm157348955e9.23.2025.04.29.07.08.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 29 Apr 2025 07:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745935727; x=1746540527; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2TdK0KknkLOYwI+XSWuaAcvX7rG//eSaXjO5J4+I7ro=; b=lPpH27jmnDxa6xJSXYh8p1T8Wr9xu+jVXwmjrU0fVqibE7XM6Zcu1/niDd48a0nDDz u9dBbR/CB+4ehkPFEhAMTolZsmWZumTrNr/UTc+KDVszL/U12R24TAgrVO0vthhtHqto A5Xp3TFbAmSXxrTjJ4Sfrf/+gVVxXUxQMBIZucA8NaqFCgWT2eXpk9ezWli5D1XcWcow lzW3KwZLcFJAJ9W0ZwpD15Y5WQIF4sCFE+9c9Loj4F53sRRW90ktpOZa1lQfLqIstVka KXQqbGLCjbea5jw0YHimEYQQqZfFOrelA/wCbZBoLCFjw2pm0DBBoUFOCJ1ejuHGM/Me aUxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745935727; x=1746540527; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2TdK0KknkLOYwI+XSWuaAcvX7rG//eSaXjO5J4+I7ro=; b=tyAK5mDiAszKjcC9djNtfVi7lk4SJ2FAMA5ezaATl7VGlsiZm16Ez+NBvsspfR5Z35 gHZDIaVNpORQp34qR4X5oeDBUiH6/AzlTGLjAveWOd1UqOuBYJJhcZduYp7P0zwIr8Py rbteR/LyeUZq689Gf6gpB+PytYW4447+AD6LRXcQxYHBOwVOabICwe5oOqyJY9fXxpjo Zw0GHua2uIVWVq62TzAHm6y8uOnXV/1HCJlxTajP9Pvei2BzroSSSB/k8BY5inkJcVHZ bM4TmH/3gtfbL7qiAlGZfCRPYPvQOj684+yfzRDuKPumyu8oP6t1HAMljaQxfkSPcaON 4JKw== X-Gm-Message-State: AOJu0YxLSEEOi2XVE6nFl6K+2/a4S0jJxk+mwpfOSUP9r+Vow1zHmYlf pA3CTq5TFOjARDfRl7DHOSnzeYICF7s82KWQ9mBQWn4ppEuZeN3gqF/CdVWnjtxe73vcz0pP8s9 Q X-Gm-Gg: ASbGncutY3KK8VC8XBnBRQwU6qXPUw07orG0N9FOfTx9LqMTxZy+Z6wh4ryn6CF1XL8 vitRL9NVODhrijkfGBxHkaekGsKxzCf7rl1OyWebSALf9gAfC/XcBuzcJdAUgKnlq9NLeKj78xC fl7n/EndzBjJsh54yIZ9Svvmdywm9/y9Raayd6UYaKQaFKhQc5PZvhUsFyYyCPSP7pYXnrieaon b3lIFuVd9wdAgPP+mTJmF3WZn5aA49+/H7ES62GL6XFyv2mdmkiRSrxsFOixCiNvXf8An1V8jFE soRmnPmYPshVKON91QJG7Js/BTMaX/G/ggAB9gPggWAMS7PRZ4r+eWfbL/sANJPmFqVRri4gra3 OlIgeujFbXfst5Cm7o6hq X-Google-Smtp-Source: AGHT+IFWlOuXDLcKoC6qJIRh5j/hcn7Yfp6eX8KlCf+i9kGpCj9E0hPGD/4Ol8IQcBfdMdTOYuCWpg== X-Received: by 2002:a05:600c:5491:b0:43c:fe15:41e1 with SMTP id 5b1f17b1804b1-441ac8ce2f9mr24719525e9.4.1745935727158; Tue, 29 Apr 2025 07:08:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Hanna Reitz , Fam Zheng , Paolo Bonzini , Gerd Hoffmann , qemu-block@nongnu.org, John Snow , "Michael S. Tsirkin" , Zhao Liu , Eduardo Habkost , Jason Wang , Kevin Wolf , Yanan Wang , Marcel Apfelbaum , Dmitry Fleytman , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v2 04/19] target/i386/cpu: Remove X86CPU::check_cpuid field Date: Tue, 29 Apr 2025 16:08:10 +0200 Message-ID: <20250429140825.25964-5-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250429140825.25964-1-philmd@linaro.org> References: <20250429140825.25964-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1745935780209019000 The X86CPU::check_cpuid boolean was only set in the pc_compat_2_4[] array, via the 'check=3Doff' property. We removed all machines using that array, lets remove that CPU property and simplify x86_cpu_realizefn(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 --- target/i386/cpu.h | 1 - target/i386/cpu.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 54bf9639f19..3a5e17e0741 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -2168,7 +2168,6 @@ struct ArchCPU { uint8_t hyperv_ver_id_sb; uint32_t hyperv_ver_id_sn; =20 - bool check_cpuid; bool enforce_cpuid; /* * Force features to be enabled even if the host doesn't support them. diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 6f21d5ed222..49179f35812 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -8169,7 +8169,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error= **errp) } } =20 - if (x86_cpu_filter_features(cpu, cpu->check_cpuid || cpu->enforce_cpui= d)) { + if (x86_cpu_filter_features(cpu, cpu->enforce_cpuid)) { if (cpu->enforce_cpuid) { error_setg(&local_err, accel_uses_host_cpuid() ? @@ -8808,7 +8808,6 @@ static const Property x86_cpu_properties[] =3D { DEFINE_PROP_UINT8("hv-version-id-sbranch", X86CPU, hyperv_ver_id_sb, 0= ), DEFINE_PROP_UINT32("hv-version-id-snumber", X86CPU, hyperv_ver_id_sn, = 0), =20 - DEFINE_PROP_BOOL("check", X86CPU, check_cpuid, true), DEFINE_PROP_BOOL("enforce", X86CPU, enforce_cpuid, false), DEFINE_PROP_BOOL("x-force-features", X86CPU, force_features, false), DEFINE_PROP_BOOL("kvm", X86CPU, expose_kvm, true), --=20 2.47.1