From nobody Mon Feb 9 20:01:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1745935587; cv=none; d=zohomail.com; s=zohoarc; b=JsI1lapxKINj0nJY9zqtl5M6x31rzXtDqvVPlihBaI2Au6hQdTGkYpUqu196QSv+Y/dNRrVGYXW3I28dqEvxgc9w9tynoztb6xppTkQv17Pks8di6DnwqDW4plxMcgH7Dc4zJJVnsnHQwjGhXAJS3oJZsXZAi38At3lCcX4RF6Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745935587; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bb/H9vVU1cMZ8hb7U4a6OciQYW7eZ95HeN92fvbr3X0=; b=gaszUV/urWjoLAZrCK5O4FH0Qwwe+bQNHNAuWvvzbHL8TBSmcDdtpUYgfP2kmiNOv2Q4VL3OS/b7V5aTyDQ9ziQrYH+uneqb7xVN1YsFHVX6bIYHLM6HjrwQEC7cPZlfycYE3AJsjIfJFMINGvZ3xIrhyyM4UB+cBKTK6jNXP2Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745935587601454.463665121943; Tue, 29 Apr 2025 07:06:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9laX-0002sa-CC; Tue, 29 Apr 2025 10:05:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9laM-0002h5-8Y for qemu-devel@nongnu.org; Tue, 29 Apr 2025 10:05:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9laJ-0005s0-AX for qemu-devel@nongnu.org; Tue, 29 Apr 2025 10:05:21 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-97zJwr8fPe-BKcVtUuDZbw-1; Tue, 29 Apr 2025 10:04:05 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 99B19180099C; Tue, 29 Apr 2025 14:03:35 +0000 (UTC) Received: from localhost (unknown [10.45.242.19]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 36E67180045C; Tue, 29 Apr 2025 14:03:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745935518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bb/H9vVU1cMZ8hb7U4a6OciQYW7eZ95HeN92fvbr3X0=; b=Twm9Wx+Zh6CnraRuKYiPvEu517Rwzw3uVEfHd5+uotYMEmt+YUWWIxKU2yPE0j1x2x734k O1cuOXy/6taAds3lSUzC9nJYYGkPInZcH3hm7b1OgUN7U81ShiM7J2lcQKfo8LRLv473JA I2UxbspwQp5k2ne5Vyowh5t2FPgTn8M= X-MC-Unique: 97zJwr8fPe-BKcVtUuDZbw-1 X-Mimecast-MFC-AGG-ID: 97zJwr8fPe-BKcVtUuDZbw_1745935427 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Stefan Berger , Eduardo Habkost , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH 4/6] qdev: make release_prop_array() free array and idempotent Date: Tue, 29 Apr 2025 18:03:04 +0400 Message-ID: <20250429140306.190384-5-marcandre.lureau@redhat.com> In-Reply-To: <20250429140306.190384-1-marcandre.lureau@redhat.com> References: <20250429140306.190384-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.489, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1745935589485019100 From: Marc-Andr=C3=A9 Lureau Fix a memory leak, and allow it to be called multiple times safely. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stefan Berger --- hw/core/qdev-properties.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index bad111833c..7a53c85887 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -620,15 +620,16 @@ static void release_prop_array(Object *obj, const cha= r *name, void *opaque) char *elem =3D *arrayptr; int i; =20 - if (!prop->arrayinfo->release) { - return; + if (prop->arrayinfo->release) { + for (i =3D 0; i < *alenptr; i++) { + Property elem_prop =3D array_elem_prop(obj, prop, name, elem); + prop->arrayinfo->release(obj, NULL, &elem_prop); + elem +=3D prop->arrayfieldsize; + } } =20 - for (i =3D 0; i < *alenptr; i++) { - Property elem_prop =3D array_elem_prop(obj, prop, name, elem); - prop->arrayinfo->release(obj, NULL, &elem_prop); - elem +=3D prop->arrayfieldsize; - } + *alenptr =3D 0; + g_clear_pointer(arrayptr, g_free); } =20 /* --=20 2.49.0