From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907225199199.65140447691874; Mon, 28 Apr 2025 23:13:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eDL-0001pY-9V; Tue, 29 Apr 2025 02:13:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDG-0001gY-EX; Tue, 29 Apr 2025 02:13:02 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDE-0005Ol-Ld; Tue, 29 Apr 2025 02:13:02 -0400 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-223f4c06e9fso48848665ad.1; Mon, 28 Apr 2025 23:12:59 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907179; x=1746511979; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=+yS6YbrLorHrCaUTeh9OJZjVOXeAFgXyyBbtgx5XvM4=; b=RYq6OyYiwd+kzjIsqai9CtYjoJ1sTSr0JYbBKB0gNVFqYOq9rF3ftM1OAViTPWsgfs Nr6vYBZSvL3jYEVvPvj5AYKEHrco60EE05VdAMbYiRtz7YXp5lNWEk0vt4UX1bRNF7Aw K17qqHl5vkSzCwn3Ge0Sv8GdBn1MUv9l/utAV1e6fbBZ0sxDvq3aamVC13VY5ASx7OE8 x7XWtIS85gn8CbQTZHpC9BeRK0YKYqQ4YX3V21aUOqKrqKuoKeh2M7BXhyt7EqfMhKf2 UCS62EXTiWDILSsh2BrazcolgAVYOYl1qcZQs0s+3EKxCuURnosrLUhmZIIzaMQ6UMSh xUyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907179; x=1746511979; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+yS6YbrLorHrCaUTeh9OJZjVOXeAFgXyyBbtgx5XvM4=; b=Uat2/sBT8BcMmKnIZXM6o7mFIOya4Wqa589qcsdjmi6L5ZnJox+f11MG1Eti3lvrxE 5O7jHVkJie6ktx9awT8hLk1z9jcur/Ng15iGxD1nEL4jUWDkJwJVisjdjEr6uAp1sZAk vYCm0K5kkL1k0Mu1yp4APd5FFcz+9LdhjCYXibjAjUbdbULWY5XQ+Mwt6iz6P2XRPADF uhd0ldUsEN4fNmnkBFYf2WHCLms65hnqU1A3eOv6C6kQA4qh9ZhxkpQowEJ3zerpMTbn xS3Y29tViUrnDWCOVaPatQQvFqZ8oCHi4kGy4yKYPZStsjhvzh7dgOTGsFIuzDuFRq10 A+qg== X-Forwarded-Encrypted: i=1; AJvYcCXNvv3Fhvkos1lvSwI43gDuCQrKsZ7GSadhOv2RyCgKhSyr4+ZB7CT2FTiGuRzgnzjhiS0i9T6C5H5d@nongnu.org X-Gm-Message-State: AOJu0YxgCAvtGGf4ZvEmHo18dWIvoxypatXKC/qAi52tmups+XPsY34t PDiNhVGMvwT84Cy6o46qkOl3vHzkplkITEtYAC4nk0ogdV5GPymvbm92mQ== X-Gm-Gg: ASbGncuSJ54Epd45jZ4beMb66HwUGNTD+47zfr3dhweULPrSE7Kl3AqL6vim3eb8IRG P4DxOh/jSDmYLblMGVBCi+y5ia99oM2ICWMPuvLPB1jUBWfyy4V0w5zxQ8ZKlzPdt5jXt5YCj5E I/U6HDvYvoJcya6ZX3PCu5UDSDBZ8+zWR4TXWUTi9SU/K7TC3APunN8YVdZ8uJtJpv4huOd92u3 UdY9yeCU3qELnn4hB46N428ubOQf/FMyPFh8u65rvL8c44IZ8Tz6DcxdWUzPBNriBsdjAKba4OV O4ViPJqU2fqj4ZEgH87W2eU9lLjMtvGqMt4Q8TA2/g6ttXU74RE= X-Google-Smtp-Source: AGHT+IEcHm1sl87iHDAdswCnM7GtQsW4fAAzhdKdkiKyH4aehnm26l1gyqYNT6Uz4vPKpJOZzd0cIA== X-Received: by 2002:a17:903:1983:b0:221:89e6:ccb6 with SMTP id d9443c01a7336-22de6c7629amr32550135ad.25.1745907178833; Mon, 28 Apr 2025 23:12:58 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 01/13] riscv/virt: Fix address type in create_fdt_socket_clint Date: Tue, 29 Apr 2025 15:42:10 +0930 Message-ID: <20250429061223.1457166-3-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x629.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907226057019000 Content-Type: text/plain; charset="utf-8" The address is a hardware address, so use hwaddr for consistency with the rest of the machine. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis --- hw/riscv/virt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 17a790821484..e4c0ac8a2a9a 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -324,7 +324,7 @@ static void create_fdt_socket_clint(RISCVVirtState *s, int cpu; g_autofree char *clint_name =3D NULL; g_autofree uint32_t *clint_cells =3D NULL; - unsigned long clint_addr; + hwaddr clint_addr; MachineState *ms =3D MACHINE(s); static const char * const clint_compat[2] =3D { "sifive,clint0", "riscv,clint0" @@ -340,8 +340,8 @@ static void create_fdt_socket_clint(RISCVVirtState *s, } =20 clint_addr =3D s->memmap[VIRT_CLINT].base + - (s->memmap[VIRT_CLINT].size * socket); - clint_name =3D g_strdup_printf("/soc/clint@%lx", clint_addr); + s->memmap[VIRT_CLINT].size * socket; + clint_name =3D g_strdup_printf("/soc/clint@%"HWADDR_PRIx, clint_addr); qemu_fdt_add_subnode(ms->fdt, clint_name); qemu_fdt_setprop_string_array(ms->fdt, clint_name, "compatible", (char **)&clint_compat, --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907238204360.3333435689127; Mon, 28 Apr 2025 23:13:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eDN-0001yR-I9; Tue, 29 Apr 2025 02:13:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDE-0001bt-EH; Tue, 29 Apr 2025 02:13:00 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDC-0005OW-J3; Tue, 29 Apr 2025 02:13:00 -0400 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-224341bbc1dso59993045ad.3; Mon, 28 Apr 2025 23:12:57 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907176; x=1746511976; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=+yS6YbrLorHrCaUTeh9OJZjVOXeAFgXyyBbtgx5XvM4=; b=DyYnRI4TlLyokwN36vw7F8atzmSUOG/g+XhIkcwd2hjsYyNK+l24HIoLVvrgHC3f7u rjlwpMISueUIiHvFCXEr7hdiEtrJBbRunzBFKfS66u8o/releDKNEnoFDXRROVGUKZk4 4MSnyhsj9/bB8re7Oe1g0STdqX0nkPYEw+vlUyP9wqnKk8oROB+KvWCjRysdHEVbWAUI 1IUbET4BVdCKAd6e4Olgv4ko1vJ3iEc12d6FUcTHN4b7TDRBHeHlnVQNjHfwMKg8fcPb ECkDptt+LWIh0KblXo8KOI9sbPPNEJo60xMtPPa+/hXCvceUhXZWoMLGZr7NDG2LfruW 7jFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907176; x=1746511976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+yS6YbrLorHrCaUTeh9OJZjVOXeAFgXyyBbtgx5XvM4=; b=EOAWBOlk4Y8+Gbrr3uKpXMCsTV8Tm1V3Dp1dADeV5li2IfHulB5A2bpvDAIbnniyqr 0JMej473cfkziVsmcOLDbpCuufvpN3eotgcuPfsBCClITOpNFKJXxtF5enpPDvwBLpPw FNzPYDtiz5vLlhrl9oxGSwF6QfHeqgl46AYLPDO2Ak5XWZWrwiZ+oosSKj1cD6U+mBhG QjZVw1kxPNv8/dzBnzorYbSiSX4sH9l0dBuFIlZGzks05PAbVC9gkpj+awL/Leu/fbxk SULNNpqcWIJ9SWksuCG6zMKCc248gtLvoWANmn9Q1TvMrsQ0d2nuTPlTCLEsEiiXRE3g R49g== X-Forwarded-Encrypted: i=1; AJvYcCXDg9h11hVQT74VsEcFWQowRC3cJYzDGr/abIGxIOiwmjxxNf/mXsl7Y5X+/En7iUJrkFVCtNXCw/aE@nongnu.org X-Gm-Message-State: AOJu0YwKIKzQEEOL6GXP0Tp4u2Q2a2jbO/VPz2gBlkfxV9PT/R9XJMua Xrp+w41KnaSrgZYaLjix5NcVg9z9owssAnVWVyLMadM1k2iE8+l6f4GlMA== X-Gm-Gg: ASbGncstx7/ywXgm50xfd8TjPTHLfSM9R9FO4CD6RfZ14AsodMcn2J8nhzsdplwe04D 4hlZPZjO62u90F06yGougvE2Ngs/JktCuncX9EwjzXoAF4RpHyoYad08yqyMpr/WkHvgZ7Ijn/c jL0Wu2yWdXCSZO8s/mYwqdLDxnA/KZwqc8l9fJJZ2VEI9vL82oDRTH2Y6xEBR+aPzu0pI0T+vk3 Y5h3nsCtDIOzthKyfyz6JjumhYPxZLsfuJ5f/Nt8Vg/kGswthE2JV8waiJN7A2dff3dCL5Jh9Rm e77BXkHLMqotxXWDGLRaaA5AqJth3xci/zVaRpiZ/W05ogo6q1c= X-Google-Smtp-Source: AGHT+IGi4wHvI+5MNpS9XCi5oOHUyyU01BumluF6/rcaW1uKWw4ZtRQaZRSZMdZ5WPnXg4F9V3KjuA== X-Received: by 2002:a17:902:ef0b:b0:220:cd9f:a180 with SMTP id d9443c01a7336-22de70a316fmr28815085ad.53.1745907176291; Mon, 28 Apr 2025 23:12:56 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 01/13] hw/riscv/virt: Fix clint base address type Date: Tue, 29 Apr 2025 15:42:09 +0930 Message-ID: <20250429061223.1457166-2-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907240055019000 Content-Type: text/plain; charset="utf-8" The address is a hardware address, so use hwaddr for consistency with the rest of the machine. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 17a790821484..e4c0ac8a2a9a 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -324,7 +324,7 @@ static void create_fdt_socket_clint(RISCVVirtState *s, int cpu; g_autofree char *clint_name =3D NULL; g_autofree uint32_t *clint_cells =3D NULL; - unsigned long clint_addr; + hwaddr clint_addr; MachineState *ms =3D MACHINE(s); static const char * const clint_compat[2] =3D { "sifive,clint0", "riscv,clint0" @@ -340,8 +340,8 @@ static void create_fdt_socket_clint(RISCVVirtState *s, } =20 clint_addr =3D s->memmap[VIRT_CLINT].base + - (s->memmap[VIRT_CLINT].size * socket); - clint_name =3D g_strdup_printf("/soc/clint@%lx", clint_addr); + s->memmap[VIRT_CLINT].size * socket; + clint_name =3D g_strdup_printf("/soc/clint@%"HWADDR_PRIx, clint_addr); qemu_fdt_add_subnode(ms->fdt, clint_name); qemu_fdt_setprop_string_array(ms->fdt, clint_name, "compatible", (char **)&clint_compat, --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174590728027381.8903842775128; Mon, 28 Apr 2025 23:14:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eDP-00023t-Ew; Tue, 29 Apr 2025 02:13:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDI-0001n9-MB; Tue, 29 Apr 2025 02:13:04 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDH-0005P3-4Z; Tue, 29 Apr 2025 02:13:04 -0400 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-224019ad9edso84833855ad.1; Mon, 28 Apr 2025 23:13:02 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.12.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907181; x=1746511981; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=AOYvObSGVQcPGHwcgkBZGdkILj0IlErh2IJkkAXBH8w=; b=T13PIwsp+4qBnGXYSrPOkvzX+mCr5rPnhfv/htozojyPgUkx2qSxUeSf8O00pc5ltE TxRC7NXxZlZ4Qq5ym8+8xDhWRruk2yfyCLm2LfBElj9GG3nruKUfNqHPH/a2lVs0sCB4 JZPjKA5rTB/wR3eeKI9qquQunynqZ6AoWNtnczl38mSYWqwlFsAoSAN0g6ur8fLHb3+t bxgZz39Vu/MjbjK0Wdi89PeUZN3nw4pfDTz4tPwKRwcrd6nXc8ZNq0zSKfMTUPmvBIcE QUynlJiwxQ0SrXbUtbIPo6D+DcqKbfD4f+CTZDLbYOLg9BOz/piPaszaCF+ygsbSnED2 2IkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907181; x=1746511981; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AOYvObSGVQcPGHwcgkBZGdkILj0IlErh2IJkkAXBH8w=; b=ZM/6Av7E9OqY3F/GhEZX/pCLjSo0q/yzUSlkRWS/oCxszTlWvnG0R+Y1Ld1rBXr2gr NcTp5Z0VKrn3v011jBlnhC6oMAOny8xvtmJqEJoCCEsoc+vKtK5fXPpuwn1+mhpD/2gz 6KasRtZHpJaay3sEbWtRR5o2KNwWcl/DuBAMvOnoOsQczRW9WOc3FlvAR5NJcdkha1WU bWhB7IwfOwDzSSpxCWIxrEjyW/msb72K0njaOyqFLIavA8vLSBeZazW6wOJtQOIDeeud DXHIAAVe26YzzIImC+9WNHOR1EbgQ0NtlxhxazeuLBjHwhskekQnNMR2hz1irHz52xUg wSTA== X-Forwarded-Encrypted: i=1; AJvYcCV8PcK3zaFQJnRW43ZYw/yksz6rHw3Mug5QCFBB7zn4B90hUhzSJMJAAKzxZuqtLF3qhpHPv7NL/w06@nongnu.org X-Gm-Message-State: AOJu0YyFPcqe3dIahDrUy3dG16OkkSaWmxbEUC1+bAOhrz96EQVutL3k Je+wJKJFtD7OR7xtWcBybk0eCV+oqjPcLReRhN1AZk6nuv68ftUY X-Gm-Gg: ASbGncs2mq1ry4BUjviNjHqekuY+FcI2AbbwI+vYMD8mn/x9Xm4L4qKBkql/2ziVwwQ I84loRDOnZXhyg8LoqPhDOUj38tpBJeayI/m9iqajmp3ZVGlcqzpr9Q2S0iapxzBSuDcrDXnMdp GpTaKwBSWlQPD/QeegsL+btJBSwJp3Ni0cvyHMAhf+tIme4dFGm2dUXyxEQcPcq84Maa/t4m89/ uJ45V2Qbr1u4TBbdtSoxZO1dtGZ3dvAxWjlfw2pCIIxapm9zuBMl8L1w2xFEgGDAIuRS3Nax0/0 68Dei0U7k3chHGeuazsL4idmNqfDiJYJk07YkXCzjPeztgjyhTk= X-Google-Smtp-Source: AGHT+IF+SetXz7acNOBSgo2ffDQeHc73ugUdIIBrtyztYYWkVVKmtvhyKbcdCNn3uamsJrAio2ov9Q== X-Received: by 2002:a17:902:e5cd:b0:223:6180:1bea with SMTP id d9443c01a7336-22de7012492mr24342605ad.37.1745907181291; Mon, 28 Apr 2025 23:13:01 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 02/13] hw/riscv/virt: Use setprop_sized_cells for clint Date: Tue, 29 Apr 2025 15:42:11 +0930 Message-ID: <20250429061223.1457166-4-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907282241019000 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index e4c0ac8a2a9a..873d41d10c70 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -346,8 +346,8 @@ static void create_fdt_socket_clint(RISCVVirtState *s, qemu_fdt_setprop_string_array(ms->fdt, clint_name, "compatible", (char **)&clint_compat, ARRAY_SIZE(clint_compat)); - qemu_fdt_setprop_cells(ms->fdt, clint_name, "reg", - 0x0, clint_addr, 0x0, s->memmap[VIRT_CLINT].size); + qemu_fdt_setprop_sized_cells(ms->fdt, clint_name, "reg", + 2, clint_addr, 2, s->memmap[VIRT_CLINT].size); qemu_fdt_setprop(ms->fdt, clint_name, "interrupts-extended", clint_cells, s->soc[socket].num_harts * sizeof(uint32_t) * 4); riscv_socket_fdt_write_id(ms, clint_name, socket); --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907284065449.43889957448357; Mon, 28 Apr 2025 23:14:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eDP-00021y-9E; Tue, 29 Apr 2025 02:13:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDL-0001wh-Pf; Tue, 29 Apr 2025 02:13:08 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDJ-0005PI-N5; Tue, 29 Apr 2025 02:13:07 -0400 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-224341bbc1dso59993775ad.3; Mon, 28 Apr 2025 23:13:04 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907184; x=1746511984; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=GHG4jLuYhT3/O7GxrAmGctXYqSe38jPl85SUA9rHDRg=; b=GjRAysQSP2eBTengQDZFym+Wm0RxO7X7z4C0TOeJoK/RIhOT6X64XetP1KukA2EgOz cMNuLVoH4MZSNMnBUT/Q6q1zOM9QXLZhsEm4fqT2/oKY/HIHpJpFJFn4OWmLjbnoPAWp nuxKZ9HplK0MvIHCLHA544RsqisaQcr1i6RjcmAyP8yyUX3xYp2RLx67DLhgq5tkJNmG UUy+O0ACK4s26Ve6w7+CG4SWq+2sebo112GTdI7WZwE0cFGQs0Lbt93jRDEg27DMQ5v9 bV+yJjrSpnNA/Mlf9J7z2E0h3V+YaPGBK2tRVHvH3Q1zqBlwKXBJ9jzZ0Fydj66T8MSy E0YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907184; x=1746511984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GHG4jLuYhT3/O7GxrAmGctXYqSe38jPl85SUA9rHDRg=; b=e8HjvhLa4ygwwQDgOICXVxjfZiXvmvkanYknf75URCH5Ovx1VuetB7fOtgbtiDmkwL 56FSQU8ReNB3UlSW3ITTWp88aLcEZrDMgj0TxcolQiNawchyqI2VmD7b0KvM8wEaXuOc CuT5+q/Ziy1p/IKwa7O7QfvyMRbUGB9jgohAnwKVUs3EPqtKXD9+/tdKlsCLuLFR+sJb 8uRTYKzjjYiMAaBwXYmaWpN495QqKEiKBzCv6OKcJ27sW3No/dbn9EaZevFyjWOUTsLp kY/1yKu5IE1IhAfCLbhH5qthe7HgniaO52IYe/jwM3SJx5CfkD7hsdX8ff0vKD7bwLnS jQYA== X-Forwarded-Encrypted: i=1; AJvYcCVuApIszcYFUZASyUMcZguUVaEAAGSCa2fwWw3QkIiUFEKbUPv1oT+4w/XHJ5rM1CgcWvAgXt1EOWZi@nongnu.org X-Gm-Message-State: AOJu0YxZUlaaDbidHTpz6Wueg9Yif3wC4DplfXDWHO4B9yvsDxpXipMj 9rn1Xze+Uzqo15Mk03Y1BsChhz3tmfVeKnLDrIBfwWXlKCoVPGS0uh0p2Q== X-Gm-Gg: ASbGncttoosoAKIwrq/+1MsYNJ9P4jEfXwEoHP6ezc/LBNrLAYWQNPygfmn4IDpbm9M 9fB8Rk3V2i6NClOifjgQXmoF0vGhUR3Hyjd5xSJmxFpZp42x7IHRUvHaK1TaewUGMP4iz868Ilk hHFWsYd1BQYVxy2oIH2Eoq2uzDzUNd8cX+TgmbFABB1AUCDByEt8NMo/DwXzy6ndYjdC1Ti3prH yXk5gpGAXoDd0ECAUf7aTMOQR/4hCAV/eDu//wK9Q6p44XCVJ2Eczo+rEWtUBcUMayNySUQnx3d csrCCKEioCzzhXnXAyVfoey34KUZeCNpYjOWKoo/Tw+mR3polT0= X-Google-Smtp-Source: AGHT+IFRIgQQcLTE4Un4Y6VTqQ9+6U8Q8YbyuVlMMyqjpBhQ5shLzRN4Od7pYApP3apHxSOCFAtNkw== X-Received: by 2002:a17:902:ef4d:b0:22d:e57a:279b with SMTP id d9443c01a7336-22de7027fb8mr28213145ad.24.1745907183766; Mon, 28 Apr 2025 23:13:03 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 03/13] hw/riscv/virt: Use setprop_sized_cells for memory Date: Tue, 29 Apr 2025 15:42:12 +0930 Message-ID: <20250429061223.1457166-5-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907284251019000 Content-Type: text/plain; charset="utf-8" Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 873d41d10c70..ed28bc06114a 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -311,8 +311,7 @@ static void create_fdt_socket_memory(RISCVVirtState *s,= int socket) size =3D riscv_socket_mem_size(ms, socket); mem_name =3D g_strdup_printf("/memory@%"PRIx64, addr); qemu_fdt_add_subnode(ms->fdt, mem_name); - qemu_fdt_setprop_cells(ms->fdt, mem_name, "reg", - addr >> 32, addr, size >> 32, size); + qemu_fdt_setprop_sized_cells(ms->fdt, mem_name, "reg", 2, addr, 2, siz= e); qemu_fdt_setprop_string(ms->fdt, mem_name, "device_type", "memory"); riscv_socket_fdt_write_id(ms, mem_name, socket); } --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907343505577.698950114545; Mon, 28 Apr 2025 23:15:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eDn-0002iM-52; Tue, 29 Apr 2025 02:13:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDP-00024C-Br; Tue, 29 Apr 2025 02:13:11 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDN-0005Pp-Mr; Tue, 29 Apr 2025 02:13:11 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-af6a315b491so5477069a12.1; Mon, 28 Apr 2025 23:13:08 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.13.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907187; x=1746511987; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=uZJUjjM9v300ojzMKIAlTuxDEZlUpQCQVvYHl95EgTw=; b=bxweW6QZcI86vjhpbb6H+nLFHeaw61HdzKy4UCIi7Qna5HRDAB8iXIjqVSoHcZAM6G lAhvppw4rBMZcQDtBWL57TjGZK8pkKPlMiL36xUZvsNxrSUlBo3FVAIKfK8vCKU5qmCG JUOAQmEqJI22yT2oSlOA31nwBNGnp0ehBcbfHZogiXCdOD29mNzz5UAOEFlLyWSt6m2r NSbRdPuYe7wFXPLoZWHBQK9USc+plpT9xQiLAlRIXGkOKQxvAXbyVa8M0LyfA0anY/Ai 8/xHsHMwlR6JOAO30kQV90Xpwb5tLsqneNm6IuyI8wZu2Ft1Vski1Qyfz95f7pm9F+1I mX5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907187; x=1746511987; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uZJUjjM9v300ojzMKIAlTuxDEZlUpQCQVvYHl95EgTw=; b=DS+9kldammToNZra+n4OXQVZjTPbAq55mlJ7eB4/UZl+5Ynuk2u8uQJ2aWTE7500Lh QR56r6lsMT5LxOvde074672jx+LQVY7x9eGQEOc4roeRsKFUa+IJRWBdgktf8ZyxUNm7 80vxs2cCaqakVkNvDnxI08kNsJJVwV2dXVC1P+0T/KlUzjSCpdDAzX9cAI+oa/X1uceH 6gtCT54AiznOUQM0MD6/Z2rqtGiUyCO6E4terTbaNZBaYEJ2TggQucXYR9B8czBBqKn/ XZyLzmc8SK9oEC6DrmJPvH+SIel9ycU2w6J3oZUDXymtpWzi4k6n51AjjXHw5VFqf7RX 2VMQ== X-Forwarded-Encrypted: i=1; AJvYcCU8karXkqHudR98rTV7mDRUaUnQ0o9rTPLf+x26Cp/l98TLofNOxKTOR76MiWDjjHbIdEMuP5MQddaK@nongnu.org X-Gm-Message-State: AOJu0Yz60da6GrExtJUdP2rX+yHlXrxkbH6L/ZwHY0QCuWmhZobJ4ynY O0icLx1xjPbO2oRhMzTHR0mQOVY/e2nI2whSN3/3YmWJbi6dl449 X-Gm-Gg: ASbGnctstCu6TKVy8y4bpq4Tmrigwp5xn3RjL6BtJcjwXwHpSs14uLJZ9qvXSCQpiHr tC+4Tlydl9UvL03sc0shYUZb+Bq4xngSqL6mx22JEGwi8LanKRlMyG+82rvGeMFMVmAfloUZ0wy Qwl+5wMnsBW+I4isUyRngLRd020ehXlNwaWi30/AOrD19uvrNa51vqrOTHEKjTrA2FGM0xS5d5b R05BrCe7i7sj1hfr/UULHlRPMGDNgzs5iheqRGpQjva8wpfLXkUUV1fOQLMXlsVQ2abhNgPvaj/ ONUQzvVW7in5IH5Kfnot5f2ao66H4jJeWEGuq5lDXKk6D1Gezhs= X-Google-Smtp-Source: AGHT+IFUldUabu4A8pWfAFTjl45zk+MhnBYpjna4w7aLyBH0QbQ8LuLSnTtri6Q8ryI3AQc+a0HeQQ== X-Received: by 2002:a17:90b:4f:b0:2ff:72f8:3708 with SMTP id 98e67ed59e1d1-30a0133b154mr20181743a91.17.1745907186495; Mon, 28 Apr 2025 23:13:06 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 04/13] hw/riscv/virt: Use setprop_sized_cells for aplic Date: Tue, 29 Apr 2025 15:42:13 +0930 Message-ID: <20250429061223.1457166-6-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=joel.stan@gmail.com; helo=mail-pg1-x52b.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907344672019000 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index ed28bc06114a..62200ea39d07 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -655,8 +655,8 @@ static void create_fdt_one_aplic(RISCVVirtState *s, int= socket, qemu_fdt_setprop_cell(ms->fdt, aplic_name, "msi-parent", msi_phand= le); } =20 - qemu_fdt_setprop_cells(ms->fdt, aplic_name, "reg", - 0x0, aplic_addr, 0x0, aplic_size); + qemu_fdt_setprop_sized_cells(ms->fdt, aplic_name, "reg", + 2, aplic_addr, 2, aplic_size); qemu_fdt_setprop_cell(ms->fdt, aplic_name, "riscv,num-sources", VIRT_IRQCHIP_NUM_SOURCES); =20 --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907218297205.70387181624437; Mon, 28 Apr 2025 23:13:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eDU-0002Kk-Sw; Tue, 29 Apr 2025 02:13:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDQ-00026y-Ek; Tue, 29 Apr 2025 02:13:12 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDO-0005Pz-Pq; Tue, 29 Apr 2025 02:13:12 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2279915e06eso63118755ad.1; Mon, 28 Apr 2025 23:13:10 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907189; x=1746511989; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=cWkcFRsJpyggITDuSxIVooDZ/mBbjHxv03/6iVGQ8mI=; b=nekZXnimCoCUcS5Tz+DtSqlrVKYuhIha3OEN2kekxloIDXt/8LcN+7pWkPAd1pGbeT GRjWsfRW8hndLZpyiiTStaXJPDW+TYMZu5XkjSqBnpLUUNdsqNZpyRObj5srAGXwUSQn 2gENg6m+NhyKIz6Ekd1BlN9qfnyOyckiVLefzsu+coayzgZZ+p+cCIeLOc2PKHrESm6u E9ohhl46c5Iy989tbjfy3lP5czS4/sTpv3J9KpEhQNjylcb2WHiAVtSTegb/khecM8JQ aYWWwR4VJ1M7TEBpl77rJi2aiwk5PR2YajcSlGFDIx/vBdYHtFkkWfkH1GVkh4pAy25z mnXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907189; x=1746511989; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cWkcFRsJpyggITDuSxIVooDZ/mBbjHxv03/6iVGQ8mI=; b=IdnP2BWbUD7UOwHSU0lYmx4nZuioG/JdyFefsTSibZ0ucvEYYpmQwv+49ds+0oqgJG T80r24Jkx/3EqyLJZ+POi20bK5Wtibxk27nhzxfRvFP4kayXJy+hkiZRSold3XR8g69X ZPfDS0+zCxf8S70So2ACN4nBd4NAF9BdSKlc+nhbRBO42U3wk/tQvMoYvDclQ1g+p8oA Y/K5ppR/H4kd5l49yAWAbqqXt1CFbUum7sy/8wEuGAcbGxt/CV3MqTqy7wCpoVqYgOtz avEUn17eV+45zLTYzXdSdNfZ0UM+YcqVh91D+RzYuYX0ys+AKO7XbEve7rodIIilBWlK HBTw== X-Forwarded-Encrypted: i=1; AJvYcCUCf+yeXX/eYULjW1EN8k1aiGcVGUCD9bBq1XekB68m3tZoe4NvV0JUXy8Am+2XZyFRNjxcugAZtdkG@nongnu.org X-Gm-Message-State: AOJu0Yy69n+clJUsJQThcW/iU4/oSDK7Eg9UBD4udC/Lx9bA5A6dvq/z kMmcDwKyhU17zOgh/kRzW0xSYdtp8x/lkEbl4NCap5LLmJC6maaHf8MkjA== X-Gm-Gg: ASbGncuY7f98POblDY5CMsP1hV4J+RwEVs5XUZzFmaRuIqE1ADZpc0kALcOygpak5Ta jhatBLlJycB7RPnW7j06V8jeQ1TVF1+cUF5HTDfSeIiXdHEGhgdWK1eMU1eQggFpgzmahZxVpFZ rPnkC3FSu4stOTV1wwiuBvpYYKOB6WZz7/De64FfNnfJysSe4gigdUhQtUnjFpr4dxqSng4kl7O B+bP6gZyObwFwXDX4cicUbwHBDqxEMp5I8KTYLf4wlfVO7etpcQisgEtNYn/8ahNmjQ4P58TZX5 9lhDq6a98j/fkgFNpIjfoa+M+RmnJHjQAEKwPdLdH4yyfxgfkUo= X-Google-Smtp-Source: AGHT+IEKFombNcX7/DtSRuUHsUQ/C+MUMn9/cQevxTulBHvuGUDhyk5GFeNlyKO6hH0XV9bjXk50IA== X-Received: by 2002:a17:903:41d1:b0:224:2717:7992 with SMTP id d9443c01a7336-22dc6a6cff9mr182056625ad.33.1745907189043; Mon, 28 Apr 2025 23:13:09 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 05/13] hw/riscv/virt: Use setprop_sized_cells for aclint Date: Tue, 29 Apr 2025 15:42:14 +0930 Message-ID: <20250429061223.1457166-7-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907219989019000 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 62200ea39d07..0141ea4795e5 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -387,8 +387,8 @@ static void create_fdt_socket_aclint(RISCVVirtState *s, qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "riscv,aclint-mswi"); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, addr, 0x0, RISCV_ACLINT_SWI_SIZE); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, addr, 2, RISCV_ACLINT_SWI_SIZE); qemu_fdt_setprop(ms->fdt, name, "interrupts-extended", aclint_mswi_cells, aclint_cells_size); qemu_fdt_setprop(ms->fdt, name, "interrupt-controller", NULL, 0); @@ -410,11 +410,11 @@ static void create_fdt_socket_aclint(RISCVVirtState *= s, qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "riscv,aclint-mtimer"); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, addr + RISCV_ACLINT_DEFAULT_MTIME, - 0x0, size - RISCV_ACLINT_DEFAULT_MTIME, - 0x0, addr + RISCV_ACLINT_DEFAULT_MTIMECMP, - 0x0, RISCV_ACLINT_DEFAULT_MTIME); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, addr + RISCV_ACLINT_DEFAULT_MTIME, + 2, size - RISCV_ACLINT_DEFAULT_MTIME, + 2, addr + RISCV_ACLINT_DEFAULT_MTIMECMP, + 2, RISCV_ACLINT_DEFAULT_MTIME); qemu_fdt_setprop(ms->fdt, name, "interrupts-extended", aclint_mtimer_cells, aclint_cells_size); riscv_socket_fdt_write_id(ms, name, socket); @@ -428,8 +428,8 @@ static void create_fdt_socket_aclint(RISCVVirtState *s, qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "riscv,aclint-sswi"); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, addr, 0x0, s->memmap[VIRT_ACLINT_SSWI].size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, addr, 2, s->memmap[VIRT_ACLINT_SSWI].size); qemu_fdt_setprop(ms->fdt, name, "interrupts-extended", aclint_sswi_cells, aclint_cells_size); qemu_fdt_setprop(ms->fdt, name, "interrupt-controller", NULL, 0); --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907286075445.1742809043752; Mon, 28 Apr 2025 23:14:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eDn-0002lU-Rg; Tue, 29 Apr 2025 02:13:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDT-0002K3-B7; Tue, 29 Apr 2025 02:13:15 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDR-0005QH-FX; Tue, 29 Apr 2025 02:13:14 -0400 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-22423adf751so56127105ad.2; Mon, 28 Apr 2025 23:13:12 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.13.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907192; x=1746511992; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=fuk0Y1xOfJSfD3ObHIwg74fuvfC9MUqNk4U7Yn8ZUG0=; b=Z3LUPpiWBbwTSfo1CkpLup0vFI/qAmwSzwuJPvGbhow1g+MwyomZ1nPpesbaFrKlFy SI2sM/7Op8KGHOqdHPTFuldJiR7DvpFnBV+0dAl8l/ikRwOKK222bCx2P/I89RcfwdBr e/c5fAk/zWFo3zRSN6g1ni2pT52WvC4IhLV3zf2ei0vZnoztARn1FH1o9aSuPpJXn1Ah eUo9neZaAi0ENyPuCKVaoITSrYjFEQdNY5ciCc0pPqeTDANzaqphvWG7oszCF1j83Kad MA7cooBfmDi3NU3r1GbLywTpgQ08iqR+eMtMoCG/YPT2YMD6agaQWU4B4fB2//Xn7r/B 9PpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907192; x=1746511992; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fuk0Y1xOfJSfD3ObHIwg74fuvfC9MUqNk4U7Yn8ZUG0=; b=m8tqPJDFDuh9nY1ycUhQBkpbTumANQbGjP6Wmlptg4GDikp3SD7qevkoY/sSYMw+Hp pEM9+bJqTcX2bjB/yrHSQHp/1DLTcNaofcAyCIcX6D2VxdII30cia7tZUunDQmOB6A8R UgPtKvG4o7XGe21dXsUhXSPkfS6bweJRQX+qs3pCOXxGSPgbXcG2X1mkiTIEIxS1NBNV Sb0ZYt49/XzPE6vOsPr13l/10TUe/OTJoC11nPgaGKRlRbDhZRWzN72Wq45+AoEaxyh8 lvwPDoOPntYohskceFZDk+qE/oJrujfaLOKpWPHmqfd4YpLLgEQ/W087hn6tnyz4ozl0 HpNw== X-Forwarded-Encrypted: i=1; AJvYcCV2XpWBfzR3+DLNecko35Ire4QnxzEXBWu2kZal1nYhr35wW6zxJGnvTDAVa+fQxAgFFLh/LJYqjB34@nongnu.org X-Gm-Message-State: AOJu0YxpnXzIte5OABvEf/HX/kdrGRe9THPhvj7X5BHik1pdCJKpFcb6 vWdc8H4uDtrqA25CcoJNz04/yKvH4wV5BpSwWOqhwIM/NWGMbqwNhPun3g== X-Gm-Gg: ASbGncv86/DxuNqr4SiAmV8/rM8WjRsl8jzrM7AUWI5t4piAj2xVl8NY8pp7jUmzwRn TtW/frd/M3+D5qq7TTfCkP/sK4ytn5GdjvuBo2xkBgi80ETsnibK68ZzuftnOz1FEP53wYrOEKd zNUd6BKPTuQzC+ZCMqYxE9ZJwlGSMYUbN0QngLPC57mMrj1JVQxyGMBxykEjnF7Ri8Ioe2cZGoW /bx4PCACgWDnS4TQU0Z1gR8BpnBZgdCn+pXkl3iOr6wkXBK/wQZ0IHClettUaTgFHwYeHe5FE9x hkdqT9hUx0SPAGV6wbxk2NGyQuE1IoynkutUWfXbh4fr+Wb4AaQ= X-Google-Smtp-Source: AGHT+IHDrE+Vh6uTV5OaRMnSgadyvWRs9pbiTqFOaSVo5KVnWZts1LEhlLGmff1k+FV/DkMbP7Vv1Q== X-Received: by 2002:a17:902:e948:b0:223:517c:bfa1 with SMTP id d9443c01a7336-22de6f1175bmr30619885ad.38.1745907191563; Mon, 28 Apr 2025 23:13:11 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 06/13] hw/riscv/virt: Use setprop_sized_cells for plic Date: Tue, 29 Apr 2025 15:42:15 +0930 Message-ID: <20250429061223.1457166-8-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907287982019100 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 0141ea4795e5..3b4c3d6b2683 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -493,8 +493,8 @@ static void create_fdt_socket_plic(RISCVVirtState *s, s->soc[socket].num_harts * sizeof(uint32_t) * 4); } =20 - qemu_fdt_setprop_cells(ms->fdt, plic_name, "reg", - 0x0, plic_addr, 0x0, s->memmap[VIRT_PLIC].size); + qemu_fdt_setprop_sized_cells(ms->fdt, plic_name, "reg", + 2, plic_addr, 2, s->memmap[VIRT_PLIC].siz= e); qemu_fdt_setprop_cell(ms->fdt, plic_name, "riscv,ndev", VIRT_IRQCHIP_NUM_SOURCES - 1); riscv_socket_fdt_write_id(ms, plic_name, socket); --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907389314799.8001055270232; Mon, 28 Apr 2025 23:16:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eDs-00038t-Al; Tue, 29 Apr 2025 02:13:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDX-0002RU-Ez; Tue, 29 Apr 2025 02:13:21 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDU-0005Qh-9R; Tue, 29 Apr 2025 02:13:17 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-22435603572so63643115ad.1; Mon, 28 Apr 2025 23:13:15 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907194; x=1746511994; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=Dc4XVi0/KGrlG+96P+rusziL4/yPHrqiH7rbpSSJBU8=; b=S8C60NhGI39fOx4wFLWpr1WckXvWbofvGzOQnq+T2nKFi8pCywLE2I0uEtp0ZYB8JV JmGVsy2uEKmkRiIWslSky36qPAyBBQM1cel3duuYOhjQ4h1OKqCm4I/PZO+ydxoZM33E 7UcCqoYeFpeeEuKLenJICb+9DK810qulDopvP7nrwrjpcwudGyl+38hOPO1ZwEVEI28g WRJ7yMJbtzNPGjCSZDk8sasUWAqW5igb035pB9Nbm/YYcJshM58BaoMcNKrJrlElE41a j4iOtNXiFzlbTrbLNxVWPsA633wZ12nm6Cwa/0LCgKFy3TZA7K4AA4X9xDwUpexTM8YI b9Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907194; x=1746511994; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Dc4XVi0/KGrlG+96P+rusziL4/yPHrqiH7rbpSSJBU8=; b=O2LsEh3SFIJSwcW6VQpOxkXppvff4DNMctTgqDgHPrmH08weFjshSxO6P1JalBYOa8 OGAXKfqK7715vF6uV2EeWrHjR+Ul80q2Jgsr0u3wj+Bcy5+S6oq+tJrAhNIhJC1KYHAz 2LtQ1dCZxMYKQbb+HINwcfD/YKmT590pZ12wf3X3JTk+3QTXgmjyY+s9Oos/mUYzw1Pc RSv8BcxkG+qpvETYonqgOfrvo6lIa6X0BAfzxeOvBdaIxzHoHoi6EtYp9vQt8MLb6F1Z Vh6z3BNpIAhqvWGL2ByKjUgEIzznroyk5dbMIawa8W/ilTXj8APuUQbp09l4kKV5Hx5B cFWA== X-Forwarded-Encrypted: i=1; AJvYcCW2nWzR+ZurWJCInJMhr+k0Wc0n2AX+FClLoVWniff7gC6TPD05sAceHvZfQ6ZsqaQC3ANSphx6vTD0@nongnu.org X-Gm-Message-State: AOJu0Yw7zykihokkSYbLKSr71jVagfsvzcwTYlgroMIhSHRO5ViJh30x BdqAuUWQ4GbC7GFsV7d7okcSAsImb9ejhli/cb/KtCpjqhmi4A7Q X-Gm-Gg: ASbGnctFmfNxDxAAy/WVRY5SDCP2KnORXpqXV7ewIoAKXV6xMuyoA/LilOr0TC7TF+p Mt79zQWlYw3BHOhK6Jtbg/iBfvNJuro4y5KQJ3lDs6fvBHmzb8UKKSy7XaRVud9IPYuIhDEnDDf i0IC7jtBIh6j71MtvQnlEK24Zp2T2JTJ9CMXPe6BI8ahAyHkFSb9i8NWmjGCHW56DqH7YVyS3lq l6L46UPI+TtRJq9IEohlPrrKtFGD/CHoZRNd0bU+R8KqHHgbAoqSCsqpix3Q7kQJIVcuebwALYC NU2j22gwOauMf4jAMjcCWeF3zvxgXyVKbdOj1MG+K3r4s0qEk4o= X-Google-Smtp-Source: AGHT+IEn0tI2Dt17oe8tmFebUIV6dIPihdYcphwr1B1CnfisH1rW75ikcwEaDctV9ZI3yyVatbGzjw== X-Received: by 2002:a17:902:f544:b0:223:44c5:4eb8 with SMTP id d9443c01a7336-22de6062474mr33847135ad.32.1745907194008; Mon, 28 Apr 2025 23:13:14 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 07/13] hw/riscv/virt: Use setprop_sized_cells for virtio Date: Tue, 29 Apr 2025 15:42:16 +0930 Message-ID: <20250429061223.1457166-9-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907391218019000 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 3b4c3d6b2683..cf7e16cc6678 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -856,9 +856,7 @@ static void create_fdt_virtio(RISCVVirtState *s, uint32= _t irq_virtio_phandle) =20 qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "virtio,mmio"= ); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, addr, - 0x0, size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", 2, addr, 2, siz= e); qemu_fdt_setprop_cell(ms->fdt, name, "interrupt-parent", irq_virtio_phandle); if (s->aia_type =3D=3D VIRT_AIA_TYPE_NONE) { --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907264336585.4423610794831; Mon, 28 Apr 2025 23:14:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eE8-0003ZK-My; Tue, 29 Apr 2025 02:14:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDb-0002Tl-6Y; Tue, 29 Apr 2025 02:13:26 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDX-0005Qy-Ka; Tue, 29 Apr 2025 02:13:22 -0400 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-223fd89d036so69602785ad.1; Mon, 28 Apr 2025 23:13:17 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.13.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907196; x=1746511996; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=i5jQ6wutrbKpg8Tugc42Fb3JNM9evspVPMNApKKkwn0=; b=DPSH8weerqDMwgHNJqmmFwaQwALgCboqnuG8Y6GrO8IdwB4ApwoioX5fKVjyVt71N7 Ryt0rcWPecNVbMD/4nk1n1qFZh+9SqxT02HWd4mTG4EihHNiX2lxwFb3HADOJCBTS4g4 +GzrUnVbq922j4yepjwELryVbmAWAPpT51M8b+e89JhL+iLlTsFtkpLtRdYOsmU8O9dh kwdCxnKI2Pc6OpWilUoIa8/mnmhas+E/EIB+D3tPMPM3Yp9My+0kP/+3FixxLNVJJz17 64FiU1efMhskwN9Q6ByhDgFEWlvzLd/Jc9/0rGCu5XCby9hqtLGIw5mBAU5IaaqMwBma FJCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907196; x=1746511996; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i5jQ6wutrbKpg8Tugc42Fb3JNM9evspVPMNApKKkwn0=; b=aO8FEeVAqGSWyNZwjUYF5zENR7nx/Nv/lVbUS3Y7lt42wPi+33vi3g7ArdbO7nATsK 8zVdrXww7URTgwxIJooLW5pBX6mlydCCzhooN97BDHT6aQe8MjxGwrjJlYmvF5uvEalR 7oPv069RWcjnVWbmJFg5NJieHtc8EtpJNCkvtr82vS9S0OcyG8GTVZG7fzH22JfadSYy DjKO6wLX3gguvGs7+HjtRAHZv2T1cTUgOFM32YRydGDxm+g+SIJioYioV1nfrhiWI3H7 MQO+pRZAc7w5wAgBCX9SOb5RurUE7mWMaZVrlEqM+YBlHurtCm5EldebrmybuAxSA15P RByg== X-Forwarded-Encrypted: i=1; AJvYcCUvRvhTsSQEC+CluNLDMf7QxBLsjIxCOGYiHRi2+fxso1zbL/PvhoT58NO2SYxHAG5xQ9FT3A+b4IBE@nongnu.org X-Gm-Message-State: AOJu0Yzz8yWtAhMQMVjF8tAqmdk8ie+9JX03PiuusEqqzpRqCGw0Hu+c XtI2Qqm/gbEemfYHWzUtCTUPDY+6XDk1GTrxS/j++ZiRL3ulYVwzc/bmtQ== X-Gm-Gg: ASbGncvsh35YniiaaZuQbPiuVTvuqngc30SeZOY3ppsIQPUpPCapC+Arb5T7e/BNQ1L lZkWovHbVUvYblaw6tIMqRWcXgQs/RwUY43ubXTYiga5Z8Gw7M9W4qItZShlJcFgxAX8kNK/Tv3 kBv1EYcrUOuKo4tqM5zNTpWx+8Uj0+IuV/IsEw1UMpIVK6N0oJgoXWq4NiTLyLT8+Y+DlqHqbMw nLPGVNPa/KEcLsadQ6BOY7BSPpoaSMuL2NOnphUXG6bKDqK6nJQG7OQh6patV6eD0mqkaLySuYg mOSddS3KuldYkfgRwZDTrqV7zpQkFyA2wm6+1qT5dnqIq/wcDgA= X-Google-Smtp-Source: AGHT+IFO6ZhzVehfjitzSOHJLmRRXTnSuJfRp7PiCXE4Bnf8xHb44Lp/5kbNdEsdvFN+GyzIGPS//Q== X-Received: by 2002:a17:903:2ec8:b0:216:6901:d588 with SMTP id d9443c01a7336-22dc69ffb69mr178117665ad.15.1745907196493; Mon, 28 Apr 2025 23:13:16 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 08/13] hw/riscv/virt: Use setprop_sized_cells for reset Date: Tue, 29 Apr 2025 15:42:17 +0930 Message-ID: <20250429061223.1457166-10-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x634.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907265980019100 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index cf7e16cc6678..baa894b11aa6 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -932,8 +932,9 @@ static void create_fdt_reset(RISCVVirtState *s, uint32_= t *phandle) qemu_fdt_setprop_string_array(ms->fdt, name, "compatible", (char **)&compat, ARRAY_SIZE(compat)= ); } - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, s->memmap[VIRT_TEST].base, 0x0, s->memmap[VIRT_TEST].size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, s->memmap[VIRT_TEST].base, + 2, s->memmap[VIRT_TEST].size); qemu_fdt_setprop_cell(ms->fdt, name, "phandle", test_phandle); test_phandle =3D qemu_fdt_get_phandle(ms->fdt, name); g_free(name); --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907420973781.0924578371655; Mon, 28 Apr 2025 23:17:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eDt-0003Em-Ir; Tue, 29 Apr 2025 02:13:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDc-0002WQ-J6; Tue, 29 Apr 2025 02:13:26 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDZ-0005RE-E9; Tue, 29 Apr 2025 02:13:24 -0400 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-225df540edcso66427255ad.0; Mon, 28 Apr 2025 23:13:20 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907199; x=1746511999; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=INpqRh2T9UJjALxwNPfMzJttYIUZLc9Q29sL9hwX7Gc=; b=cPX8VMpLiLnih5s4TRlF14JrF/V1aEen6/90yazDcQjtZvzOJRjZabbwWx0CSj8W8f NyzDZWm/TJD+mpE+u//kykWaxnZVL8T1AJEvXSdrAmMKRm2md3myE+pqnpUFKqWihEva 8U0reLZlegTuoHQ2WcUFFc+HTHcfYXSGvCH8ahC0Mc3w0OWZaCpkTb/wM03jrD/Ruq33 yb09tPBQwDgKl0B/eYbE+bxb8slwalQOLL/LOtt5R42v43VlCpxA+MXVchZCSQZmP1KD HxuFpj8FNuux5QP1EBRJFYy4Gi17PE9FdeCBFYUd5iEeL9A9ytrYFLiH2CFCi4OFrUyT O0Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907199; x=1746511999; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=INpqRh2T9UJjALxwNPfMzJttYIUZLc9Q29sL9hwX7Gc=; b=XyVrtcuKkTbMSzGVxBLwx/JqCXSS6C37158z++f/BY9fKYJ0t04vdmNhiBp6E8mikY DUWRP9YbXJh1fT4SgCNcpQ6JNScu+F1JyKwDagBwFOrnVdEepmuudhNNCbXdWbJQZP5L /IfhamBNMlVcXs5ryH+FjgAXd0P3o3cyLLah82cWdS0DlH7SMeoJ79qZUEaCJlQqp4VG qCwtIxLx4Z58cUvO4yc9DK7t9NLfN0Nv+wn+WPLv+L/9UZ3mJC0cqWpW8yxR3R9xBnyD WXQVGv79as4sDQKjX+0w4yGJX9Gm7PHeJ6hCaRaNUV8b+pm4foralLjDTHa0Nt+MiU0f 60bA== X-Forwarded-Encrypted: i=1; AJvYcCVAuIYLgQRZ2CCDlqRdsw6+KzELH3bheEieDaq4s1yphpW5R6aV5X32e0Ry7yG6r1MMctIXQdDBgVpv@nongnu.org X-Gm-Message-State: AOJu0YzJRVpMS+UY9tdZaQfoOfmVd7nBzlEdCWDjWLVf4QekqcM07T/2 3Qmi41UBo4UNTY9wiMolqqjpdH2dNoplXCj5QHxhg3g3KHD96CTKIE3K2g== X-Gm-Gg: ASbGncsTuE17guyoYXIqVEVGGDjG8ZPmKQNj9TGvGiWI+3PPDpIEAj8ydnafr7oVb4b UBeFS/pS0vVZTOfTOunmZmiqVwt1ixHreZM49WbQSjwpRlcaGm/Hj0R7UVU8BeMiyc9+T0xtF5k /YQG711+noLrEf/OXO+g+TsXx4LcDSiSLCdyCwY49Ip/GlrREyVzw8HDmgMIoV3nqkQaiFyP2Dt QEkYnhMBMPR8M/yd6z14iFAZUqVy0OJYy6ppko/bQ4sb2IPhRWbYuy0QZA1PP2ROD3mCkBd7YIE 0L+PbYr7TRqlk/AFdPFu1JTS2u/ceyMj/Xo0nhnNNqf3a3aASN0= X-Google-Smtp-Source: AGHT+IG0eegMiX3Tci+XA45yEuBDC0eREFeXygoXIJpLSeeC7y1oiQf2UaQ4XUbOGK7kShZa7vwaLg== X-Received: by 2002:a17:902:cf10:b0:224:7a4:b31 with SMTP id d9443c01a7336-22de6bfdeb1mr24861335ad.6.1745907198956; Mon, 28 Apr 2025 23:13:18 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 09/13] hw/riscv/virt: Use setprop_sized_cells for uart Date: Tue, 29 Apr 2025 15:42:18 +0930 Message-ID: <20250429061223.1457166-11-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62b.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907422516019100 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index baa894b11aa6..d9303c9bb033 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -966,9 +966,9 @@ static void create_fdt_uart(RISCVVirtState *s, s->memmap[VIRT_UART0].base); qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "ns16550a"); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, s->memmap[VIRT_UART0].base, - 0x0, s->memmap[VIRT_UART0].size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, s->memmap[VIRT_UART0].base, + 2, s->memmap[VIRT_UART0].size); qemu_fdt_setprop_cell(ms->fdt, name, "clock-frequency", 3686400); qemu_fdt_setprop_cell(ms->fdt, name, "interrupt-parent", irq_mmio_phan= dle); if (s->aia_type =3D=3D VIRT_AIA_TYPE_NONE) { --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907285755829.4929929990135; Mon, 28 Apr 2025 23:14:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eE8-0003Yc-Mu; Tue, 29 Apr 2025 02:14:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDd-0002X8-7J; Tue, 29 Apr 2025 02:13:30 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDb-0005RS-G5; Tue, 29 Apr 2025 02:13:24 -0400 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-22c33e4fdb8so59608655ad.2; Mon, 28 Apr 2025 23:13:22 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907202; x=1746512002; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=WxlPI2Cvo+aYt0rDJ/RZsKYq/rKLYTpIrIvw7Wpa0ew=; b=XvvcV19KzjJu94T6ug7vL1zXpSQMmN2g0YXnRklZVLNwqDmw33eLqqKznKKmJ5YwXh Muoip6w1u8jSa+9+Cdb1uEoG/n37v51uKD2GxUspRbopOhTtvLOKrAdll00e3eYwom/Z P1EVhx7hTntX4Cg1ZI1MB1Z9kWgHHHgk45WeZanU6GGm2RUlI0Fg37i9LwKYY2CNBI96 qd25zMZt7BWWexZeai/dGf5MsrXay+i37Objs16+zSe2s3p1/Yr+DmUndGcBUvNEX295 uZES5Xsi3CPuE9V7TBU6g9gLPt1nAbsG47HFZOfsYmmO5qQi1nt7Tvogdjq5EPfG62aE INtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907202; x=1746512002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WxlPI2Cvo+aYt0rDJ/RZsKYq/rKLYTpIrIvw7Wpa0ew=; b=UKmSM4SSq5e89oP/IJ417cZOjGbD8+CWp4hIsM93WxBoKIAnKIMBt33l+PslLsEdzx neOqKpKd/D/nrRz39V1kSjCGL/Ntv4P9DvXRsKRY+avfPocm/tUV3Exw4YfOhKr+yz+l FQWNLDNM7vb6ZpN6U/CV0yvn5pna8dhsXGBKcygoXzTptjdj5/I4shMBv+Nng8dO0l96 HnHnK4JUlW8PhDcJ/0O/VlAPph6TzPr7te9Al9FEm0/dIFl3/cTnKJVZDjYUp+p7VmPv YNfekjI9Dd8MZiodqTfMz5txnkQOVbac40xWd0+gt5r8G8HmqiPHzQAZSLiL7SdF7P4r XaHQ== X-Forwarded-Encrypted: i=1; AJvYcCXA4iXCZFdybHgfLSR4bVciBmt7+vETbJezZ+ulUojWNBN2QL0CU2vKrrY/pycu5874KSmMzOehCybO@nongnu.org X-Gm-Message-State: AOJu0YxZtvIyXq24ISsJ6RSR4syQ2/HXiC2OJ1mPYxj/KbXGmp701FAE 9II39ZA9VLVT2CV+vJABo2faZ7V6i12kDb1TT14FXdjd4Oy/HUrVGcSQaQ== X-Gm-Gg: ASbGncvgOJFCy099a46XPUORjOvWvGSt4PjsAS4xtPIpZFywPOv3Csl4pGzRHHeeuhS xmec+L61g1qGp2DExO+6TLER6Om1eXQYTGSE6dWOYF7oOJX0Nx3mD6Or4+WvY65mjzcBvj/gsV6 uFU2JuahR2kKVlnjF7LhZAxascfNJV9H+0V06rAOtS+spNdMpE82udaVZXVBxZoN6T/MAmyM89s LQTgn6C1T/AAxI3uyaHntAy6HBW8HOtbCzb4mDCFI7lRAqK3X8z08toa422fE4K4DT4fkpFJn7m RzPP666xxpGzOaeED1u5XUZvE1XGgs7KWxS10SLmjUcbU30cwKFO9dqqkxx0Xw== X-Google-Smtp-Source: AGHT+IHGd7RoTEuqvYQxIqXo+LbRYVo414Ih3xk3Y1sgp1FJrOV2dc098erqm/x0wbRZ5IQ31ArIqA== X-Received: by 2002:a17:903:120d:b0:223:47b4:aaf8 with SMTP id d9443c01a7336-22de60a3e97mr33309615ad.52.1745907201632; Mon, 28 Apr 2025 23:13:21 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 10/13] hw/riscv/virt: Use setprop_sized_cells for rtc Date: Tue, 29 Apr 2025 15:42:19 +0930 Message-ID: <20250429061223.1457166-12-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x629.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907287985019100 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index d9303c9bb033..823ef7cbe447 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -992,8 +992,9 @@ static void create_fdt_rtc(RISCVVirtState *s, qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "google,goldfish-rtc"); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, s->memmap[VIRT_RTC].base, 0x0, s->memmap[VIRT_RTC].size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, s->memmap[VIRT_RTC].base, + 2, s->memmap[VIRT_RTC].size); qemu_fdt_setprop_cell(ms->fdt, name, "interrupt-parent", irq_mmio_phandle); if (s->aia_type =3D=3D VIRT_AIA_TYPE_NONE) { --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907426363232.97399238796334; Mon, 28 Apr 2025 23:17:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eEX-0004Il-5n; Tue, 29 Apr 2025 02:14:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDg-0002dn-Vt; Tue, 29 Apr 2025 02:13:30 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDd-0005Ro-Vn; Tue, 29 Apr 2025 02:13:28 -0400 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2260c91576aso47211765ad.3; Mon, 28 Apr 2025 23:13:25 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907204; x=1746512004; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=gWxHh/yKpF2zaOUrrsaau/2srMsb179Ya0dY8ENIKYo=; b=ZhOTBG/qP8anJMD/ULvya+H5R54crvcaMAx644M+Uha6PpBKU6WAv1hTjv7EUKYYmG /FjrhYjPTALl0ZwbsfqN9mwI3xPIanSdHytzGp6L+qLfE35rugCwbPwsCKkGVPbsGhJg yTTMIMKvPWej+z8SoM6HBOoEeqkFkaD1zivO+Hn3IPrqa9+A7Su50u0KKm3RvgaYUVML Uc3ZqREdZOSVhJ25YxSgpHWR8sYKWmEJ07qvXlM7STwXzCy+Rm0hRMhGyBtVyK8pQkEo oLj1ogvftQVSvn50h7lzlWTr3n/9o6/SprMHt/M0+Z4k4EjjW8RSo2gQeOBLayKFal8A cing== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907204; x=1746512004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gWxHh/yKpF2zaOUrrsaau/2srMsb179Ya0dY8ENIKYo=; b=bKYiYVH8WCM4UlIjeRB1zgYkyWyGOgoTF0Ktypaktd3YfscSZhW8+NKoCFmk3ffqc7 rQIyNoA9t50M4x0XrJ3vB5SoFmOJ/PDFouvmSAu/47A+Ev/b2gumB3+wOfJIWwgHV4Kn WsHzZmIHjDxsFFQl9O9PA8jstsiKrUfTw4ZsRdXwV98+YSPF5KZoIy5qyVgBVrHd/OOz Jh1wDCi+zzgRx24tyIM0Ge/Pj4ubmDx0AyqBET5Jl/X2Trm7+GCMsNIlWWVPMrOQJPWS KhLAIMAkxMBNJPqbVQ4g+32W4tCy6jW/Wqts8NL1lct0gw2Cobl/QfdsdZsDLdTiyIUr Sv9A== X-Forwarded-Encrypted: i=1; AJvYcCWOmcNtE0jUUKCXVBxPT5tl/g6BBsJGvY9Bhiioteb/qLK7D34eQE1VGbdfqAnvXNtshCbydmxVEBKg@nongnu.org X-Gm-Message-State: AOJu0YyRmc6BHleByU4vCHQelWd9YSmYjFjiWqQgzrASe0zOyYsIGajX PRf6xMT0hYd/Rn6hHr6m6ZPFJ9ZkVf+HiSNXs9OYttnLPxMpw6TOynaRAA== X-Gm-Gg: ASbGncvip5PjE/GHbDGtIF+kJVtcpHOnYMGcpfCgtSeDtfJ3632KCZ51RU2lb3iPUMi TlZtELI4PMgiPE3E6mNga6GrcD4L3oMV07Bk5C9JAbGMACJEktWZP4yyZ++EJXXHZxdKqphIgUB XFzznNd74XIOhBIak9NKLBwBV5b1h9s9j35Latn+8LY7ujcAKXeO/s0ezzL5ZhGFhfBB24cNt9h uswztfO7C8FnfHu3XPDeT44U1PBXaVbEte/iSG7h6gzkbh6fEOvWikRkJq+UjdWquvCItJVELDA b3h29FtqEzxRM+Z2EKVMOATE2FkQRXbf6VB4uysrDgGC0+zpmv4= X-Google-Smtp-Source: AGHT+IF+LIV7Qk6S59MyOpf6NVddImk7M0oT/AC9cEZT3KEIqLTiBEFRonoIY990a8Z+mduVgI/NKA== X-Received: by 2002:a17:902:dcd4:b0:22d:e458:96a5 with SMTP id d9443c01a7336-22de45897f3mr39932765ad.38.1745907204306; Mon, 28 Apr 2025 23:13:24 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 11/13] hw/riscv/virt: Use setprop_sized_cells for iommu Date: Tue, 29 Apr 2025 15:42:20 +0930 Message-ID: <20250429061223.1457166-13-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907426754019000 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 823ef7cbe447..f8943f81790c 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -1088,8 +1088,7 @@ static void create_fdt_iommu_sys(RISCVVirtState *s, u= int32_t irq_chip, qemu_fdt_setprop_cell(fdt, iommu_node, "#iommu-cells", 1); qemu_fdt_setprop_cell(fdt, iommu_node, "phandle", iommu_phandle); =20 - qemu_fdt_setprop_cells(fdt, iommu_node, "reg", - addr >> 32, addr, size >> 32, size); + qemu_fdt_setprop_sized_cells(fdt, iommu_node, "reg", 2, addr, 2, size); qemu_fdt_setprop_cell(fdt, iommu_node, "interrupt-parent", irq_chip); =20 qemu_fdt_setprop_cells(fdt, iommu_node, "interrupts", --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907492473176.04375844282015; Mon, 28 Apr 2025 23:18:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eEW-0004CQ-Hg; Tue, 29 Apr 2025 02:14:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDk-0002hY-NB; Tue, 29 Apr 2025 02:13:34 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDh-0005S4-9Z; Tue, 29 Apr 2025 02:13:31 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-227c7e57da2so47536955ad.0; Mon, 28 Apr 2025 23:13:27 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907207; x=1746512007; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=iktpIu7SWJtpnnDwsmtRLfc5OtKIy8xH5BFHKzvdoFE=; b=BI9ov5arGprxI4WclIbMYsYoFPi67l2V8H+7DzHAx1HxSJdEhreCqDTwbrqOi7lP1h 8WU5RW+/0Ch/MBVQY5gUo7lyJGTlWywxgR7lsh6yysc0Tw3AxnqlsoFTUjZLi+mt/IX1 AcxgHV+f1J5CWA7aAemsE1yNTV2zPx1iZkrTUx/n3Mt4ZKdr3Ugo6E394TqN1hyZ3LhY 0o/9A00mUBUjuD1OvfR4l1g4pgz2dk708wozRWjoRYv3Md0f0mACWNNHI6g6xJMLhv2D vdT7tWJ07217M3ca8RDtPtTVA1oLUdNDodNveRqyYQrAY8kTCcCzPbgSQQmeXxCqZnie L8BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907207; x=1746512007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iktpIu7SWJtpnnDwsmtRLfc5OtKIy8xH5BFHKzvdoFE=; b=suC7ZdP89D+jmQjKa3nYQCvlX1KtttrQX96cIRBZwPYlWg10WWKZ61zgpN5sVEF57c BC6d9XrCKWmt3qYBIvVc8qi2HBNfgLDgWi72Va9fWUhwVgSfj28uaRyIpznNnqX19M79 4MkgZLZppKMCP1L2k5FHNEaG6H6geu8+EN+DPpDL8n82lJGtFpfJi0UgcI5aTlef9vqF ZIxOMkqhtxLh4fuTa/98l1m8ncw7Y64zniXDsUHwfcJK2n1O8f4ErmMt9m/E8DU9L22i DiAXDDYFwI9WYVjCPl7RcbVZ9eJQ5EOHjaELBgbXwT4jHVXbXW436uH7ycEgwqHKil06 Ym6Q== X-Forwarded-Encrypted: i=1; AJvYcCUZmIUTYCd03wYfBrYoqDRz4odroiOjawrPvOmJdTmNjOy3XmlJNiDSLnYQbVR+xWYjZDvH7SuXgIso@nongnu.org X-Gm-Message-State: AOJu0Yz5Y2JiGkM84Pxmxch49GewggHpDVnR90zRQ1FGOOMB3S1NUqnc XPXr25mzzqDek3nK7pjrOyMJKT2B/wC9UD9KVJy7phhDaUHx46r9oddMPQ== X-Gm-Gg: ASbGncsO7fJSzt5shH+hrwVpu1Vy06idbQ07STx3j/rKiMrBjVgrmOWZBaz85LnUrPO wtr9VCu/+VxqcepSwO1hIiXkpAxsj+y7lKi4deR0HYnfW9R3cfmTfyVuKz3fUBrD2qnSPB680hR 9RLUehIJLs+kVgIxrGBwyzp2RTAsbjMpvbCpnGjAhA6lgkhtaE8jp2p2uWmXgS+LxgfXs5dErtb 2rANc7tAWHIKwVozgfhQDjQIXv+nZ76XfzXgp/Q2e5Fu8UulhtTGVXCiWbi3qUDnADKaI/dW691 EHZlWs2xike50QE+VjjyjRkzsUGwRn2rk6OJDW6XnUV4M7W9ss4= X-Google-Smtp-Source: AGHT+IFgetI6sus7o9QHIx7THDiC5T3npX8Cf2qF2P25MrTljoQgDmdgruFQ5tFCrfQKY3VN1TtHyA== X-Received: by 2002:a17:903:1b6b:b0:224:160d:3f5b with SMTP id d9443c01a7336-22dc6a827efmr179985605ad.49.1745907206776; Mon, 28 Apr 2025 23:13:26 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 12/13] hw/riscv/virt: Use setprop_sized_cells for pcie Date: Tue, 29 Apr 2025 15:42:21 +0930 Message-ID: <20250429061223.1457166-14-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907494670019100 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- hw/riscv/virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index f8943f81790c..cd19c266e62a 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -894,8 +894,8 @@ static void create_fdt_pcie(RISCVVirtState *s, if (s->aia_type =3D=3D VIRT_AIA_TYPE_APLIC_IMSIC) { qemu_fdt_setprop_cell(ms->fdt, name, "msi-parent", msi_pcie_phandl= e); } - qemu_fdt_setprop_cells(ms->fdt, name, "reg", 0, - s->memmap[VIRT_PCIE_ECAM].base, 0, s->memmap[VIRT_PCIE_ECAM].size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", 2, + s->memmap[VIRT_PCIE_ECAM].base, 2, s->memmap[VIRT_PCIE_ECAM].size); qemu_fdt_setprop_sized_cells(ms->fdt, name, "ranges", 1, FDT_PCI_RANGE_IOPORT, 2, 0, 2, s->memmap[VIRT_PCIE_PIO].base, 2, s->memmap[VIRT_PCIE_PIO].size, --=20 2.47.2 From nobody Sat Nov 15 23:37:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745907355900218.48092497956645; Mon, 28 Apr 2025 23:15:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9eE0-0003Se-St; Tue, 29 Apr 2025 02:13:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9eDk-0002hq-UY; Tue, 29 Apr 2025 02:13:34 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9eDj-0005SJ-1J; Tue, 29 Apr 2025 02:13:32 -0400 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-22c336fcdaaso66176325ad.3; Mon, 28 Apr 2025 23:13:30 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52169casm93947765ad.238.2025.04.28.23.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745907209; x=1746512009; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=Tu+TdgkyipnRFzu83KfGnUiONb88PJrh8832DmQzyXc=; b=bdKi6sc75/5aCoU/YuiL3SZPFaQ/RJUIxmGztiIVDIkci/xIXAyt2/3/NOnbgsLeuS KQnkMwRU4Yf7qtejG8gf7c4znsZb95svtmJ2dLdGl1NUjHS7LAFfLI2tAtWb8v684PcT 7oGZOOEDBDVkcrPlGRXvvHSvhfVdRllJwnmjGPBiKc+kN7HgZ0fvtyuDzi7Ny316xmVT HD7YGxJnVnZMKWkaQ6S9rE9rWPeR9va7SMCDIM/B6+XrvdUO+2yi9w5+81B4SuoONkdD vzPo7MWMtX8JB8qPA7xcKaIa3ljvw6frpvm0xJgIehHxIHlacxKTKEgdIx5DLO02w6CO ruGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745907209; x=1746512009; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Tu+TdgkyipnRFzu83KfGnUiONb88PJrh8832DmQzyXc=; b=vhHAf8SELhDkZR6KUAltchOwY6x3WxsJRI7n0264TpDuKL0WNhZ9Nxd8B3Fnfx4cE4 DVs4e5M/74S/FdnCmaZT4QqA70bc+YOpPvgzmWtpURsou+rnuc0kvfJ7QXUVGOc5Bu2D XvP2K6I+W4pODRrkzjZvirdr5eunfENe2YPUy+E4fMyHXvSfUUlqONksKfKDVjY9QPZ4 1wNM9eqmjPHSdj8pEVxUgdAG+OH6rBcVlGDikhZEjjm6d6L2uhol8zJ6mrj9Hp7WykoD ipaaBj18u8s2DXkaFalwp+5CwvnuDPZDh8KYhSTaUcZNAbP6tIy8Zjcuh/P+6Lcjd6Fm SbDA== X-Forwarded-Encrypted: i=1; AJvYcCVw5Swiy5FXgvfHlSoa/B8ofUUi1OUFDLV8H68O2UafzId8MhGKukez4OVS0tY6AnDRCmR1ip+cL7OC@nongnu.org X-Gm-Message-State: AOJu0Yz7fSf/tNpWmlAKTliEMhRAqwFzexJUsWhVgW7QUBvDs7zlwVsI eWQRAF65Swgz6LcrOAZK8IS9haFDDicySZ6vhnADB/dzlBnViwcXNQZBaA== X-Gm-Gg: ASbGncs5NvpM3BQ2LOXjCpQ5ggRD02QqS+Y8j/jnyrO2WFqyldWzB1E2opuyB/aGZaV kILjpJJdn8e0ZGPnxicBIrCTDyH9iA/04eLAY8fyUYJW1oUjWXVrQ/fYqelIKYImYFEf65gVakj eTliSR5ntPTvAwzzdtR4FhkFkVacex5MP7rOaZSvJ19eVe1yhuvq/HtpO9tjQAqVu41MkZAfz0m ZOQOziMzmlvO8CXyta0DZprFknrw1Zloj0DNy23TdAE9iYUXmcBwZLZ8hXWb9nuh1+X3Kz8W3oP uUboNxPvUOAYQcGZv+DERMkMYtzyagxMtDh7CNXzJgnJp+bpme0= X-Google-Smtp-Source: AGHT+IHz8jP7H2Kwmd1ohVKDKPqm5SoYfmxw2wnZC/XkXJlA4r2ji+xXedVOgfgfvCfOVeEkBrJNNA== X-Received: by 2002:a17:903:1aaf:b0:224:78e:4eb4 with SMTP id d9443c01a7336-22de6066eb6mr33913185ad.39.1745907209255; Mon, 28 Apr 2025 23:13:29 -0700 (PDT) From: Joel Stanley To: Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 13/13] NOMERGE: virt: Adjust devices so everything is > 4G Date: Tue, 29 Apr 2025 15:42:22 +0930 Message-ID: <20250429061223.1457166-15-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429061223.1457166-1-joel@jms.id.au> References: <20250429061223.1457166-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745907358315019100 Content-Type: text/plain; charset="utf-8" Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis --- hw/riscv/virt.c | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index cd19c266e62a..1162b3a4b71a 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -80,27 +80,27 @@ static bool virt_aclint_allowed(void) } =20 static const MemMapEntry virt_memmap[] =3D { - [VIRT_DEBUG] =3D { 0x0, 0x100 }, - [VIRT_MROM] =3D { 0x1000, 0xf000 }, - [VIRT_TEST] =3D { 0x100000, 0x1000 }, - [VIRT_RTC] =3D { 0x101000, 0x1000 }, - [VIRT_CLINT] =3D { 0x2000000, 0x10000 }, - [VIRT_ACLINT_SSWI] =3D { 0x2F00000, 0x4000 }, - [VIRT_PCIE_PIO] =3D { 0x3000000, 0x10000 }, - [VIRT_IOMMU_SYS] =3D { 0x3010000, 0x1000 }, - [VIRT_PLATFORM_BUS] =3D { 0x4000000, 0x2000000 }, - [VIRT_PLIC] =3D { 0xc000000, VIRT_PLIC_SIZE(VIRT_CPUS_MAX * 2= ) }, - [VIRT_APLIC_M] =3D { 0xc000000, APLIC_SIZE(VIRT_CPUS_MAX) }, - [VIRT_APLIC_S] =3D { 0xd000000, APLIC_SIZE(VIRT_CPUS_MAX) }, - [VIRT_UART0] =3D { 0x10000000, 0x100 }, - [VIRT_VIRTIO] =3D { 0x10001000, 0x1000 }, - [VIRT_FW_CFG] =3D { 0x10100000, 0x18 }, - [VIRT_FLASH] =3D { 0x20000000, 0x4000000 }, - [VIRT_IMSIC_M] =3D { 0x24000000, VIRT_IMSIC_MAX_SIZE }, - [VIRT_IMSIC_S] =3D { 0x28000000, VIRT_IMSIC_MAX_SIZE }, - [VIRT_PCIE_ECAM] =3D { 0x30000000, 0x10000000 }, - [VIRT_PCIE_MMIO] =3D { 0x40000000, 0x40000000 }, - [VIRT_DRAM] =3D { 0x80000000, 0x0 }, + [VIRT_DEBUG] =3D { 0x0 | BIT(36), 0x100 }, + [VIRT_MROM] =3D { 0x1000 | BIT(36), 0xf000 }, + [VIRT_TEST] =3D { 0x100000 | BIT(36), 0x1000 }, + [VIRT_RTC] =3D { 0x101000 | BIT(36), 0x1000 }, + [VIRT_CLINT] =3D { 0x2000000 | BIT(36), 0x10000 }, + [VIRT_ACLINT_SSWI] =3D { 0x2F00000 | BIT(36), 0x4000 }, + [VIRT_PCIE_PIO] =3D { 0x3000000 | BIT(36), 0x10000 }, + [VIRT_IOMMU_SYS] =3D { 0x3010000 | BIT(36), 0x1000 }, + [VIRT_PLATFORM_BUS] =3D { 0x4000000 | BIT(36), 0x2000000 }, + [VIRT_PLIC] =3D { 0xc000000 | BIT(36), VIRT_PLIC_SIZE(VIRT_CP= US_MAX * 2) }, + [VIRT_APLIC_M] =3D { 0xc000000 | BIT(36), APLIC_SIZE(VIRT_CPUS_M= AX) }, + [VIRT_APLIC_S] =3D { 0xd000000 | BIT(36), APLIC_SIZE(VIRT_CPUS_M= AX) }, + [VIRT_UART0] =3D { 0x10000000 | BIT(36), 0x100 }, + [VIRT_VIRTIO] =3D { 0x10001000 | BIT(36), 0x1000 }, + [VIRT_FW_CFG] =3D { 0x10100000 | BIT(36), 0x18 }, + [VIRT_FLASH] =3D { 0x20000000 | BIT(36), 0x4000000 }, + [VIRT_IMSIC_M] =3D { 0x24000000 | BIT(36), VIRT_IMSIC_MAX_SIZE }, + [VIRT_IMSIC_S] =3D { 0x28000000 | BIT(36), VIRT_IMSIC_MAX_SIZE }, + [VIRT_PCIE_ECAM] =3D { 0x30000000 | BIT(36), 0x10000000 }, + [VIRT_PCIE_MMIO] =3D { 0x40000000 | BIT(36), 0x40000000 }, + [VIRT_DRAM] =3D { 0x80000000 | BIT(36), 0x0 }, }; =20 /* PCIe high mmio is fixed for RV32 */ --=20 2.47.2