From nobody Thu Dec 18 00:22:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1745528969; cv=none; d=zohomail.com; s=zohoarc; b=ixPLGCZmwWkV+FlTyIonpXF07k0QehxYqS7e9dVUa+p8YwbLlRDuSXan42x6mtkc4Ryg5qU3VfJqKtwRqpln7optH+Yh0ssRhPCVBsN7sCGuDQCp3/nbNOcyLUcM4Vd1yZ91/FX8zFDd3ipjsFQKgq+dYvBjaGmsj4ixb4MFbZk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745528969; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5PDfmKs2FRYilFGSf9BHWC+dQMg43pD84g/qhAfepq4=; b=TPjpjmKkJse9a90bZHBnRiHBdxZW+elwNTw0WA6uKxuJNCKsFi1KYvG3MrHt3X9SJXe83/13jTZgt/kxDsbPyPtvSBI5FxcQy0iBzKdkbxQ1K44u14UD1e7fuZfG1ALrmAQIJfNBCxjQC2v6ucDgOvgxkR0Gxfxm4EHgILDuZiw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745528969608945.8315677313916; Thu, 24 Apr 2025 14:09:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u83ox-0005wJ-Qa; Thu, 24 Apr 2025 17:09:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83ot-0005v5-6P for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83or-0001Jw-B2 for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:18 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-391-tJ2gIA6XMfqUsg5aBmibdQ-1; Thu, 24 Apr 2025 17:09:10 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 797A818004A7; Thu, 24 Apr 2025 21:09:09 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.88.13]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AD55F30001A2; Thu, 24 Apr 2025 21:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745528956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5PDfmKs2FRYilFGSf9BHWC+dQMg43pD84g/qhAfepq4=; b=ayO87ZkLEUlFI4WDG/oYvkXR5gxDGCos85swVjqy4khGxaLZluPPDj/a0QwMpPL9wqhtrM utydKbqwpdX9E1CTL2XCvMCpyWBhxnCmTuvBUkmtU6nY/8lC4yqTLOdZT9PnPw8TPCJywP hhGIbXfxzYrb92ArcUdVIe2YbrgqlqU= X-MC-Unique: tJ2gIA6XMfqUsg5aBmibdQ-1 X-Mimecast-MFC-AGG-ID: tJ2gIA6XMfqUsg5aBmibdQ_1745528949 From: John Snow To: qemu-devel@nongnu.org Cc: John Snow , Markus Armbruster , Michael Roth , Cleber Rosa , Peter Maydell Subject: [PATCH v3 1/6] qapi: Add some pylint ignores Date: Thu, 24 Apr 2025 17:08:59 -0400 Message-ID: <20250424210904.2505114-2-jsnow@redhat.com> In-Reply-To: <20250424210904.2505114-1-jsnow@redhat.com> References: <20250424210904.2505114-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.84, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1745528970113019000 Content-Type: text/plain; charset="utf-8" This restores the linting baseline in QAPI. Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- scripts/qapi/backend.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/qapi/backend.py b/scripts/qapi/backend.py index 14e60aa67af..49ae6ecdd33 100644 --- a/scripts/qapi/backend.py +++ b/scripts/qapi/backend.py @@ -13,6 +13,7 @@ =20 =20 class QAPIBackend(ABC): + # pylint: disable=3Dtoo-few-public-methods =20 @abstractmethod def generate(self, @@ -36,6 +37,7 @@ def generate(self, =20 =20 class QAPICBackend(QAPIBackend): + # pylint: disable=3Dtoo-few-public-methods =20 def generate(self, schema: QAPISchema, --=20 2.48.1 From nobody Thu Dec 18 00:22:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1745529000; cv=none; d=zohomail.com; s=zohoarc; b=liELkOwz6H51NWFwsStP0a5AbjEOOMH1UBCk4IqENIofTtcuNZxpWkfXeys/1PQfKGmlIzDpdXYmnMp/ekuAvUx1wHaOQJOa2XLAc23NreHkuIGItVetVVAwqCMYv8aaChkyBfPlm1BpVgBiHotH6jTm4duLVnU5kFVrBh/a0K4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745529000; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=f/b85gJL7xVHanuZJX/dXUtQRv8HVdyerj2fpryzRbk=; b=Uuylr0JgxFdsJOHIyzbM1jD050MGeL/02nRS/iPoOZw7RVfLBGxdFzckJcN5DYeF/w0S87gwyxc+gjxOQhVlSQEuCl9L7MTud5RF510BD1SFpyCPceGor27fN227eJb3bjhlWiKD0Vfu8MkKU9HA1gSy0or9jDIumFX0L5GYvO0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745529000527613.7733611248516; Thu, 24 Apr 2025 14:10:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u83ot-0005vK-QP; Thu, 24 Apr 2025 17:09:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83or-0005un-Vt for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83oq-0001Jn-9k for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:17 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-9TjKTdWlOR-gkVMHmCHHbA-1; Thu, 24 Apr 2025 17:09:12 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 510B9195608E; Thu, 24 Apr 2025 21:09:11 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.88.13]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BD43430001AB; Thu, 24 Apr 2025 21:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745528954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f/b85gJL7xVHanuZJX/dXUtQRv8HVdyerj2fpryzRbk=; b=iBsnb4h90QatuW59OdZLgsaecI1r2D9zibm99Lb5keqtW73GgQZBDtSVqfuYGHkXNtw8Sy 2xTDXzjeFUDKSreYdkAK3DucUpKSTkGC6g9nE8DwUKTk+joz0tExB4WfT4zMvDmSJzj1y8 cMSPsJ7/tc7pHqFZdoobcY4Mz9egDn4= X-MC-Unique: 9TjKTdWlOR-gkVMHmCHHbA-1 X-Mimecast-MFC-AGG-ID: 9TjKTdWlOR-gkVMHmCHHbA_1745528951 From: John Snow To: qemu-devel@nongnu.org Cc: John Snow , Markus Armbruster , Michael Roth , Cleber Rosa , Peter Maydell Subject: [PATCH v3 2/6] docs/qapidoc: linting fixes Date: Thu, 24 Apr 2025 17:09:00 -0400 Message-ID: <20250424210904.2505114-3-jsnow@redhat.com> In-Reply-To: <20250424210904.2505114-1-jsnow@redhat.com> References: <20250424210904.2505114-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.84, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1745529002210019000 Content-Type: text/plain; charset="utf-8" This restores the linting baseline in qapidoc. The order of some imports change slightly here due to configuring isort a little better: previously, isort was having difficulty understanding that "compat" and "qapidoc_legacy" were local modules because docs/sphinx "isn't a python package". Configuring this manually, isort chooses a different import ordering, which _is_ intentional here. Also: extra ignores are added for pylint. The most recent versions of pylint don't require these ignores, but the oldest versions we support do, so in the extra ignores go. Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- docs/sphinx/qapi_domain.py | 25 ++++++++++++++----------- docs/sphinx/qapidoc.py | 5 +++-- 2 files changed, 17 insertions(+), 13 deletions(-) diff --git a/docs/sphinx/qapi_domain.py b/docs/sphinx/qapi_domain.py index c94af5719ca..ebc46a72c61 100644 --- a/docs/sphinx/qapi_domain.py +++ b/docs/sphinx/qapi_domain.py @@ -20,16 +20,6 @@ =20 from docutils import nodes from docutils.parsers.rst import directives - -from compat import ( - CompatField, - CompatGroupedField, - CompatTypedField, - KeywordNode, - ParserFix, - Signature, - SpaceNode, -) from sphinx import addnodes from sphinx.directives import ObjectDescription from sphinx.domains import ( @@ -44,6 +34,16 @@ from sphinx.util.docutils import SphinxDirective from sphinx.util.nodes import make_id, make_refnode =20 +from compat import ( + CompatField, + CompatGroupedField, + CompatTypedField, + KeywordNode, + ParserFix, + Signature, + SpaceNode, +) + =20 if TYPE_CHECKING: from typing import ( @@ -56,7 +56,6 @@ ) =20 from docutils.nodes import Element, Node - from sphinx.addnodes import desc_signature, pending_xref from sphinx.application import Sphinx from sphinx.builders import Builder @@ -168,6 +167,8 @@ class QAPIDescription(ParserFix): """ =20 def handle_signature(self, sig: str, signode: desc_signature) -> Signa= ture: + # pylint: disable=3Dunused-argument + # Do nothing. The return value here is the "name" of the entity # being documented; for QAPI, this is the same as the # "signature", which is just a name. @@ -210,6 +211,8 @@ def _get_fqn(self, name: Signature) -> str: def add_target_and_index( self, name: Signature, sig: str, signode: desc_signature ) -> None: + # pylint: disable=3Dunused-argument + # name is the return value of handle_signature. # sig is the original, raw text argument to handle_signature. # For QAPI, these are identical, currently. diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py index 661b2c4ed0e..8011ac9efaf 100644 --- a/docs/sphinx/qapidoc.py +++ b/docs/sphinx/qapidoc.py @@ -27,6 +27,7 @@ =20 from __future__ import annotations =20 + __version__ =3D "2.0" =20 from contextlib import contextmanager @@ -56,8 +57,6 @@ QAPISchemaVisitor, ) from qapi.source import QAPISourceInfo - -from qapidoc_legacy import QAPISchemaGenRSTVisitor # type: ignore from sphinx import addnodes from sphinx.directives.code import CodeBlock from sphinx.errors import ExtensionError @@ -65,6 +64,8 @@ from sphinx.util.docutils import SphinxDirective, switch_source_input from sphinx.util.nodes import nested_parse_with_titles =20 +from qapidoc_legacy import QAPISchemaGenRSTVisitor # type: ignore + =20 if TYPE_CHECKING: from typing import ( --=20 2.48.1 From nobody Thu Dec 18 00:22:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1745529038; cv=none; d=zohomail.com; s=zohoarc; b=LYi8QqdLaaINNw8kwNV+ZQs6dMoGQ5hCrmHrpRKbkPh65Pcl1pq1wHhkNwhVyUP6WZBS8Neft57h5UlhN9dnHtvgT8iJd6aHnx6squUwz6hTqz/sa2ONGmkEMlf34HnLJKUEpv9okLaJPSmnkIEvY+R1J7FVw+ILF+Wam+FQTQI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745529038; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=f2Gd4l5OJt8E6olS/WX2slCeQRVOJ0F0HIGale2vGgE=; b=BLkV8ArbUErKCFoow2t2P+wyULncnd88h52xU+COMjWkXSUAKKCjqWpX3dq1XmX3r0+5oFVNFqOOfvxWoCTbID7XQ8wyRPkdtZGl/oYQ48w1HZoWjnYz/KYBXqKtUgHKn5p+3eVx0d/+fjVkCD1s4o3glRFQ/kXlevRkBwWFLZM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745529038678905.6785197385016; Thu, 24 Apr 2025 14:10:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u83ov-0005vj-3X; Thu, 24 Apr 2025 17:09:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83os-0005uv-If for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83oq-0001Ju-V1 for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:18 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-107-RAIt_D-jMnujdv1tTEZKdA-1; Thu, 24 Apr 2025 17:09:14 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BE5EC180087C; Thu, 24 Apr 2025 21:09:13 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.88.13]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B868630001A2; Thu, 24 Apr 2025 21:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745528956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f2Gd4l5OJt8E6olS/WX2slCeQRVOJ0F0HIGale2vGgE=; b=Yz3AGDJbNyDdDS8OVmqowxuW3jDMqE3Zpf4A04SI4C9EqK3RwQeEXLVLL5Qvr20RTELJbr 3zATlMr9gpRgx5XYUrw051LPA5SaZGt4O1wmNWRHFvOBZcPhL6WBiAtVDSw7r5i/tIASAK Zaw4TAEXUbAxvydJ68Upo39bwshbw5M= X-MC-Unique: RAIt_D-jMnujdv1tTEZKdA-1 X-Mimecast-MFC-AGG-ID: RAIt_D-jMnujdv1tTEZKdA_1745528953 From: John Snow To: qemu-devel@nongnu.org Cc: John Snow , Markus Armbruster , Michael Roth , Cleber Rosa , Peter Maydell Subject: [PATCH v3 3/6] python: update missing dependencies from minreqs Date: Thu, 24 Apr 2025 17:09:01 -0400 Message-ID: <20250424210904.2505114-4-jsnow@redhat.com> In-Reply-To: <20250424210904.2505114-1-jsnow@redhat.com> References: <20250424210904.2505114-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.84, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1745529040147019100 Content-Type: text/plain; charset="utf-8" We pin all dependencies for the "check-minreqs" test because pip lacks a dependency resolver that installs "the oldest possible package that meets dependency criteria". So, in order to test our stated minimum requirements, we pin all of our dependencies (and their dependencies, transitively) at the oldest possible versions that still work and pass tests; proving that our minimum requirements are correct. (It also ensures no new features accidentally sneak in from developers on newer platforms.) A few transitive dependencies were omitted from the pinned dependency file by accident; as a result, pip's dependency solver can pull in newer dependencies, which we don't want. This patch corrects the previous oversight and pins the missing dependencies. Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- python/tests/minreqs.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/python/tests/minreqs.txt b/python/tests/minreqs.txt index a3f423efd84..19c0f5e4c50 100644 --- a/python/tests/minreqs.txt +++ b/python/tests/minreqs.txt @@ -38,10 +38,14 @@ pyflakes=3D=3D2.5.0 =20 # Transitive mypy dependencies mypy-extensions=3D=3D1.0.0 +tomli=3D=3D1.1.0 typing-extensions=3D=3D4.7.1 =20 # Transitive pylint dependencies astroid=3D=3D2.15.4 +dill=3D=3D0.2 lazy-object-proxy=3D=3D1.4.0 +platformdirs=3D=3D2.2.0 toml=3D=3D0.10.0 +tomlkit=3D=3D0.10.1 wrapt=3D=3D1.14.0 --=20 2.48.1 From nobody Thu Dec 18 00:22:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1745528972; cv=none; d=zohomail.com; s=zohoarc; b=Xz6eyRt4RHscQOx4zD102B/CZ1i+4/ZHNvTBO2ZpSWspc6V5xtUJtrmWz35+vZRx/qwYZCzJby4ORtLMYxCbwiCZg12AtZhhYNVtX4REPVzKdouheiLvRCFzS071+7NPDfd9By514O8vOYj6nIvVslwhMsRSzmLYv52R/9+pbvE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745528972; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=a7KDP7cJJ7YwUFLjBcHPdXdi/y3nSKSycoGJYh7h388=; b=ZGgcfz9XL9TuY4U5U+4E2/nDZo4/RjNggnLOa2XhqSfjzCIm3ibsxofsmJio8M9nyrCUZLDPmiW33jhjF2IYc2ZWo7CeBhvHR6UvFJl2qUqcGwzimHdH2TYEmsLG1NeLvIE22Dlq5biwMUgWpxWHUeAe8fyM0KYdt3xFvTYOo3U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745528972420402.44896558143193; Thu, 24 Apr 2025 14:09:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u83oz-0005wg-SF; Thu, 24 Apr 2025 17:09:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83ox-0005wK-Lq for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83ov-0001KO-Or for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:23 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-o2_W9g01MQebRgDRngPmqg-1; Thu, 24 Apr 2025 17:09:17 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A2DD81955DDA; Thu, 24 Apr 2025 21:09:16 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.88.13]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7746E30001A2; Thu, 24 Apr 2025 21:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745528961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a7KDP7cJJ7YwUFLjBcHPdXdi/y3nSKSycoGJYh7h388=; b=JJbXHiND441oHr5OxVUjpRPL6pjn2byYisjvXD8/ACGmJEexIAI4nVviafrRyTBhrPcmXc 5crEtmwpLl+lLrPnRN5EMaRhJiT8IkH1xOxDqcZWFrUzwisdGj+94L9O/6BUwoRwM6N9De O8pvOIK/9XSY+hCDSe/EQA/MgybE0Vg= X-MC-Unique: o2_W9g01MQebRgDRngPmqg-1 X-Mimecast-MFC-AGG-ID: o2_W9g01MQebRgDRngPmqg_1745528956 From: John Snow To: qemu-devel@nongnu.org Cc: John Snow , Markus Armbruster , Michael Roth , Cleber Rosa , Peter Maydell Subject: [PATCH v3 4/6] python: add qapi static analysis tests Date: Thu, 24 Apr 2025 17:09:02 -0400 Message-ID: <20250424210904.2505114-5-jsnow@redhat.com> In-Reply-To: <20250424210904.2505114-1-jsnow@redhat.com> References: <20250424210904.2505114-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.84, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1745528974348019100 Content-Type: text/plain; charset="utf-8" Update the python tests to also check QAPI and the QAPI Sphinx extensions. The docs/sphinx/qapidoc_legacy.py file is not included in these checks, as it is destined for removal soon. mypy is also not called on the QAPI Sphinx extensions, owing to difficulties supporting Sphinx 3.x - 8.x while maintaining static type checking support. mypy *is* called on all of the QAPI tools themselves, though. flake8, isort and mypy use the tool configuration from the existing python directory (in setup.cfg). pylint continues to use the special configuration located in scripts/qapi/ - that configuration is more permissive. If we wish to unify the two configurations, that's a separate series and a discussion for a later date. The list of pylint ignores is also updated, owing again to the wide window of pylint version support: newer versions require pragmas to occasionally silence the "too many positional arguments" warning, but older versions do not have such a warning category and will instead yelp about an unrecognized option. Silence that warning, too. As a result of this patch, one would be able to run any of the following tests locally from the qemu.git/python directory and have it cover the QAPI tooling as well. All of the following options run the python tests, static analysis tests, and linter checks; but with different combinations of dependencies and interpreters. - "make check-minreqs" Run tests specifically under our oldest supported Python and our oldest supported dependencies. This is the test that runs on GitLab as "check-python-minreqs". This helps ensure we do not regress support on older platforms accidentally. - "make check-tox" Runs the tests under the newest supported dependencies, but under each supported version of Python in turn. At time of writing, this is Python 3.8 to 3.13 inclusive. This test helps catch bleeding-edge problems before they become problems for developer workstations. This is the GitLab test "check-python-tox" and is an optionally run, may-fail test due to the unpredictable nature of new dependencies being released into the ecosystem that may cause regressions. - "make check-dev" Runs the tests under the newest supported dependencies using whatever version of Python the user happens to have installed. This is a quick convenience check that does not map to any particular GitLab test. (Note! check-dev may be busted on Fedora 41 and bleeding edge versions of setuptools. That's unrelated to this patch and I'll address it separately and soon. Thank you for your patience, --mgmt) Finally, finally, finally: this means that QAPI tooling will be linted and type-checked from the GitLab pipelines. Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- python/setup.cfg | 1 + python/tests/minreqs.txt | 21 +++++++++++++++++++++ python/tests/qapi-flake8.sh | 4 ++++ python/tests/qapi-isort.sh | 6 ++++++ python/tests/qapi-mypy.sh | 2 ++ python/tests/qapi-pylint.sh | 6 ++++++ scripts/qapi/pylintrc | 1 + 7 files changed, 41 insertions(+) create mode 100755 python/tests/qapi-flake8.sh create mode 100755 python/tests/qapi-isort.sh create mode 100755 python/tests/qapi-mypy.sh create mode 100755 python/tests/qapi-pylint.sh diff --git a/python/setup.cfg b/python/setup.cfg index cf5af7e6641..84d8a1fd30d 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -47,6 +47,7 @@ devel =3D urwid >=3D 2.1.2 urwid-readline >=3D 0.13 Pygments >=3D 2.9.0 + sphinx >=3D 3.4.3 =20 # Provides qom-fuse functionality fuse =3D diff --git a/python/tests/minreqs.txt b/python/tests/minreqs.txt index 19c0f5e4c50..94928936d44 100644 --- a/python/tests/minreqs.txt +++ b/python/tests/minreqs.txt @@ -11,6 +11,9 @@ # When adding new dependencies, pin the very oldest non-yanked version # on PyPI that allows the test suite to pass. =20 +# Dependencies for qapidoc/qapi_domain et al +sphinx=3D=3D3.4.3 + # Dependencies for the TUI addon (Required for successful linting) urwid=3D=3D2.1.2 urwid-readline=3D=3D0.13 @@ -49,3 +52,21 @@ platformdirs=3D=3D2.2.0 toml=3D=3D0.10.0 tomlkit=3D=3D0.10.1 wrapt=3D=3D1.14.0 + +# Transitive sphinx dependencies +Jinja2=3D=3D2.7 +MarkupSafe=3D=3D1.1.0 +alabaster=3D=3D0.7.1 +babel=3D=3D1.3 +docutils=3D=3D0.12 +imagesize=3D=3D0.5.0 +packaging=3D=3D14.0 +pytz=3D=3D2011b0 +requests=3D=3D2.5.0 +snowballstemmer=3D=3D1.1 +sphinxcontrib-applehelp=3D=3D1.0.0 +sphinxcontrib-devhelp=3D=3D1.0.0 +sphinxcontrib-htmlhelp=3D=3D1.0.0 +sphinxcontrib-jsmath=3D=3D1.0.0 +sphinxcontrib-qthelp=3D=3D1.0.0 +sphinxcontrib-serializinghtml=3D=3D1.0.0 diff --git a/python/tests/qapi-flake8.sh b/python/tests/qapi-flake8.sh new file mode 100755 index 00000000000..7b5983d64a9 --- /dev/null +++ b/python/tests/qapi-flake8.sh @@ -0,0 +1,4 @@ +#!/bin/sh -e +python3 -m flake8 ../scripts/qapi/ \ + ../docs/sphinx/qapidoc.py \ + ../docs/sphinx/qapi_domain.py diff --git a/python/tests/qapi-isort.sh b/python/tests/qapi-isort.sh new file mode 100755 index 00000000000..f31f12d3425 --- /dev/null +++ b/python/tests/qapi-isort.sh @@ -0,0 +1,6 @@ +#!/bin/sh -e +python3 -m isort --sp . -c ../scripts/qapi/ +# Force isort to recognize "compat" as a local module and not third-party +python3 -m isort --sp . -c -p compat -p qapidoc_legacy \ + ../docs/sphinx/qapi_domain.py \ + ../docs/sphinx/qapidoc.py diff --git a/python/tests/qapi-mypy.sh b/python/tests/qapi-mypy.sh new file mode 100755 index 00000000000..377b29b873b --- /dev/null +++ b/python/tests/qapi-mypy.sh @@ -0,0 +1,2 @@ +#!/bin/sh -e +python3 -m mypy ../scripts/qapi diff --git a/python/tests/qapi-pylint.sh b/python/tests/qapi-pylint.sh new file mode 100755 index 00000000000..f4bb7a5a795 --- /dev/null +++ b/python/tests/qapi-pylint.sh @@ -0,0 +1,6 @@ +#!/bin/sh -e +SETUPTOOLS_USE_DISTUTILS=3Dstdlib python3 -m pylint \ + --rcfile=3D../scripts/qapi/pylintrc \ + ../scripts/qapi/ \ + ../docs/sphinx/qapidoc.py \ + ../docs/sphinx/qapi_domain.py diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc index d24eece7411..e16283ada3d 100644 --- a/scripts/qapi/pylintrc +++ b/scripts/qapi/pylintrc @@ -19,6 +19,7 @@ disable=3Dconsider-using-f-string, too-many-instance-attributes, too-many-positional-arguments, too-many-statements, + unknown-option-value, useless-option-value, =20 [REPORTS] --=20 2.48.1 From nobody Thu Dec 18 00:22:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1745529051; cv=none; d=zohomail.com; s=zohoarc; b=PbH8AVRAYTUgdJva37BJ/7RziO5IE3NLg008cGErIi2xArrbOoKJWAmzHMVRCWEuJUMYGck0hHlXFbu+QDDAUjWhdhOwKji3sV5Ro+s2lUClrjb3iRBpeK+I/jozPdSAS8NQ+JsxnOc+LYavF4/Jd7qF4fXd8OSyL5KiF+VSy5g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745529051; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=99tLQcN2KpmDghu92PB/OZ/RnLhkXlTx6d+hJOVZpOw=; b=AV5ui3WBymcQfqbHE+lA69HsYYggbFMfNiKUNLjG+R+rf/+FFZP6x+fUZIQSOa0AcCr5B2LVW6Nr1fdcNW4N1wZlewoVF0ZYC9Lt/TFCyGlcS+3SxYibmp5prO/nrHFfTsz4TySggD+H+aMrwcy9QW/KIB7JxyxB0pNpRBxW/Bg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745529051762411.30531219263094; Thu, 24 Apr 2025 14:10:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u83p4-00062V-7w; Thu, 24 Apr 2025 17:09:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83p0-0005wv-AI for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83oy-0001Ks-RZ for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:26 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584--VlGTVLMPNWfYOT4yA1WYg-1; Thu, 24 Apr 2025 17:09:20 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ABD871800875; Thu, 24 Apr 2025 21:09:18 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.88.13]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC72630001A2; Thu, 24 Apr 2025 21:09:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745528963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=99tLQcN2KpmDghu92PB/OZ/RnLhkXlTx6d+hJOVZpOw=; b=fUVkX3n+w8sZTYzTrTMipUQvJMS84wQiYitzbhEr870MER6NvOOPWgYZaxydnnM9YhhHQq 5jjgrfD1dZCtIoG//+Nxj7IMquJ7IPtosM27rMQuvKD8rRJmJwk+iJybBwod6Zs5bmJtbF eqU5iDp51GMux3mjshsZ4WA4fXBgBFQ= X-MC-Unique: -VlGTVLMPNWfYOT4yA1WYg-1 X-Mimecast-MFC-AGG-ID: -VlGTVLMPNWfYOT4yA1WYg_1745528959 From: John Snow To: qemu-devel@nongnu.org Cc: John Snow , Markus Armbruster , Michael Roth , Cleber Rosa , Peter Maydell Subject: [PATCH v3 5/6] python: Drop redundant warn_unused_configs = True Date: Thu, 24 Apr 2025 17:09:03 -0400 Message-ID: <20250424210904.2505114-6-jsnow@redhat.com> In-Reply-To: <20250424210904.2505114-1-jsnow@redhat.com> References: <20250424210904.2505114-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.84, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1745529054199019100 Content-Type: text/plain; charset="utf-8" From: Markus Armbruster strict =3D True implies warn_unused_configs =3D True. Signed-off-by: Markus Armbruster Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- python/setup.cfg | 1 - 1 file changed, 1 deletion(-) diff --git a/python/setup.cfg b/python/setup.cfg index 84d8a1fd30d..757f41d9491 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -80,7 +80,6 @@ exclude =3D __pycache__, [mypy] strict =3D True python_version =3D 3.8 -warn_unused_configs =3D True namespace_packages =3D True warn_unused_ignores =3D False =20 --=20 2.48.1 From nobody Thu Dec 18 00:22:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1745528975; cv=none; d=zohomail.com; s=zohoarc; b=MOxdq4mmdfKuzfeiTqBmRFeKD6869vZBzQcW2dUuG+5pi+ET84+G4jRvHUVH3D+PwUkeN8tGn/YcgDn4EAQNFNpqOl2kXRh55jJQqKYHRpk1RnCAAeZwEAxxcL3v6eFS2uTXsfZmzyJHYkFlwVcIiONGjcqd2O5XYguFUCEqx+g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745528975; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HnNdYThJ8kqgSSeURTEkjrC1QSMAtMDkG/bPZplBkFk=; b=LS1dsOHDYs21HSqemXyAUBsFOVnLY0XM6CkASY7lt6rKY36sex5e6D/2xvhuXr1houFJ6iknltkzZptT9veTkaFlccVrGWtiaIGUxuffuU0h9LenHTZnvmRqIQ7LAbOo4czb51S/Oyn9hqEUp8rNsF4x2hTDH8KfYrWbUSNVi7I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1745528975312469.1037586342221; Thu, 24 Apr 2025 14:09:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u83p5-00066t-CN; Thu, 24 Apr 2025 17:09:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83p2-000603-20 for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u83p0-0001LA-FI for qemu-devel@nongnu.org; Thu, 24 Apr 2025 17:09:27 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-r-EONePuNFOwc_uAyz5YzA-1; Thu, 24 Apr 2025 17:09:22 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 596921800878; Thu, 24 Apr 2025 21:09:21 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.88.13]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4507630001AB; Thu, 24 Apr 2025 21:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745528965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HnNdYThJ8kqgSSeURTEkjrC1QSMAtMDkG/bPZplBkFk=; b=UIC+7b8UEd9F4KsPYQwpKUbiA940fscQIaxbZ73+h9TIxD/lIUSIu9rUo9wqFgoKgXXabq 7uvYZk4tJ+k/qjEoDPrnYWyfV23iBlkMWa0+DofT6aLtVLgy2ca4ewd9N4u2HDPL9Wv2ad xclpHPpKNLBEDra+h1PmhkYXkj8bDBM= X-MC-Unique: r-EONePuNFOwc_uAyz5YzA-1 X-Mimecast-MFC-AGG-ID: r-EONePuNFOwc_uAyz5YzA_1745528961 From: John Snow To: qemu-devel@nongnu.org Cc: John Snow , Markus Armbruster , Michael Roth , Cleber Rosa , Peter Maydell Subject: [PATCH v3 6/6] qapi: delete un-needed python static analysis configs Date: Thu, 24 Apr 2025 17:09:04 -0400 Message-ID: <20250424210904.2505114-7-jsnow@redhat.com> In-Reply-To: <20250424210904.2505114-1-jsnow@redhat.com> References: <20250424210904.2505114-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.84, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1745528976044019000 Content-Type: text/plain; charset="utf-8" Since the previous commit, python/setup.cfg applies to scripts/qapi/ as well. Configuration files in scripts/qapi/ override python/setup.cfg. scripts/qapi/.flake8 and scripts/qapi/.isort.cfg actually match python/setup.cfg exactly, and can go. The differences between scripts/qapi/mypy.ini and python/setup.cfg are harmless: namespace_packages being set to True is a requirement for the PEP420 nested package structure of QEMU but not for scripts/qapi, but has no effect on type checking the QAPI code. warn_unused_ignores is used in python/ to be able to target a wide variety of mypy versions; some of which that have added new ignore categories that are not present in older versions. Ultimately, scripts/qapi/mypy.ini can be removed without any real change in behavior to how mypy enforces type safety there. The pylint config is being left in place because the settings differ enough from the python/ directory settings that we need a chit-chat on how to merge them O:-) Signed-off-by: John Snow Reviewed-by: Markus Armbruster --- scripts/qapi/.flake8 | 3 --- scripts/qapi/.isort.cfg | 7 ------- scripts/qapi/mypy.ini | 4 ---- 3 files changed, 14 deletions(-) delete mode 100644 scripts/qapi/.flake8 delete mode 100644 scripts/qapi/.isort.cfg delete mode 100644 scripts/qapi/mypy.ini diff --git a/scripts/qapi/.flake8 b/scripts/qapi/.flake8 deleted file mode 100644 index a873ff67309..00000000000 --- a/scripts/qapi/.flake8 +++ /dev/null @@ -1,3 +0,0 @@ -[flake8] -# Prefer pylint's bare-except checks to flake8's -extend-ignore =3D E722 diff --git a/scripts/qapi/.isort.cfg b/scripts/qapi/.isort.cfg deleted file mode 100644 index 643caa1fbd6..00000000000 --- a/scripts/qapi/.isort.cfg +++ /dev/null @@ -1,7 +0,0 @@ -[settings] -force_grid_wrap=3D4 -force_sort_within_sections=3DTrue -include_trailing_comma=3DTrue -line_length=3D72 -lines_after_imports=3D2 -multi_line_output=3D3 diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini deleted file mode 100644 index 8109470a031..00000000000 --- a/scripts/qapi/mypy.ini +++ /dev/null @@ -1,4 +0,0 @@ -[mypy] -strict =3D True -disallow_untyped_calls =3D False -python_version =3D 3.8 --=20 2.48.1