From nobody Fri Dec 19 00:16:42 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1745395841; cv=none; d=zohomail.com; s=zohoarc; b=c6oIh/DP+QziKcRkdnt4K9bxbCA7sC6ZEqD9eip9BlcNr5UGH5nkYLEBwMWOpvd2bEEKMYvz/golpdSYDIAYnpErlBP9C7KPSFWXJTZN+GPzlFvRS8Z4sVuDkRDb4iQzTg0oXgLCxRdRcowc27sMk/UpUaOuJQZOnuMoZlN/yrg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745395841; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JkSqkirxZtqwpMLlyFWcEWPfWxc+rz+ds/80NLD8cOk=; b=RcruTA7hveJvLkXSKX0OnjbFxaZ8tV0bXy/xR1dzj41nGmQxY05TtC1/PcbjFEkn5rKZXHrqvDvL1YvMmuhdWSxemDwhEXdGeQbdVGa4JCIx1oRgaVq8OYzpe9S1JQc8S6UKnnNsMtAog2mFQmtC6xPz4BpixL/dzlWOf+LwJz0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17453958418490.3954157108501022; Wed, 23 Apr 2025 01:10:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u7VAi-0000t5-H6; Wed, 23 Apr 2025 04:09:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7VAd-0000pZ-Gd; Wed, 23 Apr 2025 04:09:27 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7VAb-0006kg-12; Wed, 23 Apr 2025 04:09:27 -0400 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53N6fjbb007098; Wed, 23 Apr 2025 08:09:21 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 466psnsa5g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Apr 2025 08:09:20 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53N6T9Cs008557; Wed, 23 Apr 2025 08:09:20 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 466jfxj3jf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Apr 2025 08:09:20 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53N89JVY32244468 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Apr 2025 08:09:19 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CFCC58061; Wed, 23 Apr 2025 08:09:19 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E090E5803F; Wed, 23 Apr 2025 08:09:17 +0000 (GMT) Received: from t83lp65.lnxne.boe (unknown [9.152.108.100]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Apr 2025 08:09:17 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=JkSqkirxZtqwpMLly FWcEWPfWxc+rz+ds/80NLD8cOk=; b=ESqPQR0FgQX62gnjX0msiKXFYJ/tWamza T4HUVmxIJwkplI+psdxdgdkwsm1stXQLa8BTNkDlpoeYhz8ICuEz5XKTQwTx1LbV xlTOHyS9qJuZlcQJK8EV7CCdw/UPhDFiN5ErTQMPsSn/tTdWaWUNhiqDky2hhwkc YKTWVd4v1w3GrghLrF9MS1idxpW+9sQPdFXvp36HZR10CdFq/ddtUmaUkla/sk4I yp4j8LNtrpIWwUZ5IWQjIFvFFlvc0WZgrWS60ffEv1EUP43/91/pvYrUXatfudLb g4liI+/8/K8YOZWRZv5kE4m72pgqDdh0EjB6kx6wxnoZ/7v1qo1+A== From: Gautam Gala To: qemu-s390x@nongnu.org, qemu-devel@nongnu.org Cc: Christian Borntraeger , Thomas Huth , Steffen Eiden , Janosch Frank Subject: [PATCH v5 1/3] target/s390x: Introduce constant when checking if PV header couldn't be decrypted Date: Wed, 23 Apr 2025 10:09:13 +0200 Message-ID: <20250423080915.1048123-2-ggala@linux.ibm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250423080915.1048123-1-ggala@linux.ibm.com> References: <20250423080915.1048123-1-ggala@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: JRlyPInWhPsMQmIdhSQjY22WAFMBx8yF X-Authority-Analysis: v=2.4 cv=BIezrEQG c=1 sm=1 tr=0 ts=6808a030 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=iZ54oBYeXFZcgQDtmRkA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDIzMDA1NCBTYWx0ZWRfX2Or0XLUxVcRF 8Q/bD4n5A2fSP+pBDUuxy/jLCBg7HS5uZYu6FVYi/bI5xEEaU0UD1Ds3y+PeULIhuqDEtcCtj/a EICKuhXrsUMHr4/uSA5VaRTz4NS7/ZeNoq2+2onNBucmgriL+Mer/ADcT2O69CnNhY1scx06Ac1 tQlO3qo1FHpWXk8p4eN08WAnNuf0xdhOSGUWhzCxbWtMmW3+71J0VYBTCB+fbLGTYf+epkiwHyq Eqa2WAs710sGR5M0GRyb3uoUTwsyzyWm0gBwi+SIgFHkx7MUX3/0HiO09KssysLeKQsOUwjewd1 1w1dNS4D2Q7JBDcLVwg6o6oStZbdCchp+LuxbesCnYX1oY+jcVcyOPZKTxrRRpQVnAr7NRdn3t8 fzl4VOv8PrSc8IUdBtQNbP2iP+4oGgNMtgHcBuGrVnWne7/1+466U0ZwyAmnPDTKYwOiOuje X-Proofpoint-ORIG-GUID: JRlyPInWhPsMQmIdhSQjY22WAFMBx8yF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-23_06,2025-04-22_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 mlxscore=0 phishscore=0 malwarescore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 bulkscore=0 mlxlogscore=797 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504230054 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=ggala@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1745395843962019000 Content-Type: text/plain; charset="utf-8" Introduce a named constant when checking the Set Secure Configuration param= eters UV call return code for the case where no valid host key was found and ther= efore the PV header couldn't be decrypted (0x108). Reviewed-by: Steffen Eiden Reviewed-by: Janosch Frank Signed-off-by: Gautam Gala --- target/s390x/kvm/pv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/s390x/kvm/pv.c b/target/s390x/kvm/pv.c index b191a4a68a..c1edb860d8 100644 --- a/target/s390x/kvm/pv.c +++ b/target/s390x/kvm/pv.c @@ -147,6 +147,7 @@ bool s390_pv_vm_try_disable_async(S390CcwMachineState *= ms) return true; } =20 +#define UV_RC_SSC_INVAL_HOSTKEY 0x0108 int s390_pv_set_sec_parms(uint64_t origin, uint64_t length, Error **errp) { int ret, pvrc; @@ -158,7 +159,7 @@ int s390_pv_set_sec_parms(uint64_t origin, uint64_t len= gth, Error **errp) ret =3D s390_pv_cmd_pvrc(KVM_PV_SET_SEC_PARMS, &args, &pvrc); if (ret) { error_setg(errp, "Failed to set secure execution parameters"); - if (pvrc =3D=3D 0x108) { + if (pvrc =3D=3D UV_RC_SSC_INVAL_HOSTKEY) { error_append_hint(errp, "Please check whether the image is " "correctly encrypted for this host\n"); } --=20 2.49.0