From nobody Sun Nov 16 01:14:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=uwu@icenowy.me; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=icenowy.me); dmarc=pass(p=none dis=none) header.from=icenowy.me ARC-Seal: i=2; a=rsa-sha256; t=1744874623; cv=pass; d=zohomail.com; s=zohoarc; b=QXExlzQlXsw1LOKMt+OD7bchiD3b/K5G6nxow0ykiGGnIWWVZhtQtdvPrX53qnfMDC18xOKZ7PX61Au3K3lcO8G9XBaM38iWnQTIa9asRiIeyhKfocblpT8pHpjvnXoHoHmHrSrpYePKTzJ9GqCI6jog/VC8IarhP7G/p3B0ppE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744874623; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xKsO1uho/0nTL/EI6evKCLfwRNYH8HmHj6cAJA8H24w=; b=CtF1bfy3vHQ9sJz73Mb9LjyFoZfQq0n0ztOpHejX7/fT3B60y7cBQyWS9RwkG6f5KFCzSsmV+WdUMO/k0xD5UWF4AICOryD8hkzGtS4Gsbvysdy74WkjG1E6hCR2ilBMnC1nSNXxBUpbSkbWSg15dmu9WZLHfg90j0DNumrdRL4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=uwu@icenowy.me; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=icenowy.me); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1744874623155432.4487252269623; Thu, 17 Apr 2025 00:23:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u5JaK-0005X7-2n; Thu, 17 Apr 2025 03:22:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5JaG-0005Wi-I5; Thu, 17 Apr 2025 03:22:52 -0400 Received: from sender4-op-o15.zoho.com ([136.143.188.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5JaD-0000IO-Vn; Thu, 17 Apr 2025 03:22:52 -0400 Received: by mx.zohomail.com with SMTPS id 174487453811922.435879893512833; Thu, 17 Apr 2025 00:22:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744874541; cv=none; d=zohomail.com; s=zohoarc; b=etC8tz+N8jpqIabFPp0WtZQxw9N/+xszbsiRzYqDFylrXe0wz1Xlo/v29NZwUen7Lid1rc1Q4Z3Q3T3mK+qu7SCf5YnxnKHt9cULw8P97qIELDVBqCB/X46yGJYNNXTdL+5Qx2hxLnyX6Dok8ALnxp0OrXJIDeOsLHz58aYoOgk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744874541; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=xKsO1uho/0nTL/EI6evKCLfwRNYH8HmHj6cAJA8H24w=; b=GN5GHIdLpWJ/YG+RF+rCvd+SX3e0Q7FJoVYJPWzOhOGwiBPze3joLvzI52TichJUlVUHnVWuhfvEnpSY7n3TojbZsh6VccmbGgPERxWenF+Rq4CnGYmozrt+S5zvts8WcREaDBJHWJ8WC1Gg2HQoLV8jU9U6gZ72/AZDK4SPLUs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=icenowy.me; spf=pass smtp.mailfrom=uwu@icenowy.me; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1744874541; s=zmail2; d=icenowy.me; i=uwu@icenowy.me; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=xKsO1uho/0nTL/EI6evKCLfwRNYH8HmHj6cAJA8H24w=; b=ZKgPlvc3UGzOsGUxej+8N/VIP2v5twszjIprFtndw2lq94GEMD+iYmIs1SwYwwr7 qPtGCxAKP68+ES7Qab/npTxWBYWoNV5hAbdpV8E8izkADLaufvMsL5y01LnIqTbkcK+ tbdkybaqkzW02TyQWCfDsckHcSvksaYZPCt8bByPM1f3Ct+XlmH/ykZ4KDEGiwwur9e 1diimrx3F7bnQK1uaLQFWWdLW515KSspf86QJDWfkqgPC3D29yJ/sIGqxQmY4Kt1aF7 ESui+wTyoqHbv/+odvlZGEewnTz3U7QAUj4Jh5wNagjo5LY5hZOCFYkevogWoQzyLeY rSUsIUQE/Q== From: Icenowy Zheng To: Riku Voipio , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, Icenowy Zheng Subject: [PATCH] common-user/host/riscv: use tail pseudoinstruction for calling tail Date: Thu, 17 Apr 2025 15:22:06 +0800 Message-ID: <20250417072206.364008-1-uwu@icenowy.me> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.188.15; envelope-from=uwu@icenowy.me; helo=sender4-op-o15.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity uwu@icenowy.me) X-ZM-MESSAGEID: 1744874624922019100 Content-Type: text/plain; charset="utf-8" The j pseudoinstruction maps to a JAL instruction, which can only handle a jump to somewhere with a signed 20-bit destination. In case of static linking and LTO'ing this easily leads to "relocation truncated to fit" error. Switch to use tail pseudoinstruction, which is the standard way to tail-call a function in medium code model (emits AUIPC+JALR). Signed-off-by: Icenowy Zheng Reviewed-by: Richard Henderson --- P.S. It seems that moving it to common-user/ makes the file out of the MAINTAINERS section of "RISC-V TCG CPUS". I Manually added the maintainers there, but the MAINTAINERS file seems to need a change on this. common-user/host/riscv/safe-syscall.inc.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common-user/host/riscv/safe-syscall.inc.S b/common-user/host/r= iscv/safe-syscall.inc.S index dfe83c300e..c8b81e33d0 100644 --- a/common-user/host/riscv/safe-syscall.inc.S +++ b/common-user/host/riscv/safe-syscall.inc.S @@ -69,11 +69,11 @@ safe_syscall_end: =20 /* code path setting errno */ 0: neg a0, a0 - j safe_syscall_set_errno_tail + tail safe_syscall_set_errno_tail =20 /* code path when we didn't execute the syscall */ 2: li a0, QEMU_ERESTARTSYS - j safe_syscall_set_errno_tail + tail safe_syscall_set_errno_tail =20 .cfi_endproc .size safe_syscall_base, .-safe_syscall_base --=20 2.49.0