From nobody Tue Dec 23 10:50:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1744596303; cv=none; d=zohomail.com; s=zohoarc; b=fqXLQdSBjCHnGZL0jOC0EmoNadK/PUjv8zWR+yFfOxHOF6Lsu4O5HUYR8kyp7VePu2oBgQl+IKmQqBU8X+oSkYW7+U8VLYmsX3/PlC9/nfnHW3YgfitJGKtOgHlNGT82NSYA8DCjT3MKUjg8tJ1NhWLpcykjrXkMUyWDFnkYgKI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744596303; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dKfVbixbZRXJnTFs5ELLu2+YNiNsZxWN9ZXUPy0JFx0=; b=OqFMJLppaJTndtr7JQdOBONSkFjrfUkoM0tIy7Xkgh+x+YSMfMo/+d4DlT/oKRaJFpyaM3TyvtCXoz5uJHXDgxxrVZGGIlq3Wsfx2ucnZMz5gkTAaGOIPMmyv4D7f10QWX07cRrs4q8kLBxkJOu5c0B4JrkoNrNu1JFtnbMp4nA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1744596303193144.86169672685298; Sun, 13 Apr 2025 19:05:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u49B9-0007N5-O6; Sun, 13 Apr 2025 22:04:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u49B7-0007MF-0U for qemu-devel@nongnu.org; Sun, 13 Apr 2025 22:04:05 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u49B5-0007VR-6n for qemu-devel@nongnu.org; Sun, 13 Apr 2025 22:04:04 -0400 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53E1q7Zc029268; Mon, 14 Apr 2025 02:03:47 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 460s2u007s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Apr 2025 02:03:47 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 53DNFDKR009267; Mon, 14 Apr 2025 02:03:46 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 460d3fvqtv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Apr 2025 02:03:46 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 53E22tYm035550; Mon, 14 Apr 2025 02:03:46 GMT Received: from alaljimee5bm-ol9-20250405.osdevelopmeniad.oraclevcn.com (alaljimee5bm-ol9-20250405.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.254.235]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 460d3fvqg0-14; Mon, 14 Apr 2025 02:03:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2023-11-20; bh=dKfVb ixbZRXJnTFs5ELLu2+YNiNsZxWN9ZXUPy0JFx0=; b=jwqDIUsxXhXdvOEQ4Y6r7 F0yuo1jPC+sg8w8BKyGo73sF1iLfe+kBbwv4Ib8mG5cV0KTvAg/fuuyK8W0eD2oQ LHMVt5JiKRJNoxLdK7nLcuhhspWn7CNKpjZ3lu3Wj7Eyo7K5hgqXuSenth5Y2+rL GUZUO0fGjCcR+9mrw1Z1JMv/a61nV/GFUigflKWQPnwU+IknrAGc7QU9fTPbgM7P EpMgLKFSS67sm2/aLeqkahJkEtt9S0iSflNu+qvWhqQq0J6EnMaA2QPODouRUjGP lOhBRZ9pqHZgKwnHxcL/sj9h0WJHHuKzNXXXzsy+aeFPVqQ9Bdxjr1aBa2zdYgUG Q== From: Alejandro Jimenez To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, richard.henderson@linaro.org, eduardo@habkost.net, peterx@redhat.com, david@redhat.com, philmd@linaro.org, mst@redhat.com, marcel.apfelbaum@gmail.com, alex.williamson@redhat.com, vasant.hegde@amd.com, suravee.suthikulpanit@amd.com, santosh.shukla@amd.com, sarunkod@amd.com, Wei.Huang2@amd.com, joao.m.martins@oracle.com, boris.ostrovsky@oracle.com, alejandro.j.jimenez@oracle.com Subject: [PATCH 13/18] amd_iommu: Invalidate address translations on INVALIDATE_IOMMU_ALL Date: Mon, 14 Apr 2025 02:02:48 +0000 Message-ID: <20250414020253.443831-14-alejandro.j.jimenez@oracle.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250414020253.443831-1-alejandro.j.jimenez@oracle.com> References: <20250414020253.443831-1-alejandro.j.jimenez@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-13_12,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502280000 definitions=main-2504140014 X-Proofpoint-GUID: YHu7N6ILpEdE2mUJvDEKPPOtI7jf8a3H X-Proofpoint-ORIG-GUID: YHu7N6ILpEdE2mUJvDEKPPOtI7jf8a3H Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.165.32; envelope-from=alejandro.j.jimenez@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.266, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @oracle.com) X-ZM-MESSAGEID: 1744596304289019100 Content-Type: text/plain; charset="utf-8" When the kernel IOMMU driver issues an INVALIDATE_IOMMU_ALL, the address translation and interrupt remapping information must be cleared for all Device IDs and all domains. Introduce a helper to sync the shadow page table for all the address spaces with registered notifiers, which replays both MAP and UNMAP events. Signed-off-by: Alejandro Jimenez --- hw/i386/amd_iommu.c | 49 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index e24eab34c9e0..3bfa08419ffe 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -100,6 +100,7 @@ static int amdvi_as_to_dte(AMDVIAddressSpace *as, uint6= 4_t *dte); static void amdvi_sync_shadow_page_table_range(AMDVIAddressSpace *as, uint64_t *dte, hwaddr addr, uint64_t size, bool send_un= map); +static void amdvi_address_space_unmap(AMDVIAddressSpace *as, IOMMUNotifier= *n); =20 uint64_t amdvi_extended_feature_register(AMDVIState *s) { @@ -462,6 +463,47 @@ static void amdvi_intremap_inval_notify_all(AMDVIState= *s, bool global, x86_iommu_iec_notify_all(X86_IOMMU_DEVICE(s), global, index, mask); } =20 +static void amdvi_address_space_sync(AMDVIAddressSpace *as) +{ + IOMMUNotifier *n; + uint64_t dte[4] =3D { 0 }; + + /* If only UNMAP notifiers are registered, drop all existing mappings = */ + if (!(as->notifier_flags & IOMMU_NOTIFIER_MAP)) { + IOMMU_NOTIFIER_FOREACH(n, &as->iommu) { + /* + * Directly calling memory_region_unmap_iommu_notifier_range()= does + * not guarantee that the addr_mask eventually passed as param= eter + * to the notifier is valid. Use amdvi_address_space_unmap() w= hich + * ensures the notifier range is divided into properly aligned + * regions, and issues notifications for each one. + */ + amdvi_address_space_unmap(as, n); + } + return; + } + + if (amdvi_as_to_dte(as, dte)) { + return; + } + + amdvi_sync_shadow_page_table_range(as, &dte[0], 0, UINT64_MAX, true); +} + +/* + * This differs from the replay() method in that it issues both MAP and UN= MAP + * notifications since it is called after global invalidation events in or= der to + * re-sync all address spaces. + */ +static void amdvi_iommu_address_space_sync_all(AMDVIState *s) +{ + AMDVIAddressSpace *as; + + QLIST_FOREACH(as, &s->amdvi_as_with_notifiers, next) { + amdvi_address_space_sync(as); + } +} + static void amdvi_inval_all(AMDVIState *s, uint64_t *cmd) { if (extract64(cmd[0], 0, 60) || cmd[1]) { @@ -473,6 +515,13 @@ static void amdvi_inval_all(AMDVIState *s, uint64_t *c= md) amdvi_intremap_inval_notify_all(s, true, 0, 0); =20 amdvi_iotlb_reset(s); + + /* + * Fully replay the address space i.e. send both UNMAP and MAP events = in + * order to synchronize guest and host IO page tables tables. + */ + amdvi_iommu_address_space_sync_all(s); + trace_amdvi_all_inval(); } =20 --=20 2.43.5