From nobody Fri Dec 19 20:12:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1744111642; cv=none; d=zohomail.com; s=zohoarc; b=Vmprgp8ITh5tA4+eyTgtGVGXdn9+UjFJu6dijxkO9WdYDn+tNy2n70+gS38JtCmhBpJVuFMSdbjrudWaxeRdcFuyt/f8r0cp/38B1sg10oUTWhI++KsJJ8HuydZopV9Gu+s7wVrr1VdTYDKMjCg1OvKV7JtccZgeBIv719DVeV0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744111642; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cZYjj3TSQknbpghdbxSdQf+QPw46EKUTI+qxJHOAmRg=; b=cJvl4+/1cRIp3bvtVbh/lz321bI6EOMVssX7hAn0GYrOe6BGd/UOdAq/6m+6cc6CMFViXcYJLxiatrRPL4u4aiEhtwxa5Jy/yd4ZgqoRgJuN8ZEbJDWrdKM8+GQvzKMvpv0ZXJANJp+NzxhwOVsGBycdE1apJCmelfvVek9Owfk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1744111642701280.1519882212366; Tue, 8 Apr 2025 04:27:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u275a-0007WQ-Sp; Tue, 08 Apr 2025 07:25:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u275Y-0007WC-AO for qemu-devel@nongnu.org; Tue, 08 Apr 2025 07:25:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u275W-0006NG-H0 for qemu-devel@nongnu.org; Tue, 08 Apr 2025 07:25:55 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-KFGmRhtJM0-UIAUkiu1m4g-1; Tue, 08 Apr 2025 07:25:48 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E197818001FA; Tue, 8 Apr 2025 11:25:46 +0000 (UTC) Received: from rh-jmarcin.redhat.com (unknown [10.44.34.27]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D0E7719560AD; Tue, 8 Apr 2025 11:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744111553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cZYjj3TSQknbpghdbxSdQf+QPw46EKUTI+qxJHOAmRg=; b=VRM3ezGE8zEKtMeVdeyVCpwaMEfbbTSQLAYZt7EBsF/24avj8yvMbojRbwaUxP4tXB59Sl z6telflKgu5heWi7hWLZhTrJFMBeNTZxAfZX3cVIyA0vwjUKLpvQxm6SYlys35S91HEN9S KRQPpGjGAFUnH5Si/yoOQfTS0YX0IWk= X-MC-Unique: KFGmRhtJM0-UIAUkiu1m4g-1 X-Mimecast-MFC-AGG-ID: KFGmRhtJM0-UIAUkiu1m4g_1744111547 From: Juraj Marcin To: qemu-devel@nongnu.org Cc: Juraj Marcin , vsementsov@yandex-team.ru, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Paolo Bonzini Subject: [PATCH v3 1/5] io: Fix partial struct copy in qio_dns_resolver_lookup_sync_inet() Date: Tue, 8 Apr 2025 13:25:00 +0200 Message-ID: <20250408112508.1638722-2-jmarcin@redhat.com> In-Reply-To: <20250408112508.1638722-1-jmarcin@redhat.com> References: <20250408112508.1638722-1-jmarcin@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jmarcin@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.845, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1744111643923019100 Content-Type: text/plain; charset="utf-8" From: Juraj Marcin Commit aec21d3175 (qapi: Add InetSocketAddress member keep-alive) introduces the keep-alive flag, but this flag is not copied together with other options in qio_dns_resolver_lookup_sync_inet(). This patch fixes this issue and also prevents future ones by copying the entire structure first and only then overriding a few attributes that need to be different. Fixes: aec21d31756c (qapi: Add InetSocketAddress member keep-alive) Signed-off-by: Juraj Marcin Reviewed-by: Daniel P. Berrang=C3=A9 --- io/dns-resolver.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/io/dns-resolver.c b/io/dns-resolver.c index 53b0e8407a..3712438f82 100644 --- a/io/dns-resolver.c +++ b/io/dns-resolver.c @@ -111,22 +111,11 @@ static int qio_dns_resolver_lookup_sync_inet(QIODNSRe= solver *resolver, uaddr, INET6_ADDRSTRLEN, uport, 32, NI_NUMERICHOST | NI_NUMERICSERV); =20 - newaddr->u.inet =3D (InetSocketAddress){ - .host =3D g_strdup(uaddr), - .port =3D g_strdup(uport), - .has_numeric =3D true, - .numeric =3D true, - .has_to =3D iaddr->has_to, - .to =3D iaddr->to, - .has_ipv4 =3D iaddr->has_ipv4, - .ipv4 =3D iaddr->ipv4, - .has_ipv6 =3D iaddr->has_ipv6, - .ipv6 =3D iaddr->ipv6, -#ifdef HAVE_IPPROTO_MPTCP - .has_mptcp =3D iaddr->has_mptcp, - .mptcp =3D iaddr->mptcp, -#endif - }; + newaddr->u.inet =3D *iaddr; + newaddr->u.inet.host =3D g_strdup(uaddr), + newaddr->u.inet.port =3D g_strdup(uport), + newaddr->u.inet.has_numeric =3D true, + newaddr->u.inet.numeric =3D true, =20 (*addrs)[i] =3D newaddr; } --=20 2.48.1