From nobody Mon Feb 9 22:08:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1744054099; cv=none; d=zohomail.com; s=zohoarc; b=g60zDqnNci3QSKzkpmhBWk53VtRl2jhGSPY3j2If98Em2JjOFGUxore/whTAnt4T1HtENqBuuKfVqq6hniwmwEcuLC6UZyOQqz++KDwsrZ0AHDUT6OOLM7grkt06D8MU1O4T/2//fony7XB5QVmkLcy2HM5FIetiT6AHOoZN3R0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744054099; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0JNy0H8rZ3mqJbvaSLWvLnEsqqiwOr/aprP21Ezpjjs=; b=GMqjVtKAEhjXdG/zNyx/QUZtLyBd5I5J8VKC+phpOmhxBQ/ddLWOz17yEHIsWxCwzy4WpNTb82YPBJlURd/pb/8eEX5Wn28ge64rxHDRGKfDqgn3Oy8Lc8TPZh0OnLCEJlaaYX8ltdUkcvKOR6ylydSKRL9Tw4a5V/PR7NoCI2A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174405409979459.14416243460016; Mon, 7 Apr 2025 12:28:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u1s8h-0001qX-2j; Mon, 07 Apr 2025 15:28:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u1s7v-0001hB-Hg for qemu-devel@nongnu.org; Mon, 07 Apr 2025 15:27:26 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u1s7u-0002kg-03 for qemu-devel@nongnu.org; Mon, 07 Apr 2025 15:27:23 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 537Iev58002203 for ; Mon, 7 Apr 2025 19:27:20 GMT Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45twtawbra-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 07 Apr 2025 19:27:20 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-736cb72efd5so4134362b3a.3 for ; Mon, 07 Apr 2025 12:27:20 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d97ee619sm9206559b3a.52.2025.04.07.12.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 12:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0JNy0H8rZ3mqJbvaSLWvLnEsqqiwOr/aprP21Ezpjjs=; b=XE/B4tm5cy/35HBX CoEuSEw10M6oepe21VccPYl43UJAMxJ1O0kwqkgBqfzRsOW+IF//cJcCyPOhTNBY iu1UZqx+gbdKiwIWcVMBQgrmLTz0SXtU7cvDHIkHTqkmS8yh3uawQSs17VR0ppoV CmqHAfwJUewU/UAYJVU25VCPkWPxcDaN2KDqU0Gh81gtykeYI/slSNLe+Q7CI6xJ SUKub3CKdraYxoU1kgTumoPirxeSl/o0otpPDVa77696stdGY0jh9i/+Y96npCKh IRIJ1iwLpd4vqBfsC/emqEPInfrV6jvi2yuHWn8zsWv6NtnpqtZQ+k8WL5lhhal+ GNx+aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744054039; x=1744658839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0JNy0H8rZ3mqJbvaSLWvLnEsqqiwOr/aprP21Ezpjjs=; b=JN0aTkdpSWr0WvsAtDalGtGkhub54fNaVSb5vkVuezuWtKqZQrLtZjdEV1kifdLk01 qejk1fICY+iwbpH7o9Z7K7wc/g2D9T0cxSNqdJ7+cGYj+JLlUVkdq6imCLhTMMkuwAY7 h5W3x96cHnu/aH77+FrnPBH1imxSjs6uINdEyfCD5OfeCM573rbTOf3NK+wHMLLmX6pJ JKmE3o0986//b4mi/6/VUt7gN+Q0YdSRKLxOYGoAqBKm9AGbAgUEKWPZGI9fmmE/Zetd s92aMxZCWR//AdyTkhwIma/CjV6A2PcLfdCVBVFLpAt+zOgg3mh+6UXUyYiA8R13q5JI y8wA== X-Gm-Message-State: AOJu0YztUNBGhH800yc/fiVHonPVYEB2bsC5vUQ6lSIj+9dVEUUqPnUt WFG5lSk625gQPqPqQwgoTtw6mnYKN5m9MqKswIvRgPFg94I2UUcYLyxsqdQaJAMoiEV0ZAa23mI ntx3SUOf1BrErFa2wrtGXWxm5bs7lziJILo68MI3bfMcYj/Mr+3e9aNBtACDviQ== X-Gm-Gg: ASbGncuAuri52VPjfMFlKcIfuIcPDed8oiORrAjKl0xCdQLPSP37PqTaEdab62c9t3j wub3mKpXZQNn3DTbwshnqn82X691LRyywfV8lsKITJ/hhn0/5yrhWSqfte+TEr6R+Df93tmGZay zvSD7aza/uY2LaXMJR3EUQ9u0TmsN17MWpFRDDyftt6b06rmEBOgpGkV5Vj4r06HCmxuq9vvlQO 9DeY1JtiO7jYWSidD10P3IPCNrMi7fUqExujKlx41AVnzJQtvh+mCE8x7X6cY+rpcF5Da1OAnoY 2wUed310cwzmSmnvhlS70uYPyr4lyW80abcNoNmCHm5NipHDHlaG0HGqjXdxt6kr X-Received: by 2002:a05:6a00:244b:b0:736:450c:fa56 with SMTP id d2e1a72fcca58-739e6fa9cfamr14551789b3a.5.1744054039358; Mon, 07 Apr 2025 12:27:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKt0SgA+ox6gfndudPGmsMONQJztQ01Z57Zr14sCFVS7+ZRu8K0WJldGkf8Iejw+VUaeI3pA== X-Received: by 2002:a05:6a00:244b:b0:736:450c:fa56 with SMTP id d2e1a72fcca58-739e6fa9cfamr14551768b3a.5.1744054038989; Mon, 07 Apr 2025 12:27:18 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, richard.henderson@linaro.org, philmd@linaro.org, matheus.bernardino@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng, marco.liebel@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex.bennee@linaro.org, quic_mburton@quicinc.com, sidneym@quicinc.com Subject: [PATCH v3 5/5] target/hexagon: Remove unreachable Date: Mon, 7 Apr 2025 12:27:05 -0700 Message-Id: <20250407192705.2605614-6-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250407192705.2605614-1-brian.cain@oss.qualcomm.com> References: <20250407192705.2605614-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 6WOOfMzrVNzNTsg0WRzLyjFzTvi83AeG X-Authority-Analysis: v=2.4 cv=LLlmQIW9 c=1 sm=1 tr=0 ts=67f42718 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=WeWQB0ruK5ITHrmzxTQA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: 6WOOfMzrVNzNTsg0WRzLyjFzTvi83AeG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-07_05,2025-04-07_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 clxscore=1015 mlxlogscore=706 malwarescore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 spamscore=0 adultscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504070136 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1744054101253019000 We should raise an exception in the event that we encounter a packet that can't be correctly decoded, not fault. Signed-off-by: Brian Cain --- target/hexagon/decode.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c index b5ece60450..1db7f1950f 100644 --- a/target/hexagon/decode.c +++ b/target/hexagon/decode.c @@ -489,7 +489,6 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t en= coding) insn->iclass =3D iclass_bits(encoding); return 1; } - g_assert_not_reached(); } else { uint32_t iclass =3D get_duplex_iclass(encoding); unsigned int slot0_subinsn =3D get_slot0_subinsn(encoding); @@ -512,6 +511,11 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t e= ncoding) } g_assert_not_reached(); } + /* + * invalid/unrecognized opcode; return 1 and let gen_insn() raise an + * exception when it sees this empty insn. + */ + return 1; } =20 static void decode_add_endloop_insn(Insn *insn, int loopnum) --=20 2.34.1