From nobody Sun Nov 16 04:16:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1743735248; cv=none; d=zohomail.com; s=zohoarc; b=lTUrGvkh/C907pGucKfCSCdsQUGAKbFKPhzEEJYw3LQo/y8Uo9/tkE8WEHS6XWGZecJdBcvSXceSfkCMlqyfLai4oe2hguI8WSob08WSBn+0BTNL5m0VUtHOKxQsz/UrLLGHvijSC37oHydesO+8GGdRpDT+l+qfyLOTdw6yB5k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743735248; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rOv9AfRtm4zcRad8q04n0pfTqeC4Q7o4V7dElaVWBUw=; b=Fbrw9d7fdJA9hNE4SVimocp4qmEF3Q25c2pVQBA23WpczVneLBgh22r5k8zGXRJ34wS7mrkwAjFT+0wZ/Es4IijTKPBZzrnQ4P4saqYS5boQSmTM36wDKh9KBD6kaPEMdEKlV/+5FCJkb2hnqeqi2Z0vOZcm1HGxcPI/BVPZJO0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174373524849719.668470685302736; Thu, 3 Apr 2025 19:54:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0XAb-00061W-21; Thu, 03 Apr 2025 22:52:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAU-0005tn-SK for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:30 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAR-0006lb-F4 for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:30 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5341Oisg012629 for ; Fri, 4 Apr 2025 02:52:25 GMT Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45t2d50gc3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 04 Apr 2025 02:52:24 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2254bdd4982so23388885ad.1 for ; Thu, 03 Apr 2025 19:52:24 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785ea16bsm22014865ad.106.2025.04.03.19.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 19:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rOv9AfRtm4zcRad8q04n0pfTqeC4Q7o4V7dElaVWBUw=; b=VW0UqCy7dnER2rgR 95dG1wJqlTy4CcBzajNoW+RqJ0aOMLumk3D3qcCn+YE2kjj/wv9QhSR5phrBfw2D AuTnKlZuKeE6/4TcihrWur6oiIdBLMEOV0gaKPJHNgcxrxJd3TBEWajC2Mt+YTnN VX7UuVZtY4T1SSEgBMqTl/HYeFYQ+t4AhZgizeSTnPqjh+sSyzHlzcnnYPc5Fx/d cNwLQvQlSCYLkRyZFFAiSWn+rXjEjgfoqodDD4FnX2evzh4biKumB/xQq0+ownkh 0URLXJHZmxgmTLDxBN1DnTpr/NUFlg9eaVYDS8pLm07W8P805m1xPgsh0cobS8DZ HfYNsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743735144; x=1744339944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rOv9AfRtm4zcRad8q04n0pfTqeC4Q7o4V7dElaVWBUw=; b=M75HEWV032nFVkwrzVA3LStBa/OvkRssVtLd8OztFf5SmZ4qqTDqSPSqfAGmHIi31m MeIyVcXv8RJGIpjEran2fyuQNa8XPl90zabeUNjX51gS/rVX3ISEjnfuihCDD5JEL4RH yAXzSZ5sS1UgrLXPJp1VkmctezL6ogoydSmdXkKEOikBw1RtfbEzQSDp/x1GovKlAR6j PxHs2OVnpPM8kNBxUJ/ZDHTzWsKz8svVVKfhTQj3Ftw8gTV7wMGrbgtBDAUDLeT/wAaW /f1QvBeha04PrBWkRammDFfJAis0ZKsBai70bnDr3YcfidVraRcU6Jm2odmV9kIQjf1o G7JQ== X-Gm-Message-State: AOJu0YwHvpjSh2lxZnUMe6pOWWjaaES1Tcj4+ppK1aBK5BpHcoJYMrJW dZ3O6zm25TSHC/M1kVSdT/rltrc0FMoa7aDq55rIXDRRaiQOePFW/gx/BIS81L8b+3y1Utps9BF R/SwQ/PTOBZOOwRv+1fr5dWIzm4g7QGEupc0JmvgMc83S5dbtMjt/SEyBe0jJ6w== X-Gm-Gg: ASbGncvdTAp99r1xIkZuETQM1kGLTMpqy5uiSM92LMU3MPKEXfCwhL1/tOCc+TqwxG9 vL6Od3sfzYF/RxZisXpTwfCCOA/BJUAZzW2KhYTbVWzgHQvn/SJSX/O1pgj+vQQ6qvFtRpaSCpv lWJXEdf18MuwjP+WbllQUT4WRr1EzI5J+Qi3yAmce1FquwfBnE8WoGaE469cEiXCGGkPLR4tReP iusHG5PiKtqMPybScueg7Ec+RiPnCA9PGIV9KwS4F8O/0sxSEDBHIkogbO2xahFTBswSOGxJEgf jleUuOZeXPdxhLeqo3Zo5nhSn7n13vsALlY4f7qhbLFLRe/2mX8aUkqrq1SnSE6O X-Received: by 2002:a17:903:3d0d:b0:224:7a4:b2a with SMTP id d9443c01a7336-22a8a045ceamr21058275ad.11.1743735143769; Thu, 03 Apr 2025 19:52:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFdlVUFzpzBERZOOxUXiM88AYV8QE2fkZNgtVLPNeCyoE5rDxE1VGbB3VS5yoE60WxgNrVQHA== X-Received: by 2002:a17:903:3d0d:b0:224:7a4:b2a with SMTP id d9443c01a7336-22a8a045ceamr21057915ad.11.1743735143194; Thu, 03 Apr 2025 19:52:23 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, richard.henderson@linaro.org, philmd@linaro.org, matheus.bernardino@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng, marco.liebel@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex.bennee@linaro.org, quic_mburton@quicinc.com, sidneym@quicinc.com, Brian Cain Subject: [PATCH 1/6] target/hexagon: handle .new values Date: Thu, 3 Apr 2025 19:51:58 -0700 Message-Id: <20250404025203.335025-2-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> References: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 8EHkZeTEgaarjdxCr3a6osraeH6ECHtQ X-Proofpoint-ORIG-GUID: 8EHkZeTEgaarjdxCr3a6osraeH6ECHtQ X-Authority-Analysis: v=2.4 cv=bZtrUPPB c=1 sm=1 tr=0 ts=67ef4968 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=rPjZFjiy9LBZz0qYGpsA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-04_01,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 mlxlogscore=432 mlxscore=0 bulkscore=0 priorityscore=1501 spamscore=0 adultscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504040019 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1743735250560019100 From: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/hex_common.py | 27 ++++++++++++++++++++++----- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py index 758e5fd12d..242dee3731 100755 --- a/target/hexagon/hex_common.py +++ b/target/hexagon/hex_common.py @@ -349,6 +349,12 @@ def helper_arg(self): self.reg_tcg(), f"{self.helper_arg_type()} {self.helper_arg_name()}" ) + def from_subtype(self, subtype): + if subtype =3D=3D "": + return self + raise Exception( + f"unknown subtype '{subtype}' on generic Register class") + =20 # # Every register is either Single or Pair or Hvx @@ -1070,11 +1076,22 @@ def init_registers(): for reg in new_regs: new_registers[f"{reg.regtype}{reg.regid}"] =3D reg =20 -def get_register(tag, regtype, regid): - if f"{regtype}{regid}V" in semdict[tag]: - return registers[f"{regtype}{regid}"] - else: - return new_registers[f"{regtype}{regid}"] +def is_new_reg(tag, regid): + if regid[0] in "NO": + return True + return regid[0] =3D=3D "P" and \ + f"{regid}N" in semdict[tag] and \ + f"{regid}V" not in semdict[tag] + +def get_register(tag, regtype, regid, subtype=3D""): + regid =3D f"{regtype}{regid}" + is_new =3D is_new_reg(tag, regid) + try: + reg =3D new_registers[regid] if is_new else registers[regid] + except KeyError: + raise Exception(f"Unknown {'new ' if is_new else ''}register {regi= d}" +\ + f"from '{tag}' with syntax '{semdict[tag]}'") from= None + return reg.from_subtype(subtype) =20 def helper_ret_type(tag, regs): ## If there is a scalar result, it is the return type --=20 2.34.1 From nobody Sun Nov 16 04:16:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1743735195; cv=none; d=zohomail.com; s=zohoarc; b=D0U7gb9M9nwE7Un45eHXI38t9cr9lYsIpJuQXDXvEvFCy+InSJ/cPwO5SpYW6AOgZ+ZPpTDEwi5PEgxn6gU1rCc+DvNKrnMfXhEq32cUE+1CbF3+blYMWc88q0hVPiROB8AUB+ZTnOVgOOtj/JXnslWSDQHqdx1PDbgsb8Ws8Kc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743735195; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gVoHJ0OtSSYZsMzuDVY7GZ5ga6wHPMe1mgwZjB5K2qs=; b=cBjq4TsOPP8j4O3txteHpwanN/z2rl7UVrgmiyWbuzJricomjm+wRWdeORw9OsynQYOoeNjgfyWU+dwykuVdI3oj6wOXV1AWxovhohJYlbd6GZS6itFCmsxNY0OAFjDR13haKKlkCbuzGMeZs1FyczogNeubV1qhMyQn6I2QTxM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743735195509123.29829686629068; Thu, 3 Apr 2025 19:53:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0XAZ-000606-QM; Thu, 03 Apr 2025 22:52:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAU-0005tm-SF for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:30 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAR-0006lo-8w for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:30 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5341OPuT010956 for ; Fri, 4 Apr 2025 02:52:25 GMT Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45t2d8rgcq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 04 Apr 2025 02:52:25 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-225ab228a37so16009865ad.2 for ; Thu, 03 Apr 2025 19:52:25 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785ea16bsm22014865ad.106.2025.04.03.19.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 19:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gVoHJ0OtSSYZsMzuDVY7GZ5ga6wHPMe1mgwZjB5K2qs=; b=jKH/3nV1kdP4smjS 4aN1PSt/nilZEK5Budxs+Hkky2tHHKl3PxWf5ioxM15PqDrTpmO5XHg1SiBaKpC2 Q4cpJwFn6hYndUO5pTl+2Du7qS5oyiPaCHshMVA4i8DBSwDTHWrxOanAcN5wxq2t 9qYUKijEtQXmr2UJmAG2dmOKWfE/cfW+ohEqf5+gubQPC4QEz7tRkyP/G4stmuVu QUc+z4fBYHF2j96R8Ssx7pSP1GR7eZ9Gcrzf1ghb7LmzAU/4zvcs2gPVD4gLY8QH GOxNnw0OWx62kAXZe0VJmB8zq2C+tkZjNkuwGDk7FrPwWDpocA9M5lMajDINO15R KcLJWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743735145; x=1744339945; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gVoHJ0OtSSYZsMzuDVY7GZ5ga6wHPMe1mgwZjB5K2qs=; b=O4fc2Z5pXu3Vj8z0hnNV0qoYyaUeNGpoMzJeG452F6EcyMddMi0V6AvnKRNzujdkI0 wCRHo43HyieLRBFi3eSf4nllFoyZaYMtttt8RQTI+GrT/qHFvHSCqnQUWbEAtF0RjtiG kJFEv8EcSBNq0/snypBv2HQYnXDKGX5YJRVfva1t/g2ZqD1yEk7A20OKZhaq/kPIBmr1 GxWEx+M3ElpxsiJ24jTICiE03StWhB/ecSFgA9iHnwWGIxJigDr+F8SZbSpnzfPiomjG lnbtWsqfHZjRbH7mNIezudMyfECUhGrFML/4epBw0ju3o2F98eJJZCCdTpvNxac3Nvdf pjog== X-Gm-Message-State: AOJu0YwrqFx9mVclyg1PIbVvRXBRoxYstUMC//+j2yIaK7mlmjzw5Rel fWr2nxgWppHApURvweI5v5dgCg6jCcPkQbP0fAqQuBmAEuCBAdzpb1LXMseTGbDXccMn1RkxLh2 zxAflcOoyJN0esBi45mjOq+r0IQ64mD0aWDgNWq8ZBJK8KDjmuNJYCGz5DQHweQ== X-Gm-Gg: ASbGncvMW+Veo4lIHKt2EEhNgUAyeTlkoTj5dQl9fK/uWnUcAlT/qWSUoI22x4KtY1t F31QKOcA5UTbfFA4i7MRUJBFLd1EV7TtJ3JdldVrlsvqV8zDpxNLex1o/JIOHwEoMppDkmqoa+m CzMiBBgVuvJoTfaZu+FYx+rjvYcGWvhSfUJwRcT7KGzJiFeNopAPlX2K4ZVdEBaUqDzqqqK2uhh U9gYGQmobV7Mf6yd3pADTAG9wB5dkN/9ERfAcfzfyFUuI7e2bUDMZjGFNTZGOqc55HF/dbmBTOV pckZVkCbM45I1skU/tPh/HW3mTJcUQShJXEt1QvnZ4CBDxwCysTvB/8hmhv87kTl X-Received: by 2002:a17:903:3bc8:b0:220:ff3f:6cc0 with SMTP id d9443c01a7336-22a8a09a69cmr21682515ad.38.1743735144746; Thu, 03 Apr 2025 19:52:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2cfgnvgfdl/LJCKwZeuuAK774BHHSN9msKNrW/9SVbwk/sQdEqYHnoJceDJUf0s9FRilC0A== X-Received: by 2002:a17:903:3bc8:b0:220:ff3f:6cc0 with SMTP id d9443c01a7336-22a8a09a69cmr21682325ad.38.1743735144365; Thu, 03 Apr 2025 19:52:24 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, richard.henderson@linaro.org, philmd@linaro.org, matheus.bernardino@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng, marco.liebel@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex.bennee@linaro.org, quic_mburton@quicinc.com, sidneym@quicinc.com, Brian Cain Subject: [PATCH 2/6] target/hexagon: Fix badva reference, delete CAUSE Date: Thu, 3 Apr 2025 19:51:59 -0700 Message-Id: <20250404025203.335025-3-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> References: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: EMyql-j3t_5bl1QcCbIFIhCrq-a-sjZh X-Authority-Analysis: v=2.4 cv=IeOHWXqa c=1 sm=1 tr=0 ts=67ef4969 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=HN0uuiy-se_EESAQhN8A:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: EMyql-j3t_5bl1QcCbIFIhCrq-a-sjZh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-04_01,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=904 spamscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504040019 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1743735197871019100 From: Brian Cain The BADVA reg is referred to with the wrong identifier. The CAUSE reg field of SSR is not yet modeled. Signed-off-by: Brian Cain --- target/hexagon/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index 766b678651..62f1fe15b8 100644 --- a/target/hexagon/cpu.c +++ b/target/hexagon/cpu.c @@ -216,8 +216,7 @@ static void hexagon_dump(CPUHexagonState *env, FILE *f,= int flags) qemu_fprintf(f, " cs0 =3D 0x00000000\n"); qemu_fprintf(f, " cs1 =3D 0x00000000\n"); #else - print_reg(f, env, HEX_REG_CAUSE); - print_reg(f, env, HEX_REG_BADVA); + print_reg(f, env, HEX_SREG_BADVA); print_reg(f, env, HEX_REG_CS0); print_reg(f, env, HEX_REG_CS1); #endif --=20 2.34.1 From nobody Sun Nov 16 04:16:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1743735206; cv=none; d=zohomail.com; s=zohoarc; b=kr1RZTaX+fBXgWdMoCwk2p+rzVneWuGjwsacV2I474XNLUlHA6tmYpj5Sf6V8w82nv5VxGucxBLYL+U19Trcgbvx0BHdjEGL0F/KQ21bMMdLpo2QkugACUhv2zKfJIdM/fO7/zV/3i3aLkcBGV5XKUM8uaJFtMVjqi9o8RL4icE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743735206; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QsGP2ijL+WlGrewJ27McO4Tyi4F00Bmlcuv9pKxeHBE=; b=QnfSUQ6qFYAn7BCOAt4PyOsQFQ58mKYKHnfV9fAq4TzipeYQFeYZlG56g+2a5sJZ7NIDsllVJwADgCil53ePpKdItjwsksc6BNChcpoiOrC8s9a+xvtQAHshUpkX+9S3CGcDgsqjSXZ/wTynvbHi1pVn1txjiRQRnkdw7tMteiQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743735206756696.3490324282661; Thu, 3 Apr 2025 19:53:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0XAX-0005ue-7c; Thu, 03 Apr 2025 22:52:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAU-0005to-SS for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:30 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAS-0006m8-ST for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:30 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5341O2xo028502 for ; Fri, 4 Apr 2025 02:52:27 GMT Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45t2d40fwg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 04 Apr 2025 02:52:27 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-227ed471999so14384575ad.3 for ; Thu, 03 Apr 2025 19:52:27 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785ea16bsm22014865ad.106.2025.04.03.19.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 19:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QsGP2ijL+WlGrewJ27McO4Tyi4F00Bmlcuv9pKxeHBE=; b=B3ds98udxwE2FyxH yck6qeXAtUZIwaulBkwtGBw2APMKj5qeE8NFyjpTS12ADWNHt3vGCOBtoGNK33iJ VhIhz7vuNCGB0RWLBtoJ6NxeBZbkng2iQNkTwkAKCwXHGW/K/IMVw/+3kkg0BP1M b5/izTGXqkOfsXIFQHtHd9z+2atyPQ3lEIfT0CSBDZp7/moBIhZqq/stg4l21JL+ 1rC+AsGBtVlsRgIYTqM+d02te6GjAO4Eo3qPzNEKNS02ddktrzfdw/VVV0t46xWv 6/05dFeMNaI4o/q7zkZz9WZMxeiECygeEp7PxDeILpkDusl6mEMAIYmLi66bpqUt 8TbnAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743735146; x=1744339946; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QsGP2ijL+WlGrewJ27McO4Tyi4F00Bmlcuv9pKxeHBE=; b=BIpUeiG7VGCDmTOoUo92q2f2D45Hii3Hl/9knb/unwgGjTM2p5e/1A0CuFwZ3RDERh sJkbu5JskqBVqYEkKnbXLhcXbficDx8acBG/wn9DgFG7itZwiUvJck8S/aS1vDojkiXu wbOchUz+bbsjcxEuUYyNLfm6KAkiqSQTyzWqtZm7glUOwi/Na8dxjUV/SqRQ4Ek+/oNl QbWpGQpGrLS/SLx2L8PIGuloaVo8NYDl8XSQUHHOnUGujpJbHrTxOZIBnV9hxcJnwJLR 8YrqS4bISIcwFcLdtaJbNCJMBXy0aetT2R0s67SzAHjZsdLW6+8UoThGDIc9Vu0ZJIUW WKkA== X-Gm-Message-State: AOJu0YzEf6fouMlG7P8Qc9gg3pypT5UJtATQo2XH5iEtMRCFQmpq7Ud6 Ga+bnqlCUF01EMlJ7bdNVmlMqNHOe2SDpD+IXegxXlRWSBp9S/txhC2uhNpQiDzEREiuAPBWO+8 sR1cXnY8FyFD4z+7cvHikpt4FXgtzWruRRQ3ECwvUHa2OL0WESxGjGywOC9pAVQ== X-Gm-Gg: ASbGncuDzPB/rEraZsLbldm0bLJULRivHwf0WpSibKfwp8uem8vuF/SaZvJqXU8xyDz 1eu222jSbVEct5vUfKc54HETHGRArzx5c5IN9oFY1TCWr1I3yCIs99CD+mD0Ib1rPnT/p+vJO3J EeNU9ClhME92l7K8S1xf6r2HH6EtMrL8nke4cRack3Ud64GQxR6pB+py+q5WeoXaYVu7O7TH3b7 CEKeLnZftBwvu0lIViVQitlp2olAJItWzfTLOrZXwRuna8xyYDO3t5fH8PsahQEYVHcWjR6CP1w 5xys5t6OGkVpptu5OK2mR6wKbpAxiylf0vuApjDSdic6woRj7Xv+1pFDY3YoRpSk X-Received: by 2002:a17:903:1a10:b0:224:2201:84da with SMTP id d9443c01a7336-22a8a049edcmr17446035ad.6.1743735146032; Thu, 03 Apr 2025 19:52:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHN18YHDs9gEJzuYBVd92DhPG2qHkopHYswJNKEVer6zjkWdSLEGyMmtZNTYoheZF4x0YuXWw== X-Received: by 2002:a17:903:1a10:b0:224:2201:84da with SMTP id d9443c01a7336-22a8a049edcmr17445855ad.6.1743735145664; Thu, 03 Apr 2025 19:52:25 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, richard.henderson@linaro.org, philmd@linaro.org, matheus.bernardino@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng, marco.liebel@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex.bennee@linaro.org, quic_mburton@quicinc.com, sidneym@quicinc.com, Brian Cain Subject: [PATCH 3/6] target/hexagon: Add missing A_CALL attr, hintjumpr to multi_cof Date: Thu, 3 Apr 2025 19:52:00 -0700 Message-Id: <20250404025203.335025-4-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> References: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: CC8B3RQ4rZeHfGdcNJRiz3Zu8K8Pd-4l X-Authority-Analysis: v=2.4 cv=HrJ2G1TS c=1 sm=1 tr=0 ts=67ef496b cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=ExrS_PMGiXDxMcIyg5oA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: CC8B3RQ4rZeHfGdcNJRiz3Zu8K8Pd-4l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-04_01,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 clxscore=1015 mlxscore=0 phishscore=0 mlxlogscore=715 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504040019 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1743735208453019100 From: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/hex_common.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py index 242dee3731..85eabc9876 100755 --- a/target/hexagon/hex_common.py +++ b/target/hexagon/hex_common.py @@ -247,8 +247,11 @@ def need_next_PC(tag): =20 =20 def need_pkt_has_multi_cof(tag): - return "A_COF" in attribdict[tag] - + return ( + "A_JUMP" in attribdict[tag] + or "A_CALL" in attribdict[tag] + or "J2_rte" =3D=3D tag + ) and tag !=3D "J2_hintjumpr" =20 def need_pkt_need_commit(tag): return 'A_IMPLICIT_WRITES_USR' in attribdict[tag] --=20 2.34.1 From nobody Sun Nov 16 04:16:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1743735195; cv=none; d=zohomail.com; s=zohoarc; b=Dajdo5o49R/3/6uY2qftZMgmTyJ0SruZpX9uUmxtQx8NIcKoFKuxmBq+lp5jbJO6mqehGhnNomjtF3eWUmmPj99gCneUworcvKucEedr5paost7Bvl3qpZXQVRSlliZWT/i/tSCXexZaqgmHoSUq8WenlQG1XTdH0uEpgsqzD5Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743735195; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XdOoA6yP8KgHJ0ReAntJTjKigv+wvIvUfO0xtSYIysE=; b=VdK4y5bJcsHJCuHSYuLCOkLFtKkoDZjDalC0HrgrTLJ6idBNWEU0QF2ig9RQaQHDxIHoiaeJmZ46tG8gXEUJErh2OMtt+IzbI/tD6US/uq8fjQhe+Z0j7PVU7jzt002/fNJoH9oToNMETKVNZ4rbQiRDeLwwZDaRrSgOIl7GMJc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743735195576632.862568814573; Thu, 3 Apr 2025 19:53:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0XAY-0005xN-Tz; Thu, 03 Apr 2025 22:52:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAW-0005ud-LY for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:33 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAU-0006mP-KM for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:32 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5341PEwh012194 for ; Fri, 4 Apr 2025 02:52:29 GMT Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45t2d8rgcu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 04 Apr 2025 02:52:28 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-2ff798e8c93so1614117a91.2 for ; Thu, 03 Apr 2025 19:52:28 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785ea16bsm22014865ad.106.2025.04.03.19.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 19:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XdOoA6yP8KgHJ0ReAntJTjKigv+wvIvUfO0xtSYIysE=; b=hLr57IbcFDEkxujR RV4xDgWWjUWJW/QOg4wxkLZ6VoSwoviqv8xgDa5djCK+p6gXF1OkE6OjdZvIwbx/ LC9WEVcl/rUpKyXxGZcL77jNGn6tA7nnkc17jWNDNVYNCHg6AQjEMWasBmXE6JBX Xh1namUZk+MMv6qGa0JLAiXle883FGxXz9wTq2IxLnPzwyN93S9GP5ub4WAztBdX FpodmvhQhGHmcaFJnRWBevRgDg2ESHuxth+8ZgjD6L00lPwzUsf/BawYC18UQouX hcgVDU9xiP1+2r+dpkz7qNgLhwIc8eRh1IBXh7PJFDfcDUe9pNC6BK3aHqUwhoBc zKWUyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743735148; x=1744339948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XdOoA6yP8KgHJ0ReAntJTjKigv+wvIvUfO0xtSYIysE=; b=sXAk91zsEKC7O1iWAnhFaRGSC/00zri6Gl2yYm0RXRV9TGxX8WG5dbM/FeAEiAwk4y IIjXJhOJVisyLutiezRqtKBrHNrtWYZpvh3SdBb4x+avPkSXPkTzk8zeR/3r5ZJUJ7oQ VCuhP7dqAomiKOaVl598Ls9vgTkh3tHR7HHtyWw0Q+RsVMS8Bi9X2iejaq7PpcCamx18 Bo/ADfPWRHWQuGe8aVTqZf6yCBf8radB48wleszSYAlrvuYuYM1NP3bxiii4DUwo/pR8 pfDPO3jlw6EkFVY7jO+dD+Xk0GFM9W0zoqJC5BFURP/Fotvi2F3W3Fgn0VG/+M14aot3 Tuig== X-Gm-Message-State: AOJu0YxdIQYrr2qAhNMYDAjh1VYs1FYLSWRKEIhVoksPMZ8kNaM1WoaA Lh7e34Umsr+tuqp6mp+ahbieGEfb8t+nFY66N2hil8TqeZFDHqJL0nH6PmJYeHaNg6MHkDkdT4/ WSoeY3ygB3mMacMDoCIjaZfM0gtb4xmAp8ynfOEns3GRo1hbm9bKRem9kqv2mJA== X-Gm-Gg: ASbGncuncQPrL1GUX8DpoMED6LxHVFy6uZ+bJIkbiwOkiLt9IT/6KfAv5kw4bWtjDnN It6OSnws8clZ29SeGr4GzC9b89DP9J/GqSOa/VI/ih7i12Do+NjS5kASXWO6oDbE0GIfhx3TKdg feuVp32b0Ea65UlJTpfrcusMvWWORekqnCRxd1/JhXxquRWjsUasb17S3zF6sve2nQQuGiWe5ER eNW+/lFEvJ4yM+9Z93hM3aumeQag8Sv9fLBvISHTkIVVwkpoApl7B+5tZoDDGOR9bRkN7npTSD/ 2AD6EDLH/8m+TJSSOcx4iC2kaliki//CdO+3dFkfdDtgXq1YE44N2Kmu8P0kCCGB X-Received: by 2002:a17:902:f64a:b0:223:50f0:b97 with SMTP id d9443c01a7336-22a8a0a6599mr18143595ad.52.1743735147493; Thu, 03 Apr 2025 19:52:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtUkv5/xJSlUucYvbaDLJICnmK+NOC8JobHTZ6nDAUEynndyPIvbyALwSsxvnC67UHAiIaXg== X-Received: by 2002:a17:902:f64a:b0:223:50f0:b97 with SMTP id d9443c01a7336-22a8a0a6599mr18143205ad.52.1743735147003; Thu, 03 Apr 2025 19:52:27 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, richard.henderson@linaro.org, philmd@linaro.org, matheus.bernardino@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng, marco.liebel@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex.bennee@linaro.org, quic_mburton@quicinc.com, sidneym@quicinc.com, Brian Cain Subject: [PATCH 4/6] target/hexagon: s/pkt_has_store/pkt_has_scalar_store Date: Thu, 3 Apr 2025 19:52:01 -0700 Message-Id: <20250404025203.335025-5-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> References: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: _xsFAn0nYvMi9CsZTcKFWk4Ibb2SZ19p X-Authority-Analysis: v=2.4 cv=IeOHWXqa c=1 sm=1 tr=0 ts=67ef496c cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=NfTq8dMVL6FJjgmeXnEA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: _xsFAn0nYvMi9CsZTcKFWk4Ibb2SZ19p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-04_01,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=687 spamscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504040019 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1743735198026019100 From: Brian Cain To remove any confusion with HVX or other potential store instructions, we'll qualify this context var with "scalar". Signed-off-by: Brian Cain --- target/hexagon/idef-parser/README.rst | 2 +- target/hexagon/insn.h | 4 ++-- target/hexagon/macros.h | 8 ++++---- target/hexagon/decode.c | 4 ++-- target/hexagon/genptr.c | 3 ++- target/hexagon/idef-parser/parser-helpers.c | 4 ++-- target/hexagon/op_helper.c | 4 ++-- target/hexagon/translate.c | 9 +++++---- target/hexagon/gen_helper_funcs.py | 2 +- 9 files changed, 21 insertions(+), 19 deletions(-) diff --git a/target/hexagon/idef-parser/README.rst b/target/hexagon/idef-pa= rser/README.rst index 7199177ee3..235e3debee 100644 --- a/target/hexagon/idef-parser/README.rst +++ b/target/hexagon/idef-parser/README.rst @@ -637,7 +637,7 @@ tinycode for the Hexagon ``add`` instruction :: =20 ---- 00021094 - mov_i32 pkt_has_store_s1,$0x0 + mov_i32 pkt_has_scalar_store_s1,$0x0 add_i32 tmp0,r2,r2 mov_i32 loc2,tmp0 mov_i32 new_r1,loc2 diff --git a/target/hexagon/insn.h b/target/hexagon/insn.h index 24dcf7fe9f..5d59430da9 100644 --- a/target/hexagon/insn.h +++ b/target/hexagon/insn.h @@ -66,8 +66,8 @@ struct Packet { =20 bool pkt_has_dczeroa; =20 - bool pkt_has_store_s0; - bool pkt_has_store_s1; + bool pkt_has_scalar_store_s0; + bool pkt_has_scalar_store_s1; =20 bool pkt_has_hvx; Insn *vhist_insn; diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index ee3d4c88e7..b6e5c8aae2 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -82,7 +82,7 @@ */ #define CHECK_NOSHUF(VA, SIZE) \ do { \ - if (insn->slot =3D=3D 0 && ctx->pkt->pkt_has_store_s1) { \ + if (insn->slot =3D=3D 0 && ctx->pkt->pkt_has_scalar_store_s1) { \ probe_noshuf_load(VA, SIZE, ctx->mem_idx); \ process_store(ctx, 1); \ } \ @@ -93,11 +93,11 @@ TCGLabel *noshuf_label =3D gen_new_label(); \ tcg_gen_brcondi_tl(TCG_COND_EQ, PRED, 0, noshuf_label); \ GET_EA; \ - if (insn->slot =3D=3D 0 && ctx->pkt->pkt_has_store_s1) { \ + if (insn->slot =3D=3D 0 && ctx->pkt->pkt_has_scalar_store_s1) { \ probe_noshuf_load(EA, SIZE, ctx->mem_idx); \ } \ gen_set_label(noshuf_label); \ - if (insn->slot =3D=3D 0 && ctx->pkt->pkt_has_store_s1) { \ + if (insn->slot =3D=3D 0 && ctx->pkt->pkt_has_scalar_store_s1) { \ process_store(ctx, 1); \ } \ } while (0) @@ -524,7 +524,7 @@ static inline TCGv gen_read_ireg(TCGv result, TCGv val,= int shift) =20 #define fLOAD(NUM, SIZE, SIGN, EA, DST) \ do { \ - check_noshuf(env, pkt_has_store_s1, slot, EA, SIZE, GETPC()); \ + check_noshuf(env, pkt_has_scalar_store_s1, slot, EA, SIZE, GETPC()= ); \ DST =3D (size##SIZE##SIGN##_t)MEM_LOAD##SIZE(env, EA, GETPC()); \ } while (0) #endif diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c index 23deba2426..b5ece60450 100644 --- a/target/hexagon/decode.c +++ b/target/hexagon/decode.c @@ -236,9 +236,9 @@ static void decode_set_insn_attr_fields(Packet *pkt) if (GET_ATTRIB(opcode, A_SCALAR_STORE) && !GET_ATTRIB(opcode, A_MEMSIZE_0B)) { if (pkt->insn[i].slot =3D=3D 0) { - pkt->pkt_has_store_s0 =3D true; + pkt->pkt_has_scalar_store_s0 =3D true; } else { - pkt->pkt_has_store_s1 =3D true; + pkt->pkt_has_scalar_store_s1 =3D true; } } } diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 2c5e15cfcf..7c73772e40 100644 --- a/target/hexagon/genptr.c +++ b/target/hexagon/genptr.c @@ -395,7 +395,8 @@ static inline void gen_store_conditional8(DisasContext = *ctx, #ifndef CONFIG_HEXAGON_IDEF_PARSER static TCGv gen_slotval(DisasContext *ctx) { - int slotval =3D (ctx->pkt->pkt_has_store_s1 & 1) | (ctx->insn->slot <<= 1); + int slotval =3D + (ctx->pkt->pkt_has_scalar_store_s1 & 1) | (ctx->insn->slot << 1); return tcg_constant_tl(slotval); } #endif diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/i= def-parser/parser-helpers.c index a7dcd85fe4..3316c230f8 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -1725,7 +1725,7 @@ void gen_cancel(Context *c, YYLTYPE *locp) =20 void gen_load_cancel(Context *c, YYLTYPE *locp) { - OUT(c, locp, "if (insn->slot =3D=3D 0 && pkt->pkt_has_store_s1) {\n"); + OUT(c, locp, "if (insn->slot =3D=3D 0 && pkt->pkt_has_scalar_store_s1)= {\n"); OUT(c, locp, "ctx->s1_store_processed =3D false;\n"); OUT(c, locp, "process_store(ctx, 1);\n"); OUT(c, locp, "}\n"); @@ -1750,7 +1750,7 @@ void gen_load(Context *c, YYLTYPE *locp, HexValue *wi= dth, =20 /* Lookup the effective address EA */ find_variable(c, locp, ea, ea); - OUT(c, locp, "if (insn->slot =3D=3D 0 && pkt->pkt_has_store_s1) {\n"); + OUT(c, locp, "if (insn->slot =3D=3D 0 && pkt->pkt_has_scalar_store_s1)= {\n"); OUT(c, locp, "probe_noshuf_load(", ea, ", ", width, ", ctx->mem_idx);\= n"); OUT(c, locp, "process_store(ctx, 1);\n"); OUT(c, locp, "}\n"); diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 6da8db8ea5..6ff37680d9 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -463,11 +463,11 @@ void HELPER(probe_pkt_scalar_hvx_stores)(CPUHexagonSt= ate *env, int mask) * If the load is in slot 0 and there is a store in slot1 (that * wasn't cancelled), we have to do the store first. */ -static void check_noshuf(CPUHexagonState *env, bool pkt_has_store_s1, +static void check_noshuf(CPUHexagonState *env, bool pkt_has_scalar_store_s= 1, uint32_t slot, target_ulong vaddr, int size, uintptr_t ra) { - if (slot =3D=3D 0 && pkt_has_store_s1 && + if (slot =3D=3D 0 && pkt_has_scalar_store_s1 && ((env->slot_cancelled & (1 << 1)) =3D=3D 0)) { probe_read(env, vaddr, size, MMU_USER_IDX, ra); commit_store(env, 1, ra); diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 5271c4e022..aca77dfdb1 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -705,11 +705,11 @@ static void process_store_log(DisasContext *ctx) * the memory accesses overlap. */ Packet *pkt =3D ctx->pkt; - if (pkt->pkt_has_store_s1) { + if (pkt->pkt_has_scalar_store_s1) { g_assert(!pkt->pkt_has_dczeroa); process_store(ctx, 1); } - if (pkt->pkt_has_store_s0) { + if (pkt->pkt_has_scalar_store_s0) { g_assert(!pkt->pkt_has_dczeroa); process_store(ctx, 0); } @@ -834,8 +834,9 @@ static void gen_commit_packet(DisasContext *ctx) * involved in committing the packet. */ Packet *pkt =3D ctx->pkt; - bool has_store_s0 =3D pkt->pkt_has_store_s0; - bool has_store_s1 =3D (pkt->pkt_has_store_s1 && !ctx->s1_store_process= ed); + bool has_store_s0 =3D pkt->pkt_has_scalar_store_s0; + bool has_store_s1 =3D + (pkt->pkt_has_scalar_store_s1 && !ctx->s1_store_processed); bool has_hvx_store =3D pkt_has_hvx_store(pkt); if (pkt->pkt_has_dczeroa) { /* diff --git a/target/hexagon/gen_helper_funcs.py b/target/hexagon/gen_helper= _funcs.py index c1f806ac4b..a9c0e27a80 100755 --- a/target/hexagon/gen_helper_funcs.py +++ b/target/hexagon/gen_helper_funcs.py @@ -69,7 +69,7 @@ def gen_helper_function(f, tag, tagregs, tagimms): if hex_common.need_slot(tag): if "A_LOAD" in hex_common.attribdict[tag]: f.write(hex_common.code_fmt(f"""\ - bool pkt_has_store_s1 =3D slotval & 0x1; + bool pkt_has_scalar_store_s1 =3D slotval & 0x1; """)) f.write(hex_common.code_fmt(f"""\ uint32_t slot =3D slotval >> 1; --=20 2.34.1 From nobody Sun Nov 16 04:16:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1743735222; cv=none; d=zohomail.com; s=zohoarc; b=GH2/rHrxuUFPL8C/2qd3C6qPLqk/v2V6BHqCNjfVVNzhHn8pr0rO6aSB2cWwFAzqlc/Y9DptcZ4Zj4dFf6VIkDXsJVWmRLCi2h3YuEcnov+AoCVV1HFKPWTcmU5B1ghZzQyIq6fxlfbxl19mOo7/oa2JhMd7Vmv8aIVKCN7HQgc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743735222; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=X6WsiV3WAnDhq6R8jZFhwXEKmS+scYU94YlEcS5TmFs=; b=JhGUYWY+zI+kwCRLxn5r1/CRNxYbLe1ybFQF+u+ebciaruoKmH4cIZ+JEAi6bhnnKBsQeoBBe4igUK7XSyZkWJFTtPTKihbAFSEDpxPcHYUJ2eLvB8cyd8sE7rqZb1KyKhU5C5JcnTwxM99nESpnolQ3bBCDqmlp5xNsTQDq6NA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17437352222541012.1187644199059; Thu, 3 Apr 2025 19:53:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0XAa-00060x-Bu; Thu, 03 Apr 2025 22:52:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAW-0005uf-Ub for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:33 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAV-0006ma-FV for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:32 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5341OFes016251 for ; Fri, 4 Apr 2025 02:52:30 GMT Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45t2d8gg37-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 04 Apr 2025 02:52:29 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-227ea16b03dso23241505ad.3 for ; Thu, 03 Apr 2025 19:52:29 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785ea16bsm22014865ad.106.2025.04.03.19.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 19:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= X6WsiV3WAnDhq6R8jZFhwXEKmS+scYU94YlEcS5TmFs=; b=jRiEzVmSMevs0i/l oN09KE5wq2Wrjxugao+4a8DFQpXfXxWkT1NPUzF36O4V9G0ckAUtzTqp8MIDkBf3 Snso0HhaCHIv8EqQQ9+2/wylxHJzyckO4hlnvd3PnWOoPyqMD6U/P1raQBYWPQln o4rSMNHubIyA4x0ugIHvzQSzwhiCEbPQ4q/tx6+4727OXR6/cXBvbDMyaS/000vn GSmVck3S2dahnJy9GuJvYB9j7l+A4p4uYVkZmsE/3gRgak0oVOskbfIyBAU6nT01 BZwYszV6Dz0PNy8BW2NApwo3Waqu0pvhe2f53r22Dwju8S9uku5V4anhy3k0N1YM 7m1xog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743735149; x=1744339949; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X6WsiV3WAnDhq6R8jZFhwXEKmS+scYU94YlEcS5TmFs=; b=RowznvBgEIYZp/IbDP00aMdkjdqmrFveatKGI9F6NXgiDLvNaZ+auz/IDm7oE3YVdq Putx+sTFoQv2OYYq5zCpXxa6dTC6SJ3GwVCS9PAMujyv5Lrb7+5Y6aHLETiTWmo+RPy9 GgZXHKSwQNzWQUzWd3O+a6Hld7KXp/eYLq1jHjzwqt6GBv0MVE4+JaLRTiKF5nXasMin N1Tgx+Cu0AsuuCCjhku6IprzTbHFn6N1zsL513FJMromEiT4istlGFFOfGbDN2m2QhsZ X0EcXyfNgEar+Jpqd2IhEKVcKA+ZD9cTPgt41Glhgo9ALipH4fcl9t/KrlJ2qJV9dvg8 XTow== X-Gm-Message-State: AOJu0YwBxXooLQr923Orivj6B1b/62mH/7YTbW/VNZ6qN7JlAfjPF6/5 PSeotB0chRaysjoMDNVB6trLPXX1uhMrNZHeUHsYdfWy0URQGOOpNgOLbsRTa0v3DYCSSNGre5n CbosVG5CVOB9gu2Sa8lWfcKEY4xowy1UPP9rn1jJacllKFIKi3RWIIQNKBKDJ+g== X-Gm-Gg: ASbGnctGYzq05W7hP2qRyGBQFVaxsHN1NttZs7dY2pX+sWdveVFXKXsa80LjwM99xq7 NqowobujcR9d6bj/Oai/na7a4M9ASpECZ3t74gWyXIM0T0IR5uNNV5H66UoJDroIYM2geVQm51M d8snHaeJGpzjf10r38X+jgd6KwQAl04WGIDags1A4FqIT9L0XXhfmL+sKf08cqPBsOBHfvkPuMa PLUD37htYucp37zyAWSXV/SqoGhXSRFZhHjac6mPsCWCNMG7toJSpDs7G2E787wFlukPbFVR3d4 A2vMY4GjYf1IlnxkR0mV2N+00Q123nFDyTBaodQnMwaer6dwrnLBBAKJ33cwT+9Q X-Received: by 2002:a17:903:8c3:b0:220:c143:90a0 with SMTP id d9443c01a7336-22a8a065780mr25065745ad.24.1743735148754; Thu, 03 Apr 2025 19:52:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZlnc0VY63us9hxSXeeXaNYyyBx0ppr/E/Bz/V7WmU+HJkfttBxKhAKFAAJaL2jpLiRre8WA== X-Received: by 2002:a17:903:8c3:b0:220:c143:90a0 with SMTP id d9443c01a7336-22a8a065780mr25065295ad.24.1743735148379; Thu, 03 Apr 2025 19:52:28 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, richard.henderson@linaro.org, philmd@linaro.org, matheus.bernardino@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng, marco.liebel@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex.bennee@linaro.org, quic_mburton@quicinc.com, sidneym@quicinc.com, Brian Cain Subject: [PATCH 5/6] target/hexagon: Remove unreachable Date: Thu, 3 Apr 2025 19:52:02 -0700 Message-Id: <20250404025203.335025-6-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> References: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: MAAVbo8QxjqCQKhdAsF8Kl8Kh_OR2kFN X-Proofpoint-ORIG-GUID: MAAVbo8QxjqCQKhdAsF8Kl8Kh_OR2kFN X-Authority-Analysis: v=2.4 cv=N+gpF39B c=1 sm=1 tr=0 ts=67ef496e cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=WeWQB0ruK5ITHrmzxTQA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-04_01,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 mlxlogscore=707 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504040019 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1743735224311019000 From: Brian Cain We should raise an exception in the event that we encounter a packet that can't be correctly decoded, not fault. Signed-off-by: Brian Cain --- target/hexagon/decode.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c index b5ece60450..1db7f1950f 100644 --- a/target/hexagon/decode.c +++ b/target/hexagon/decode.c @@ -489,7 +489,6 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t en= coding) insn->iclass =3D iclass_bits(encoding); return 1; } - g_assert_not_reached(); } else { uint32_t iclass =3D get_duplex_iclass(encoding); unsigned int slot0_subinsn =3D get_slot0_subinsn(encoding); @@ -512,6 +511,11 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t e= ncoding) } g_assert_not_reached(); } + /* + * invalid/unrecognized opcode; return 1 and let gen_insn() raise an + * exception when it sees this empty insn. + */ + return 1; } =20 static void decode_add_endloop_insn(Insn *insn, int loopnum) --=20 2.34.1 From nobody Sun Nov 16 04:16:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1743735225; cv=none; d=zohomail.com; s=zohoarc; b=Z9acoYsZDVpFGg6ZjSOetDSnt6naMgz8YI6XfVELZUWUzQHim/vF4J7TmyxSUV2hTsO7BHgvJBb4GNT3eAdO3zKhLlgX8iJmmN+CDZQK6FnmA1M5Nfinp/JKpFLP6yTqZLxKHn3vImPJB3gZWRzrIDJZwkabOeowvYHEQDipBuQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743735225; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=czvdxpjQBy2FgdjvVsvcJ/pDTWya3Xl1wmwT9xVccCA=; b=kCO1OyTRePo992NmoA6blmoDB9bEwyRj5IH63pBaSjzWd/CwKPnvynR4UB52/IS3GRbaKyqlvahLLiYfFXvp1TdCLM4DMItUpQY6AK5UGXuPk2GsZpSCYyYb+i6x4aaDQbgmDz2ogFiG93dAmsKEICb5ICnV13GDxA8fIdwYm+0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743735225851865.572538135206; Thu, 3 Apr 2025 19:53:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0XAc-00065B-4l; Thu, 03 Apr 2025 22:52:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAY-0005xc-SJ for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:34 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0XAX-0006mv-0F for qemu-devel@nongnu.org; Thu, 03 Apr 2025 22:52:34 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5341O8Wj016188 for ; Fri, 4 Apr 2025 02:52:31 GMT Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45t2d8gg3a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 04 Apr 2025 02:52:31 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3032ea03448so1743616a91.2 for ; Thu, 03 Apr 2025 19:52:31 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785ea16bsm22014865ad.106.2025.04.03.19.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 19:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= czvdxpjQBy2FgdjvVsvcJ/pDTWya3Xl1wmwT9xVccCA=; b=dsGqbfHl1tGYC4ue o8biD4+KMclAc2K+qmFjWOyeD0acHUX13ZwaJLpY33iccwHohsIjLhpgIQPlCVt9 TrYf3By8WbOk+V/DoPv7UDdVbLyVQjsxzhElO/IOobUaJfSRh5cg/prKm4sYiKll lRh++WTxziwq7WobCbwk3ypm1HhLdpJVlsmWCCGM4YPnaiz2r2O6pnQvQZgygiPI vLwnKjkaZJaCXq5kDZoMVr0hCaswaMLIgKkf19Uu595yx18rokEc0JxU7Sl4j2Ao apopJ/tT5L1HuomLpocRVrNdt47v6b0D60aRZpQPivFaQrsO/CklvUCUWBMNTY3t qRf5GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743735150; x=1744339950; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=czvdxpjQBy2FgdjvVsvcJ/pDTWya3Xl1wmwT9xVccCA=; b=FBACGhVI3h4XgcHpnVdoSNsLPz+cnOq686m5sgqwXmaJUPQaPP7OmQe3JATLtCli/y rmt2vw2u9GzfeuTDRBaaseHgmGz/S7fWHZ9mWQYH1l7O0oD1Q7KG7zibsmwhAR5DbWEE yE6N6co/dcYx8ROcQbvHr5d8+e9YLNoEd1EmAJR/W16j8Wt+/thKWuJlC5QUua4DCgGE CCFgkquetxRzP6iYUCbmDpYr8jJjqJQLyBTlIhItFTgddr87MvLSz9iNaMSVo9CNHPwt DO/hN/MP6EqIfBUBOOwsN81NI44dEtGzETaa5A/uDoKvZFNJLqP0mp/xDAah1OfbsMvK ADpA== X-Gm-Message-State: AOJu0Yzmmp90iKwV25eunFtpndyciaYmsYZr8FLVlTqsCqHiZ/LrAajO OW6MQYWGpnEGxJP6JfolCwjXlRht6bLS8hQyRPmbYMtkuM9McJwBj2mDlhYeWc9YtHEFK6l8f2k ii5X1LH9cr+DjCw2TeCKGpuQANu0+u4nvlcTWAXe9LG5yRfIK9m4Mv6o83Ovqrw== X-Gm-Gg: ASbGnctk9VWKqinJZUky3zPMC4jmZPzi96jxZABuAFqn70fTVkkxQQ4P6JrabYJLd0F 1fkqGkAwRpakFJTLiIgcUwBPFXjXRCqDuwCjX9GBCekA2V5FH/GN7IrctBqW0VXmjtinQOUFsQZ nZbMjFhzy3IiElWDAEBQYOKTGG/qLXIxvmpTQND/xCu30SFncl3tn7ldMtl3zR+SucejbvVX3fT f2M3i8yCsQ1o/U1r19F1xczDoB5XQ1xAQzyB7ChWK+Ow3mUtbAlr57CM1mykA03BamH5ExEDkWD vBGBISh9nIPICaA5/Rk9YeVrsRiPTR9Dsk9vZUmHMwDrCxInaa+jhNrkFEP0gMVT X-Received: by 2002:a17:90b:2650:b0:2ee:e518:c1cb with SMTP id 98e67ed59e1d1-306a4821ce8mr2598856a91.7.1743735150365; Thu, 03 Apr 2025 19:52:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpCvuN06qhn0oo5IVtpvcYcgLV6zaRscaedoxN6rs5NB9KICtubTTD6L+HuYVRR6MEqVRlew== X-Received: by 2002:a17:90b:2650:b0:2ee:e518:c1cb with SMTP id 98e67ed59e1d1-306a4821ce8mr2598818a91.7.1743735149777; Thu, 03 Apr 2025 19:52:29 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, richard.henderson@linaro.org, philmd@linaro.org, matheus.bernardino@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng, marco.liebel@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex.bennee@linaro.org, quic_mburton@quicinc.com, sidneym@quicinc.com, Brian Cain Subject: [PATCH 6/6] target/hexagon: Add memory order definition Date: Thu, 3 Apr 2025 19:52:03 -0700 Message-Id: <20250404025203.335025-7-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> References: <20250404025203.335025-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: teloBLVnbpkmM5ihttBuD35wgBF2DASj X-Proofpoint-ORIG-GUID: teloBLVnbpkmM5ihttBuD35wgBF2DASj X-Authority-Analysis: v=2.4 cv=N+gpF39B c=1 sm=1 tr=0 ts=67ef496f cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=SgXgUqScEDldHOCFpxoA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-04_01,2025-04-03_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 mlxlogscore=805 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504040019 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1743735226132019000 From: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/cpu-param.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/hexagon/cpu-param.h b/target/hexagon/cpu-param.h index 45ee7b4640..ccaf6a9d28 100644 --- a/target/hexagon/cpu-param.h +++ b/target/hexagon/cpu-param.h @@ -23,4 +23,9 @@ #define TARGET_PHYS_ADDR_SPACE_BITS 36 #define TARGET_VIRT_ADDR_SPACE_BITS 32 =20 +/* + * Hexagon processors have a strong memory model. + */ +#define TCG_GUEST_DEFAULT_MO (TCG_MO_ALL) + #endif --=20 2.34.1