From nobody Sun Nov 16 04:16:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1743712986; cv=none; d=zohomail.com; s=zohoarc; b=hCYRtmDb4ldkRZWmdZ1Mr8aZ5unWm1KVtbloycXZMgOw282Me4AXl3uqAuagtU251e/ynQMEaXgX3SZeM6ZRqedkmYPmM7ImmyXby1zEMG5cbPfF24HdbjdVENDB+pPAhYB/ttYhzJDcx1BZ0Ex+VUxuZglmorTf0HjtG2LFJMA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743712986; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cla1lcEde+/dwIvUCkqYoXlnQEk1tsR3rIU5tsr/g9c=; b=YmtMM6rFfx1xqCVugJSPswBYy3ca6/7JfA2BkQ5TXNQHmY/aly1xfxL4byTFT6qQSh9KULxst/5X0tyu8BS/WptnJJ8lpr1LWXlTChdVzdj9TslLrnCT7Rb4+6OA1ZN4BX5XEsxxPYzTiWVMwFQzwOAtJYwV0IGArQKh+DnIhyo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743712986360107.10500825961572; Thu, 3 Apr 2025 13:43:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RMi-0000P3-8b; Thu, 03 Apr 2025 16:40:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RMg-0000OD-ND for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:40:42 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RMd-00050l-8W for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:40:42 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-39c31e4c3e5so650817f8f.0 for ; Thu, 03 Apr 2025 13:40:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34be2f4sm27264105e9.19.2025.04.03.13.40.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712837; x=1744317637; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cla1lcEde+/dwIvUCkqYoXlnQEk1tsR3rIU5tsr/g9c=; b=AaABUsrIxq/L4VmQZ283u2WGtaBQxVATjngMGzQ9HssQlUcKpRntFvCtyqpdN06Z0L /K9Di+IX6JKx0ouxdE/j1aYRa4WDNBBT0JmmrQVKPjG6vIFZYrTPnyh00gc5wkBfeOpY mKIrHpgX1mjX/WNJilEpTxfNOtY1iOBL5SdTsj4VcfqSiJZdzVjoIPXzULkyBTdM8WUp Va4bHyvvNnmrtTghPufljF9czu4ajQ3WNWhJ1mwwNNpNT7xB29LDVqqlmdzoA/eVbpi4 ufB6m6yi/Rrv6yelUEEqAOIzBzSEZKpRwDmVpbGrW4O/EJNu/vc4HFpX5a9yE8svkzso kyyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712837; x=1744317637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cla1lcEde+/dwIvUCkqYoXlnQEk1tsR3rIU5tsr/g9c=; b=FiBlIgyJnNgS1K+chLU51XRijfR52RDchRXO/A3kIjZjHt5P8IP+Xouq/s4NjBstKW g5anCKGA8OiXxBT88nNDS6Qu+S53DjXbsb1NT49UZdtkZmszc3o2KGNnhODbzL+OadT2 6P1jCrNwJTQ0t9FhUGoXsBxhIcLn0kJRyQmZ6eOTr9WC0vh5yugKeLYaIzrZYbqY8mMg Iq8BA/sC6T1TukJxzxNIQ+q/YEagWhjwgjt7KH1zU5wVr/xJy8FaV10nCWeHYICfGKiE JjnLYbTV2opJu/4d2YBLHwMYnn8tV28Ui/xmbcbsC+oby5OHf8savdxjc38oPL0VtghC Ljsg== X-Gm-Message-State: AOJu0Yyerl51nLQrlhJVTSUBiWkVx9v5ZdcWs8qmtSz3UiumVYXwovsU ukSDRIBJj+zY7Ilebq2Kg0WSwSKvnR8eicwoAF6ZlGP77sKUmvxldqPWHe3rg/cBcFd3T/LNfvZ D X-Gm-Gg: ASbGnctelJsOOWU72TIL9HKMxbNRafuAOHV6GKivPElyEBX4mo6F4i4o+r6doEQxX8C OCQgVwDXBPT19yjKjtbS5Z1sKD/2Vjn0qif2TAj3XxTinOeAqGJg0C1hAaFZHh69zSCTxekWKNW 075/SWKIg7NFZWukLMTjBBzxCYHYf4pKOIQBHMTm/Awzua7pdQ4kTGY6/cS9HVV1ihjaGO2YmvH hjYJU4WY/s0pQmwaW8Rjye4nFfYByxcoEDTiJ9i9Jp1I9SehfCIOnsKeqvra2RLyB0Z/8Aa92BH utbCeI4y0TWI5mKeQZ+7s/hIx3ON5h7jgurTjwDx/FdoI67+I/6JOlWCu6Zt6WuLE0C4hEGKkZA 3/Gqya6jN+Y+3z2ufJaiUUOql X-Google-Smtp-Source: AGHT+IGq6MUAr4j6d4oFja99cnwBgM5fgWuSZdJ6FfKkZLO9wGdfJSDuz7LTmnOuzEJWijRc1JruUQ== X-Received: by 2002:a05:6000:2489:b0:391:4873:7943 with SMTP id ffacd0b85a97d-39cb35aaaeamr604653f8f.32.1743712836771; Thu, 03 Apr 2025 13:40:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Andrew Jones , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Udo Steinberg , Shannon Zhao , Gustavo Romero , Igor Mammedov , Peter Maydell , Ani Sinha , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.1 v3 1/9] hw/arm/virt: Remove pointless VirtMachineState::tcg_its field Date: Thu, 3 Apr 2025 22:40:21 +0200 Message-ID: <20250403204029.47958-2-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403204029.47958-1-philmd@linaro.org> References: <20250403204029.47958-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1743712987702019000 VirtMachineState::tcg_its has the negated logic value of VirtMachineClass::no_tcg_its. Directly use the latter, removing the former. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Eric Auger --- include/hw/arm/virt.h | 1 - hw/arm/virt.c | 13 +++++-------- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h index c8e94e6aedc..17c160429ea 100644 --- a/include/hw/arm/virt.h +++ b/include/hw/arm/virt.h @@ -150,7 +150,6 @@ struct VirtMachineState { bool highmem_mmio; bool highmem_redists; bool its; - bool tcg_its; bool virt; bool ras; bool mte; diff --git a/hw/arm/virt.c b/hw/arm/virt.c index a96452f17a4..177e9e0eadb 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -710,11 +710,12 @@ static inline DeviceState *create_acpi_ged(VirtMachin= eState *vms) =20 static void create_its(VirtMachineState *vms) { + VirtMachineClass *vmc =3D VIRT_MACHINE_GET_CLASS(vms); const char *itsclass =3D its_class_name(); DeviceState *dev; =20 if (!strcmp(itsclass, "arm-gicv3-its")) { - if (!vms->tcg_its) { + if (vmc->no_tcg_its) { itsclass =3D NULL; } } @@ -831,7 +832,9 @@ static void create_gic(VirtMachineState *vms, MemoryReg= ion *mem) redist_region_count); =20 if (!kvm_irqchip_in_kernel()) { - if (vms->tcg_its) { + VirtMachineClass *vmc =3D VIRT_MACHINE_GET_CLASS(vms); + + if (!vmc->no_tcg_its) { object_property_set_link(OBJECT(vms->gic), "sysmem", OBJECT(mem), &error_fatal); qdev_prop_set_bit(vms->gic, "has-lpi", true); @@ -3357,12 +3360,6 @@ static void virt_instance_init(Object *obj) } else { /* Default allows ITS instantiation */ vms->its =3D true; - - if (vmc->no_tcg_its) { - vms->tcg_its =3D false; - } else { - vms->tcg_its =3D true; - } } =20 /* Default disallows iommu instantiation */ --=20 2.47.1 From nobody Sun Nov 16 04:16:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1743712874; cv=none; d=zohomail.com; s=zohoarc; b=Gzq9QK8N33X+qctvlfyoB1Ve74C6PgWYMewrdvG83KoeMJSQ0XLNnmCBCohuCXcOlCMSbyQi3CYYKstLOkv4EfFicQUFUsOws2Gtcx5RLyhprLlWAlbDwFdtlIWC6QIXwPKnR2UhNGMSVLA5kJigKYHg8w8HHr7UgyyCiOChFMw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743712874; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=91qw8dB7Eg7Eq+MHz4XIrej88B1FVRM9ctS9zjgiZGk=; b=b53UxD+wUud+qZ7sbCpRZtxdYbZP9yX75KTpWKb21GYZcdpQRb5DNEqh2Y91C+c4FvKYWbpxOTdCw0TXACN0KYsURifoygTGw+ZHzElyoDm0u+lCuO8J9ARDuLzQ6bszYy19fRAOw4ctTezwxJ8xv5Sp+jaJNE2of5cvSsbln7U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743712874845555.208077464897; Thu, 3 Apr 2025 13:41:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RMp-0000QQ-1J; Thu, 03 Apr 2025 16:40:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RMn-0000QE-Io for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:40:49 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RMi-000523-Om for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:40:49 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3913b539aabso772213f8f.2 for ; Thu, 03 Apr 2025 13:40:44 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1663053sm30876275e9.15.2025.04.03.13.40.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712842; x=1744317642; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=91qw8dB7Eg7Eq+MHz4XIrej88B1FVRM9ctS9zjgiZGk=; b=wiNHb4TXxLhauYBb42lEygT+ElfPmQYLPU1CT3g2wPNmVMQQjWOtxLHTxnBM9qkRWm YW3KjzLTVRNmYy+VGdp2JOJEc50aCWdnnO+m0/X3TAnD48pX7NkJSDmV8IjKHpVtl6FI fUPrfG0LyxBWk7LZjJU4EeEppx+Hu+E/eOcVkciaO7H9gdol8NGh7nWlmJ3qhfSea1VF dwKIM0vjVxpw1F4vbDwpz5JXnKIJW6Ow7SBqgPhMp70Io20Pv+UVEhM3OpU48tNaXDZo PLng0Lk8RhOdDhjytLxM/lF/4mHbpV+aDFyzJfHF64aopkaRZ6Czcl1TeamQl2UxKhrC U99A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712842; x=1744317642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=91qw8dB7Eg7Eq+MHz4XIrej88B1FVRM9ctS9zjgiZGk=; b=YQIMGNsZx6hxiHa4Icr3JveorEg1cT0cWAqW0B/C+hCfRp2OjJe0nxH+/ozq4gAuXt VxSJzWQOZDPdhYCFSuRSymL8vkCpT47uPkQUUNaH9XxCjDnHI9lQdKu0Qwvc7Hgxq4Jt eY8tevDQV+RJIa6HMKjqzv4UxgZyxJaRsKwR31nOPVKVQWfWAG8CE0HH196NbnrrbcSZ U31qPGg8MojZG2UzOf29P1IxEi/FQwKsfs29XkXpJzNUr/j0GwBJzPCOhGqEWLwog7AS M9Ci56Ou0c2+WgpSxhhCm6gf/PN50fnl4HOCkk/SiYRLtr9tKTUo3xfL00g9ykXM/aQK xM4g== X-Gm-Message-State: AOJu0YwHigf/pA4Inej8oBuzZ2q0/im9BwU07D/oeM4MzNkfhmHaO00f I1kIU9BwQMHrXI5qr2U5KNb/k8Sz895ZBRR/kjZwcRiMcC/MRkXv3Eot58hQrKQymglrmlyX1eI F X-Gm-Gg: ASbGncvihW+YAVBh2VLZ1VCoWcTRzKf8ksqgURz3cByBKQY7seYx4rUvFCuEjMrEH4R U6ViWjjSliRc8boGbDt0nZR7eza8YyRm5+cHoETfRwJlHaYNIsKuEaPEjg8ATf/5NpcOBFmBirF FjIU15ntlXqfiBKa0sxcOiOPjHOjZa957G7stmlufYU5ixqYT7vK+gdU1qYRqQAbgpNKp4JfyKE OhmTGjqjM+ufJlDT/T+508tnjFqTY4YTeH7iEYqhu2++1ucsTkqE/zz4LhlHmzC8ysAWu7cykQ3 muihfipdP1pHUS1ORfbXkgrAzmQsjch9yWe/9PNkuv7IKy0Kt2jcmz5poaXhpMvQ4QimqI9hzoX KygXtPHvh1RXPlbiV/sS8yPGobmrF7JJNoXQ= X-Google-Smtp-Source: AGHT+IF0VB25+QWZbsznnQinFc032J8n9BsALOb34HjpL7ukA/Tx7TYioKqQiRbt6yig2CP+o+N8Tg== X-Received: by 2002:a05:6000:188f:b0:391:3915:cfea with SMTP id ffacd0b85a97d-39cba93329amr612537f8f.38.1743712842401; Thu, 03 Apr 2025 13:40:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Andrew Jones , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Udo Steinberg , Shannon Zhao , Gustavo Romero , Igor Mammedov , Peter Maydell , Ani Sinha , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH-for-10.1 v3 2/9] hw/intc/gicv3_its: Do not check its_class_name() for NULL Date: Thu, 3 Apr 2025 22:40:22 +0200 Message-ID: <20250403204029.47958-3-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403204029.47958-1-philmd@linaro.org> References: <20250403204029.47958-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1743712875629019000 Since commit cc5e719e2c8 ("kvm: require KVM_CAP_SIGNAL_MSI"), its_class_name() single implementation doesn't return NULL anymore. Update the prototype docstring, and remove the pointless checks. Reported-by: Gustavo Romero Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Eric Auger --- include/hw/intc/arm_gicv3_its_common.h | 2 +- hw/arm/virt-acpi-build.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/intc/arm_gicv3_its_common.h b/include/hw/intc/arm_g= icv3_its_common.h index 7dc712b38d2..3c7b543b018 100644 --- a/include/hw/intc/arm_gicv3_its_common.h +++ b/include/hw/intc/arm_gicv3_its_common.h @@ -128,7 +128,7 @@ struct GICv3ITSCommonClass { * Return the ITS class name to use depending on whether KVM acceleration * and KVM CAP_SIGNAL_MSI are supported * - * Returns: class name to use or NULL + * Returns: class name to use */ const char *its_class_name(void); =20 diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 3ac8f8e1786..9b7fc99f170 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -741,7 +741,7 @@ build_madt(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) memmap[VIRT_HIGH_GIC_REDIST2].si= ze); } =20 - if (its_class_name() && !vmc->no_its) { + if (!vmc->no_its) { /* * ACPI spec, Revision 6.0 Errata A * (original 6.0 definition has invalid Length) @@ -973,7 +973,7 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTa= bles *tables) vms->oem_table_id); } =20 - if (its_class_name() && !vmc->no_its) { + if (!vmc->no_its) { acpi_add_table(table_offsets, tables_blob); build_iort(tables_blob, tables->linker, vms); } --=20 2.47.1 From nobody Sun Nov 16 04:16:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1743713059; cv=none; d=zohomail.com; s=zohoarc; b=ngiD60Zi4MBFL2BKPfM0pTVB7tPZgMSUUTcTwiyXwGNUCSkm+UXk1ieHa3+aDWMRmVptaZzj3Vdq1lN12wCWftaA4IbyIhgXhm0ZEuKkDLpVzDJ0BQ0/oJbOnHQoC5n4NiVYYDNkDsa3wAkFPczQCghDwN4iagcforQbduNxoPk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743713059; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SuT3rRChRQlFqOt9wOfD9dqVNsRbmscUvrlQveNmeCQ=; b=Pe//Fqiua3enxlLOvfYneoFCqmRFqZxDxscZ1GjN3pNaE5mTYgNS075IfvvUR0sNOHXAHOZTH3XQEC9SNqCXMGdMidXTA0N+7mY8JoFMUqGtUskXzeiLIx3FLEVLvywiyr5E+AepYVmpRxtWgqc2BIEG3uW9JbJIyXzzvIgARMc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743713059412762.026386298617; Thu, 3 Apr 2025 13:44:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RMs-0000SD-2v; Thu, 03 Apr 2025 16:40:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RMq-0000R1-1y for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:40:52 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RMo-00052s-Cs for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:40:51 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-39c14016868so1184009f8f.1 for ; Thu, 03 Apr 2025 13:40:49 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34a8d67sm27667955e9.12.2025.04.03.13.40.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712848; x=1744317648; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SuT3rRChRQlFqOt9wOfD9dqVNsRbmscUvrlQveNmeCQ=; b=uOUHGa3nAzLCCBRWwun+Yrye/hWW/2ZHX8limWayTJqOttULKcl83zIrSX2WtZKTu+ 8eUOiABT9JBx5SCUMNLKBPX+UVmL/rcW3+2vqkN5HMHf+9qM1LjeDZqRk4gquqUcd2eR CWdGUQo7CpepaBzxqslGAwIuJhwILeo+xVrJDDwHHLVSfjXRgZSXUgB+1d/vn63m7hnI fmqLPRYnf6p+i+ylmz41mWq1MBNQOSbLbsCN3sBKEejM1fBjhx6ftrAnB/Zn9IbwgpnI 8Wh0Qup97CxyPmtZX3hsAHIAWxgTGpG2V7c7Qd9IvXb54zJTtSh5gkbNoozsfMyEkOhe Fp/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712848; x=1744317648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SuT3rRChRQlFqOt9wOfD9dqVNsRbmscUvrlQveNmeCQ=; b=YqkL2IBfZHVqqPWaRMcDJBNLmGBUblenH18VYbq9//i3ST1DVae+cHUgKR9Wt80GXE R96k509sdLopxjYOCbJFLEnTYHFVTasajZySkbh5TXbgC7UByGCB6KygrwII+LllIqXz esh3pe/pRATBYlEcrykNpR6yGpqIC2vZx45ipq0PGjG/XuvEqbx+yztP8MilNytz085C BsF/dGWcoCsz4AV4wVAU94zjfgXASSJ+nLquaDk81A8vxPJB8wv+QoHBrL1zLHIqmI+U 5Fh90CEFlz302bB7S9GWuEc1PwsjMhn8udRTm49+mbflUBVOUtJAcoBPbd/o1GX9myiD FhSw== X-Gm-Message-State: AOJu0YxTS46MajFjOPM/fapfK/zgerJk9YncCZm+1ZevY7sV3GYxf8KI ZmMQEJ5AxNp1iJZJM0MX5Wkokbr7TAl9vDu61g4HtJMzguijp6K/ddaLlDnDSCNwyWvqoljAUqM w X-Gm-Gg: ASbGnctWp//zV/uUIVDRv3jF52xBzJgMKKP0ts1qAjAiFlDeosY+EWu8n5ZiD/a4hRA 2SRZ/xrqgn8zPYi/H7pCuHcX3kgn8ijIQz+QjhR+skjOPITtm9uqYSc0+r/byaYQCDRYCwkbm7d i/3gUvv77onzad1jw7iOO9VxPGkzQUIvmJ4Nm7PZoc+m3tKf4wAEdQo7q24UUTFvOS/gf2BBiQ9 Uego/VoUWBZ1OQjzPizZ2H1Rnhe/x0GpltMp1EBCgGKX4UwN/kHmMzVxoB8u6mM6Gij3x7i0MF7 qdRAR2eiJWnnAvBjHCQpWL1wZjnCI5IMvOHnVpJ7pmMFrXkwFHIO+rNz3ZP+ry/m/SuAEHdXbPG 8HrYNzQraX9PWOrg2la5kfVvt X-Google-Smtp-Source: AGHT+IF2VMf4EDjDDN59fjDN+tbSx4iQ6z95AwQIjihuuUbgWCnpzmAUquWXDrOlNBosmQV55armwQ== X-Received: by 2002:a05:6000:4402:b0:39c:1257:cd3f with SMTP id ffacd0b85a97d-39d14663264mr123060f8f.57.1743712848318; Thu, 03 Apr 2025 13:40:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Andrew Jones , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Udo Steinberg , Shannon Zhao , Gustavo Romero , Igor Mammedov , Peter Maydell , Ani Sinha , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH-for-10.1 v3 3/9] hw/arm/virt: Simplify create_its() Date: Thu, 3 Apr 2025 22:40:23 +0200 Message-ID: <20250403204029.47958-4-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403204029.47958-1-philmd@linaro.org> References: <20250403204029.47958-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1743713061324019100 No need to strstr() check the class name when we can use kvm_irqchip_in_kernel(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Eric Auger Reviewed-by: Gustavo Romero --- hw/arm/virt.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 177e9e0eadb..326986deb16 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -711,21 +711,15 @@ static inline DeviceState *create_acpi_ged(VirtMachin= eState *vms) static void create_its(VirtMachineState *vms) { VirtMachineClass *vmc =3D VIRT_MACHINE_GET_CLASS(vms); - const char *itsclass =3D its_class_name(); DeviceState *dev; =20 - if (!strcmp(itsclass, "arm-gicv3-its")) { - if (vmc->no_tcg_its) { - itsclass =3D NULL; - } - } - - if (!itsclass) { + assert(!vmc->no_its); + if (!kvm_irqchip_in_kernel() && vmc->no_tcg_its) { /* Do nothing if not supported */ return; } =20 - dev =3D qdev_new(itsclass); + dev =3D qdev_new(its_class_name()); =20 object_property_set_link(OBJECT(dev), "parent-gicv3", OBJECT(vms->gic), &error_abort); --=20 2.47.1 From nobody Sun Nov 16 04:16:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1743713066; cv=none; d=zohomail.com; s=zohoarc; b=aygP4soKosYi83Qg1ukh1Qgi3RQVvd7jESCF7k5wxKRMSCRQa/bfx9Va8QYWSSTxEFm8/17IawttqcDMPZb7V8GA+3+tZFP/BgmzZZ75LFGZw0lEhMI1SdINQEHIcS8mpGO9J7PFbxVScWoz9y/Q3TFVBqnE8DzomZIJHHcJsKs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743713066; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wgBNy0vxL5goVE1RO7+eU01X51ted55h8TOUfbLYmNA=; b=aFllNKoGMFiY4P6dcF5cmfSORrscSHrZvY1WhSVAnU0JRgIzmx+EV7QhrOeITzJiLklIowDmdjmEWU67FRfjj5NyyEJwcsUjY6bR5V8FM9PUtNpQ0Kg3HMUxXIq7B4pwiq6ExeTDsle1qlyZrJ/IQI1zgPi6+OU7QEJwtQiFRc8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743713066464493.2108620531584; Thu, 3 Apr 2025 13:44:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RMy-0000TA-6y; Thu, 03 Apr 2025 16:41:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RMv-0000Sm-5D for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:40:57 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RMt-00053m-Bv for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:40:56 -0400 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-39149bccb69so1182100f8f.2 for ; Thu, 03 Apr 2025 13:40:54 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d92dsm2701086f8f.71.2025.04.03.13.40.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712853; x=1744317653; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wgBNy0vxL5goVE1RO7+eU01X51ted55h8TOUfbLYmNA=; b=H30ZVGJKBcaaq2FOoqIwv/af32jtCU0el+/5zMVoqK1CvVmSoOZ/rxZDV7qXe/HJwV uTDpOZbQgmgimhkgNUbwsDxbgaHYkbxjCwWmEtPfTk5JB0SCSht0SX9F8xH3t6CbW1bz Uh57RKKWHIs+y0LqtVuAa3cLYjVYb2x1BI2pT3mUpElwKgxKvLX5vmBkGIOQpdYkxY7H 5inTP/9ZPyvKiNc8BhRwqR/796/vNZ7bePhMHPIfbcfdxqSVTg58inXEQnVs9poCUKeb ILlBUZAH9On7zsbXT0k0wKQqh+uvRduU8OqXP2C3Yo9eT6prVEWyjm1PdwguQC1SszAF Cn2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712853; x=1744317653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wgBNy0vxL5goVE1RO7+eU01X51ted55h8TOUfbLYmNA=; b=o0BFs1+5VDD6RKBDZkGqQu5EnQtO8iDjvgRYuHcJIrmzSpx0tG8FxYDQF4FBqD/tC0 xw7ttwlSM1CUi/bX7ttgRFm5cCXtmXUEgpL0a9g3Zd9yx+buqsrod7SaTV4unzi/H6Ic ADiDk292vz20ikuSTISl6w+EvsnqGscqko81oj7JbhUF8lNUbeOkD/iRuM5iEoiUHaJk w1MFrcy6pD5PE4b+rDWeIZ44T6jjiEx5lf8cN900ArXLNSM5X2Gjukkjky4v2cJruw+b wqNn+voyUEpJO0YyOLxIPdZBos6Smuv3KZlODpnoMAFS4Se1PnbHUErAqHXQw+R1onFj V0bg== X-Gm-Message-State: AOJu0Yx9Z4wLmLlLp9qZzeB0pxUkOn1AMHPrBOCd8V02j/GlSmN6lf4G O4HDrV14KEc8n2F0GrMKCDR7Q+u07H9Qm5wi1lvILcApq9zy0MaWZkwPrt9/C73aJi91Y9U3ytq H X-Gm-Gg: ASbGncuEDOgz0Qqz3VI3tekCzf0TPKTsgMAoRAYDRZOtUcknJk4qb+YNLiuNxBFc3qZ milSewcAQ/K7rU2c280mGa7t9pL1mp+mexoL0vgqJ7fd4C3Uq1a4lnXSngnk2V0nlcXWWfhq/Y+ VCDRGlpLBF8wxIFAeYzQfTpDVuiHsQUIl3h9/r35Ops4ifATpMwOiH8A2AtAO+SknXFrLsZIvN9 qhhyGaQEb98P2vWekNfF/Ut1DYgNv44UHkudbhsiTxM81qoIhKuW4iUeQPh4U54eDAaTgBAeyag Sk0pJxh6wi0gxTuDT+Fx2uLFZuyoxi35JyoFwS61Gsdu9QcwhbX94/aaf6JxoVMiNOVwDg9dGzj Z4/ojz2/5Ztg7eeUlDCEw4gqV X-Google-Smtp-Source: AGHT+IH4lgvNsUHnBXhJTwhPZ6ES/eca2Luz/7MBxFtwM/gfjOqkPfYWg5DMg91sjnjMgnPylkv8YA== X-Received: by 2002:a5d:6dab:0:b0:391:31c8:ba59 with SMTP id ffacd0b85a97d-39cb357afeamr595947f8f.4.1743712853197; Thu, 03 Apr 2025 13:40:53 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Andrew Jones , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Udo Steinberg , Shannon Zhao , Gustavo Romero , Igor Mammedov , Peter Maydell , Ani Sinha , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH-for-10.1 v3 4/9] hw/arm/virt-acpi: Factor its_enabled() helper out Date: Thu, 3 Apr 2025 22:40:24 +0200 Message-ID: <20250403204029.47958-5-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403204029.47958-1-philmd@linaro.org> References: <20250403204029.47958-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1743713067986019000 GIC ITS is checked for the MADT and IORT tables. Factor the checks out to the its_enabled() helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Gustavo Romero Reviewed-by: Richard Henderson Reviewed-by: Eric Auger --- hw/arm/virt-acpi-build.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 9b7fc99f170..1c389ef5cdb 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -208,6 +208,13 @@ static void acpi_dsdt_add_tpm(Aml *scope, VirtMachineS= tate *vms) #define ROOT_COMPLEX_ENTRY_SIZE 36 #define IORT_NODE_OFFSET 48 =20 +static bool its_enabled(VirtMachineState *vms) +{ + VirtMachineClass *vmc =3D VIRT_MACHINE_GET_CLASS(vms); + + return !vmc->no_its; +} + /* * Append an ID mapping entry as described by "Table 4 ID mapping format" = in * "IO Remapping Table System Software on ARM Platforms", Chapter 3. @@ -670,7 +677,6 @@ static void build_madt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) { int i; - VirtMachineClass *vmc =3D VIRT_MACHINE_GET_CLASS(vms); const MemMapEntry *memmap =3D vms->memmap; AcpiTable table =3D { .sig =3D "APIC", .rev =3D 4, .oem_id =3D vms->oe= m_id, .oem_table_id =3D vms->oem_table_id }; @@ -741,7 +747,7 @@ build_madt(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) memmap[VIRT_HIGH_GIC_REDIST2].si= ze); } =20 - if (!vmc->no_its) { + if (its_enabled(vms)) { /* * ACPI spec, Revision 6.0 Errata A * (original 6.0 definition has invalid Length) @@ -973,7 +979,7 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTa= bles *tables) vms->oem_table_id); } =20 - if (!vmc->no_its) { + if (its_enabled(vms)) { acpi_add_table(table_offsets, tables_blob); build_iort(tables_blob, tables->linker, vms); } --=20 2.47.1 From nobody Sun Nov 16 04:16:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743713001490925.2089645444808; Thu, 3 Apr 2025 13:43:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RN5-0000Ui-9w; Thu, 03 Apr 2025 16:41:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RN1-0000UG-0L for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:41:03 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RMz-00054g-1T for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:41:02 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-43cf06eabdaso11711695e9.2 for ; Thu, 03 Apr 2025 13:41:00 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30096ecasm2751545f8f.18.2025.04.03.13.40.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712858; x=1744317658; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=877Ft8S2r+Y3e5owHO3tHYlDGhoIjLwtX0511Fk5+so=; b=fU/VdtIOELqOhynYVKlhaAzreWU1Cxx5ASG3rnM6Uot5h9d/19qAo5MlMmpamS7NHG h0oKQ/1bcOBq0x2wbH2ez59979Uv6QPxluNk7GLdvSdDjr7hkAV1JISrmkoDCQnBcVdD 7jMmvvSQfzKm8DvCBEN/nWMHZwM5JZjoM1xjn9NijvWOIaXpFaDKzyuVvmRREzbQ7x3F Wof8XLGCOQhxvd5sv4RZQjVKoO8hhyP6qIsjp831Yl6oRKz49m2G1Rgcrtre2Lhsqxua jRlczzBp80Su8ZxaXW7JTx7ZqNT5qZq8MzIRC2hlRguaVmBk3q3NbQrBJjVu2V83LWxu IptA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712858; x=1744317658; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=877Ft8S2r+Y3e5owHO3tHYlDGhoIjLwtX0511Fk5+so=; b=vdo9mir9jyd89RHxce9CdnAdxVUsmcOJSXF+gtcdzeSF2ERPcfIoXcOTbJC2LiuNTs 55iASjcpmWuU7gxUu6oCU7Mpwk1vKWG38FBpZypRd/Lv2p7Yq8WUkVf9rNf4vRJqGmf2 Hl0lPeSkwGErpOwPdEf3jkkKOdsY3sZIg9Il2/+c5JitRsGWG2sR5jlEsfDs5edlT0Ae uA9eGQTS0Cxw+RDe1nNPMLuRlT8zrrao/Lr8ygtGNRt++hNJ9jBJehpWzbCMmUPMp5UM +XAs5l3S8BrtTjSfpAmv6GvFjc/2milnJSzB4cIf39XGmY2dtXTGZ5DNNpw39SxmW2qE kaIg== X-Gm-Message-State: AOJu0Yz16Hs3U3+XJNY41UlZclEtNZzkZogzLFKjSkdpd2G2GxzCYMvS pj/ddJHkQwEu50IDSLvIeDEz9k/dSbzYYJxezjvsQXhDYSd9IpjMPOIWHGLT7Ltob5KzNVl4qaY L X-Gm-Gg: ASbGncscYk2mfixKpz+//6vdndcwwllERPoVuYcejuUBPIGjFAkU9brBGzsYE/6XWSh lOx5zTNrROnyHyphkD66oAmrrfo641K+luf6mvq4Pgj4Hnzc8Jw+qMyUe+XGVU6Df4CNy0C1nvu I7ILmdg0NOukFKN8p7g4ihK6365yKF/TSNcWxFr3jJqLPfLCvflscRwlY28kPq2Xr2oxBv19MQc YxMYGXVC1JFG3DUahJYiJX1hliwNUoV/eAhFACXmdz1DWIz4fwzMMjp/VKn2cGy2Q8G733bpQOn lcBC8d7/WTQXba2sA2WOcNh61PeIvge8ma8Buva+t3AWD/s122acX0bdJXuzi8+B2tCQLh2jIof U7ufFbD1cZma8Zuj/+QCHOiyn X-Google-Smtp-Source: AGHT+IGfjUcJG9Fw7vR54jYQJL9/ZtCgzSobq42OEOH5Ba74HI3rkv7ic03mtQjOW5kojYSeYFTrzA== X-Received: by 2002:a05:600c:4e05:b0:43c:f8fe:dd82 with SMTP id 5b1f17b1804b1-43ecf90b278mr5431455e9.18.1743712858208; Thu, 03 Apr 2025 13:40:58 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Andrew Jones , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Udo Steinberg , Shannon Zhao , Gustavo Romero , Igor Mammedov , Peter Maydell , Ani Sinha , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.1 v3 5/9] qtest/bios-tables-test: Add test for -M virt, its=off Date: Thu, 3 Apr 2025 22:40:25 +0200 Message-ID: <20250403204029.47958-6-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403204029.47958-1-philmd@linaro.org> References: <20250403204029.47958-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1743713003021019100 Add the use case reported as issue #2886 [*]. The test passes while it shouldn't. We are going to fix that in the following commits. [*] https://gitlab.com/qemu-project/qemu/-/issues/2886 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/bios-tables-test.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 0a333ec4353..baaf199e01c 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-test.c @@ -2146,6 +2146,25 @@ static void test_acpi_aarch64_virt_tcg_topology(void) free_test_data(&data); } =20 +static void test_acpi_aarch64_virt_tcg_its_off(void) +{ + test_data data =3D { + .machine =3D "virt", + .arch =3D "aarch64", + .tcg_only =3D true, + .uefi_fl1 =3D "pc-bios/edk2-aarch64-code.fd", + .uefi_fl2 =3D "pc-bios/edk2-arm-vars.fd", + .cd =3D "tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.= qcow2", + .ram_start =3D 0x40000000ULL, + .scan_len =3D 128ULL * 1024 * 1024, + }; + + test_acpi_one("-cpu cortex-a57 " + "-M virtualization=3Don,secure=3Doff " + "-M gic-version=3Dmax,its=3Doff,iommu=3Dsmmuv3", &data); + free_test_data(&data); +} + static void test_acpi_q35_viot(void) { test_data data =3D { @@ -2577,6 +2596,8 @@ int main(int argc, char *argv[]) test_acpi_aarch64_virt_tcg_acpi_hmat); qtest_add_func("acpi/virt/topology", test_acpi_aarch64_virt_tcg_topology); + qtest_add_func("acpi/virt/its_off", + test_acpi_aarch64_virt_tcg_its_off); qtest_add_func("acpi/virt/numamem", test_acpi_aarch64_virt_tcg_numamem); qtest_add_func("acpi/virt/memhp", test_acpi_aarch64_virt_tcg_m= emhp); --=20 2.47.1 From nobody Sun Nov 16 04:16:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1743712900; cv=none; d=zohomail.com; s=zohoarc; b=Xe3cokHjtpE/C0SXitqdQVNIClsWU94XT329qpY5ugAEEPuQwwTrijorJVPI3LGk9ArJNAxnPLa4QX5X+oYR/XNqzEE+htGjSMyfIlf9UG1PPm9H8mUJFTuHIsQRE9k3Wfgu4hSXU7tlTcID2oFcbJ7/yr3mpkQTvSo4vTZhChY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743712900; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MLYRdVVgThynsCkkZUPojC5QmxuF1gOqeLFrpCloSHE=; b=UG0CM/lFmscmFACqBr9N/4vIjOod1JbB3eJQAlfDf02JPdTvHjF+0ADcn8Snj8qgoTL7iEbUoLqIgrNKpUwoNrEmIp85KYmIqFIFRB2D0jar/CH/mkwv7tjhEYE6SN5PtOjGsRE2H1uiumDsBQxZO6F/kV+Z69C8QPjUqAr4kQM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743712899995624.4832091755852; Thu, 3 Apr 2025 13:41:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RNB-0000WD-3L; Thu, 03 Apr 2025 16:41:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RN7-0000VS-1W for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:41:09 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RN3-00055Z-R2 for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:41:08 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3912d2c89ecso1174856f8f.2 for ; Thu, 03 Apr 2025 13:41:05 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1662feesm30696335e9.12.2025.04.03.13.41.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712864; x=1744317664; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MLYRdVVgThynsCkkZUPojC5QmxuF1gOqeLFrpCloSHE=; b=xq/grt//rjkCSrHHgRRorlsHP0+4zw95I1KhE3Q8XUnN8EiZQW6UdXpE63YSZ3pXp/ HCq8K5EhEqliHt9OYVnK52I0Ql/kEttUOxRNclBluaAWSaV71Q04GwCBlTVl/kApu2W8 3USH+U9l63pHRS4mKFW5Cobnhe6kmL8piFkxbGiqte8i8bxPqDTVumZRyYAPliprOPJt j1pcWmGpSdWbdrtpd0ReFgjqKloh7ef3TEIyemi4AjQ0uduaDFY9xNv89jTxNf+pPe/o a6POsiaF/0Ih8T09qeItrICB4HgGFAfyS0vexGrEYTX+lbFStW8cn2pF8OA5/0HNjuyS d7rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712864; x=1744317664; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MLYRdVVgThynsCkkZUPojC5QmxuF1gOqeLFrpCloSHE=; b=sL9kGK+jxlBgE37nqyWZs5KMgoZL267HRtR1NZFEpHCEW/NZf8uKmew9XHxpD7GosT gBuH0PMd1vxIKjKwpYtHV1aO3BQOnZEhVwlidGNaisrs0aDg178IC/+mC6zlyQfV2AF5 Y/Ra+v6kbFraptFHsMsT1RGgoilJt3FCLqFxV+Zi8KXaKuj8nq/S1RX5qTerQ1mkk2BO j+9qn2bgzHKLbwz//tEPpZH75PlnMOIdstpjLjDQqIdQiNSHO7QN0fEzWBERSPnk9jjW mDDElCCvxwVZRWtURaIqmnhZepk31Yob4UfaT0pSogYhEt2D10LPHhmaHCtYcn0EL0r/ TmJw== X-Gm-Message-State: AOJu0YxXdPyMTX1CbEz+nxgSVQ4KlzWSQoZ1v/Ib6ctTA//Pn5NFTcwe XklFQqNdKA/hVuwnh0JQBpbImz1HVt4tEQo8V8ziWlE7b9kogGhF+0I+GO/YjRDCGm8kwQzm2Z8 b X-Gm-Gg: ASbGnctSvpD3qv/FiauJ04/tzZVk1zFkjljYPIYAtW7nVxBSx5HKUsEpvUfQtG4d2ub YNWVbtIM+7hvFT/iQgXRsLWSe08I85FybK0mKjGDxxJXKz5v0L8Cm3hSdg8dzEAJKEdsG+JOxLM bJRMf2UQgktnDtBPiv1Z1ENfuW9QgDkPWKBV+K8UXJsZiaHLLwSP7rGZZRbG1Sxw0WxhFe1LhTl Hx3kBsJoeNdXcTETOQ1Ndx5KMpYObbABs6ZD7U262xuDNVnJ+9zF0HOCTIWIL3BmFIuV8alzksR KIkTh04LXL57jKUYNPlMVT9IcZlx+tUMCFi/CkVnohd/ssyG8uwAAcleJ4v6jmADaMKTQ8TRgaO 6oNReV9oF1sMdjiOU/uNp/9/e X-Google-Smtp-Source: AGHT+IHojbYMTI2SxjbDhqL1jep68YzCCoAPzFjtnoNR9EhzKBd3AcnPJyCUlbk4mdyAKPNG58yR5A== X-Received: by 2002:a05:6000:270e:b0:39b:fa24:9519 with SMTP id ffacd0b85a97d-39d0de2d383mr130133f8f.35.1743712863777; Thu, 03 Apr 2025 13:41:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Andrew Jones , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Udo Steinberg , Shannon Zhao , Gustavo Romero , Igor Mammedov , Peter Maydell , Ani Sinha , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.1 v3 6/9] qtest/bios-tables-test: Whitelist aarch64/virt 'its_off' variant blobs Date: Thu, 3 Apr 2025 22:40:26 +0200 Message-ID: <20250403204029.47958-7-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403204029.47958-1-philmd@linaro.org> References: <20250403204029.47958-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1743712901016019100 We are going to fix the test_acpi_aarch64_virt_tcg_its_off() test. In preparation, copy the ACPI tables which will be altered as 'its_off' variants, and whitelist them. Reviewed-by: Gustavo Romero Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ tests/qtest/bios-tables-test.c | 1 + tests/data/acpi/aarch64/virt/APIC.its_off | Bin 0 -> 184 bytes tests/data/acpi/aarch64/virt/FACP.its_off | Bin 0 -> 276 bytes tests/data/acpi/aarch64/virt/IORT.its_off | Bin 0 -> 236 bytes 5 files changed, 4 insertions(+) create mode 100644 tests/data/acpi/aarch64/virt/APIC.its_off create mode 100644 tests/data/acpi/aarch64/virt/FACP.its_off create mode 100644 tests/data/acpi/aarch64/virt/IORT.its_off diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios= -tables-test-allowed-diff.h index dfb8523c8bf..3421dd5adf3 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1 +1,4 @@ /* List of comma-separated changed AML files to ignore */ +"tests/data/acpi/aarch64/virt/APIC.its_off", +"tests/data/acpi/aarch64/virt/FACP.its_off", +"tests/data/acpi/aarch64/virt/IORT.its_off", diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index baaf199e01c..55366bf4956 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-test.c @@ -2151,6 +2151,7 @@ static void test_acpi_aarch64_virt_tcg_its_off(void) test_data data =3D { .machine =3D "virt", .arch =3D "aarch64", + .variant =3D ".its_off", .tcg_only =3D true, .uefi_fl1 =3D "pc-bios/edk2-aarch64-code.fd", .uefi_fl2 =3D "pc-bios/edk2-arm-vars.fd", diff --git a/tests/data/acpi/aarch64/virt/APIC.its_off b/tests/data/acpi/aa= rch64/virt/APIC.its_off new file mode 100644 index 0000000000000000000000000000000000000000..c37d05d6e05805304f10afe73eb= 7cb9100fcccfa GIT binary patch literal 184 zcmZ<^@O0k6z`($=3D+{xeBBUr&HBEVSz2pEB4AU24G0Uik$i-7~iVgWL^17JJ`2AFzr bgb+@aBn}xq0gwb2)Q)cq{30-g9B_L93G4|0 literal 0 HcmV?d00001 diff --git a/tests/data/acpi/aarch64/virt/FACP.its_off b/tests/data/acpi/aa= rch64/virt/FACP.its_off new file mode 100644 index 0000000000000000000000000000000000000000..606dac3fe4b55c31fd68b25d3a4= 127eeef227434 GIT binary patch literal 276 zcmZ>BbPf<TjFfcO#g+N#Zh@s|zoCF3AP#UU@ R!2`+%Dg6Hr$N|zYvjDIZ5CH%H literal 0 HcmV?d00001 --=20 2.47.1 From nobody Sun Nov 16 04:16:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1743713053; cv=none; d=zohomail.com; s=zohoarc; b=ehLbIY5QcIuHyUa1eo7aPG3xBbe8P0QIKKrC3Y5/FDgMGBSkivGC02PGX4qDc6nINvIEABvrwpleWD/KCW312e7sRRpOovAXknRayLqfo2gJnc1uBFRmjFnjsPzUd+rWQhDFrNPKzwlUi3Nw8eoSqY6rfNN8dNlu/nqIMtutUcc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743713053; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AzIe1y6exrD0xJczT8npcuq1OBfi7eudR1jNiJ2MiPM=; b=LQe6kgxqU1sWTg463W8VNV+mC+tZ9D/zD2d8Qoe5pNOX3DxrQii9RwgBdNUeUyTlaJb69qra0c/K5xqMwLSU+0llwTdDDfd53CUwkM8F2uDeTIea1Lm7NVZqGY+q+rf13GxxOvGHv+BmXwpmRNFQxzFmNpEJfDb7+1OortH1BTg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743713053197848.4484587903951; Thu, 3 Apr 2025 13:44:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RNI-0000bk-6n; Thu, 03 Apr 2025 16:41:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RNB-0000Wb-Qv for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:41:15 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RN9-00056D-Jm for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:41:13 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-43690d4605dso9486075e9.0 for ; Thu, 03 Apr 2025 13:41:10 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1630ddesm30923505e9.5.2025.04.03.13.41.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712869; x=1744317669; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AzIe1y6exrD0xJczT8npcuq1OBfi7eudR1jNiJ2MiPM=; b=s+rknz10+5TcCyvo2fbjrz69Orcn8pi/St4AhB4/J5pNxRdm323XiVwcAioaaCWMlp QoJ7B3M+zuo6NGX6Pt+Ry8MxCvlUV9onNHsEh4qZqNVmJhkEt1FCkTsXusFYbfo/LXRd nyUihKn5EeBDW3I6Zq4ToRMd9vD1hqfK6BJjYC5xTye0m+apuOupEgzpoddfxzyphHXj BEi5vm+UukArFt3p5hqJTAWt0CYruNoNlffuNA2+roiW6wrSzWlhE7HcdC0NlunLoHkV 2egl9LYZW19AtMEE+HutjnCaNS0VcniWtjXq77fqqwsF/X5YyiDY4fJcsxq7AkeZed8X vFVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712869; x=1744317669; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AzIe1y6exrD0xJczT8npcuq1OBfi7eudR1jNiJ2MiPM=; b=kOHnDW13cfsNsRkrVEXo41mH21Qgv2Y6Mt4ub4IfVptSk14ceoyw4ZY5H+ve5sB/Oz vbT0WGidq9Cu15ttD1+Qox4hRSGNYLaTKjgTudS6ECSze52SYfUItyERY/z21bzS40cV 5RzB7MdPpzj5zDOr7H6bwasma5FFDkVjnuLhvvTNB7Tc4w0VHFoSLHr6deOdzOJfZ/6D mR4GTeVEckU7gGWHkTSRldgwK1l/c2yJ8sCaNBDo2RyHY5C0zsNJ3ipn46HR59TCMEjZ 83g9A92880EIfyF4DpQL5anZdSBWD9zDNZMdT0ImBS+uI6ilb0+yJq60x/L/Q6Mdj+mR sn0w== X-Gm-Message-State: AOJu0Yy6+Mzvy8d28dRUqkWU1NvwQhFkNha1UAzFijTb9rFFIzOd+OBn K3+LDqeemTkI5SuRyXmby1wZyujluBqpAmBF7xr34az/dUR5GiHx/IbIDTryGzo4mAFKIx2e+Vv G X-Gm-Gg: ASbGnctAi3N57D3mLRNBANcu2OwLGMr/GcwgXMpwV3A0mSNY8BP3zu9ZPCXzo2P7J7s cN4cgZQJ5J95e1GQQhMd00lkLD16qknsscEVAwMvvuZrgHsPk/5WWW8C2KDgtQo8E8ANnkaonC2 wTGvfsdjU9vkPmrYli8HuLqaforVLGlpBRinVO5YepnWlmAOzNoD5Zyx3rjL1g2qxWcSQu0C48h BZ36/ECj05Z36O4+5l37jtDhjfoOGSUqPxpkPUfT0+zbqUjEBncJlbPxtTh73QGde4MxzCUNWc6 3Gijyky5QmGGZD2UluiAurMaspo7AkO13HNbI7rtY1xhEG+KdjJfrN46svP5XiTzzd/S9nQ4WTM jFfb6M6XLthzwt3MhJZC5zPn8 X-Google-Smtp-Source: AGHT+IGf6uH+7GL3enjPwL35FczmiuP3WQ9HgY23LIOqkXLkKIH/Lul8LuROoosf3k3pEiGcm8IRjQ== X-Received: by 2002:a05:6000:2509:b0:390:d6ab:6c49 with SMTP id ffacd0b85a97d-39cb35b1a8cmr571814f8f.35.1743712868622; Thu, 03 Apr 2025 13:41:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Andrew Jones , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Udo Steinberg , Shannon Zhao , Gustavo Romero , Igor Mammedov , Peter Maydell , Ani Sinha , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.1 v3 7/9] hw/arm/virt-acpi: Always build IORT table (even with GIC ITS disabled) Date: Thu, 3 Apr 2025 22:40:27 +0200 Message-ID: <20250403204029.47958-8-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403204029.47958-1-philmd@linaro.org> References: <20250403204029.47958-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1743713053975019000 Citing Gustavo [*]: Gating IORT table generation entirely based on the presence of ITS looks wrong because IORT table has data beyond GIC ITS, like for SMMUv3 etc.. [*] https://lore.kernel.org/qemu-devel/bae6e29a-7290-47d2-8caf-14702ee091f0= @linaro.org/ Reported-by: Gustavo Romero Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/virt-acpi-build.c | 38 +++++++++++++++++++++----------------- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 1c389ef5cdb..e7e27951cb9 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -287,6 +287,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) uint32_t id =3D 0; GArray *smmu_idmaps =3D g_array_new(false, true, sizeof(AcpiIortIdMapp= ing)); GArray *its_idmaps =3D g_array_new(false, true, sizeof(AcpiIortIdMappi= ng)); + bool has_its =3D its_enabled(vms); =20 AcpiTable table =3D { .sig =3D "IORT", .rev =3D 3, .oem_id =3D vms->oe= m_id, .oem_table_id =3D vms->oem_table_id }; @@ -325,9 +326,12 @@ build_iort(GArray *table_data, BIOSLinker *linker, Vir= tMachineState *vms) =20 nb_nodes =3D 3; /* RC, ITS, SMMUv3 */ rc_mapping_count =3D smmu_idmaps->len + its_idmaps->len; - } else { + } else if (has_its) { nb_nodes =3D 2; /* RC, ITS */ rc_mapping_count =3D 1; + } else { + nb_nodes =3D 1; /* RC */ + rc_mapping_count =3D 1; } /* Number of IORT Nodes */ build_append_int_noprefix(table_data, nb_nodes, 4); @@ -336,17 +340,19 @@ build_iort(GArray *table_data, BIOSLinker *linker, Vi= rtMachineState *vms) build_append_int_noprefix(table_data, IORT_NODE_OFFSET, 4); build_append_int_noprefix(table_data, 0, 4); /* Reserved */ =20 - /* Table 12 ITS Group Format */ - build_append_int_noprefix(table_data, 0 /* ITS Group */, 1); /* Type */ - node_size =3D 20 /* fixed header size */ + 4 /* 1 GIC ITS Identifier = */; - build_append_int_noprefix(table_data, node_size, 2); /* Length */ - build_append_int_noprefix(table_data, 1, 1); /* Revision */ - build_append_int_noprefix(table_data, id++, 4); /* Identifier */ - build_append_int_noprefix(table_data, 0, 4); /* Number of ID mappings = */ - build_append_int_noprefix(table_data, 0, 4); /* Reference to ID Array = */ - build_append_int_noprefix(table_data, 1, 4); /* Number of ITSs */ - /* GIC ITS Identifier Array */ - build_append_int_noprefix(table_data, 0 /* MADT translation_id */, 4); + if (has_its) { + /* Table 12 ITS Group Format */ + build_append_int_noprefix(table_data, 0 /* ITS Group */, 1); /* Ty= pe */ // + node_size =3D 20 /* fixed header size */ + 4 /* 1 GIC ITS Identif= ier */; + build_append_int_noprefix(table_data, node_size, 2); /* Length */ + build_append_int_noprefix(table_data, 1, 1); /* Revision */ + build_append_int_noprefix(table_data, id++, 4); /* Identifier */ + build_append_int_noprefix(table_data, 0, 4); /* Number of ID mappi= ngs */ + build_append_int_noprefix(table_data, 0, 4); /* Reference to ID Ar= ray */ + build_append_int_noprefix(table_data, 1, 4); /* Number of ITSs */ + /* GIC ITS Identifier Array */ + build_append_int_noprefix(table_data, 0 /* MADT translation_id */,= 4); + } =20 if (vms->iommu =3D=3D VIRT_IOMMU_SMMUV3) { int irq =3D vms->irqmap[VIRT_SMMU] + ARM_SPI_BASE; @@ -429,7 +435,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) build_iort_id_mapping(table_data, range->input_base, range->id_count, IORT_NODE_OFFSET); } - } else { + } else if (has_its) { /* output IORT node is the ITS group node (the first node) */ build_iort_id_mapping(table_data, 0, 0x10000, IORT_NODE_OFFSET); } @@ -979,10 +985,8 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildT= ables *tables) vms->oem_table_id); } =20 - if (its_enabled(vms)) { - acpi_add_table(table_offsets, tables_blob); - build_iort(tables_blob, tables->linker, vms); - } + acpi_add_table(table_offsets, tables_blob); + build_iort(tables_blob, tables->linker, vms); =20 #ifdef CONFIG_TPM if (tpm_get_version(tpm_find()) =3D=3D TPM_VERSION_2_0) { --=20 2.47.1 From nobody Sun Nov 16 04:16:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1743712901; cv=none; d=zohomail.com; s=zohoarc; b=hxKDQvsxY5YjWfgtM9WF7hNl86p0Oo2iuGUB3H6WE5s9NnNKp/HMDkCqzvEMsOtk+sHDxlETEpWG8h/uDZ1/BMNNohSAgMtY/dZtfdIfLgWvygDB56uBYvkRtVMi/dGF0BpFYLrgQ3dEuvkAl9ACIaJFe3g9Wh0HfVd+oWrtgQk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743712901; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Y1ud80T7n6XBN/Vt1w60MmBJZWVmW7lhw8QbR2LN0sI=; b=NtfZ56UpOVuNwtn9LRm8UCc0HSbMRsKO6Da3ZLVbuLZiMHdwQS/uopiRcLzAQxqr9Jv0TjbS9hCPrwoXWswOEkE+pWYsfM2Vpe3tj+/vqrnC1iHlbdb4LbRaplBmIT8vinUSyjWQ56XZzxOyigGtEpMFPkgScIIYnwrJ4yKCmpo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743712901854765.6371194643842; Thu, 3 Apr 2025 13:41:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RNU-0000p7-P2; Thu, 03 Apr 2025 16:41:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RNI-0000c5-6y for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:41:20 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RND-00057B-Kg for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:41:19 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-43cec5cd73bso7894005e9.3 for ; Thu, 03 Apr 2025 13:41:14 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34a7615sm27325625e9.9.2025.04.03.13.41.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712873; x=1744317673; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y1ud80T7n6XBN/Vt1w60MmBJZWVmW7lhw8QbR2LN0sI=; b=jVaWe86fgsmIvWn+/TpVJEMqk2sRsRSyTMw5iTrjf/RtTnQag3Rx2HLsf0RoUC7UDG u+K4oswtlyOl4AWsA5yEKMWJF1DXWnIrnA1S3rOK01qE4GTHW7bQ68l9lRDzpucdghRZ FPwZMCyf0L1NHH4mAW3p1asgRMMqNF4IB7HbR/GZwKqM27nC6++mNOb6lB7rsgIeXbX1 7XA62rmn24M4izH3FPFNyguGhS9xd27Z04JLHGPhqbu7I4ueMhM/W3Aze59eE1sWxwuj ekO1fQ2dy55mtObdmXhI0ymTNXfDF4mVGQBADzfOe/VjoWiL0TMeaTWG9n1F7aHXvdKh JkfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712873; x=1744317673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y1ud80T7n6XBN/Vt1w60MmBJZWVmW7lhw8QbR2LN0sI=; b=kgzQ+y3HxPMnCzpMuoAxuX6MyXPQeJPH2wvKzghuljyKHEm85Ri0zaTqzb225a0Uu6 RjWpRfS9JbklkDkv/4l2mBL7+xEfS3ej9YcLhrxXvUg5LKVTqFHyfUGnU+oBCSORq4MN nbJNdI3iYZ1pxTHGT7EboFArdYecbTEzubCG5T/rO5vgSUyN2m4w5qhh82tIwLMqpqd7 VCjNMFp9OyQ/buuITw4jZotQ92FlAHE0oHTfb/6sLEXr9UKFFv4qHwwTBmKItnq+nWhy a3/kiQ4Vi1nUtfAbQqbcnFVsGyyRNgsEQAbFV5OFj8mWQtBeiVdfPI52QIdqdPZpUFdd leiA== X-Gm-Message-State: AOJu0Yyqx6Mea6iA/PCn4gWQkRfvVKdgQLZso2z7bQhFKzYSU+vzC3K9 bEdXXrkZP3qtRQPaCnu/Ek1ggL2JLKC/pUl26P09o6doszF9L3Gg7J7yaZRj3agV2Y85vFj5tY4 U X-Gm-Gg: ASbGnctaX5C8UDqkFhS+SbkmW++ROvH9s3sJ9+F5wFCXwNb1V7P0foKPh+FTqStNJ1n aj+beHTjMHUnfP1t/0wRCOycIH1jEl/8PhZ9bMVU3y7p2BBj/nVhMai1FCJB5Js8qlI7BFuDaCB 2Xe7BT7X7fAb08gA28l9WurWfcGRHeZjcj9e6kN0QyylktoAeOpyTmoVvSU+kvSxfFtaVLZ/DxY xPS46C+/OJi1l/9x930qX154DChk0aTn8NyJyLg/bgbHcjouNHqlHFdwhJTEvmllR/Czw9qoswA MEwG2CYVsXv72oh+6R/Pl1K4izddMdlfkZlu8JmixrXXWL8JgQ8SanIu4Tatc4mKO5eccdUf9Q7 cJOdyIzi5f7o7C7oBpzDfmGyS X-Google-Smtp-Source: AGHT+IEU+UhUNAfd9zMk+eAeD58yweIdBZ4ugK4h46Ifvyvwj/FZT0/mzLLDu94w+ivy3mHLgSMRbA== X-Received: by 2002:a5d:6d8b:0:b0:391:ab2:9e71 with SMTP id ffacd0b85a97d-39cb35bd8bfmr546809f8f.20.1743712873478; Thu, 03 Apr 2025 13:41:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Andrew Jones , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Udo Steinberg , Shannon Zhao , Gustavo Romero , Igor Mammedov , Peter Maydell , Ani Sinha , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.1 v3 8/9] hw/arm/virt-acpi: Do not advertise disabled GIC ITS Date: Thu, 3 Apr 2025 22:40:28 +0200 Message-ID: <20250403204029.47958-9-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403204029.47958-1-philmd@linaro.org> References: <20250403204029.47958-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1743712903393019000 GIC ITS can be disabled at runtime using '-M its=3Doff', which sets VirtMachineState::its =3D false. Check this field to avoid advertising the ITS in the MADT table. Reported-by: Udo Steinberg Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2886 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Gustavo Romero --- hw/arm/virt-acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index e7e27951cb9..38a9e6fe0c5 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -212,7 +212,7 @@ static bool its_enabled(VirtMachineState *vms) { VirtMachineClass *vmc =3D VIRT_MACHINE_GET_CLASS(vms); =20 - return !vmc->no_its; + return !vmc->no_its && vms->its; } =20 /* --=20 2.47.1 From nobody Sun Nov 16 04:16:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1743712925; cv=none; d=zohomail.com; s=zohoarc; b=hdsV+ICOLW9pis7Z4BTv1bt0H2YHXnQTw9j9wQNfc7P3LOumqye7hDAmdhWo1Zku1vXtED15LXxjDH+s3iaux7vVa1Ec3T7wtH59clsf+oJc1GgfCeuI6dqR0aWKPtbNxkHxbRxlnMOKX9bXsnMX/z0o6FhInMhaGjAmshKWtgY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743712925; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5zTfaj2srAh7NFFgFGPtQA78JVUrBzadEZv8Wvdm4mc=; b=eFw1GFBYXF60iRkxeJ2etoAW3ZNz0ymDRu5QmDmNwnpMcIMnz6m8UlLNV9p71SzDwC9UiunXAYIPAZ4RDJs1Bzuw6axxFVO9eZvbSDU+TJZVT60HkUAsthcV81OTAkUuLvfjYklBKH+7E3zrY481TO+xiOEI1OXSCx8mAv2SW28= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743712925293650.7394287749642; Thu, 3 Apr 2025 13:42:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RNe-00019u-LU; Thu, 03 Apr 2025 16:41:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RNN-0000l2-Hs for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:41:26 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RNJ-00057s-It for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:41:25 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4394a823036so12622565e9.0 for ; Thu, 03 Apr 2025 13:41:20 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020da49sm2607411f8f.80.2025.04.03.13.41.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712878; x=1744317678; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5zTfaj2srAh7NFFgFGPtQA78JVUrBzadEZv8Wvdm4mc=; b=TXt9LFRGbGxgBClC+uv3hENfIYeDDZ26AawUl4vSdnxEWjjl/ujvjFXZwO9n6ewiTF c0P1S2jr8hCmzqm1pIPA+4raBn+a3mwuZ4GXYUG7SNKzQfcTnMv7UFBCjQYSw4r4fmVS Qp90k2oZLNQzhQzeSBs/qVQEyotOIX5hCgGhb6IuhFI+lADTK5LxMI+RC9KFZe+F1r+8 G0Bekph6bkSNvXuW7ZaGvfCR4xmW1Wd53a2cRtdhHNGpwHwVvWZTvWIICu0w/gyshcK3 kPou/jxC+JXmEd64+hoy2O6RaUQ2pE93204ikhjXwW08yS32aVYbxwLUc2T2s+M9iv/a MiYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712878; x=1744317678; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5zTfaj2srAh7NFFgFGPtQA78JVUrBzadEZv8Wvdm4mc=; b=bRnNq8XqYwn8QjfxdUyVpJCprDnNVozXyo8WZyXl4EqLvPiH5QFrCGtc6cHRQkhKgZ kxOSWwCXGCpMqrpZa70HEQHDg3yZO5Oyp26C6eTlHHQkbQkdEcwxspbympIjfkXFnP6/ JGuTmUT72ghxpc7eVPUmoqVn0t/3RLlm1FBCJEk93ABDeqK/3rP+4LMJLXJWSRNTffYp s56jHNefCIbjYaVpKjPw4cBAeFmVwUvpB0JlD5wEB6vKYbah82I5HTWPOFIMHtHh8q/j drt+Uih0QszqwayceyGe3mo3KRMa+drpOlFBgJFqK/Wq+0Fl5sgzMePT/cMlE2lzVXLj SZ3A== X-Gm-Message-State: AOJu0YzWkmSLHEd6TBX5qPKyViDOPeMHD0XTk+OpjHHGgBJVQRd34W7h MRznqxlQe+DQpy1L9hcqvc98qm3Sj0SO0eBTMfKo272YBkcfQYeDcKjU6MbROa8F2buO5ndxKeF M X-Gm-Gg: ASbGncu01A8yTfKDDTDhFYMQcRGX2XBbC+Okspkv7DiBHVsWjueKwjb7LO4qXEDtYp3 LHp3W1qgR5ui6HQRcXfH40mnKjRhGRZWUKuLEUh9mfB4V9PbfLHk5MjKl5cxxDAEQTgnDW2pSLh iMrHQeIu5IZomj4Bihdga3gflWP9fF4jz9ZUqSFPUTlIuoO42RUlqJc46/7lxrN3asTIjlnxyGX lRfeOBqNocnt8mIxOE1VqoaQjgz2FM9n88xcqJOOuCwct078sBMfgBBhWsj7J6PU5uDbCiZpqaW OcFPuI9eIoF3Lt8YJbW1JFxjRyWtdzfJI3zAO05ixNU3zQm9ZEYAawnXAyUn1psdzkvI65Qjers U2levY3JmfuSlsf1JVTU7uATH X-Google-Smtp-Source: AGHT+IEYg7yqGL0lozy9IwxV5DIzu2vdi8h1OGoNyGieuji3bi43ZtlFeratq+5HGp/bvCBx8lgV4Q== X-Received: by 2002:a05:600c:5011:b0:43d:fa:1f9a with SMTP id 5b1f17b1804b1-43ecfa06fe8mr5687125e9.30.1743712878359; Thu, 03 Apr 2025 13:41:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Andrew Jones , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Udo Steinberg , Shannon Zhao , Gustavo Romero , Igor Mammedov , Peter Maydell , Ani Sinha , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.1 v3 9/9] qtest/bios-tables-test: Update aarch64/virt 'its_off' variant blobs Date: Thu, 3 Apr 2025 22:40:29 +0200 Message-ID: <20250403204029.47958-10-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403204029.47958-1-philmd@linaro.org> References: <20250403204029.47958-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1743712925644019000 Commit the blobs generated by tests/data/acpi/rebuild-expected-aml.sh. Changes in the tables: @@ -1,32 +1,32 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20240927 (64-bit version) * Copyright (c) 2000 - 2023 Intel Corporation * * Disassembly of tests/data/acpi/aarch64/virt/APIC.its_off * * ACPI Data Table [APIC] * * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue = (in hex) */ [000h 0000 004h] Signature : "APIC" [Multiple APIC = Description Table (MADT)] -[004h 0004 004h] Table Length : 000000B8 +[004h 0004 004h] Table Length : 000000A4 [008h 0008 001h] Revision : 04 -[009h 0009 001h] Checksum : A7 +[009h 0009 001h] Checksum : EE [00Ah 0010 006h] Oem ID : "BOCHS " [010h 0016 008h] Oem Table ID : "BXPC " [018h 0024 004h] Oem Revision : 00000001 [01Ch 0028 004h] Asl Compiler ID : "BXPC" [020h 0032 004h] Asl Compiler Revision : 00000001 [024h 0036 004h] Local Apic Address : 00000000 [028h 0040 004h] Flags (decoded below) : 00000000 PC-AT Compatibility : 0 [02Ch 0044 001h] Subtable Type : 0C [Generic Interrupt Dis= tributor] [02Dh 0045 001h] Length : 18 [02Eh 0046 002h] Reserved : 0000 [030h 0048 004h] Local GIC Hardware ID : 00000000 [034h 0052 008h] Base Address : 0000000008000000 [03Ch 0060 004h] Interrupt Base : 00000000 @@ -49,37 +49,29 @@ [06Ch 0108 008h] Virtual GIC Base Address : 0000000000000000 [074h 0116 008h] Hypervisor GIC Base Address : 0000000000000000 [07Ch 0124 004h] Virtual GIC Interrupt : 00000019 [080h 0128 008h] Redistributor Base Address : 0000000000000000 [088h 0136 008h] ARM MPIDR : 0000000000000000 [090h 0144 001h] Efficiency Class : 00 [091h 0145 001h] Reserved : 00 [092h 0146 002h] SPE Overflow Interrupt : 0000 [094h 0148 002h] TRBE Interrupt : 100E [094h 0148 001h] Subtable Type : 0E [Generic Interrupt Red= istributor] [095h 0149 001h] Length : 10 [097h 0151 002h] Reserved : 0000 [098h 0152 008h] Base Address : 00000000080A0000 [0A0h 0160 004h] Length : 00F60000 -[0A4h 0164 001h] Subtable Type : 0F [Generic Interrupt Tra= nslator] -[0A5h 0165 001h] Length : 14 -[0A7h 0167 002h] Reserved : 0000 -[0A8h 0168 004h] Translation ID : 00000000 -[0ACh 0172 008h] Base Address : 0000000008080000 -[0B4h 0180 004h] Reserved : 00000000 +Raw Table Data: Length 164 (0xA4) -Raw Table Data: Length 184 (0xB8) - - 0000: 41 50 49 43 B8 00 00 00 04 A7 42 4F 43 48 53 20 // APIC......= BOCHS + 0000: 41 50 49 43 A4 00 00 00 04 EE 42 4F 43 48 53 20 // APIC......= BOCHS 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ..= ..BXPC 0020: 01 00 00 00 00 00 00 00 00 00 00 00 0C 18 00 00 // ..........= ...... 0030: 00 00 00 00 00 00 00 08 00 00 00 00 00 00 00 00 // ..........= ...... 0040: 04 00 00 00 0B 50 00 00 00 00 00 00 00 00 00 00 // .....P....= ...... 0050: 01 00 00 00 00 00 00 00 17 00 00 00 00 00 00 00 // ..........= ...... 0060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 0070: 00 00 00 00 00 00 00 00 00 00 00 00 19 00 00 00 // ..........= ...... 0080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 0090: 00 00 00 00 0E 10 00 00 00 00 0A 08 00 00 00 00 // ..........= ...... - 00A0: 00 00 F6 00 0F 14 00 00 00 00 00 00 00 00 08 08 // ..........= ...... - 00B0: 00 00 00 00 00 00 00 00 // ........ + 00A0: 00 00 F6 00 // .... /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20240927 (64-bit version) * Copyright (c) 2000 - 2023 Intel Corporation * * Disassembly of tests/data/acpi/aarch64/virt/FACP * * ACPI Data Table [FACP] * * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue = (in hex) */ [000h 0000 004h] Signature : "FACP" [Fixed ACPI Des= cription Table (FADT)] [004h 0004 004h] Table Length : 00000114 [008h 0008 001h] Revision : 06 -[009h 0009 001h] Checksum : 12 +[009h 0009 001h] Checksum : 14 [00Ah 0010 006h] Oem ID : "BOCHS " [010h 0016 008h] Oem Table ID : "BXPC " [018h 0024 004h] Oem Revision : 00000001 [01Ch 0028 004h] Asl Compiler ID : "BXPC" [020h 0032 004h] Asl Compiler Revision : 00000001 [024h 0036 004h] FACS Address : 00000000 [028h 0040 004h] DSDT Address : 00000000 [02Ch 0044 001h] Model : 00 [02Dh 0045 001h] PM Profile : 00 [Unspecified] [02Eh 0046 002h] SCI Interrupt : 0000 [030h 0048 004h] SMI Command Port : 00000000 [034h 0052 001h] ACPI Enable Value : 00 [035h 0053 001h] ACPI Disable Value : 00 [036h 0054 001h] S4BIOS Command : 00 [037h 0055 001h] P-State Control : 00 @@ -82,35 +82,35 @@ Use Platform Timer (V4) : 0 RTC_STS valid on S4 wake (V4) : 0 Remote Power-on capable (V4) : 0 Use APIC Cluster Model (V4) : 0 Use APIC Physical Destination Mode (V4) : 0 Hardware Reduced (V5) : 1 Low Power S0 Idle (V5) : 0 [074h 0116 00Ch] Reset Register : [Generic Address Structur= e] [074h 0116 001h] Space ID : 00 [SystemMemory] [075h 0117 001h] Bit Width : 00 [076h 0118 001h] Bit Offset : 00 [077h 0119 001h] Encoded Access Width : 00 [Undefined/Legacy] [078h 0120 008h] Address : 0000000000000000 [080h 0128 001h] Value to cause reset : 00 -[081h 0129 002h] ARM Flags (decoded below) : 0003 +[081h 0129 002h] ARM Flags (decoded below) : 0001 PSCI Compliant : 1 - Must use HVC for PSCI : 1 + Must use HVC for PSCI : 0 [083h 0131 001h] FADT Minor Revision : 03 [084h 0132 008h] FACS Address : 0000000000000000 [08Ch 0140 008h] DSDT Address : 0000000000000000 [094h 0148 00Ch] PM1A Event Block : [Generic Address Structur= e] [094h 0148 001h] Space ID : 00 [SystemMemory] [095h 0149 001h] Bit Width : 00 [096h 0150 001h] Bit Offset : 00 [097h 0151 001h] Encoded Access Width : 00 [Undefined/Legacy] [098h 0152 008h] Address : 0000000000000000 [0A0h 0160 00Ch] PM1B Event Block : [Generic Address Structur= e] [0A0h 0160 001h] Space ID : 00 [SystemMemory] [0A1h 0161 001h] Bit Width : 00 [0A2h 0162 001h] Bit Offset : 00 [0A3h 0163 001h] Encoded Access Width : 00 [Undefined/Legacy] @@ -164,34 +164,34 @@ [0F5h 0245 001h] Bit Width : 00 [0F6h 0246 001h] Bit Offset : 00 [0F7h 0247 001h] Encoded Access Width : 00 [Undefined/Legacy] [0F8h 0248 008h] Address : 0000000000000000 [100h 0256 00Ch] Sleep Status Register : [Generic Address Structur= e] [100h 0256 001h] Space ID : 00 [SystemMemory] [101h 0257 001h] Bit Width : 00 [102h 0258 001h] Bit Offset : 00 [103h 0259 001h] Encoded Access Width : 00 [Undefined/Legacy] [104h 0260 008h] Address : 0000000000000000 [10Ch 0268 008h] Hypervisor ID : 00000000554D4551 Raw Table Data: Length 276 (0x114) - 0000: 46 41 43 50 14 01 00 00 06 12 42 4F 43 48 53 20 // FACP......= BOCHS + 0000: 46 41 43 50 14 01 00 00 06 14 42 4F 43 48 53 20 // FACP......= BOCHS 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ..= ..BXPC 0020: 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 0040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 0050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 0060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 0070: 00 00 10 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... - 0080: 00 03 00 03 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... + 0080: 00 01 00 03 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 0090: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 00A0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 00B0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 00C0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 00D0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 00E0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 00F0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... 0100: 00 00 00 00 00 00 00 00 00 00 00 00 51 45 4D 55 // ..........= ..QEMU 0110: 00 00 00 00 // .... @@ -1,122 +1,111 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20240927 (64-bit version) * Copyright (c) 2000 - 2023 Intel Corporation * * Disassembly of tests/data/acpi/aarch64/virt/IORT.its_off * * ACPI Data Table [IORT] * * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue = (in hex) */ [000h 0000 004h] Signature : "IORT" [IO Remapping T= able] -[004h 0004 004h] Table Length : 000000EC +[004h 0004 004h] Table Length : 000000D4 [008h 0008 001h] Revision : 03 -[009h 0009 001h] Checksum : 57 +[009h 0009 001h] Checksum : A3 [00Ah 0010 006h] Oem ID : "BOCHS " [010h 0016 008h] Oem Table ID : "BXPC " [018h 0024 004h] Oem Revision : 00000001 [01Ch 0028 004h] Asl Compiler ID : "BXPC" [020h 0032 004h] Asl Compiler Revision : 00000001 [024h 0036 004h] Node Count : 00000003 [028h 0040 004h] Node Offset : 00000030 [02Ch 0044 004h] Reserved : 00000000 -[030h 0048 001h] Type : 00 -[031h 0049 002h] Length : 0018 -[033h 0051 001h] Revision : 01 +[030h 0048 001h] Type : 04 +[031h 0049 002h] Length : 0058 +[033h 0051 001h] Revision : 04 [034h 0052 004h] Identifier : 00000000 -[038h 0056 004h] Mapping Count : 00000000 -[03Ch 0060 004h] Mapping Offset : 00000000 +[038h 0056 004h] Mapping Count : 00000001 +[03Ch 0060 004h] Mapping Offset : 00000044 -[040h 0064 004h] ItsCount : 00000001 -[044h 0068 004h] Identifiers : 00000000 - -[048h 0072 001h] Type : 04 -[049h 0073 002h] Length : 0058 -[04Bh 0075 001h] Revision : 04 -[04Ch 0076 004h] Identifier : 00000001 -[050h 0080 004h] Mapping Count : 00000001 -[054h 0084 004h] Mapping Offset : 00000044 - -[058h 0088 008h] Base Address : 0000000009050000 -[060h 0096 004h] Flags (decoded below) : 00000001 +[040h 0064 008h] Base Address : 0000000009050000 +[048h 0072 004h] Flags (decoded below) : 00000001 COHACC Override : 1 HTTU Override : 0 Proximity Domain Valid : 0 DeviceID Valid : 0 -[064h 0100 004h] Reserved : 00000000 -[068h 0104 008h] VATOS Address : 0000000000000000 -[070h 0112 004h] Model : 00000000 -[074h 0116 004h] Event GSIV : 0000006A -[078h 0120 004h] PRI GSIV : 0000006B -[07Ch 0124 004h] GERR GSIV : 0000006D -[080h 0128 004h] Sync GSIV : 0000006C -[084h 0132 004h] Proximity Domain : 00000000 -[088h 0136 004h] Device ID Mapping Index : 00000000 +[04Ch 0076 004h] Reserved : 00000000 +[050h 0080 008h] VATOS Address : 0000000000000000 +[058h 0088 004h] Model : 00000000 +[05Ch 0092 004h] Event GSIV : 0000006A +[060h 0096 004h] PRI GSIV : 0000006B +[064h 0100 004h] GERR GSIV : 0000006D +[068h 0104 004h] Sync GSIV : 0000006C +[06Ch 0108 004h] Proximity Domain : 00000000 +[070h 0112 004h] Device ID Mapping Index : 00000000 -[08Ch 0140 004h] Input base : 00000000 -[090h 0144 004h] ID Count : 0000FFFF -[094h 0148 004h] Output Base : 00000000 -[098h 0152 004h] Output Reference : 00000030 -[09Ch 0156 004h] Flags (decoded below) : 00000000 +[074h 0116 004h] Input base : 00000000 +[078h 0120 004h] ID Count : 0000FFFF +[07Ch 0124 004h] Output Base : 00000000 +[080h 0128 004h] Output Reference : 00000030 +[084h 0132 004h] Flags (decoded below) : 00000000 Single Mapping : 0 -[0A0h 0160 001h] Type : 02 -[0A1h 0161 002h] Length : 004C -[0A3h 0163 001h] Revision : 03 -[0A4h 0164 004h] Identifier : 00000002 -[0A8h 0168 004h] Mapping Count : 00000002 -[0ACh 0172 004h] Mapping Offset : 00000024 +[088h 0136 001h] Type : 02 +[089h 0137 002h] Length : 004C +[08Bh 0139 001h] Revision : 03 +[08Ch 0140 004h] Identifier : 00000001 +[090h 0144 004h] Mapping Count : 00000002 +[094h 0148 004h] Mapping Offset : 00000024 -[0B0h 0176 008h] Memory Properties : [IORT Memory Access Prope= rties] -[0B0h 0176 004h] Cache Coherency : 00000001 -[0B4h 0180 001h] Hints (decoded below) : 00 +[098h 0152 008h] Memory Properties : [IORT Memory Access Prope= rties] +[098h 0152 004h] Cache Coherency : 00000001 +[09Ch 0156 001h] Hints (decoded below) : 00 Transient : 0 Write Allocate : 0 Read Allocate : 0 Override : 0 -[0B5h 0181 002h] Reserved : 0000 -[0B7h 0183 001h] Memory Flags (decoded below) : 03 +[09Dh 0157 002h] Reserved : 0000 +[09Fh 0159 001h] Memory Flags (decoded below) : 03 Coherency : 1 Device Attribute : 1 Ensured Coherency of Accesses : 0 -[0B8h 0184 004h] ATS Attribute : 00000000 -[0BCh 0188 004h] PCI Segment Number : 00000000 -[0C0h 0192 001h] Memory Size Limit : 40 -[0C1h 0193 002h] PASID Capabilities : 0000 -[0C3h 0195 001h] Reserved : 00 +[0A0h 0160 004h] ATS Attribute : 00000000 +[0A4h 0164 004h] PCI Segment Number : 00000000 +[0A8h 0168 001h] Memory Size Limit : 40 +[0A9h 0169 002h] PASID Capabilities : 0000 +[0ABh 0171 001h] Reserved : 00 -[0C4h 0196 004h] Input base : 00000000 -[0C8h 0200 004h] ID Count : 000000FF -[0CCh 0204 004h] Output Base : 00000000 -[0D0h 0208 004h] Output Reference : 00000048 -[0D4h 0212 004h] Flags (decoded below) : 00000000 +[0ACh 0172 004h] Input base : 00000000 +[0B0h 0176 004h] ID Count : 000000FF +[0B4h 0180 004h] Output Base : 00000000 +[0B8h 0184 004h] Output Reference : 00000030 +[0BCh 0188 004h] Flags (decoded below) : 00000000 Single Mapping : 0 -[0D8h 0216 004h] Input base : 00000100 -[0DCh 0220 004h] ID Count : 0000FEFF -[0E0h 0224 004h] Output Base : 00000100 -[0E4h 0228 004h] Output Reference : 00000030 -[0E8h 0232 004h] Flags (decoded below) : 00000000 +[0C0h 0192 004h] Input base : 00000100 +[0C4h 0196 004h] ID Count : 0000FEFF +[0C8h 0200 004h] Output Base : 00000100 +[0CCh 0204 004h] Output Reference : 00000030 +[0D0h 0208 004h] Flags (decoded below) : 00000000 Single Mapping : 0 -Raw Table Data: Length 236 (0xEC) +Raw Table Data: Length 212 (0xD4) - 0000: 49 4F 52 54 EC 00 00 00 03 57 42 4F 43 48 53 20 // IORT.....W= BOCHS + 0000: 49 4F 52 54 D4 00 00 00 03 A3 42 4F 43 48 53 20 // IORT......= BOCHS 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ..= ..BXPC 0020: 01 00 00 00 03 00 00 00 30 00 00 00 00 00 00 00 // ........0.= ...... - 0030: 00 18 00 01 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... - 0040: 01 00 00 00 00 00 00 00 04 58 00 04 01 00 00 00 // .........X= ...... - 0050: 01 00 00 00 44 00 00 00 00 00 05 09 00 00 00 00 // ....D.....= ...... - 0060: 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ..........= ...... - 0070: 00 00 00 00 6A 00 00 00 6B 00 00 00 6D 00 00 00 // ....j...k.= ..m... - 0080: 6C 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // l.........= ...... - 0090: FF FF 00 00 00 00 00 00 30 00 00 00 00 00 00 00 // ........0.= ...... - 00A0: 02 4C 00 03 02 00 00 00 02 00 00 00 24 00 00 00 // .L........= ..$... - 00B0: 01 00 00 00 00 00 00 03 00 00 00 00 00 00 00 00 // ..........= ...... - 00C0: 40 00 00 00 00 00 00 00 FF 00 00 00 00 00 00 00 // @.........= ...... - 00D0: 48 00 00 00 00 00 00 00 00 01 00 00 FF FE 00 00 // H.........= ...... - 00E0: 00 01 00 00 30 00 00 00 00 00 00 00 // ....0.....= .. + 0030: 04 58 00 04 00 00 00 00 01 00 00 00 44 00 00 00 // .X........= ..D... + 0040: 00 00 05 09 00 00 00 00 01 00 00 00 00 00 00 00 // ..........= ...... + 0050: 00 00 00 00 00 00 00 00 00 00 00 00 6A 00 00 00 // ..........= ..j... + 0060: 6B 00 00 00 6D 00 00 00 6C 00 00 00 00 00 00 00 // k...m...l.= ...... + 0070: 00 00 00 00 00 00 00 00 FF FF 00 00 00 00 00 00 // ..........= ...... + 0080: 30 00 00 00 00 00 00 00 02 4C 00 03 01 00 00 00 // 0........L= ...... + 0090: 02 00 00 00 24 00 00 00 01 00 00 00 00 00 00 03 // ....$.....= ...... + 00A0: 00 00 00 00 00 00 00 00 40 00 00 00 00 00 00 00 // ........@.= ...... + 00B0: FF 00 00 00 00 00 00 00 30 00 00 00 00 00 00 00 // ........0.= ...... + 00C0: 00 01 00 00 FF FE 00 00 00 01 00 00 30 00 00 00 // ..........= ..0... + 00D0: 00 00 00 00 // .... Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/bios-tables-test-allowed-diff.h | 3 --- tests/data/acpi/aarch64/virt/APIC.its_off | Bin 184 -> 164 bytes tests/data/acpi/aarch64/virt/IORT.its_off | Bin 236 -> 212 bytes 3 files changed, 3 deletions(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios= -tables-test-allowed-diff.h index 3421dd5adf3..dfb8523c8bf 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1,4 +1 @@ /* List of comma-separated changed AML files to ignore */ -"tests/data/acpi/aarch64/virt/APIC.its_off", -"tests/data/acpi/aarch64/virt/FACP.its_off", -"tests/data/acpi/aarch64/virt/IORT.its_off", diff --git a/tests/data/acpi/aarch64/virt/APIC.its_off b/tests/data/acpi/aa= rch64/virt/APIC.its_off index c37d05d6e05805304f10afe73eb7cb9100fcccfa..f24ac8fbff5261a52434abcfcff= 96dbdc7709de4 100644 GIT binary patch delta 18 ZcmdnNxP+0*F~HM#2?GNI%e#qOvj8xy1yKM1 delta 39 jcmZ3&xPy_)F~HM#2Ll5G%kqg_vqbnsfJ`vp;DE6Jpmzmj diff --git a/tests/data/acpi/aarch64/virt/IORT.its_off b/tests/data/acpi/aa= rch64/virt/IORT.its_off index 0fceb820d509e852ca0849baf568a8e93e426738..25f64407c4aac11bda2d1ac24cd= 8999a1d84c80d 100644 GIT binary patch delta 37 tcmaFEc!iP6(?2NW3IhWJ^WuqIYOE{~3@i*2eZv_UCoa`yG?;i%8UVn-3Gn~` delta 61 zcmcb@_=3Db_o(?2NW4FdxMbNECqHCYA;21XzU4qzOX2nH6$iKgL