From nobody Sun Nov 16 04:12:32 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1743537312; cv=none; d=zohomail.com; s=zohoarc; b=YGGoMIx7pz+lHXsjbEqtSQL1VEbZxdxk1Ol1MP6yU0pdkJ8fUJW2uwbOi2KUCpGo60PAfVsRHcxjdmMxtTuXHed7IoEMyuJYjEmltEw1tiW7ISOZG/8kbiSbPRbzc0oeLn1LPpKrgx5ofWB4szPjTVbONznff6yvonoQpZQ5SvU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743537312; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sZRpxeZp7MCAQlerfbPOpSzYPqrrNrQzZz6Uo8WLPWs=; b=if8o5fHZurHWQYrkMJKHRdE0haAU4SoVLiShd93t/T++/nYL54ubX6FWEVlkucZP8H8wZwBl+jIEq9XOvtMODvcQlhAJcsiFRKTphwkcSYZUJ+hJkWrFtN7x5vMnp9rggOSvWos1cIZzVk60d0dH1PsEUBQOizXEBh1Ke/dM8nI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743537312755628.8489337528513; Tue, 1 Apr 2025 12:55:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tzhge-00024K-Rf; Tue, 01 Apr 2025 15:54:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tzhgW-00023p-DI for qemu-devel@nongnu.org; Tue, 01 Apr 2025 15:54:08 -0400 Received: from smtp-out2.suse.de ([195.135.223.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tzhgT-0004Ib-Ho for qemu-devel@nongnu.org; Tue, 01 Apr 2025 15:54:07 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D83661F445; Tue, 1 Apr 2025 19:53:59 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F4059138A5; Tue, 1 Apr 2025 19:53:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MJ/rK1VE7GdNSAAAD6G6ig (envelope-from ); Tue, 01 Apr 2025 19:53:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743537240; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sZRpxeZp7MCAQlerfbPOpSzYPqrrNrQzZz6Uo8WLPWs=; b=ZpIKMQKfeyOsxksEAADAn5+w5x+9DFG0RAIp9gesHJtGRpnj/1IUY/LH8WUMmuvJGtMGF4 uOsEQHx6FK27v52YQAUild259LTM4lXgxKT5MAjcy1HChd0JtJTKS8tMASjukFbepq+PsQ h7ZQaeCdZtgRAKmtKhlJ6aUVRSuNb4Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743537240; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sZRpxeZp7MCAQlerfbPOpSzYPqrrNrQzZz6Uo8WLPWs=; b=xW1VMrzAvAr75kAPa4ZKHrJG73ekA8b1DjxXTItzSi76ZgZ/lEN9qIFGvXZ8zq1YXc3yOO vV47etiZwU+JJcCg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743537239; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sZRpxeZp7MCAQlerfbPOpSzYPqrrNrQzZz6Uo8WLPWs=; b=UIzCURRWGTOtdneXYVntIMQGh0UYVlFCAlpfgYFN9PNwuff7jE1bjSCRYucybSxr6RUs7m kL0BoB1XZrfz3FNc1/PM7Y6Om8tMb8H51tMnu3q9+RPyypRslMRQ03SrPf++U2EajBj17g oRN/3sKf3KvTU8vk23ma8rKE7zdyoUQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743537239; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sZRpxeZp7MCAQlerfbPOpSzYPqrrNrQzZz6Uo8WLPWs=; b=dFuuJiBW33Tb3mcadTClIiaoZewIH11d/qV4mMfRTuLdv3H7ZBB6Tskuz2ckcqPK2V3wMG e6ln84Yw1vZ3XsAA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Xu , Marco Cavenati , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Michael Tokarev Subject: [PULL 1/1] migration: fix SEEK_CUR offset calculation in qio_channel_block_seek Date: Tue, 1 Apr 2025 16:53:53 -0300 Message-Id: <20250401195353.803-2-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20250401195353.803-1-farosas@suse.de> References: <20250401195353.803-1-farosas@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_FIVE(0.00)[5]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:email, suse.de:mid] X-Spam-Score: -3.30 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.223.131; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) (identity @suse.de) X-ZM-MESSAGEID: 1743537315465019000 From: Marco Cavenati The SEEK_CUR case in qio_channel_block_seek was incorrectly using the 'whence' parameter instead of the 'offset' parameter when calculating the new position. Fixes: 65cf200a51 ("migration: introduce a QIOChannel impl for BlockDriverS= tate VMState") Signed-off-by: Marco Cavenati Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michael Tokarev Message-ID: <20250326162230.3323199-1-Marco.Cavenati@eurecom.fr> Signed-off-by: Fabiano Rosas --- migration/channel-block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/channel-block.c b/migration/channel-block.c index fff8d87094..b0477f5b6d 100644 --- a/migration/channel-block.c +++ b/migration/channel-block.c @@ -123,7 +123,7 @@ qio_channel_block_seek(QIOChannel *ioc, bioc->offset =3D offset; break; case SEEK_CUR: - bioc->offset +=3D whence; + bioc->offset +=3D offset; break; case SEEK_END: error_setg(errp, "Size of VMstate region is unknown"); --=20 2.35.3