From nobody Sun Nov 16 04:05:48 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1743462333; cv=none; d=zohomail.com; s=zohoarc; b=MFzgiNRmbJtfI1P7phKRW0GEJFgi6f3/CZerqoZoMPdnplx5wbW08oA78hxSQVPfQNVMjzwihMeScwCz0lZ8b8LT36f9saEEcbO298qjwxzrSzn/L8PjFqsi8rkVajRXLcoFsjxhkSmD/cdO30A1TqIvBwKN43Li09PrcMa3dxM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743462333; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BIwoF+GPbpxMD6AIqgIwHFGJjyw7iyBvkQD2QC7CyfI=; b=ltQIwPztbTjFGzULqPj/+eAZfIzSE+NcKNB675T6vlq4HPjrto3+p7ErSqFYRmEMZAoPPqPE/Zt3imGWUVXlZlD57Bgp19txx1pA4rduGIt3tv4cNDp7sYbv8Sl4hkmUuTLKaNqMLo5H/f1mwcBP39ODqcqnbqKopCh91/kztgQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743462333231824.4474255784005; Mon, 31 Mar 2025 16:05:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tzOBd-0006kt-91; Mon, 31 Mar 2025 19:04:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tzOBb-0006kb-IQ for qemu-devel@nongnu.org; Mon, 31 Mar 2025 19:04:55 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tzOBZ-0005lK-Qy for qemu-devel@nongnu.org; Mon, 31 Mar 2025 19:04:55 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so50200995e9.2 for ; Mon, 31 Mar 2025 16:04:53 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d82dede2csm178484285e9.5.2025.03.31.16.04.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 31 Mar 2025 16:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743462292; x=1744067092; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BIwoF+GPbpxMD6AIqgIwHFGJjyw7iyBvkQD2QC7CyfI=; b=hbFLxMK6yVuDK7+IhMqnG9IjMNLMGb47o/7nkjnlBOnOsfjA0ZVHjZIzJ1fMP0n7Tx JygYtJpEFcIevNcfhjyIcVZyQ1WAz0EEue80Id3lHXLshKqyhpa+g5KVybZg3m+K7ln/ 3TGjEvxA2oynSNsUxObv93+w84WpGBiD8yxbY9dsT9GRSapRPD0iWdILBAV0hfGFTSZ1 DAlqLTjZTDzO0VfPQt9BWc4/SloBNoI+PUVxUNx1wvI4sxF9XOGHOxcvBewJRz+P5S8B QHzB9NOz4Z5v5bSuTExLq4eySGF8aOsLYkrjtpGIqAwcUSeCJuZWNCOwUr2uW3mcczIs i7cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743462292; x=1744067092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BIwoF+GPbpxMD6AIqgIwHFGJjyw7iyBvkQD2QC7CyfI=; b=u499BnaywMFBjK558OuX0e8equKjWRkPEZfQCoDASyDp0YIZgTN9fbJRsoHoUflw3l 4Buw8N62Ko1+oCA8ES9k3VcsF27n6vKP4HHfGALJqD0aFSbVo4MXtbhI6a19e+CWfqfk rJL+YuOrI7AaSVMgYEg6XaSTaa+PEo0uPUKTOtYh6IquKOPCU1rRVURB6GnHd7SLScd6 PR4ix985Q2bbUapLnOKQNlWG6kaV9rXeKs/gfFfoDZeXJUQEbiG7ElPxVXNhmCRlhNGG ukgCT5IQGvxgUa8Fd8sV9gVkAv7J58P8LFUtZmFyyiIhA1koEddoik7letp9xAGr4k4L FlwA== X-Gm-Message-State: AOJu0YyreJd3EBgaxzXKVgeA/YqJXrk71y/tSRjNtCfZay1PE1nI35Jy hetBiwHT0GoEVW6Yi9LpZgxbejg+BSgANMv1Uqz1YqbMaS0SUHp3GnAZ9pwCgeTOVkgImJSGFEg v X-Gm-Gg: ASbGncuhdI3J8Cp3lLtDQ6bbeRuV2lepczz302xTPxBJhZaiUdvGYTEGmuu0nI5pELp O7zsRE+eDWsMzrDOTNmt6CYJllua2S5mZ5ARqRq1XgOv7aBVTrRDBZwlzsJQCHz9viCtA5xR7N4 YO+PRCCT0BU48tEwio6AvoK8FmWmYvSW2UQYU55qF6MP1+SDTE1IzTxIKKWFqLXNcbRxu7+FyuW KXOkOr1TklFQOdwMlJ9oNbpjVbcTEIIKAOxe3Qg2Sm9bqdaDJVKTKP3uDa3GNvCVX2wYXEWmVOG ku9AAUVA1oS2AQtEnKAyhdWw9YBIUDMc/Y5zwLX84fldbqoQXucp+1elt0tsIV3hQZiy8X/gnme DAKoqCMGWHgqoM2sPNWg= X-Google-Smtp-Source: AGHT+IGUilWhJMwZyv1V/AuW/cHPS9rG+VU64t83RM44b28se6lJCnS81qadmgoX7hhrC4ZW+uluSQ== X-Received: by 2002:a05:600c:3b9d:b0:43c:fe15:41c9 with SMTP id 5b1f17b1804b1-43db6227a09mr87300745e9.9.1743462291971; Mon, 31 Mar 2025 16:04:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Steven Lee , Peter Maydell , Jamin Lin , Troy Lee , Joel Stanley , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , qemu-arm@nongnu.org, Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.0 1/2] hw/misc/aspeed_scu: Set MemoryRegionOps::impl::access_size to 32-bit Date: Tue, 1 Apr 2025 01:04:43 +0200 Message-ID: <20250331230444.88295-2-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250331230444.88295-1-philmd@linaro.org> References: <20250331230444.88295-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1743462335123019000 All MemoryRegionOps::read/write() handlers switch over a 32-bit aligned value, because converted using TO_REG(), which is defined as: #define TO_REG(offset) ((offset) >> 2) So all implementations are 32-bit. Set min/max access_size accordingly. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Andrew Jeffery --- hw/misc/aspeed_scu.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c index 76cfd916716..6703f3f9691 100644 --- a/hw/misc/aspeed_scu.c +++ b/hw/misc/aspeed_scu.c @@ -427,6 +427,10 @@ static const MemoryRegionOps aspeed_ast2400_scu_ops = =3D { .read =3D aspeed_scu_read, .write =3D aspeed_ast2400_scu_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .impl =3D { + .min_access_size =3D 4, + .max_access_size =3D 4, + }, .valid =3D { .min_access_size =3D 1, .max_access_size =3D 4, @@ -437,6 +441,8 @@ static const MemoryRegionOps aspeed_ast2500_scu_ops =3D= { .read =3D aspeed_scu_read, .write =3D aspeed_ast2500_scu_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .impl.min_access_size =3D 4, + .impl.max_access_size =3D 4, .valid.min_access_size =3D 4, .valid.max_access_size =3D 4, .valid.unaligned =3D false, @@ -779,6 +785,8 @@ static const MemoryRegionOps aspeed_ast2600_scu_ops =3D= { .read =3D aspeed_ast2600_scu_read, .write =3D aspeed_ast2600_scu_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .impl.min_access_size =3D 4, + .impl.max_access_size =3D 4, .valid.min_access_size =3D 4, .valid.max_access_size =3D 4, .valid.unaligned =3D false, @@ -906,6 +914,8 @@ static const MemoryRegionOps aspeed_ast2700_scu_ops =3D= { .read =3D aspeed_ast2700_scu_read, .write =3D aspeed_ast2700_scu_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .impl.min_access_size =3D 4, + .impl.max_access_size =3D 4, .valid.min_access_size =3D 1, .valid.max_access_size =3D 8, .valid.unaligned =3D false, @@ -1028,6 +1038,8 @@ static const MemoryRegionOps aspeed_ast2700_scuio_ops= =3D { .read =3D aspeed_ast2700_scuio_read, .write =3D aspeed_ast2700_scuio_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .impl.min_access_size =3D 4, + .impl.max_access_size =3D 4, .valid.min_access_size =3D 1, .valid.max_access_size =3D 8, .valid.unaligned =3D false, --=20 2.47.1 From nobody Sun Nov 16 04:05:48 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1743462346; cv=none; d=zohomail.com; s=zohoarc; b=XbWgerSr+d3R+JHl0tdzdbvdlZh6nKDUmryoQ8pA/azHaOio4V1VshyENz3oL3g3sC0Y+pE+P3XkJJLYWXv57IgJpnTQ/GWJ7jHrhvEuoIEdiDl5iOn6TXNOblDZj5mcQOs7Dy7AAHCh/m62JYWscMGqIfTRt6Cp0n+2hJ/39/Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743462346; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YlaEyhXAp6ocXg8HeW9O6/zASqUSt0dLhdV4fK8vO5o=; b=GOJKgFVJVTHrF2XAUUaAWvpXJoY37aDDnwy1oyzVU1rHuC0wjhHZDEsYNvGA1j8coD7bcyzyZT2jpJ+uxL+e+JGEKk9wqJUcloWVmOHMrWFAg5AF5gvvgg+ZJDe1UXLDrR0o2HKi1gAsbC5yzEeAw7ifCmVY9rthSxfQn02Pc3w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1743462346285275.5882529048463; Mon, 31 Mar 2025 16:05:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tzOBi-0006pn-6g; Mon, 31 Mar 2025 19:05:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tzOBh-0006pD-Ca for qemu-devel@nongnu.org; Mon, 31 Mar 2025 19:05:01 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tzOBf-0005m4-HN for qemu-devel@nongnu.org; Mon, 31 Mar 2025 19:05:01 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-39c13fa05ebso923076f8f.0 for ; Mon, 31 Mar 2025 16:04:59 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c0b79e0afsm12611613f8f.65.2025.03.31.16.04.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 31 Mar 2025 16:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743462298; x=1744067098; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YlaEyhXAp6ocXg8HeW9O6/zASqUSt0dLhdV4fK8vO5o=; b=C8pT92wb0FbRLoZD05rAyMUuPZU+OvOpWqBa7MhNug4tr2LFb56MmepYb17293eUOg 7UG45qPUPNKufVBMgTFneG+8n1mJQmFiD9brduhTjtyZWMvxYPfZrjaA46Lc/+YOfmFF GDPfpdYdl1jzpokQfaS9PQHuwMPWcrZ5Y1W8GAPTixZVqDrPWyjBLIQXDpefg7VFoDdx qK49geabIZiA2FuPzWNsNRUuSaiJYcHx9NjyRVLDcS0dpLnhQ03XF5xWdiNXmYiKnKT9 3tPACA76V9vwflyIKsykY5ZyxYJo/qnroDwvuy3SdBamb8EOVicWPjHs5sStWSGSSNq3 3eqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743462298; x=1744067098; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YlaEyhXAp6ocXg8HeW9O6/zASqUSt0dLhdV4fK8vO5o=; b=vQmo8nAgJQiqaH7CsMGhFfhisnPAxFt49xEa0gWfpAJPmh+eZHcYfvtJGsXsl87hOp iTlyzyjzecKLm+6zZoE7h//P4XiG9crav77NvKTQj+st68tBpgnfzjs/5r9DXwnmV/md 1eepxOh+jPAzOy2ZbfWlmqygD/0snNVOqf+HrvsMhfplq+1RzQcYI/H3SaT3fF5qvr2s QVgBCmHtLeyISMSTcYzOxICV9tcquoEMgrZqN0p279gUZyQ9fY+XJ7eiADXssFv8z6fV iTVxpr9SZ5FHdGsoGP45mXraUCzaP6laJs6FdUuH9STE/5fXEKD/ioaQj5rukwr9YTzE CnRw== X-Gm-Message-State: AOJu0Yz5Ez/I2szd+HRirnu3Gw1/nHFk2WSguMJyEtVoLgM0NUILkj/s XVy9anH1W3SciNqGLhvxjcWaj/bfe/3esRMWLFf6jnYQNFAosxgX2T9Nshtl8zHnGzoO1sBjWit 0 X-Gm-Gg: ASbGncshAbJfRevHcflulLOtHnJpEzZZPJB/0Bt0CRsiyjDEMKWm8gKGpPtC1O8CB6+ Ui4l+SfTqJnvsRn23uDczUjpJ+zoSqDetrQyQfCk+uVmumEnGLQOP67DXxruS8/x2KT3dVX7UCq lFbZrxj1bHEf5Bn0cP0U5kY33iZWIiHQ/u5V2g8IAr965pWrMnfTTrlGnpTWYv8pUHUZkd+zwyR pI4u7PY7n1ev3p/6v74clneqSyzQodiAwRISq2Rm2b9AZ9dRmeItd8YZ8sDaOxJJhehEabVGL+l 0jT8+a0gMuWj/XJtlJFV65bHuQHjZ8S1M7gvUZxTXzic+lQgX215W+VFVd3MtRT9v0RPMqPPMpH ooO7Uz1pCNBn+egqUzxl2mijUtfbTwg== X-Google-Smtp-Source: AGHT+IGwoMF+YRQ+3eICOIA9vfUiwZjjDbrkCivGMOmqJmDw/sK50eUG0NhFdKTk1oQSKpWRxfavZg== X-Received: by 2002:a5d:6d8d:0:b0:39a:ca04:3dff with SMTP id ffacd0b85a97d-39c1211805dmr7884916f8f.40.1743462297814; Mon, 31 Mar 2025 16:04:57 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Steven Lee , Peter Maydell , Jamin Lin , Troy Lee , Joel Stanley , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , qemu-arm@nongnu.org, Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.0 2/2] hw/misc/aspeed_scu: Correct minimum access size for AST2500 / AST2600 Date: Tue, 1 Apr 2025 01:04:44 +0200 Message-ID: <20250331230444.88295-3-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250331230444.88295-1-philmd@linaro.org> References: <20250331230444.88295-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1743462346579019000 From: Joel Stanley Guest code was performing a byte load to the SCU MMIO region, leading to the guest code crashing (it should be using proper accessors, but that is not Qemu's bug). Hardware and the documentation[1] both agree that byte loads are okay, so change all of the aspeed SCU devices to accept a minimum access size of 1. [1] See the 'ARM Address Space Mapping' table in the ASPEED docs. This is section 6.1 in the ast2400 and ast2700, and 7.1 in the ast2500 and ast2600 datasheets. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2636 Signed-off-by: Joel Stanley Reviewed-by: Troy Lee Message-ID: <20241118021820.4928-1-joel@jms.id.au> [PMD: Rebased, only including SCU changes] Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Andrew Jeffery --- hw/misc/aspeed_scu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c index 6703f3f9691..1af1a35a081 100644 --- a/hw/misc/aspeed_scu.c +++ b/hw/misc/aspeed_scu.c @@ -443,7 +443,7 @@ static const MemoryRegionOps aspeed_ast2500_scu_ops =3D= { .endianness =3D DEVICE_LITTLE_ENDIAN, .impl.min_access_size =3D 4, .impl.max_access_size =3D 4, - .valid.min_access_size =3D 4, + .valid.min_access_size =3D 1, .valid.max_access_size =3D 4, .valid.unaligned =3D false, }; @@ -787,7 +787,7 @@ static const MemoryRegionOps aspeed_ast2600_scu_ops =3D= { .endianness =3D DEVICE_LITTLE_ENDIAN, .impl.min_access_size =3D 4, .impl.max_access_size =3D 4, - .valid.min_access_size =3D 4, + .valid.min_access_size =3D 1, .valid.max_access_size =3D 4, .valid.unaligned =3D false, }; --=20 2.47.1