From nobody Thu Apr 3 11:43:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174309273209849.412455494614505; Thu, 27 Mar 2025 09:25:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1txq2C-0002AO-5m; Thu, 27 Mar 2025 12:24:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txq2A-00028l-5L; Thu, 27 Mar 2025 12:24:46 -0400 Received: from air.basealt.ru ([193.43.8.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txq28-00042z-BE; Thu, 27 Mar 2025 12:24:45 -0400 Received: from boringlust.malta.altlinux.ru (obninsk.basealt.ru [217.15.195.17]) (Authenticated sender: rastyoginds) by air.basealt.ru (Postfix) with ESMTPSA id 53C9323383; Thu, 27 Mar 2025 19:24:42 +0300 (MSK) From: gerben@altlinux.org To: qemu-block@nongnu.org, kwolf@redhat.com, hreitz@redhat.com Cc: qemu-devel@nongnu.org, sdl.qemu@linuxtesting.org, Denis Rastyogin Subject: [PATCH 2/4] qemu-img: fix offset calculation in bench Date: Thu, 27 Mar 2025 19:24:21 +0300 Message-ID: <20250327162423.25154-3-gerben@altlinux.org> X-Mailer: git-send-email 2.42.2 In-Reply-To: <20250327162423.25154-1-gerben@altlinux.org> References: <20250327162423.25154-1-gerben@altlinux.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=193.43.8.18; envelope-from=gerben@altlinux.org; helo=air.basealt.ru X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1743092735401019100 Content-Type: text/plain; charset="utf-8" From: Denis Rastyogin This error was discovered by fuzzing qemu-img. The current offset calculation leads to an EIO error in block/block-backend.c: blk_check_byte_request(): if (offset > len || len - offset < bytes) { return -EIO; } This triggers the error message: "qemu-img: Failed request: Input/output error". Example of the issue: offset: 260076 len: 260096 bytes: 4096 This fix ensures that offset remains within a valid range. Signed-off-by: Denis Rastyogin --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 2044c22a4c..71c9fe496f 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -4491,7 +4491,7 @@ static void bench_cb(void *opaque, int ret) if (b->image_size =3D=3D 0) { b->offset =3D 0; } else { - b->offset %=3D b->image_size; + b->offset %=3D b->image_size - b->bufsize; } if (b->write) { acb =3D blk_aio_pwritev(b->blk, offset, b->qiov, 0, bench_cb, = b); --=20 2.42.2