From nobody Wed Apr 2 13:11:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1742907920; cv=none; d=zohomail.com; s=zohoarc; b=NkKS+KgzozLhLnPGBVi04R0+YI5qlxOFXW6DNt/w12j6FbPXiMxofH5wN3cMz6wsY67uauT2+Ni34xD3IgK2UqYf9qPhh9SpIXuASxG95TtCAvAYHyZlIMVW19bWB40eIK9Q8l6Bz3CJMS81c6K5VHwSeyuCYn9KFHaxLp3ZEj4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742907920; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rHkl1CLLTMtxzzv7to/S3wSbPsj8b4TlffAoIJKx3UM=; b=YFOyTs2FA2IvkmHXgLymkEchyEbPvqFf4gE3Mj0g5jQo+c7kxweQVqhKPF+Fei2eZtDeLtPBRhEtQgnf0/B7ge6msd2zcpHtoWCdPiHyxnqToKki6kQtxga0BfxqSi0KrL5uuz+4YL/ZR1oUSNeqArakt8PVCbfVhGn92MnYbnI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742907920717142.98515437398237; Tue, 25 Mar 2025 06:05:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tx3wK-0001ES-Id; Tue, 25 Mar 2025 09:03:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tx3vP-0000pF-8T for qemu-devel@nongnu.org; Tue, 25 Mar 2025 09:02:45 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tx3vM-000824-Vp for qemu-devel@nongnu.org; Tue, 25 Mar 2025 09:02:34 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-43ce71582e9so38535275e9.1 for ; Tue, 25 Mar 2025 06:02:31 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3997f9e66a7sm13670849f8f.76.2025.03.25.06.02.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Mar 2025 06:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742907750; x=1743512550; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rHkl1CLLTMtxzzv7to/S3wSbPsj8b4TlffAoIJKx3UM=; b=VUTu5RSWfwR0TBwN7s4Ng7ylnc+06k55gxqq6tnlvTs7SsxJ9aNj52AfnNfNV8uy39 qu39VAgyWQYk0hAenXqsdjJFJ6nMqobjD7DFgGMpGpXdEjJSzPi3hOe48OGxw1Mf5ZXo hjRlGOESHiPLDRE3nLUmkYitzPgzHlULqS/QCrml8BmlgP4xmyO522rz/4TyDt2CnoVH /31hVLsiTXmB/7MGtDGIp/0tuL5XwLPwadSaFxdK+K3Bmls4cwwVuRYF2OGKTBZJmksF +ZZ3v55seCO7zWo3nPRle3X9M1KeI3hBKw6yAYD8ZXZ+4HDiMhcdgO6/WgbokD+qksne gBMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742907750; x=1743512550; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rHkl1CLLTMtxzzv7to/S3wSbPsj8b4TlffAoIJKx3UM=; b=H2GfN0fZOwWGy4kvEKINgBhzrDVLLmgHLfFjyTXf2E19RlS6xWjfc0W0H2SYxCux4X ljQhJdog75CaYI2/9MqH/2gaphQYUfJtxnG+pNTCvQIkkrhv6Gr8lHxmhMTBYYk1MTgx N+JkpvthAJuvxoknGQpT2gTxrfg9EFfFecqsY6N92+sk+HvJXQD1PzO7jncGy64gBOYO SG7OCNOLEFz7yyRIEGXgc3jT/ViEyENyCl3acIG0q6OyWSO+7ZNWdhvAkpZEOh0KOJtH ORuqRGqoRsQGyVYogLFJJ2Q+nuih7JDZuYFv+F285B5fLVnDx9hESdsYA2cjIgZDhn7b VCdA== X-Gm-Message-State: AOJu0Yy3LPPNpxUzqJB6Q3SV8NsAdbn7XtG74XYtIVLyKBrlsdP2clBG ECY/oy9HPDHFt02ZfA5pv91UskYvaqJDnZ36wvTsMmcmP129/SOdTjgBdRbRmEYszZJPtwrPwme w X-Gm-Gg: ASbGncuET6+0cLlH+raenLrio3yYmjb3vXjl6jb3AtTXYmPIUP+lBbxQEJln3cA3Fvc JrIfkpEtm6d7HDI0VWaWtpj0SgMUvPAibSocSzE+qf16qbT0wf8C1YQl2rSWwScYv2SjwunSjzK vF2ksOShhMhhsuDmqgZq0lZylKLWi80/eIFNJO/LJMBNDx6xQy3MQ0KJSQjmVrKUkIdV1m3DYlO gfG0yJMkBBSfUuYWoXNXk3nZSWqJ2Aj9928gTO+6LorrYNuuS4PGqvJKpGgTzUo53j5lzMNlmlc qADH3HbMDHcTZVzjbEZBTgLqVxJw5SOWWwfR6Ny9B+rLRULPsAww0PFotzt2ayqBNVM4XEcUSaG S0XQIKRj1OCsbrHbRaW0vrKPoMRFKIw== X-Google-Smtp-Source: AGHT+IFFDabTZixO+e5sAR1FX1lGbsGU7mFepQeZGMHMboFlwZ4ePzjLUfieuUPI1GSRjfgrNgbTVg== X-Received: by 2002:a05:6000:1f8f:b0:391:2dea:c984 with SMTP id ffacd0b85a97d-3997f8f6129mr14693864f8f.11.1742907748366; Tue, 25 Mar 2025 06:02:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Eduardo Habkost , Zhao Liu , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Riku Voipio , Paolo Bonzini , Nicholas Piggin , Richard Henderson , qemu-ppc@nongnu.org Subject: [PATCH-for-10.1 1/5] target/i386: Use explicit little-endian LD/ST API Date: Tue, 25 Mar 2025 14:02:16 +0100 Message-ID: <20250325130221.76116-2-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250325130221.76116-1-philmd@linaro.org> References: <20250325130221.76116-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1742907922615019000 The x86 architecture uses little endianness. Directly use the little-endian LD/ST API. Mechanical change using: $ end=3Dle; \ for acc in uw w l q tul; do \ sed -i -e "s/ld${acc}_p(/ld${acc}_${end}_p(/" \ -e "s/st${acc}_p(/st${acc}_${end}_p(/" \ $(git grep -wlE '(ld|st)t?u?[wlq]_p' target/i386/); \ done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20241004163042.85922-10-philmd@linaro.org> Reviewed-by: Pierrick Bouvier --- target/i386/gdbstub.c | 24 ++++++++++----------- target/i386/tcg/system/excp_helper.c | 4 ++-- target/i386/xsave_helper.c | 32 ++++++++++++++-------------- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c index 04c49e802d7..9262cf46b0a 100644 --- a/target/i386/gdbstub.c +++ b/target/i386/gdbstub.c @@ -94,10 +94,10 @@ static int gdb_read_reg_cs64(uint32_t hflags, GByteArra= y *buf, target_ulong val) static int gdb_write_reg_cs64(uint32_t hflags, uint8_t *buf, target_ulong = *val) { if (hflags & HF_CS64_MASK) { - *val =3D ldq_p(buf); + *val =3D ldq_le_p(buf); return 8; } - *val =3D ldl_p(buf); + *val =3D ldl_le_p(buf); return 4; } =20 @@ -231,7 +231,7 @@ int x86_cpu_gdb_read_register(CPUState *cs, GByteArray = *mem_buf, int n) static int x86_cpu_gdb_load_seg(X86CPU *cpu, X86Seg sreg, uint8_t *mem_buf) { CPUX86State *env =3D &cpu->env; - uint16_t selector =3D ldl_p(mem_buf); + uint16_t selector =3D ldl_le_p(mem_buf); =20 if (selector !=3D env->segs[sreg].selector) { #if defined(CONFIG_USER_ONLY) @@ -287,15 +287,15 @@ int x86_cpu_gdb_write_register(CPUState *cs, uint8_t = *mem_buf, int n) if (n < CPU_NB_REGS) { if (TARGET_LONG_BITS =3D=3D 64) { if (env->hflags & HF_CS64_MASK) { - env->regs[gpr_map[n]] =3D ldtul_p(mem_buf); + env->regs[gpr_map[n]] =3D ldq_le_p(mem_buf); } else if (n < CPU_NB_REGS32) { - env->regs[gpr_map[n]] =3D ldtul_p(mem_buf) & 0xffffffffUL; + env->regs[gpr_map[n]] =3D ldq_le_p(mem_buf) & 0xffffffffUL; } return sizeof(target_ulong); } else if (n < CPU_NB_REGS32) { n =3D gpr_map32[n]; env->regs[n] &=3D ~0xffffffffUL; - env->regs[n] |=3D (uint32_t)ldl_p(mem_buf); + env->regs[n] |=3D (uint32_t)ldl_le_p(mem_buf); return 4; } } else if (n >=3D IDX_FP_REGS && n < IDX_FP_REGS + 8) { @@ -306,8 +306,8 @@ int x86_cpu_gdb_write_register(CPUState *cs, uint8_t *m= em_buf, int n) } else if (n >=3D IDX_XMM_REGS && n < IDX_XMM_REGS + CPU_NB_REGS) { n -=3D IDX_XMM_REGS; if (n < CPU_NB_REGS32 || TARGET_LONG_BITS =3D=3D 64) { - env->xmm_regs[n].ZMM_Q(0) =3D ldq_p(mem_buf); - env->xmm_regs[n].ZMM_Q(1) =3D ldq_p(mem_buf + 8); + env->xmm_regs[n].ZMM_Q(0) =3D ldq_le_p(mem_buf); + env->xmm_regs[n].ZMM_Q(1) =3D ldq_le_p(mem_buf + 8); return 16; } } else { @@ -315,7 +315,7 @@ int x86_cpu_gdb_write_register(CPUState *cs, uint8_t *m= em_buf, int n) case IDX_IP_REG: return gdb_write_reg(env, mem_buf, &env->eip); case IDX_FLAGS_REG: - env->eflags =3D ldl_p(mem_buf); + env->eflags =3D ldl_le_p(mem_buf); return 4; =20 case IDX_SEG_REGS: @@ -341,10 +341,10 @@ int x86_cpu_gdb_write_register(CPUState *cs, uint8_t = *mem_buf, int n) return 4; =20 case IDX_FP_REGS + 8: - cpu_set_fpuc(env, ldl_p(mem_buf)); + cpu_set_fpuc(env, ldl_le_p(mem_buf)); return 4; case IDX_FP_REGS + 9: - tmp =3D ldl_p(mem_buf); + tmp =3D ldl_le_p(mem_buf); env->fpstt =3D (tmp >> 11) & 7; env->fpus =3D tmp & ~0x3800; return 4; @@ -362,7 +362,7 @@ int x86_cpu_gdb_write_register(CPUState *cs, uint8_t *m= em_buf, int n) return 4; =20 case IDX_MXCSR_REG: - cpu_set_mxcsr(env, ldl_p(mem_buf)); + cpu_set_mxcsr(env, ldl_le_p(mem_buf)); return 4; =20 case IDX_CTL_CR0_REG: diff --git a/target/i386/tcg/system/excp_helper.c b/target/i386/tcg/system/= excp_helper.c index 6876329de21..f00bb15afe0 100644 --- a/target/i386/tcg/system/excp_helper.c +++ b/target/i386/tcg/system/excp_helper.c @@ -85,7 +85,7 @@ static bool ptw_translate(PTETranslate *inout, hwaddr add= r) static inline uint32_t ptw_ldl(const PTETranslate *in, uint64_t ra) { if (likely(in->haddr)) { - return ldl_p(in->haddr); + return ldl_le_p(in->haddr); } return cpu_ldl_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, ra); } @@ -93,7 +93,7 @@ static inline uint32_t ptw_ldl(const PTETranslate *in, ui= nt64_t ra) static inline uint64_t ptw_ldq(const PTETranslate *in, uint64_t ra) { if (likely(in->haddr)) { - return ldq_p(in->haddr); + return ldq_le_p(in->haddr); } return cpu_ldq_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, ra); } diff --git a/target/i386/xsave_helper.c b/target/i386/xsave_helper.c index 996e9f3bfef..fc10bfa6718 100644 --- a/target/i386/xsave_helper.c +++ b/target/i386/xsave_helper.c @@ -43,8 +43,8 @@ void x86_cpu_xsave_all_areas(X86CPU *cpu, void *buf, uint= 32_t buflen) for (i =3D 0; i < CPU_NB_REGS; i++) { uint8_t *xmm =3D legacy->xmm_regs[i]; =20 - stq_p(xmm, env->xmm_regs[i].ZMM_Q(0)); - stq_p(xmm + 8, env->xmm_regs[i].ZMM_Q(1)); + stq_le_p(xmm, env->xmm_regs[i].ZMM_Q(0)); + stq_le_p(xmm + 8, env->xmm_regs[i].ZMM_Q(1)); } =20 header->xstate_bv =3D env->xstate_bv; @@ -58,8 +58,8 @@ void x86_cpu_xsave_all_areas(X86CPU *cpu, void *buf, uint= 32_t buflen) for (i =3D 0; i < CPU_NB_REGS; i++) { uint8_t *ymmh =3D avx->ymmh[i]; =20 - stq_p(ymmh, env->xmm_regs[i].ZMM_Q(2)); - stq_p(ymmh + 8, env->xmm_regs[i].ZMM_Q(3)); + stq_le_p(ymmh, env->xmm_regs[i].ZMM_Q(2)); + stq_le_p(ymmh + 8, env->xmm_regs[i].ZMM_Q(3)); } } =20 @@ -101,10 +101,10 @@ void x86_cpu_xsave_all_areas(X86CPU *cpu, void *buf, = uint32_t buflen) for (i =3D 0; i < CPU_NB_REGS; i++) { uint8_t *zmmh =3D zmm_hi256->zmm_hi256[i]; =20 - stq_p(zmmh, env->xmm_regs[i].ZMM_Q(4)); - stq_p(zmmh + 8, env->xmm_regs[i].ZMM_Q(5)); - stq_p(zmmh + 16, env->xmm_regs[i].ZMM_Q(6)); - stq_p(zmmh + 24, env->xmm_regs[i].ZMM_Q(7)); + stq_le_p(zmmh, env->xmm_regs[i].ZMM_Q(4)); + stq_le_p(zmmh + 8, env->xmm_regs[i].ZMM_Q(5)); + stq_le_p(zmmh + 16, env->xmm_regs[i].ZMM_Q(6)); + stq_le_p(zmmh + 24, env->xmm_regs[i].ZMM_Q(7)); } =20 #ifdef TARGET_X86_64 @@ -177,8 +177,8 @@ void x86_cpu_xrstor_all_areas(X86CPU *cpu, const void *= buf, uint32_t buflen) for (i =3D 0; i < CPU_NB_REGS; i++) { const uint8_t *xmm =3D legacy->xmm_regs[i]; =20 - env->xmm_regs[i].ZMM_Q(0) =3D ldq_p(xmm); - env->xmm_regs[i].ZMM_Q(1) =3D ldq_p(xmm + 8); + env->xmm_regs[i].ZMM_Q(0) =3D ldq_le_p(xmm); + env->xmm_regs[i].ZMM_Q(1) =3D ldq_le_p(xmm + 8); } =20 env->xstate_bv =3D header->xstate_bv; @@ -191,8 +191,8 @@ void x86_cpu_xrstor_all_areas(X86CPU *cpu, const void *= buf, uint32_t buflen) for (i =3D 0; i < CPU_NB_REGS; i++) { const uint8_t *ymmh =3D avx->ymmh[i]; =20 - env->xmm_regs[i].ZMM_Q(2) =3D ldq_p(ymmh); - env->xmm_regs[i].ZMM_Q(3) =3D ldq_p(ymmh + 8); + env->xmm_regs[i].ZMM_Q(2) =3D ldq_le_p(ymmh); + env->xmm_regs[i].ZMM_Q(3) =3D ldq_le_p(ymmh + 8); } } =20 @@ -241,10 +241,10 @@ void x86_cpu_xrstor_all_areas(X86CPU *cpu, const void= *buf, uint32_t buflen) for (i =3D 0; i < CPU_NB_REGS; i++) { const uint8_t *zmmh =3D zmm_hi256->zmm_hi256[i]; =20 - env->xmm_regs[i].ZMM_Q(4) =3D ldq_p(zmmh); - env->xmm_regs[i].ZMM_Q(5) =3D ldq_p(zmmh + 8); - env->xmm_regs[i].ZMM_Q(6) =3D ldq_p(zmmh + 16); - env->xmm_regs[i].ZMM_Q(7) =3D ldq_p(zmmh + 24); + env->xmm_regs[i].ZMM_Q(4) =3D ldq_le_p(zmmh); + env->xmm_regs[i].ZMM_Q(5) =3D ldq_le_p(zmmh + 8); + env->xmm_regs[i].ZMM_Q(6) =3D ldq_le_p(zmmh + 16); + env->xmm_regs[i].ZMM_Q(7) =3D ldq_le_p(zmmh + 24); } =20 #ifdef TARGET_X86_64 --=20 2.47.1 From nobody Wed Apr 2 13:11:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1742907843; cv=none; d=zohomail.com; s=zohoarc; b=N5sTQN4ENCyeh8wQwEUZ68kjMGGB1FgVIa0AxnTvjpGAvFC710750lUTPk1rpSwrLAzfYsTiVGS82tU2INXkPPUFPW/0tjooGffTBUB796xxOTc/WUTPadG/GL0q2ejFF+CcYAe/5xaqhMnrmOlftsnF9GxsCRGX3W7trdPwcAA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742907843; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jFyrhQBtENvr7c7C7/qCg1WgDkZETsoaD0YCLqZYx2k=; b=RYvlyaHqjpYDwbADLUE/0hyFsPte4AwF97AvTelYf2HHmpuAeILjQX50JmElKPGTOxPLdhBtp6m8P3jWsvcaKu6/4IEJGoe/bs/H6hHfnrGv5/ESFYXJbjHhf/+dS8GpFgrAMB+/VsAUfQSbQhmopa1gYQjcOikT37R8fiOGUA0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742907843448881.2369669053454; Tue, 25 Mar 2025 06:04:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tx3wN-0001J0-Vm; Tue, 25 Mar 2025 09:03:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tx3vS-0000pr-BF for qemu-devel@nongnu.org; Tue, 25 Mar 2025 09:02:46 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tx3vQ-00082Z-Mj for qemu-devel@nongnu.org; Tue, 25 Mar 2025 09:02:38 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-39ac56756f6so1650159f8f.2 for ; Tue, 25 Mar 2025 06:02:35 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d43f3328bsm200503165e9.1.2025.03.25.06.02.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Mar 2025 06:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742907754; x=1743512554; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jFyrhQBtENvr7c7C7/qCg1WgDkZETsoaD0YCLqZYx2k=; b=fMQFBux3glu/qbW8tkOYIkNAwMo4LdITAsXvrfaO0ifEwgFT/Qkq8aEbJuXVLXTeFG U+n86MR/9krLSEs2acs2JdoB0i5kBwVG9VDxebNqBSQS7yROa/WPf4tqLE+4pXkVwhJe FSW4dzWrDr91OPqlZgaMvLfJs63ueTJCM10Rx4U1stpBKNeB0qxh+uKqFdITPHpB2X6h JfPS3620UgWk0Mrc4c0OcOF05iU4mtf7DXjqiCe5cYACAbTV+6+IPu0ANXO6XUS6BiJo Jq6ydDKTdnpGW+Z1WEqkYkfwID1aVFJONbwRmFKOtMGFMuPTpi7jTWr1DlRaghtSleRb FxMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742907754; x=1743512554; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jFyrhQBtENvr7c7C7/qCg1WgDkZETsoaD0YCLqZYx2k=; b=NzG52NPwb6Vkg5WoMSq9ORvQkc2MJzvIWGSnohsi3h+qAbYxPghVmK+RbrR5gMpUri +k8w/AMJ1cz4cID1YcbiLlPVspqvzHPLj/w4vl7iQAiINy+chkKye7QfBsIazpwpEX/j jDNgiWZ9ehc3cGmfWgWn6uSRGmM9EkluV7762Rxfdq70TlBBj+iruTOIGA864BdAl2s3 GYFJiXn3X5sKrkoHOd/I/EafPIh+irT2rI+YwtzTDdjWDsQwXF0SO8uZENoec5VUS5sM KXoxW8lkEyNr3rLoRLW9MhOZEWQ5WOUlMpTrUSU7GpDjWqTVT6kWzX92MI3B51u7ypkx KMzA== X-Gm-Message-State: AOJu0YxFrOIgx8pWBVS4RwBPwM4OP2Ej2sQTn5WbY0xJXng69VxLX2tI H08cdbWyQt/1qQIE0GIhE/MhIyDHVQmnep8WnUGkaJCiXT7XAsyxVaYWo1RYRCwkZWy7JZPh70q E X-Gm-Gg: ASbGncuTBF/MKGUJ2XhUs/s3xKzk1Q1/ep+5VvsRZIXwmqkSyw1MiSJRikiyk0h9GdS n/K4oR95uDvHRkHXr5WSz7FNpysIgfYxnPwEeCNMXO8ZCjOFNScJh5pDm4gnXaQ9DoA8V5Gcmc5 58Pb9SQSIrr3YTkBBIBB8LS9VlSnUJj5Nuk7l6TuJz7a6GeGRZcr6kNcSzoxqSUasOjxySEToYz eycoASoeSqaHCGtcv2hhyySk0Y64Zje4mYhVAn0bUZ929wtLp48enuBOtg9u9Vsagpk07k7Smo4 Thugh8f780DX6M3aDluvQyi81/OgNrLp7DIKvSb/UWet4hB4tuQ7MiTH9yCEqsyzA3v7bH11IN8 WajMN8BKoV00IJmQV6mE= X-Google-Smtp-Source: AGHT+IEBOArO4GvzBizOpIN8ZP+KW2vp0DsI/6kS0fhOEclGJnXrJwNPuVR6oaALc0w+GGyq3/xJpQ== X-Received: by 2002:a5d:5f92:0:b0:391:212:459a with SMTP id ffacd0b85a97d-3997f90ff74mr15601417f8f.22.1742907753660; Tue, 25 Mar 2025 06:02:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Eduardo Habkost , Zhao Liu , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Riku Voipio , Paolo Bonzini , Nicholas Piggin , Richard Henderson , qemu-ppc@nongnu.org Subject: [PATCH-for-10.1 2/5] gdbstub: Remove ldtul_be_p() and ldtul_le_p() macros Date: Tue, 25 Mar 2025 14:02:17 +0100 Message-ID: <20250325130221.76116-3-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250325130221.76116-1-philmd@linaro.org> References: <20250325130221.76116-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1742907844518019100 Last uses of ldtul_be_p() were removed in commit 78920b4ff2b ("target/sparc: Use explicit big-endian LD/ST API"), and of ldtul_le_p() in 39631d57d7c ("target/riscv: Use explicit little-endian LD/ST API"). Remove these legacy macros. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- include/gdbstub/helpers.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/gdbstub/helpers.h b/include/gdbstub/helpers.h index 6f7cc48adcb..26140ef1ac0 100644 --- a/include/gdbstub/helpers.h +++ b/include/gdbstub/helpers.h @@ -95,13 +95,9 @@ static inline uint8_t *gdb_get_reg_ptr(GByteArray *buf, = int len) #if TARGET_LONG_BITS =3D=3D 64 #define gdb_get_regl(buf, val) gdb_get_reg64(buf, val) #define ldtul_p(addr) ldq_p(addr) -#define ldtul_le_p(addr) ldq_le_p(addr) -#define ldtul_be_p(addr) ldq_be_p(addr) #else #define gdb_get_regl(buf, val) gdb_get_reg32(buf, val) #define ldtul_p(addr) ldl_p(addr) -#define ldtul_le_p(addr) ldl_le_p(addr) -#define ldtul_be_p(addr) ldl_be_p(addr) #endif =20 #endif /* _GDBSTUB_HELPERS_H_ */ --=20 2.47.1 From nobody Wed Apr 2 13:11:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1742907839; cv=none; d=zohomail.com; s=zohoarc; b=GyP8AgA/ucpqRcqsGmP8vVRed2HhKtIO7KUr9hPszxnIOLmL1Qn+frOnKweE+Fhgjo2jIYObtKb+lqzCzQfD/2yPy1TAtXBlBnAbgqUljlTvGZoMdquHnRWjdnMUbsdtd8qLTK1/rGdmZUaylwELWut3c2+rTCLdNRu5tfwv61A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742907839; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=J/DOA8hAmAVfg6M/0jKhvBqsPxQAowypQJ33xuaxeRc=; b=IjEKAcftji9TtrUdMySQnOVQinNb9qRWf1z/HQ2RtuET1lZ9Xy7RovuFslHR6TqGVYaEt92LHVrNrDkXxXP5NjtQGpbC+GWcNSg1PhRPHa3ss80YIDz3gXXAznYOXdO9+WaYX+gpkSTZLSuTDyuEBbx9QO+O3ahQ6AHafgJV+Rw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742907839798537.9371527131992; Tue, 25 Mar 2025 06:03:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tx3wJ-0001B3-GR; Tue, 25 Mar 2025 09:03:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tx3vY-0000sG-1J for qemu-devel@nongnu.org; Tue, 25 Mar 2025 09:02:46 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tx3vV-000833-Eg for qemu-devel@nongnu.org; Tue, 25 Mar 2025 09:02:43 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-43bb6b0b898so53663675e9.1 for ; Tue, 25 Mar 2025 06:02:40 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d43f43e50sm198899785e9.12.2025.03.25.06.02.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Mar 2025 06:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742907759; x=1743512559; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J/DOA8hAmAVfg6M/0jKhvBqsPxQAowypQJ33xuaxeRc=; b=zHmbEOfiP8/YbteXBDxqsoUfUnkBO+XvhsMFySm0A4rz6zkN/4owWPfPE5ry5a9uoN 30Fi7C4a/dNw3xwEN9N42VSv6OlbTX8iV4SuUDoMIYrHNKxSjHMfdZEA+0vVZgz46F0G jp9OuIiZcaSkLeL/wE+/6dxd2nH0MuwU01eOn4OwXByd1AdMdmjDLyaepW+bvhk3W8Qz RV2mykVD23wVgXj3vS3OmgjKKUd3bfghJvDVz0HPw/GFEIBbQSrbjoH/P/t9+Kaku8N/ 391tv1UDo7Ye4z+1D7ltxh5HfegRfCgxT64SQyANdz49I9vTqF2YfLSBnsKwYg3EypUa EYdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742907759; x=1743512559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J/DOA8hAmAVfg6M/0jKhvBqsPxQAowypQJ33xuaxeRc=; b=OrZya6DqYrCR9szV1b/FdxbRSqlrZtCBq5lW8nnbJBj5lGkyBSDRPhQajsSUP9T3+2 ZINVJtfDRoZwUoVZzdBuRXWpROhyc5TXQiOxOsZnaRortIoSBzbA/ferxcJGrntGCV6j FG2PGEJumRPm8HMl16+LWYmxMsrmaVl3wrIwmIZrDXJN+riC/kH+J/zUbC4VqYWkHBSJ Mwd5FwgX6V2W+fiRiUujsTWOj83BWG49nyuwGToTSWMMxCwjttIiFwZmbBrX8TS90qs8 9Mpj1wki2ep/cE+tq8E/zXUy5Vbh2EcDQ7wq9YN014oH3Ec5AjYwyTlyl5rCMl7Y8vVi KtjQ== X-Gm-Message-State: AOJu0YxzF1WSB/esRcekG+ztcAcADLfa9sJgkc4jIdsXQ0oRbhIB/1GS rqxFlkWH+ESAeXXBa7rFn1mvz+E8ypUi+ea0ri7cRrgrVnQ7egSgW+hkG3Nk10hkulrfuSwaRtx z X-Gm-Gg: ASbGncuENMfbHFMdZ5Y4Oue9sxPDEqzsrFrjzF6Bugy//FnYWuMfyAeKC5K8GvvDq8G qp+uEELsykXMzp+Swd6wa+yBXlxPuV9EOXxpjbumPY853hMQLKY9kaRu2KNw8B+VbfXZc1t8T6s 0XtV3nAvlYl0PE3y8qgB7MUrbw6ym2+22ug2cJUZuic2XRFg11UfnwTkwn/vrxFcp4A/Io3PTrI kaLEjICk8nsTWvO5bgJxToACZ164fqcHyjkS5QBcNMEloqiZ4EWwX3SJH3X0kdDRs8UrjZ827jX MY3PURpIYG7y5+02Pe0d1f3OM1iygv3oxu1b4PSIAbAClHDf5JoJ/++5KQH13lTnnNyWtieOxv1 nrBUgGxIYhlF4SSQK2mc= X-Google-Smtp-Source: AGHT+IER1+XvWTZ4UFakvZLTuYePWcaH1fuaZlt1K+eW1Kk6zElKCMWesaNDlxy3KNbbqoADoz2RMw== X-Received: by 2002:a05:6000:1ac9:b0:390:fbdd:994d with SMTP id ffacd0b85a97d-3997f910670mr15533763f8f.27.1742907758574; Tue, 25 Mar 2025 06:02:38 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Eduardo Habkost , Zhao Liu , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Riku Voipio , Paolo Bonzini , Nicholas Piggin , Richard Henderson , qemu-ppc@nongnu.org Subject: [PATCH-for-10.1 3/5] target/ppc/gdbstub: Replace TARGET_LONG_SIZE -> sizeof(target_ulong) Date: Tue, 25 Mar 2025 14:02:18 +0100 Message-ID: <20250325130221.76116-4-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250325130221.76116-1-philmd@linaro.org> References: <20250325130221.76116-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1742907842185019000 TARGET_LONG_SIZE is equivalent of sizeof(target_ulong). Since this is the single use of TARGET_LONG_SIZE in a source file, use the equivalent form to be able to remove the definition in a pair of commits. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- target/ppc/gdbstub.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c index 3b28d4e21c7..4d36dcfb563 100644 --- a/target/ppc/gdbstub.c +++ b/target/ppc/gdbstub.c @@ -367,6 +367,7 @@ static int gdb_get_spr_reg(CPUState *cs, GByteArray *bu= f, int n) { PowerPCCPU *cpu =3D POWERPC_CPU(cs); CPUPPCState *env =3D &cpu->env; + target_ulong val; int reg; int len; =20 @@ -375,10 +376,7 @@ static int gdb_get_spr_reg(CPUState *cs, GByteArray *b= uf, int n) return 0; } =20 - len =3D TARGET_LONG_SIZE; - /* Handle those SPRs that are not part of the env->spr[] array */ - target_ulong val; switch (reg) { #if defined(TARGET_PPC64) case SPR_CFAR: @@ -402,6 +400,7 @@ static int gdb_get_spr_reg(CPUState *cs, GByteArray *bu= f, int n) } gdb_get_regl(buf, val); =20 + len =3D sizeof(val); ppc_maybe_bswap_register(env, gdb_get_reg_ptr(buf, len), len); return len; } @@ -410,6 +409,7 @@ static int gdb_set_spr_reg(CPUState *cs, uint8_t *mem_b= uf, int n) { PowerPCCPU *cpu =3D POWERPC_CPU(cs); CPUPPCState *env =3D &cpu->env; + target_ulong val; int reg; int len; =20 @@ -418,11 +418,11 @@ static int gdb_set_spr_reg(CPUState *cs, uint8_t *mem= _buf, int n) return 0; } =20 - len =3D TARGET_LONG_SIZE; + len =3D sizeof(val); ppc_maybe_bswap_register(env, mem_buf, len); =20 /* Handle those SPRs that are not part of the env->spr[] array */ - target_ulong val =3D ldn_p(mem_buf, len); + val =3D ldn_p(mem_buf, len); switch (reg) { #if defined(TARGET_PPC64) case SPR_CFAR: --=20 2.47.1 From nobody Wed Apr 2 13:11:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1742907873; cv=none; d=zohomail.com; s=zohoarc; b=Jq3fdj0JB8mvdEJ3oW6+Fvm52CWXCHTE2fSM/apako0dqCRfdKdKVM5aDTLygJlURDW3XFsA+mWR7v9szAXlEzXx2+mj0RZXZe1BVXDLeb1+Y1bR0z0dwIjkovK/HMxooaaVMJ9gmVgSd+0JrTAuMj4x2Rt31WSVtHzP7GHg6/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742907873; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XPwtIJ7PyZH/NUhwd2km9X/kSSpo1y0r8LhrZ/SyOu8=; b=U/SqsIBpHXts4ojiEKnj1IukRXxPpH2fEKyV52z+326wlgdVcb8pwMfYERGfWDoHJg2vKfErgZSKcbpCSQLCZilyduVOiaCbzrljiOvix5sxtBYB1LeMgsDZGaqw2ShgDOy3YJXb1Xy+fxe/HHpz4xpsrHE0/9yQ3aHWdxWpgCU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742907873927248.67610886299758; Tue, 25 Mar 2025 06:04:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tx3wU-0001Pk-L6; Tue, 25 Mar 2025 09:03:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tx3vc-0000tv-4m for qemu-devel@nongnu.org; Tue, 25 Mar 2025 09:02:50 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tx3vZ-00083S-Ns for qemu-devel@nongnu.org; Tue, 25 Mar 2025 09:02:47 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-43cf3192f3bso47982445e9.1 for ; Tue, 25 Mar 2025 06:02:45 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d440eda26sm201420575e9.36.2025.03.25.06.02.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Mar 2025 06:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742907764; x=1743512564; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XPwtIJ7PyZH/NUhwd2km9X/kSSpo1y0r8LhrZ/SyOu8=; b=YZcBzdFNAn7GSksyuJ2pEZ7k3rPKX/D8FQhQsthfTXloZdSbpLclz/4uGNOaG6M0b0 oomTRzzToUnKbbBIKD/UAN8DlRCJf4i25nfqmxqgsAiizZASjBBJa2LLhRM6G3QsVO/K RHHPDTNiHnV0Xr5AoHRavJDZXnOBND9PIITghSQ5UvYIpKyWp9nWQai+cs3H7CYY34bi g3A19OQE34gUPEkJqvKxbbVUcLsJG9y42UxSi0n5b33LOI5q6wORVJuRwQtttoVYeo9k ua8NkBcO7n5zZ6hVdniBbgOCM6K3isxSpCcwLP2uPk/nKO2zKyVkSdLah1Ome2tzxtBG 7bqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742907764; x=1743512564; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XPwtIJ7PyZH/NUhwd2km9X/kSSpo1y0r8LhrZ/SyOu8=; b=VC1fEqvA4A845eqNyAgA7CFuIdQhKVkOP/F0S9l3OeFe5xm4RQaGiLLjSu/AKB0Xzc 4mkWI03y8O7Iwwpm9y4cgP2FCJDPTmrnxqSF/T0L7gvu3U3AGOsXchSY8nM8Ze7qt/n/ OBMq9XwgVaMBK7Ncy8SgvWyZ3V5c+4fRx84WV+t8atAlZAtja2GCkGBTHLtoyI5YaAI0 LEtggmFQGTdPsmIlpu65kVBGXgpCGT2C0sIcveFkaxfKF4x3DpizUEbIt35vqTo+XSA9 YM4y0/JEOw9WS2a4EAgzxXTg4KJ7JdENfE3iWUnj8Dl49368qaSGUO4Mg6poElppVrzL BmUA== X-Gm-Message-State: AOJu0YxMaIz+SFq3QIcExalo5sID5ZdGvhaxKh4+K5a11/o9cIqX0EOP vWc67suUM34yK/JjmBy8tbYgfnVswBnw/WHJbyd2hT648CC3eTGLG4fccIzm+IKLD6ZpWnI9Sjn S X-Gm-Gg: ASbGncuizWnDeH79tNhHEJmfoo/SDABunbhTGyVpkT5jHonBhFyufi33O360MZMhsAX keKagK8JA5xBn+IKSGX9n7d2pIYqXfiEM6faLwqDi3KEWjx4LA224TqSEJiaPNtawAeJRiP3wwl 7oI+QyVjzO1auodBACrg+o9oL/WtkMpZyukWbLw7bYwyiY8PbDFteJDfANE/Dk1Nknx/mizlNnq iOhK4aeWX0uhcZpAXUKhh1OBM/QFFKrqutI2eDYISttSS58fTJ4yBcyAHdAsLyDGtD+s/hE11HV l1pDq0+XCcaMrzMQij3cO+Z8JVQwzjcIKGj/FlIjUnvBp4b69wIDuQBOf4B02jGxxwwE5pLI3gx H3ob6lC8Ykg+aMJG9wKA= X-Google-Smtp-Source: AGHT+IEMIP/8iOrSgXM1xj9+77tapHOdqrFUtarrlpEzgOJ6FvO7fKL0tpMBgH/nfRs1lb39dAiytQ== X-Received: by 2002:a05:600c:83cf:b0:43d:22d9:4b8e with SMTP id 5b1f17b1804b1-43d509ec3famr189652755e9.10.1742907763580; Tue, 25 Mar 2025 06:02:43 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Eduardo Habkost , Zhao Liu , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Riku Voipio , Paolo Bonzini , Nicholas Piggin , Richard Henderson , qemu-ppc@nongnu.org Subject: [PATCH-for-10.1 4/5] user/tswap: Replace TARGET_LONG_SIZE -> TARGET_LONG_BITS Date: Tue, 25 Mar 2025 14:02:19 +0100 Message-ID: <20250325130221.76116-5-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250325130221.76116-1-philmd@linaro.org> References: <20250325130221.76116-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1742907876749019100 Having in "exec/target_long.h" this definition: #define TARGET_LONG_SIZE (TARGET_LONG_BITS / 8) It is safe to check TARGET_LONG_BITS =3D=3D 32 instead of the equivalent TARGET_LONG_SIZE =3D=3D 4 expression. This removes the last use of TARGET_LONG_SIZE outside of "exec/target_long.h". Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- include/user/tswap-target.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/user/tswap-target.h b/include/user/tswap-target.h index 4719330dbbc..1c66a5b9344 100644 --- a/include/user/tswap-target.h +++ b/include/user/tswap-target.h @@ -11,7 +11,7 @@ #include "exec/cpu-defs.h" #include "exec/tswap.h" =20 -#if TARGET_LONG_SIZE =3D=3D 4 +#if TARGET_LONG_BITS =3D=3D 32 #define tswapl(s) tswap32(s) #define bswaptls(s) bswap32s(s) #else --=20 2.47.1 From nobody Wed Apr 2 13:11:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1742907840; cv=none; d=zohomail.com; s=zohoarc; b=RiTaUd2MnmPeF7LsBIDbT2jddXmAyCYBxdGxKreuHsf8qDXJcuDaAPnbn6/W6ef8R57DcjkFDy5y0M/TPno2bKWMSzAYq7sD3GRAThBtm8SpzjoHAIZFKLzBNPx1xpvHzJjNWRKZ8Vewkyede+FPKzmkJRhRex6Ul9mg+s56Z84= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742907840; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4sDqJtqOWjvSs4usBVbY5N6y1YZHqf2bWga8DmhhKKI=; b=eo1xa/fyj+hw9uTI7/JM568B0PlNEEmH9ROTDhawPXJlYqFcd6WRRe89455Ps02N0DwyvelbfQ1DINc/xrWs7O5WVBKHO5rbkg19iCq9BNacA14LnTMWo/PS5bJ8k53Xh9xrK5jlKNwE1MD69H746RnOVFfCP622bbEX2/yhQq0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742907840284740.3248396754179; Tue, 25 Mar 2025 06:04:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tx3wT-0001NT-07; Tue, 25 Mar 2025 09:03:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tx3vi-0000zt-Io for qemu-devel@nongnu.org; Tue, 25 Mar 2025 09:03:00 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tx3vg-00084b-Hn for qemu-devel@nongnu.org; Tue, 25 Mar 2025 09:02:54 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-43cfa7e7f54so33781995e9.1 for ; Tue, 25 Mar 2025 06:02:52 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d4fd9ec29sm149225455e9.30.2025.03.25.06.02.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Mar 2025 06:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742907770; x=1743512570; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4sDqJtqOWjvSs4usBVbY5N6y1YZHqf2bWga8DmhhKKI=; b=Ufxvfb3QUcH/FBOuo5nefIOvDMg0xxbi6vDaBau4MkOTlleXS/slSd9WKBysjJEheZ ot3jG3vsfpQP1LwCK30Q43zpAessJ0baDQKdgEERqaUJnX8IksP053BAsdxtsCrr1w5D hgEJSRbOnAcklC4Px5UTsJvkMnwsWAiIGm6av7pglzk8NuMwHpNdtbd4cqcjXUDg5HIo wgIokFHu4EFp1Vpg4Lz3/fD1nyLC2fHGM5nn8XPnAklP9OpccStzduR9JT605kk++qYS L9m53DLZHQagtKg9X0ln8diCEeuzxz1wJpbSpTQruqNXmczucZ0kY7+Ffp1KjAHuqWeB iH6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742907770; x=1743512570; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4sDqJtqOWjvSs4usBVbY5N6y1YZHqf2bWga8DmhhKKI=; b=uMHvISr9See1P4ifmMaMdE3y3ennHmMmpRGpmHSFM/oYOg3PSuAy91iKYZycUVanAj 7m9stMK6kQnYcXDXMAWurAO3FJQw7G7B1bgnFkzcFbMXLLRWBlNawPgsNoZcuDHYrU96 5kupLiDfvobUSPuIM2MmV8AbOy2o5Q5aRQl7SfstypZqZkOl/x3fx6Fh2NfC7szJCccu 7K4VLxmrmhdyHaBiMpwC2qTIC7YWPnyHTg5KEsSY+P8PpLhwqoPOev5imk4nb402oKfL sfsXp1gs2j4UkxjOdP3AGZAWI9/Nw1z6Hi4U6PDGEhFT1ZwoOkT/jIxLnkUZTlbI/Hi2 NZbA== X-Gm-Message-State: AOJu0YyA9duvR1XsY3ckh3Hew9KemXauBOM+Zr3ojIQzHt+RuEPlVpla LRkGANu/cPnbRtd2i/4m1oMAnW0IW6Jt41UMPF+/rl8U4G/fPnwCBxaBDGzzGqG3jsPxqJ142MG 3 X-Gm-Gg: ASbGnculcYeI4YQjF+iK3P0TAL9Evm+1iMI4fr95dnfVLOwd4csIKxKGwBtI6mbNYAD s9gOz1gXNBQHo6rrlsdNsqf9rHJ2F4SrGrtGNIiThVQQUs8cjmr5L8K5i/+eLyHC6qOmxWefiaE 0Wy2sME+IcTSbErO97kThedSRanFlWznZMIqLkKWYGIcyPMFWWXjIkaQq0XcW3I8BxuNd/IFfe0 y9sIZSID0/ULGoacN+vNljzFBYwbV+7SePQsei0zVfP2epz1o2LddyXrHufh8wM7fuFxlfT4e7r NW/LU9FLMjhMeTcSI3JWz3kDxo3wAkhKwN+USotoMHa401HhGMxhv1/ZvZGDPxo0HxmDwsSnbb9 VGD3z9V3QJwOnm+kXtk0= X-Google-Smtp-Source: AGHT+IHYsYWl0t83+0KxiDgq8X1lmd9f8Ood9cREOUiUzl6ZX+LzQoQnAbSp1vOaQKh2X4n0wy90lQ== X-Received: by 2002:a05:600c:3552:b0:43d:186d:a4bf with SMTP id 5b1f17b1804b1-43d523cf4d6mr124041165e9.0.1742907768709; Tue, 25 Mar 2025 06:02:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Eduardo Habkost , Zhao Liu , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Riku Voipio , Paolo Bonzini , Nicholas Piggin , Richard Henderson , qemu-ppc@nongnu.org Subject: [PATCH-for-10.1 5/5] exec/target_long: Remove TARGET_LONG_SIZE definition Date: Tue, 25 Mar 2025 14:02:20 +0100 Message-ID: <20250325130221.76116-6-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250325130221.76116-1-philmd@linaro.org> References: <20250325130221.76116-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1742907842164019001 Directly use TARGET_LONG_BITS, so we don't need the TARGET_LONG_SIZE definition at all. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- include/exec/target_long.h | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/include/exec/target_long.h b/include/exec/target_long.h index 3cd8e26a23f..d8898625f4e 100644 --- a/include/exec/target_long.h +++ b/include/exec/target_long.h @@ -20,17 +20,15 @@ #error TARGET_LONG_BITS not defined #endif =20 -#define TARGET_LONG_SIZE (TARGET_LONG_BITS / 8) - /* target_ulong is the type of a virtual address */ -#if TARGET_LONG_SIZE =3D=3D 4 +#if TARGET_LONG_BITS =3D=3D 32 typedef int32_t target_long; typedef uint32_t target_ulong; #define TARGET_FMT_lx "%08x" #define TARGET_FMT_ld "%d" #define TARGET_FMT_lu "%u" #define MO_TL MO_32 -#elif TARGET_LONG_SIZE =3D=3D 8 +#elif TARGET_LONG_BITS =3D=3D 64 typedef int64_t target_long; typedef uint64_t target_ulong; #define TARGET_FMT_lx "%016" PRIx64 @@ -38,7 +36,7 @@ typedef uint64_t target_ulong; #define TARGET_FMT_lu "%" PRIu64 #define MO_TL MO_64 #else -#error TARGET_LONG_SIZE undefined +#error unsupported TARGET_LONG_BITS value #endif =20 #endif /* _TARGET_LONG_H_ */ --=20 2.47.1