From nobody Tue Apr 1 15:49:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail header.i=@fujitsu.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1742717120; cv=none; d=zohomail.com; s=zohoarc; b=OqJ2IS+S77shKx6GtdBMu+cPA8CsylHsw/kq90RfAINa8/apPXpXBLxDDpW4SVOffph1HesBfJ6qlNu3eoUcs4Vem1FR6XPDcVLwaztTTPTkGAB7WFmJ76sJARWHVA9JfOk+FdcoR383AD3LPfPJX1JZqNv+jbrWLbJ6Wf+ADRc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742717120; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Sender:Subject:Subject:To:To:Message-Id; bh=wj8XHzvEtLecEYEbqZRbNmG13TbrPneNnBSUBdQCP3w=; b=UwjRkARsXWXQR4qPB+JDRzHjsELFbxWu1kuClXxEwhgHD3olH2z0Qi9OKs4H6DezFsYhaMLurkQCXVOFWQzbyxbnPvCgFIbA0cZKR3SE1dkvuPgSZcpEHVPw7wpyFW8rwE5Z25jn21bhrgqu5nRH6QsWbL/9Y3czia+e3T5XNqg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail header.i=@fujitsu.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742717120700772.4369345985411; Sun, 23 Mar 2025 01:05:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1twGK1-0007iJ-Du; Sun, 23 Mar 2025 04:04:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twGJz-0007i8-WD for qemu-devel@nongnu.org; Sun, 23 Mar 2025 04:04:40 -0400 Received: from esa3.hc1455-7.c3s2.iphmx.com ([207.54.90.49]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twGJy-0006Vi-6c for qemu-devel@nongnu.org; Sun, 23 Mar 2025 04:04:39 -0400 Received: from unknown (HELO oym-r3.gw.nic.fujitsu.com) ([210.162.30.91]) by esa3.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2025 17:04:30 +0900 Received: from oym-m1.gw.nic.fujitsu.com (oym-nat-oym-m1.gw.nic.fujitsu.com [192.168.87.58]) by oym-r3.gw.nic.fujitsu.com (Postfix) with ESMTP id 848F8E9EE5 for ; Sun, 23 Mar 2025 17:04:27 +0900 (JST) Received: from edo.cn.fujitsu.com (edo.cn.fujitsu.com [10.167.33.5]) by oym-m1.gw.nic.fujitsu.com (Postfix) with ESMTP id 4480BD4F46 for ; Sun, 23 Mar 2025 17:04:27 +0900 (JST) Received: from FNSTPC.g08.fujitsu.local (unknown [10.167.135.44]) by edo.cn.fujitsu.com (Postfix) with ESMTP id E6BF01A00A0; Sun, 23 Mar 2025 16:04:25 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj2; t=1742717079; x=1774253079; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=58LqqjA2NDxKt5Zx4AeK6Ham2POP/vmhVzEhbT7fq3g=; b=Zpozm3ManKcJo5F1UB0Hcm8ihIlIV/t7JNEwNbr0oKpcuzuNwBhf/BvA 40DGC34dzEfn8zPIFql8blNir/cnr1acYuN8y3UsVP5xAL3xm/Ckhc2cX qn2DpNYOMzFizOiZZFOtD+4fDGqb2kglZBXU6suKGdAAFqfBhMAnnQvS0 fNtmkPbRaLzVRXxee4j2UcnS7cpqJz3z6WItKJuW3vSW9kXwq7mQumHeT v596gO4flejNbqRPUCy4Qm2riZBMXnvdR/qH59Xzz9u5q4+BAqVe8pnS8 XzB0X3slanwruKMZpPu5DTIX/sSgoD6vfIoG760QziZ9WYrB8g+Yiu3QH w==; X-CSE-ConnectionGUID: /+gz4H6lRFaLO1P3bVl7Ww== X-CSE-MsgGUID: RlSaA5tAS6WmXHGG3fDWsw== X-IronPort-AV: E=McAfee;i="6700,10204,11381"; a="193894444" X-IronPort-AV: E=Sophos;i="6.14,269,1736780400"; d="scan'208";a="193894444" To: Jonathan Cameron , qemu-devel@nongnu.org Cc: Fan Ni , linux-cxl@vger.kernel.org, Marcel Apfelbaum , Li Zhijian Subject: [PATCH] hw/pci-bridge/pci_expander_bridge: Fix HDM passthrough condition Date: Sun, 23 Mar 2025 16:04:20 +0800 Message-ID: <20250323080420.935930-1-lizhijian@fujitsu.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.54.90.49; envelope-from=lizhijian@fujitsu.com; helo=esa3.hc1455-7.c3s2.iphmx.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Li Zhijian From: Li Zhijian via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742717122088116600 Content-Type: text/plain; charset="utf-8" Reverse the logical condition for HDM passthrough support in pci_expander_bridge. This patch ensures the HDM passthrough condition is evaluated only when hdm_for_passthrough is set to true, aligning behavior with intended semantics and comments. Signed-off-by: Li Zhijian --- This change corrects what appears to be a previous mistake in logic regarding HDM passthrough conditions. --- hw/pci-bridge/pci_expander_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expand= er_bridge.c index 3396ab4bdd..25f8922d76 100644 --- a/hw/pci-bridge/pci_expander_bridge.c +++ b/hw/pci-bridge/pci_expander_bridge.c @@ -307,7 +307,7 @@ static void pxb_cxl_dev_reset(DeviceState *dev) * The CXL specification allows for host bridges with no HDM decoders * if they only have a single root port. */ - if (!PXB_CXL_DEV(dev)->hdm_for_passthrough) { + if (PXB_CXL_DEV(dev)->hdm_for_passthrough) { dsp_count =3D pcie_count_ds_ports(hb->bus); } /* Initial reset will have 0 dsp so wait until > 0 */ --=20 2.41.0