From nobody Wed Apr 2 14:05:54 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1742568784; cv=none; d=zohomail.com; s=zohoarc; b=bgBcJJEOtRi91cHeWCJtFrR02KYtxH+f4sMSm5PquWEgLGkGl/6QubPSspCJEeng+H/TGqiRLub/O/AhycnVF0nst99NYShWis3fSnF9v5CrszIFmvWEXQdTva7Fv8uSRqz6skxZMTn55peYpUeMsxpYSx9IHezI7Cy8CqNip3g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742568784; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TtMBE0I0CzdKHMGaIl8cmK8TvAyuKUcO1nCSx7kdsUY=; b=jusrOSs35wZnOWC09bzhKRh8weEa89QxWtAx/z4KHV+BmPCuMgCFeL3vKHjXgqPUegHUnO+VjvEs6nLGiT9SF8FNcXjp4oDjzuKSaQWXOvF7xvHNLSP0aIkm4cjutvwVsMphla500WOmQNEc48g5zYkLsXajzKfNF7b+Lx7UiEc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742568784493133.59976228648122; Fri, 21 Mar 2025 07:53:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tvdjj-0001ev-Vs; Fri, 21 Mar 2025 10:52:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvdjI-0001RZ-5z for qemu-devel@nongnu.org; Fri, 21 Mar 2025 10:52:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvdjG-0006V2-Ji for qemu-devel@nongnu.org; Fri, 21 Mar 2025 10:52:11 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-5cNPNSpqPd6GRf2S-vj4AQ-1; Fri, 21 Mar 2025 10:52:05 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 02596196D2D2; Fri, 21 Mar 2025 14:52:04 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.22.74.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 03AE41800370; Fri, 21 Mar 2025 14:52:03 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C548621E66C6; Fri, 21 Mar 2025 15:51:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742568728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TtMBE0I0CzdKHMGaIl8cmK8TvAyuKUcO1nCSx7kdsUY=; b=WRLC4Be37jl8f37rJjSSWJ1h6Z6UQI5IHGPqiBJM/DAQHImlMcvNYKHQ+Xjd992M7kp4vT VDmmmvSG6imykfs0+MdeoJ0mwbzZY4h7eku7rF2TegjlJz60izqNjnYSp9KpTR/t0taeHF +3jCvcLE6+ljHvJA3VSa0LQYmVyxceg= X-MC-Unique: 5cNPNSpqPd6GRf2S-vj4AQ-1 X-Mimecast-MFC-AGG-ID: 5cNPNSpqPd6GRf2S-vj4AQ_1742568724 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, zhenwei pi Subject: [PULL 1/8] cryptodev: Fix error handling in cryptodev_lkcf_execute_task() Date: Fri, 21 Mar 2025 15:51:51 +0100 Message-ID: <20250321145158.3896812-2-armbru@redhat.com> In-Reply-To: <20250321145158.3896812-1-armbru@redhat.com> References: <20250321145158.3896812-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.332, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1742568786951019000 Content-Type: text/plain; charset="utf-8" When cryptodev_lkcf_set_op_desc() fails, we report an error, but continue anyway. This is wrong. We then pass a non-null @local_error to various functions, which could easily fail error_setv()'s assertion on failure. Fail the function instead. When qcrypto_akcipher_new() fails, we fail the function without reporting the error. This leaks the Error object. Add the missing error reporting. This also frees the Error object. Signed-off-by: Markus Armbruster Message-ID: <20250312101131.1615777-1-armbru@redhat.com> Reviewed-by: zhenwei pi --- backends/cryptodev-lkcf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/backends/cryptodev-lkcf.c b/backends/cryptodev-lkcf.c index 41cf24b737..352c3e8958 100644 --- a/backends/cryptodev-lkcf.c +++ b/backends/cryptodev-lkcf.c @@ -330,6 +330,8 @@ static void cryptodev_lkcf_execute_task(CryptoDevLKCFTa= sk *task) cryptodev_lkcf_set_op_desc(&session->akcipher_opts, op_desc, sizeof(op_desc), &local_error) !=3D= 0) { error_report_err(local_error); + status =3D -VIRTIO_CRYPTO_ERR; + goto out; } else { key_id =3D add_key(KCTL_KEY_TYPE_PKEY, "lkcf-backend-priv-key", p8info, p8info_len, KCTL_KEY_RING); @@ -346,6 +348,7 @@ static void cryptodev_lkcf_execute_task(CryptoDevLKCFTa= sk *task) session->key, session->keylen, &local_error); if (!akcipher) { + error_report_err(local_error); status =3D -VIRTIO_CRYPTO_ERR; goto out; } --=20 2.48.1