From nobody Wed Apr 2 14:25:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1742549282; cv=none; d=zohomail.com; s=zohoarc; b=mDTkGGo5pvdS2Xth5WCG1S5iX5FGVXSTXXG1iNMmrlBIZJ6OsxmOgYCrrB5fhAVIll387nM1jlrLyp3fCBEz7Bo7lOqVr1kjIW1QhcVcQj0YdC5h5Jqz472KIvvnC53ty1ctU0ASwWLwl+75Bca4xhXq9IjHxdBbbHYysHz3YVE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742549282; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=2DQODn4qUfAigCDs4nh4a5GTfeUtPWLZbk06ID3i28g=; b=gkX3lgeH8yB7a8OZHGcLlPoVA7O7aoQGXTfm0nfgDQgcSBKLUmOVAuf+yKVRtYKmzdDlKxBcw7/bPuhUZyOz4ndD3xe3pI4PvH0TyVOAR1o462xHcsYTc85h+Pri8hDbqNBl4fLKHh1fgkXESMR6X8tBUHVYg60sDt+ApSgNtCs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174254928216197.61466472700465; Fri, 21 Mar 2025 02:28:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tvYeR-0006SG-OD; Fri, 21 Mar 2025 05:26:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvYeI-0006Hi-Ty; Fri, 21 Mar 2025 05:26:43 -0400 Received: from mail.aspeedtech.com ([211.20.114.72] helo=TWMBX01.aspeed.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvYeH-00056m-Ai; Fri, 21 Mar 2025 05:26:42 -0400 Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Fri, 21 Mar 2025 17:26:25 +0800 Received: from mail.aspeedtech.com (192.168.10.10) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Fri, 21 Mar 2025 17:26:25 +0800 To: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , "Joel Stanley" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: , Subject: [PATCH v1 04/22] hw/misc/aspeed_hace: Update hash source address handling to 64-bit for AST2700 Date: Fri, 21 Mar 2025 17:26:00 +0800 Message-ID: <20250321092623.2097234-5-jamin_lin@aspeedtech.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250321092623.2097234-1-jamin_lin@aspeedtech.com> References: <20250321092623.2097234-1-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=211.20.114.72; envelope-from=jamin_lin@aspeedtech.com; helo=TWMBX01.aspeed.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_FAIL=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jamin Lin From: Jamin Lin via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1742549282965019100 Content-Type: text/plain; charset="utf-8" The AST2700 CPU, based on the Cortex-A35, is a 64-bit processor, and its DR= AM address space is also 64-bit. To support future AST2700 updates, the source hash buffer address data type is being updated to 64-bit. Signed-off-by: Jamin Lin --- hw/misc/aspeed_hace.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 4bcf6ed074..9771d6e490 100644 --- a/hw/misc/aspeed_hace.c +++ b/hw/misc/aspeed_hace.c @@ -154,7 +154,7 @@ static void do_hash_operation(AspeedHACEState *s, int a= lgo, bool sg_mode, uint32_t sg_addr =3D 0; uint32_t pad_offset; uint32_t len =3D 0; - uint32_t src =3D 0; + uint64_t src =3D 0; void *haddr; hwaddr plen; int i; @@ -177,7 +177,8 @@ static void do_hash_operation(AspeedHACEState *s, int a= lgo, bool sg_mode, break; } =20 - src =3D s->regs[R_HASH_SRC] + (i * SG_LIST_ENTRY_SIZE); + src =3D deposit64(src, 0, 32, s->regs[R_HASH_SRC]); + src +=3D i * SG_LIST_ENTRY_SIZE; =20 len =3D address_space_ldl_le(&s->dram_as, src, MEMTXATTRS_UNSPECIFIED, NULL); @@ -212,8 +213,9 @@ static void do_hash_operation(AspeedHACEState *s, int a= lgo, bool sg_mode, } } else { plen =3D s->regs[R_HASH_SRC_LEN]; + src =3D deposit64(src, 0, 32, s->regs[R_HASH_SRC]); =20 - haddr =3D address_space_map(&s->dram_as, s->regs[R_HASH_SRC], + haddr =3D address_space_map(&s->dram_as, src, &plen, false, MEMTXATTRS_UNSPECIFIED); if (haddr =3D=3D NULL) { qemu_log_mask(LOG_GUEST_ERROR, "%s: qcrypto failed\n", __func_= _); --=20 2.43.0