From nobody Wed Apr 2 14:26:58 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1742549367; cv=none; d=zohomail.com; s=zohoarc; b=BIKAR0mkkTABI+x/dN1h8ZfEI9UZrbnLkZRcl9ZnZNO/AMvshlb1MWH7VYoZGBiBUKog1MmN2u08BbYU+UukBwXhWDR7ziwn47sTwEcElUGgymF9OL01+DBJQ1mSY2AYf1qT8pCvf3jxiFuxUUBeeV+EQEx558E3mUnhUkjNtGo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742549367; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=J3L0bBO43HSPPNEFMDhc3Blc19GSY61sfhHd4K7gXrs=; b=fjkmQQpQSvp1eNL76AZyoDm302i9ca/XFYN6Uta+iDpTKaFwibBgVepJ7XJIb/9NmWLcJyKf7Plyze5wE4hlqdtld09Fg2aXiZe8O0dnW9KmZKHJD8tZCn0pLTX2sYEa0BQGj0cJ1oG1LCiNCy6z9rYcJX0r0casING3Ex/TQ6U= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742549367782211.4064676894227; Fri, 21 Mar 2025 02:29:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tvYf7-0007Gy-Nj; Fri, 21 Mar 2025 05:27:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvYet-0006pl-QM; Fri, 21 Mar 2025 05:27:22 -0400 Received: from mail.aspeedtech.com ([211.20.114.72] helo=TWMBX01.aspeed.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvYep-00056m-PF; Fri, 21 Mar 2025 05:27:17 -0400 Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Fri, 21 Mar 2025 17:26:27 +0800 Received: from mail.aspeedtech.com (192.168.10.10) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Fri, 21 Mar 2025 17:26:27 +0800 To: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , "Joel Stanley" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: , Subject: [PATCH v1 12/22] hw/misc/aspeed_hace Support to dump plaintext and digest for better debugging Date: Fri, 21 Mar 2025 17:26:08 +0800 Message-ID: <20250321092623.2097234-13-jamin_lin@aspeedtech.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250321092623.2097234-1-jamin_lin@aspeedtech.com> References: <20250321092623.2097234-1-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=211.20.114.72; envelope-from=jamin_lin@aspeedtech.com; helo=TWMBX01.aspeed.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_FAIL=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jamin Lin From: Jamin Lin via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1742549369356019100 Content-Type: text/plain; charset="utf-8" 1. Disabled by default. Uncomment "#define DEBUG_HACE 1" to enable it. 2. Uses the "qemu_hexdump" API to dump the digest result. 3. Uses the "iov_hexdump" API to dump the source vector, which contains the source plaintext. Signed-off-by: Jamin Lin --- hw/misc/aspeed_hace.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index b8e473ee3f..ae4d2fa687 100644 --- a/hw/misc/aspeed_hace.c +++ b/hw/misc/aspeed_hace.c @@ -10,8 +10,10 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/cutils.h" #include "qemu/log.h" #include "qemu/error-report.h" +#include "qemu/iov.h" #include "hw/misc/aspeed_hace.h" #include "qapi/error.h" #include "migration/vmstate.h" @@ -20,6 +22,8 @@ #include "hw/irq.h" #include "trace.h" =20 +/* #define DEBUG_HACE 1 */ + #define R_CRYPT_CMD (0x10 / 4) =20 #define R_STATUS (0x1c / 4) @@ -268,6 +272,10 @@ static void do_hash_operation(AspeedHACEState *s, int = algo, bool sg_mode, } } =20 +#ifdef DEBUG_HACE + iov_hexdump(iov, i, stdout, "plaintext", 0xa000); +#endif + if (acc_mode) { if (qcrypto_hash_updatev(s->hash_ctx, iov, i, &local_err) < 0) { qemu_log_mask(LOG_GUEST_ERROR, "qcrypto hash update failed : %= s", @@ -311,6 +319,10 @@ static void do_hash_operation(AspeedHACEState *s, int = algo, bool sg_mode, "aspeed_hace: address space write failed\n"); } =20 +#ifdef DEBUG_HACE + qemu_hexdump(stdout, "digest", digest_buf, digest_len); +#endif + for (; i > 0; i--) { address_space_unmap(&s->dram_as, iov[i - 1].iov_base, iov[i - 1].iov_len, false, --=20 2.43.0