From nobody Wed Apr 2 14:26:58 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1742549292; cv=none; d=zohomail.com; s=zohoarc; b=dv4uptPPTJ27ybwOQXT1elIs6Cp0jOtC70plP/HyzrNZlj8EojCMnoG5Hp/fKRP9glN7lYeLjTobsrGtX/fJRxvsndIi8Vx5+ug3rof8ymCB1u2UiWmMcnFS8rPjm1RPVTvHC7VCSvNPOV/ZtHwKqORGNwhT+U/RxYvEa+w4Ogs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742549292; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=inpvI2tLmMmJRYewBkqsi55iju6JfoXM08iq6C9L6lY=; b=AF+4qbUg5je7D/JQIdZyHu+FfJiBAqKjBfgvl4odqcu6UV43aUi7qwEYTAY1tDt8aukQA5Ksy6BDbqTdOmuH2fB+huCcdlBnRF5hDcRHEcMssP8LBZUDpK3y8nAEcZKQMSnBFI/MDlpS3/iBavx66JNFBsSgolqK4yEteD6I31I= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742549292862109.04134060605202; Fri, 21 Mar 2025 02:28:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tvYez-0006vq-8r; Fri, 21 Mar 2025 05:27:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvYeR-0006TC-SQ; Fri, 21 Mar 2025 05:26:51 -0400 Received: from mail.aspeedtech.com ([211.20.114.72] helo=TWMBX01.aspeed.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvYeP-00056m-Fi; Fri, 21 Mar 2025 05:26:51 -0400 Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Fri, 21 Mar 2025 17:26:27 +0800 Received: from mail.aspeedtech.com (192.168.10.10) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Fri, 21 Mar 2025 17:26:27 +0800 To: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , "Joel Stanley" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: , Subject: [PATCH v1 10/22] hw/misc/aspeed_hace:: Support setting different memory size Date: Fri, 21 Mar 2025 17:26:06 +0800 Message-ID: <20250321092623.2097234-11-jamin_lin@aspeedtech.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250321092623.2097234-1-jamin_lin@aspeedtech.com> References: <20250321092623.2097234-1-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=211.20.114.72; envelope-from=jamin_lin@aspeedtech.com; helo=TWMBX01.aspeed.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_FAIL=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jamin Lin From: Jamin Lin via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1742549295128019000 Content-Type: text/plain; charset="utf-8" The memory size was previously hardcoded to 0x1000 (4K). However, the actual memory size of the HACE controller varies across different models: 1. AST2400/AST2500: 0x1000 (4K) 2. AST2600/AST1030: 0x10000 (64K) 3. AST2700: 0x100 (256 bytes) To address this, a new class attribute, mem_size, has been introduced to dynamically set the appropriate memory size for each HACE model, ensuring correct allocation across AST2400, AST2500, AST2600, AST1030 and AST2700. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- include/hw/misc/aspeed_hace.h | 1 + hw/misc/aspeed_hace.c | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/include/hw/misc/aspeed_hace.h b/include/hw/misc/aspeed_hace.h index 58fb66009a..db95f2fd4b 100644 --- a/include/hw/misc/aspeed_hace.h +++ b/include/hw/misc/aspeed_hace.h @@ -53,6 +53,7 @@ struct AspeedHACEClass { uint32_t dest_hi_mask; uint32_t key_hi_mask; bool has_dma64; + uint64_t mem_size; }; =20 #endif /* ASPEED_HACE_H */ diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index d4f653670e..53b3b390e3 100644 --- a/hw/misc/aspeed_hace.c +++ b/hw/misc/aspeed_hace.c @@ -463,11 +463,12 @@ static void aspeed_hace_realize(DeviceState *dev, Err= or **errp) { AspeedHACEState *s =3D ASPEED_HACE(dev); SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); + AspeedHACEClass *ahc =3D ASPEED_HACE_GET_CLASS(s); =20 sysbus_init_irq(sbd, &s->irq); =20 memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_hace_ops, s, - TYPE_ASPEED_HACE, 0x1000); + TYPE_ASPEED_HACE, ahc->mem_size); =20 if (!s->dram_mr) { error_setg(errp, TYPE_ASPEED_HACE ": 'dram' link not set"); @@ -521,6 +522,7 @@ static void aspeed_ast2400_hace_class_init(ObjectClass = *klass, void *data) =20 dc->desc =3D "AST2400 Hash and Crypto Engine"; =20 + ahc->mem_size =3D 0x1000; ahc->src_mask =3D 0x0FFFFFFF; ahc->dest_mask =3D 0x0FFFFFF8; ahc->key_mask =3D 0x0FFFFFC0; @@ -540,6 +542,7 @@ static void aspeed_ast2500_hace_class_init(ObjectClass = *klass, void *data) =20 dc->desc =3D "AST2500 Hash and Crypto Engine"; =20 + ahc->mem_size =3D 0x1000; ahc->src_mask =3D 0x3fffffff; ahc->dest_mask =3D 0x3ffffff8; ahc->key_mask =3D 0x3FFFFFC0; @@ -559,6 +562,7 @@ static void aspeed_ast2600_hace_class_init(ObjectClass = *klass, void *data) =20 dc->desc =3D "AST2600 Hash and Crypto Engine"; =20 + ahc->mem_size =3D 0x10000; ahc->src_mask =3D 0x7FFFFFFF; ahc->dest_mask =3D 0x7FFFFFF8; ahc->key_mask =3D 0x7FFFFFF8; @@ -578,6 +582,7 @@ static void aspeed_ast1030_hace_class_init(ObjectClass = *klass, void *data) =20 dc->desc =3D "AST1030 Hash and Crypto Engine"; =20 + ahc->mem_size =3D 0x10000; ahc->src_mask =3D 0x7FFFFFFF; ahc->dest_mask =3D 0x7FFFFFF8; ahc->key_mask =3D 0x7FFFFFF8; @@ -597,6 +602,7 @@ static void aspeed_ast2700_hace_class_init(ObjectClass = *klass, void *data) =20 dc->desc =3D "AST2700 Hash and Crypto Engine"; =20 + ahc->mem_size =3D 0x100; ahc->src_mask =3D 0x7FFFFFFF; ahc->dest_mask =3D 0x7FFFFFF8; ahc->key_mask =3D 0x7FFFFFF8; --=20 2.43.0