From nobody Fri Apr 4 05:33:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1742390448; cv=none; d=zohomail.com; s=zohoarc; b=LhTHIKqrWLjdL18RbD6wzxaAmXc3EOYwq9APv4CNcTpxZo0fTTt/9TPOiBQjEFpvG48dlOXYcY8rM0eUKxLMi1dl/2yvIRJt9nxYKcT8dqDbUMnCntEwsZZ5T5R21FiFL/3sfT3BXI10BFmd7v+AuxJ8LBt3lBGEILLN2cIT8Pk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742390448; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yO8tatKd3Pm3cwIW7k7JzR0bRCuWoVaygtzUxWeAGQs=; b=jjm4KLSilEizBSzdtcAxPn0yMP/hWTrNw23Wa0Il6PDqFbyhysoDcpLh18EQihcdTFAsyGELK4x68fHlB1O+25SyCNqPUwCWDphvDD47FtZ9NrSJrvk44bPRXmZIIO9oRCSbKYl0UHIt14gMCvg0eMC6HHi+kG0QcMdyyE7GEQ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742390448947789.9738161957209; Wed, 19 Mar 2025 06:20:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tutKK-0008SF-AN; Wed, 19 Mar 2025 09:19:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tutKI-0008Re-JM for qemu-devel@nongnu.org; Wed, 19 Mar 2025 09:19:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tutKG-0007cA-HV for qemu-devel@nongnu.org; Wed, 19 Mar 2025 09:19:17 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-_1cYEbWiO2COeHVdfJdBHg-1; Wed, 19 Mar 2025 09:19:12 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EB37F19560B2 for ; Wed, 19 Mar 2025 13:19:11 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.32.212]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 49A273001D12; Wed, 19 Mar 2025 13:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742390355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yO8tatKd3Pm3cwIW7k7JzR0bRCuWoVaygtzUxWeAGQs=; b=YR8w4r8TiLSmYj4mb1T/uosWInQnnG5fUWb7npOw3YEtlSFs7A3e/Oq6mfOGp8kVWgaAdA ENoDxwloJZ++tpmv74sWYD346M8lz06B5SwjuxAQ5Jlm9ksXpSBBNP1MMWcWIkXlkT8Tbu oTjUyXHf8dcB+lUCNPCqEuq4y96Wy/4= X-MC-Unique: _1cYEbWiO2COeHVdfJdBHg-1 X-Mimecast-MFC-AGG-ID: _1cYEbWiO2COeHVdfJdBHg_1742390352 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 3/8] tests/functional: remove all class level fields Date: Wed, 19 Mar 2025 14:18:46 +0100 Message-ID: <20250319131851.148817-4-thuth@redhat.com> In-Reply-To: <20250319131851.148817-1-thuth@redhat.com> References: <20250319131851.148817-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.337, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1742390451305019100 From: Daniel P. Berrang=C3=A9 A number of fields are set at the class level on QemuBaseTest, even though the exact same named field is then set at the object level later in most cases. The 'self.logger' initialization in ACPI bits test needs to be removed since 'self.log' won't exist at that point in the flow. It already initialized 'self.logger' later in the setUp() method, so the __init__ method was redundant. Signed-off-by: Daniel P. Berrang=C3=A9 Message-ID: <20250317124300.84266-1-berrange@redhat.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/functional/qemu_test/testcase.py | 6 ------ tests/functional/test_acpi_bits.py | 1 - 2 files changed, 7 deletions(-) diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu= _test/testcase.py index 50d232a7c63..50c401b8c3c 100644 --- a/tests/functional/qemu_test/testcase.py +++ b/tests/functional/qemu_test/testcase.py @@ -33,12 +33,6 @@ =20 class QemuBaseTest(unittest.TestCase): =20 - arch =3D None - - workdir =3D None - log =3D None - logdir =3D None - ''' @params compressed: filename, Asset, or file-like object to uncompress @params format: optional compression format (gzip, lzma) diff --git a/tests/functional/test_acpi_bits.py b/tests/functional/test_acp= i_bits.py index 20da4356873..8e0563a97b1 100755 --- a/tests/functional/test_acpi_bits.py +++ b/tests/functional/test_acpi_bits.py @@ -119,7 +119,6 @@ def __init__(self, *args, **kwargs): =20 self._debugcon_addr =3D '0x403' self._debugcon_log =3D 'debugcon-log.txt' - self.logger =3D self.log =20 def _print_log(self, log): self.logger.info('\nlogs from biosbits follows:') --=20 2.48.1