From nobody Tue Feb 10 14:33:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1742303651; cv=none; d=zohomail.com; s=zohoarc; b=AGgI8b/cJhN+i/RMoJMF2MkVgIVsLoxI1BfF91+LSGJshx3UWtl781wNnGhJuI1qotuWI1t6F2/AGabPbIqK7ywpCLLz5l6fxhhLsU3I2pVCkGzElozq+lZmIgh8MVFSjyEgjMNgdaV3kVBNbkRS2LjF3WCeI1OfVdyNjbpKvrE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742303651; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0cc1uZY19mfyr0bTj71wtNtnhiaEWQlAkAZt8nIkpWE=; b=avAONbI8Q4x0O7KOd3rxUoqmX4c5hnOz1y4zshFRLGbmCJQP575PeFlbSxGB7nsu5LJCeWwu2zeWBiHrOpGiVwml41AhJhJ9H8ZzakwURyGYsAwdL2BlZN0K3wCRNEX3LK8gRQgJFh8H2d7B70wFJdpQ4zf624Mc4S+u+9wI1K4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742303651529447.0426970196272; Tue, 18 Mar 2025 06:14:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tuWjo-0002Xk-Sf; Tue, 18 Mar 2025 09:12:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuWiq-0001ts-J1; Tue, 18 Mar 2025 09:11:09 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tuWio-0003la-Fc; Tue, 18 Mar 2025 09:11:08 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-30bae572157so56630771fa.3; Tue, 18 Mar 2025 06:11:04 -0700 (PDT) Received: from corvink-nb.beckhoff.com ([195.226.174.194]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3147f3101sm850678066b.69.2025.03.18.06.10.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 06:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742303463; x=1742908263; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0cc1uZY19mfyr0bTj71wtNtnhiaEWQlAkAZt8nIkpWE=; b=jVIBAN+urq1B3opUxjK+RiS0Mw84yZSlhTkeH21Dt8JljuVUGDc8dtpnArGHhDg/xF hWQfpueJD1SBN2tdvwAiLZzHKFwEwTg4VV8v2wGWaH2brneLCnEJ5aSxq41s8Bgj11Hv DTgkbMG8tE+3pvNdnSHYGKM1PZze6woKeE0obMWGN2lRRkSxulrFcNs7ABOEq812vznE rX1QgZqZ3m94zY6KoJZyVNmKeAITfwRhTXNMD0Xq0rXN8bDi6jMF/84lS87NJ0mEvBqx j9cBB+JvY+3fI8/AjAR758w3uT6anW01VnB1ZFU1rzcPbhMkU8NN3qdhBqaSy6nnCjko bdJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742303463; x=1742908263; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0cc1uZY19mfyr0bTj71wtNtnhiaEWQlAkAZt8nIkpWE=; b=rP0DLie17Q/nrlaF4Jg8Bod2uNEcnzUFUIt4GUebEaSEArkTiZ+CnzbzsSFnTlsgep AvLfQT2QlfFZYnTKGjFKSshfsVyVkSZ/PrPfQBibkJeIE06/4zH/hwXKkQUtac2l0YCb GNaggENddXOC+WQmrtnD66X6G4SJmjgtOq3hBtmSSU0Ms0svG6oBxPKU/ZLQC4ACNdnL IKLcSzTNbYB8Gn4s9WlOuBm4TFiCghYZWlC9PB4KcKZXT5QyNxkAuga48G4eH9KCKwxV VBuNDliakErM9BKL03EzywOIZL5usz3kCwT4bdtiut8ycVPgR8qwpDULI9jgj4VBaW7D 2fvA== X-Forwarded-Encrypted: i=1; AJvYcCWDgxnWT26+ppWU0iy0/kAalcuYnKZXnuz++sMPJ/fkKyiXtbRf8db6+ujBypUPrTuFQWFAEUtqtg==@nongnu.org X-Gm-Message-State: AOJu0Yxy9hjnmL6lVKqTGdxotiANjZQ2u9uGTuybCsNn83/Jo4RadX7a WAwoFfFMhaXVo5sPwLk0bDv3KsHI6zwl0orH7IDKJ4nk4DoZc5f8ArAeaCdL X-Gm-Gg: ASbGnctjCwuFLjPSpwWK7VRljXOLlb6+uy0BdeBoMByYfPWz+hronSfc8Nbj1OxRqvW +Ux6MupfcPloOMRkirlhzcJ9ShD3OBrdiAPDOJQelM4lrXFWQfn158eaBw7+4dPPNHSQLSZ47b9 oATZJfXfMQmRWzIWaJUR8i3/YxghJ1dKH5iCvCveR24QQUx7b4kO9ShW3e0EfX6WFW3nDLGk8zO e7FXhpREOjZ5IiZwecmUvtvRqZSUsoKnFzdCQ1vDGx1d+mYm40n2hveJU+iSir6Ikh7lQfQcjVy j+EMI9cGRMg3AZ3PcgvvEbX3zegzVg2/wXRmU6WB5mglKRnjEeB+NjgVpJ+0xPGXex0= X-Google-Smtp-Source: AGHT+IHwT1XLLORMDllqjLTe01RDYTLtyhmLqkNxCh58gk3HHiNRNQAqN7J99vv+LnWYu2+dINHGgw== X-Received: by 2002:a17:907:97d3:b0:ac3:cff:80f1 with SMTP id a640c23a62f3a-ac3303e70e3mr1680550766b.54.1742303442070; Tue, 18 Mar 2025 06:10:42 -0700 (PDT) From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: =?UTF-8?q?Yannick=20Vo=C3=9Fen?= , "Edgar E. Iglesias" , Peter Maydell , Alistair Francis , =?UTF-8?q?Corvin=20K=C3=B6hne?= , Paolo Bonzini , YannickV Subject: [PATCH 08/21] hw/dma/zynq-devcfg: Fix register memory Date: Tue, 18 Mar 2025 14:07:59 +0100 Message-ID: <20250318130817.119636-9-corvin.koehne@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250318130817.119636-1-corvin.koehne@gmail.com> References: <20250318130817.119636-1-corvin.koehne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::229; envelope-from=corvin.koehne@gmail.com; helo=mail-lj1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1742303652318019000 From: YannickV Registers are always 32 bit aligned. R_MAX is not the maximum register address, it is the maximum register number. The memory size can be determined by 4 * R_MAX. Currently every register with an offset bigger than 0x40 will be ignored, because the memory size is set wrong. This effects the MCTRL register and makes it useless. This commit restores the correct behaviour. Signed-off-by: Yannick Vo=C3=9Fen Reviewed-by: Edgar E. Iglesias --- hw/dma/xlnx-zynq-devcfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/dma/xlnx-zynq-devcfg.c b/hw/dma/xlnx-zynq-devcfg.c index c595d090fa..24461677ef 100644 --- a/hw/dma/xlnx-zynq-devcfg.c +++ b/hw/dma/xlnx-zynq-devcfg.c @@ -400,7 +400,7 @@ static void xlnx_zynq_devcfg_init(Object *obj) s->regs_info, s->regs, &xlnx_zynq_devcfg_reg_ops, XLNX_ZYNQ_DEVCFG_ERR_DEBUG, - XLNX_ZYNQ_DEVCFG_R_MAX); + XLNX_ZYNQ_DEVCFG_R_MAX * 4); memory_region_add_subregion(&s->iomem, A_CTRL, ®_array->mem); --=20 2.49.0