From nobody Fri Apr 4 05:08:08 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1742223785; cv=none; d=zohomail.com; s=zohoarc; b=NQBbgZ5aqcU8RFLHwY67R7LCFbgIrcHqdj1AGTwRT+pZ/lbvFd3eLQPfIRZy8miSYoARgtARg6j/5nI0kNKueaLxjO4garQSDXH7XefuOWZls8wsY/bI8hZtJvkKBdo4ekhKKf/iauyB0FA1kHwDwYqfkX7zvXGiE1U5hubUeXg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742223785; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rdEbrFiWnDTXGsqL9hkwBVU3NZKj5bZ9kC7Nvw8+KPY=; b=eXEUC8KyubY22wxw1ZhxAmT88zyWhYqzSqnHh5G8ATPrNrQzSsZJNRtVIKkVZcC0GeaIU3ZOoH464UJ0xPiBXApm0OgfvbGe36kSsUumZKUDKSDf3t8eG5M4x7dlAXzBrI2TREkVsV28zft+mvmBUOPia7mYQvjD8Jm9SXvMbTk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1742223785033166.9146106358562; Mon, 17 Mar 2025 08:03:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tuBqS-000586-E7; Mon, 17 Mar 2025 10:53:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuBpv-0004y4-AG; Mon, 17 Mar 2025 10:53:10 -0400 Received: from mgamail.intel.com ([192.198.163.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuBpm-00061r-VT; Mon, 17 Mar 2025 10:53:01 -0400 Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2025 07:52:35 -0700 Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39]) by orviesa004.jf.intel.com with ESMTP; 17 Mar 2025 07:52:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742223175; x=1773759175; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=w7POmeU7VP6eIrAcsdWPqJZKF2jRdbcjZRS+bIqVuS8=; b=nZsAZnyk674/TcTHrAjNpvcaNM47GiZROv9kNj/FqJUtmSYX6IUMcKNJ /sa8yb77mjAN4VPhaXuiO5Vshh6Fv09V+HHnlfFGq5t1K07OcY87hI8ym RRKyPxnTk2hWa2+XdNXqMqkqcbSYDI7YahFdJoFI92FPE5Wlb/XAEoQaw fCHrVnXJjTl+Mk8l8TCIVoh6kkMms9G+ucUEd5cmbDyL397zvO5do75IB DBjBcaCYDziUbPjh9zLDEd7Qm5Sn3r4TM7MqDz1UiorbAZH8xDMEuliCf UZS/rT8axzGzjUaOD6IFRmPjwWC80yM5WJ6sEk7ENf8UC15J59YD2g+kx g==; X-CSE-ConnectionGUID: MIxTDT6TRHOPE2lyeruqUQ== X-CSE-MsgGUID: W89MJnHHRWWV/kHJijofxg== X-IronPort-AV: E=McAfee;i="6700,10204,11376"; a="54694602" X-IronPort-AV: E=Sophos;i="6.14,254,1736841600"; d="scan'208";a="54694602" X-CSE-ConnectionGUID: m4cpMr+JSICYRJyoyWXW0g== X-CSE-MsgGUID: RQ7T7ea1R4eoFvJLdnoJxQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,254,1736841600"; d="scan'208";a="126988512" From: Zhao Liu To: Paolo Bonzini Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org, Zhao Liu Subject: [PATCH 06/17] rust/vmstate: Fix size field of VMStateField with VMS_ARRAY_OF_POINTER flag Date: Mon, 17 Mar 2025 23:12:25 +0800 Message-Id: <20250317151236.536673-7-zhao1.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250317151236.536673-1-zhao1.liu@intel.com> References: <20250317151236.536673-1-zhao1.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.198.163.10; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.335, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1742223790689019100 Content-Type: text/plain; charset="utf-8" The `size` field of the VMStateField with VMS_ARRAY_OF_POINTER flag should stores the size of pointer, which depends on platform. Currently, `*const`, `*mut`, `NonNull`, `Box<>` and their wrapper are supported, and they have the same size as `usize`. Store the size (of `usize`) when VMS_ARRAY_OF_POINTER flag is set. The size may be changed when more smart pointers are supported, but now the size of "usize" is enough. Signed-off-by: Zhao Liu --- rust/qemu-api/src/vmstate.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/rust/qemu-api/src/vmstate.rs b/rust/qemu-api/src/vmstate.rs index e877ee5e391d..5af75b4777e9 100644 --- a/rust/qemu-api/src/vmstate.rs +++ b/rust/qemu-api/src/vmstate.rs @@ -256,6 +256,10 @@ pub const fn with_array_flag(mut self, num: usize) -> = Self { if (self.flags.0 & VMStateFlags::VMS_POINTER.0) !=3D 0 { self.flags =3D VMStateFlags(self.flags.0 & !VMStateFlags::VMS_= POINTER.0); self.flags =3D VMStateFlags(self.flags.0 | VMStateFlags::VMS_A= RRAY_OF_POINTER.0); + // VMS_ARRAY_OF_POINTER flag stores the size of pointer. + // FIXME: *const, *mut, NonNull and Box<> have the same size a= s usize. + // Resize if more smart pointers are supported. + self.size =3D std::mem::size_of::(); } self.flags =3D VMStateFlags(self.flags.0 & !VMStateFlags::VMS_SING= LE.0); self.flags =3D VMStateFlags(self.flags.0 | VMStateFlags::VMS_ARRAY= .0); --=20 2.34.1