From nobody Tue Apr 8 04:57:19 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1741710381; cv=none;
d=zohomail.com; s=zohoarc;
b=XwHDh9t3H4v+WjO20Wfk2srJDDwBp43CC8Fb2CAcbpMN7vjBLRv2PSzqdywIDemMRO2gJcxt9MFf6FwpdbxwxhOFF94bflaj1gsdQdCvpGOlvsDtGkqBldfh9sGWsE+pA7sQ8R+q02UwR/TfV23t23lqLGPu2XyT2wpLCOzBHnA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1741710381;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=ijg+IbW5ZDUV9XuY1BEmdaIm+JELa5s99Z8Jg9OqbXc=;
b=ngGdOFkUpyP6wnucwSrIQdBrhuWjwlrQhHlN+v+itptGuWlLVPB3ITbwB7TOdeulZcNM0J9bK7iWwpCTwF/B/QSxpblGi0TuuBsMff665RmECEsXVwc1DVUxOoAOEYutbh9E7N0OnJehq39zW3MFU3AfXmKa096rbczHNdzmdEI=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<marcandre.lureau@redhat.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1741710381622612.7053389608793;
Tue, 11 Mar 2025 09:26:21 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1ts23I-0004wx-H6; Tue, 11 Mar 2025 12:01:58 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)
id 1ts21v-0003pc-31
for qemu-devel@nongnu.org; Tue, 11 Mar 2025 12:00:31 -0400
Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)
id 1ts21q-0005eN-S2
for qemu-devel@nongnu.org; Tue, 11 Mar 2025 12:00:30 -0400
Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com
(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by
relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,
cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-_BW9SrojOLSI8a8NyiqnWg-1; Tue,
11 Mar 2025 12:00:22 -0400
Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com
(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest
SHA256)
(No client certificate requested)
by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS
id AB1611955D80
for <qemu-devel@nongnu.org>; Tue, 11 Mar 2025 16:00:21 +0000 (UTC)
Received: from localhost (unknown [10.45.242.5])
by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP
id C1045195608F; Tue, 11 Mar 2025 16:00:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1741708826;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=ijg+IbW5ZDUV9XuY1BEmdaIm+JELa5s99Z8Jg9OqbXc=;
b=Z4R5m0/2zmRU04SzPt0wWem/urQYoP8kkBRNbAhBtsmXtHG2ITY3mNNEr9EboWNRzhaOSy
julYyD6rWpRpsnbT9gcuJui/Ycxo+8r4BUVbnyGdx7oRj1lPT4iHlcejY9eUvJy5IQPQ9c
qSSV4k4zwVEKz/n1i1jAUk9RbMg2lYE=
X-MC-Unique: _BW9SrojOLSI8a8NyiqnWg-1
X-Mimecast-MFC-AGG-ID: _BW9SrojOLSI8a8NyiqnWg_1741708821
From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>
Subject: [PATCH for-10.1 05/10] ui/clipboard: delay clipboard update when not
running
Date: Tue, 11 Mar 2025 19:59:27 +0400
Message-ID: <20250311155932.1472092-6-marcandre.lureau@redhat.com>
In-Reply-To: <20250311155932.1472092-1-marcandre.lureau@redhat.com>
References: <20250311155932.1472092-1-marcandre.lureau@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=170.10.133.124;
envelope-from=marcandre.lureau@redhat.com;
helo=us-smtp-delivery-124.mimecast.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,
DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity @redhat.com)
X-ZM-MESSAGEID: 1741710383838019100
From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
When VM is paused, we shouldn't notify of clipboard changes, similar to
how input are being treated.
On unsuspend, notify of the current state.
Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
---
ui/clipboard.c | 40 ++++++++++++++++++++++++++++++++++++++--
1 file changed, 38 insertions(+), 2 deletions(-)
diff --git a/ui/clipboard.c b/ui/clipboard.c
index f5db60c63d..ec00a0b8ec 100644
--- a/ui/clipboard.c
+++ b/ui/clipboard.c
@@ -1,4 +1,5 @@
#include "qemu/osdep.h"
+#include "system/runstate.h"
#include "ui/clipboard.h"
#include "trace.h"
=20
@@ -7,6 +8,10 @@ static NotifierList clipboard_notifiers =3D
=20
static QemuClipboardInfo *cbinfo[QEMU_CLIPBOARD_SELECTION__COUNT];
=20
+static VMChangeStateEntry *cb_change_state_entry =3D NULL;
+
+static bool cb_reset_serial_on_resume =3D false;
+
static const VMStateDescription vmstate_cbcontent =3D {
.name =3D "clipboard/content",
.version_id =3D 0,
@@ -33,8 +38,32 @@ const VMStateDescription vmstate_cbinfo =3D {
}
};
=20
+static void qemu_clipboard_change_state(void *opaque, bool running, RunSta=
te state)
+{
+ int i;
+
+ if (!running) {
+ return;
+ }
+
+ if (cb_reset_serial_on_resume) {
+ qemu_clipboard_reset_serial();
+ }
+
+ for (i =3D 0; i < QEMU_CLIPBOARD_SELECTION__COUNT; i++) {
+ if (cbinfo[i]) {
+ qemu_clipboard_update(cbinfo[i]);
+ }
+ }
+
+}
+
void qemu_clipboard_peer_register(QemuClipboardPeer *peer)
{
+ if (cb_change_state_entry =3D=3D NULL) {
+ cb_change_state_entry =3D qemu_add_vm_change_state_handler(qemu_cl=
ipboard_change_state, NULL);
+ }
+
notifier_list_add(&clipboard_notifiers, &peer->notifier);
}
=20
@@ -109,7 +138,9 @@ void qemu_clipboard_update(QemuClipboardInfo *info)
}
}
=20
- notifier_list_notify(&clipboard_notifiers, ¬ify);
+ if (runstate_is_running() || runstate_check(RUN_STATE_SUSPENDED)) {
+ notifier_list_notify(&clipboard_notifiers, ¬ify);
+ }
=20
if (cbinfo[info->selection] !=3D info) {
qemu_clipboard_info_unref(cbinfo[info->selection]);
@@ -189,7 +220,12 @@ void qemu_clipboard_reset_serial(void)
info->serial =3D 0;
}
}
- notifier_list_notify(&clipboard_notifiers, ¬ify);
+
+ if (runstate_is_running() || runstate_check(RUN_STATE_SUSPENDED)) {
+ notifier_list_notify(&clipboard_notifiers, ¬ify);
+ } else {
+ cb_reset_serial_on_resume =3D true;
+ }
}
=20
void qemu_clipboard_set_data(QemuClipboardPeer *peer,
--=20
2.47.0