From nobody Fri Apr 4 03:40:11 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1741609454; cv=none; d=zohomail.com; s=zohoarc; b=MzcyGC945l2Z6v0ye1CBqHJldyWogaTCIyIyRqV4RzjuxeVfYYsREJ7QEiQxBldCcY2I2VeUcHUHM0eJL0vdhgDsSiK6ldn3mrPLJ6BBMD8Ju2W167ic/SbwjSzVL4AaLnkohF6TLii4bJZ8RqAfrNL0xFpwoj8HBE4gDKu9+uQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1741609454; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4WQlBLlp4ltXr/SfUXVELPpmGEbHirnEhHyZVd5u19w=; b=Hi6Ax9HM3hwJyADuKX+/Mr/WmAdD0xiy709x6ZyIWotw5IvdvhBXvYzT9suNdI4tBl5ApmtdifX+4zb4P2CfHaD6nU2x08fbTt0QT+YjC14Xy+6lS8dtAge1CZCmwORmokWvVLuBSCUI1JfnMCXeK4NYfXMG3/LviF39G6a0Y1k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1741609454296146.51565422363626; Mon, 10 Mar 2025 05:24:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trcA9-0005l1-LB; Mon, 10 Mar 2025 08:23:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trcA4-0005ju-5S for qemu-devel@nongnu.org; Mon, 10 Mar 2025 08:23:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trcA0-0004zG-Iy for qemu-devel@nongnu.org; Mon, 10 Mar 2025 08:23:11 -0400 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-P7ZMbLWWO1O1I9Ymd_ryaA-1; Mon, 10 Mar 2025 08:23:06 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7F3631955DCC; Mon, 10 Mar 2025 12:23:05 +0000 (UTC) Received: from localhost.localdomain (unknown [10.72.112.39]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2FA551800370; Mon, 10 Mar 2025 12:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741609387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4WQlBLlp4ltXr/SfUXVELPpmGEbHirnEhHyZVd5u19w=; b=BZQXhDZbQCQNnyZKkODD4/3pBPZ4dUUmev45UpWry8vNC3HRSQXufZFIJcaDzvdWp2MEKH a0st466CA2p7TCjFt8kV3ri8RJaW2x349VeaS60nFiy2NqdV/pX7MKPGeYpQxtudnNjiUa CH0XsedaIjkE0oKyQvfC9PFsjjhH5zU= X-MC-Unique: P7ZMbLWWO1O1I9Ymd_ryaA-1 X-Mimecast-MFC-AGG-ID: P7ZMbLWWO1O1I9Ymd_ryaA_1741609385 From: Jason Wang To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Jason Wang Subject: [PULL 5/5] tap-linux: Open ipvtap and macvtap Date: Mon, 10 Mar 2025 20:22:40 +0800 Message-ID: <20250310122240.2908-6-jasowang@redhat.com> In-Reply-To: <20250310122240.2908-1-jasowang@redhat.com> References: <20250310122240.2908-1-jasowang@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1741609456590019100 Content-Type: text/plain; charset="utf-8" From: Akihiko Odaki ipvtap and macvtap create a file for each interface unlike tuntap, which creates one file shared by all interfaces. Try to open a file dedicated to the interface first for ipvtap and macvtap. Signed-off-by: Akihiko Odaki Signed-off-by: Jason Wang --- net/tap-linux.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/net/tap-linux.c b/net/tap-linux.c index 1226d5fda2..22ec2f45d2 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -45,10 +45,21 @@ int tap_open(char *ifname, int ifname_size, int *vnet_h= dr, int len =3D sizeof(struct virtio_net_hdr); unsigned int features; =20 - fd =3D RETRY_ON_EINTR(open(PATH_NET_TUN, O_RDWR)); + + ret =3D if_nametoindex(ifname); + if (ret) { + g_autofree char *file =3D g_strdup_printf("/dev/tap%d", ret); + fd =3D open(file, O_RDWR); + } else { + fd =3D -1; + } + if (fd < 0) { - error_setg_errno(errp, errno, "could not open %s", PATH_NET_TUN); - return -1; + fd =3D RETRY_ON_EINTR(open(PATH_NET_TUN, O_RDWR)); + if (fd < 0) { + error_setg_errno(errp, errno, "could not open %s", PATH_NET_TU= N); + return -1; + } } memset(&ifr, 0, sizeof(ifr)); ifr.ifr_flags =3D IFF_TAP | IFF_NO_PI; --=20 2.42.0