From nobody Fri Apr 4 04:11:18 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1741605309; cv=pass;
d=zohomail.com; s=zohoarc;
b=llzNJeuVkkLIY1ULUM/1bJic8sREHC1UuOjKva2nwcLVzs+MWk7DPaC7GyJlC02guaXZbmRd2hzoJo4WTGMY1z62tQzJBtT0QbKaaePMrZsN31gqonyo18L/i12/1I1jtZpCvTO3Qqj8FGweuPM8dyVoTzTwnLDFYfE5HHBlVuY=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1741605309;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=bEdXZ8XsEweXcVfjNo0aOl3uqxA6h51gazlqnvqGS7w=;
b=Jy9aQ07kgLTTN2ie0zQIDz7AwwjD7ZWj6/sFmBqIayxl4e/XgHIczOmq3Xgko6dgMX1t+CYiAyCM172Ws6qf33LCuNw+/+z3f2L64mk1gviBnq2jJrFqQ0kI4ATwvcY8pqLnuFQ3MxMRW9h5ZWpp0Mv0ferbhqIX4JpkP1RTZCM=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1741605309352510.555794946216;
Mon, 10 Mar 2025 04:15:09 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1trb54-0004zc-1Q; Mon, 10 Mar 2025 07:13:58 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb4t-0004sy-Jw
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:13:50 -0400
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb4r-0001N6-Cx
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:13:47 -0400
Received: by mx.zohomail.com with SMTPS id 1741605205999381.665930788457;
Mon, 10 Mar 2025 04:13:25 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1741605210; cv=none;
d=zohomail.com; s=zohoarc;
b=GqkNhMCGYvEud45ljyD6W+J1PEArXo84Eqzkvkx0T1EYpkmsENjGWCPx/mAg0YqYl8DFagq013UvTP5v/v1Nbzerb7Tv/uxm2BA4+79ZA5zewqFciguV6B2h5eNuty6jIcBvBD7IypYRoosePliq0imrxDvTo0MeJ9R3zadEqsM=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1741605210;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=bEdXZ8XsEweXcVfjNo0aOl3uqxA6h51gazlqnvqGS7w=;
b=TBiR+keQ0IGA9f56+XSEtoxChRucD/CevBMAS3R4wb/YKGmG5ItW+6f9acCBoj/BDZ6wFUFRJP4HrYK+9xkqcNHqFpOU2jjvR9tfLVWjUNuzlMqtswXkqPHqQSlRL0UAYge8PJ6yowQVXsQr70UFXNrf0UFgtYSAy5qnltUa1Uw=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741605210;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=bEdXZ8XsEweXcVfjNo0aOl3uqxA6h51gazlqnvqGS7w=;
b=guv4xvvCJyG5KwnkDN3kXQLAwONquO5u3e6D6sZi8pu3UtQLPYrjV4IWlrOgpR0K
ZbZ4Sl2GrVI6bCMVyOPYIeYuglEYnUI9Oe+aeq2cT+p7U2Ixfwhu0ss9hPzFIsb0AZw
5oj3dED5z7GlpA8ve8GNy4Ou0s5j5RLdoKWyckyI=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v10 01/10] ui/sdl2: Restore original context after new context
creation
Date: Mon, 10 Mar 2025 14:12:25 +0300
Message-ID: <20250310111234.145891-2-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
References: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1741605311086019100
SDL API changes GL context to a newly created GL context, which differs
from other GL providers that don't switch context. Change SDL backend to
restore the original GL context. This allows Qemu's virtio-gpu to support
new virglrenderer async-fencing feature for Virgl contexts, otherwise
virglrenderer's vrend creates a fence-sync context on the Qemu's
main-loop thread that erroneously stays in-use by the main-loop after
creation, not allowing vrend's fence-sync thread switch to this new
context that belongs to it.
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
ui/sdl2-gl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c
index e01d9ab0c7bf..b1fe96d6af22 100644
--- a/ui/sdl2-gl.c
+++ b/ui/sdl2-gl.c
@@ -168,6 +168,9 @@ QEMUGLContext sdl2_gl_create_context(DisplayGLCtx *dgc,
SDL_GL_CONTEXT_PROFILE_ES);
ctx =3D SDL_GL_CreateContext(scon->real_window);
}
+
+ SDL_GL_MakeCurrent(scon->real_window, scon->winctx);
+
return (QEMUGLContext)ctx;
}
=20
--=20
2.48.1
From nobody Fri Apr 4 04:11:18 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1741605298; cv=pass;
d=zohomail.com; s=zohoarc;
b=B5y+nDNJdsbaaO6VnLU07oz4wR5AFt6IUtMfbeUS3nIn4fFDuyv964a895wxkzRD5zRWV6U6o74nXMqykw7qp8LQLgwvK5WtYBpmqOh0H5LwBl3Qt1nBWQhiABG7Cg0BUeR+BZWI4qPreE8dGJddR7eTXzAZ7pSA4BmKy740zMM=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1741605298;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=M4pi+UnN5dUEXkVAoFS/FugtivsnTaYh30k+VaQ+ehY=;
b=AGqgEXcDP1sodRLa31WlZqovgpwy2sb6W584tL5uYKlYGXB+f6wFIa0Aekr7QKRauJ7nMen6aqfFVSeSXAHF0SoaZbmoRN9PWEjQ7KcqRLDXw85WNOb8H5jnr01Lsb7kB5MhKDVNRtyhgl+qnB+sxcg16CyqPWDxHr0MBuDRg2Q=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1741605298748701.4783478360998;
Mon, 10 Mar 2025 04:14:58 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1trb57-00050A-0e; Mon, 10 Mar 2025 07:14:02 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb50-0004y3-Fn
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:13:56 -0400
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb4t-0001NF-Ck
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:13:52 -0400
Received: by mx.zohomail.com with SMTPS id 1741605211585123.34637938179242;
Mon, 10 Mar 2025 04:13:31 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1741605213; cv=none;
d=zohomail.com; s=zohoarc;
b=XWo3sZ5gh1pDH/PW/z0Fu8gtgmtwdWrwtLU+OYz6a+fKJ5wgdahuCLkJDfCW10vyGe9WOsVcpNNc3uqC0R5XQZqOhYtQ/11HXbkTufK4QyxQMui+BK5GVm2zaj78OASn64wHCUdUD+CmDyCestUZUbAl5t+dQZ0EKXpERjzGpRg=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1741605213;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=M4pi+UnN5dUEXkVAoFS/FugtivsnTaYh30k+VaQ+ehY=;
b=mbBZOn3gnqzaVEfqe9rbsNF0+oHh+z70Ow8HkV2azSFxY5TEIeIkht0NRuc5Z4ODCcGsJFZBfYaCIYVDeWSe/GkNtqvVWa96ZM+yk2tOyLI8PfVkkm0zKfDSO3THfQGQPkmkWXgA40Tn6CvKRcIMDxeKwTXfaHkjJJiu23VulGg=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741605213;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=M4pi+UnN5dUEXkVAoFS/FugtivsnTaYh30k+VaQ+ehY=;
b=J+uJiFqDP59+gdspu4Saz3abba7wRsgieoI3AuFAjZUr/xZ+GuCdBNp4lACP5s3d
HVIAvw/KAEVmvlffRUgcTS+oXB+FEecoEvcU1YW2xdaTZAbBmBXMuQobDvQBbFE5Es1
PHjcS9TB8wJs4xvnPRptRrylPlzRFi/dAnT/MY88=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v10 02/10] ui/sdl2: Implement dpy dmabuf functions
Date: Mon, 10 Mar 2025 14:12:26 +0300
Message-ID: <20250310111234.145891-3-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
References: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1741605301440019100
From: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
If EGL is used, we can rely on dmabuf to import textures without
doing copies.
To get this working on X11, we use the existing SDL hint:
SDL_HINT_VIDEO_X11_FORCE_EGL (because dmabuf can't be used with GLX).
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Signed-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.c=
om>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
include/ui/sdl2.h | 7 ++++++
meson.build | 6 ++---
ui/sdl2-gl.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++
ui/sdl2.c | 42 +++++++++++++++++++++++++++++++
4 files changed, 115 insertions(+), 4 deletions(-)
diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h
index dbe6e3d9739b..9daf5ecffae7 100644
--- a/include/ui/sdl2.h
+++ b/include/ui/sdl2.h
@@ -45,6 +45,7 @@ struct sdl2_console {
bool gui_keysym;
SDL_GLContext winctx;
QKbdState *kbd;
+ bool has_dmabuf;
#ifdef CONFIG_OPENGL
QemuGLShader *gls;
egl_fb guest_fb;
@@ -96,5 +97,11 @@ void sdl2_gl_scanout_texture(DisplayChangeListener *dcl,
void *d3d_tex2d);
void sdl2_gl_scanout_flush(DisplayChangeListener *dcl,
uint32_t x, uint32_t y, uint32_t w, uint32_t h);
+void sdl2_gl_scanout_dmabuf(DisplayChangeListener *dcl,
+ QemuDmaBuf *dmabuf);
+void sdl2_gl_release_dmabuf(DisplayChangeListener *dcl,
+ QemuDmaBuf *dmabuf);
+bool sdl2_gl_has_dmabuf(DisplayChangeListener *dcl);
+void sdl2_gl_console_init(struct sdl2_console *scon);
=20
#endif /* SDL2_H */
diff --git a/meson.build b/meson.build
index 8b9fda4d95e6..c0b5f1ccc026 100644
--- a/meson.build
+++ b/meson.build
@@ -1966,10 +1966,8 @@ if get_option('gtk') \
endif
endif
=20
-x11 =3D not_found
-if gtkx11.found()
- x11 =3D dependency('x11', method: 'pkg-config', required: gtkx11.found())
-endif
+x11 =3D dependency('x11', method: 'pkg-config', required: gtkx11.found())
+
png =3D not_found
if get_option('png').allowed() and have_system
png =3D dependency('libpng', version: '>=3D1.6.34', required: get_optio=
n('png'),
diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c
index b1fe96d6af22..8d53e340d40d 100644
--- a/ui/sdl2-gl.c
+++ b/ui/sdl2-gl.c
@@ -26,6 +26,8 @@
*/
=20
#include "qemu/osdep.h"
+#include "qemu/main-loop.h"
+#include "qemu/error-report.h"
#include "ui/console.h"
#include "ui/input.h"
#include "ui/sdl2.h"
@@ -249,3 +251,65 @@ void sdl2_gl_scanout_flush(DisplayChangeListener *dcl,
=20
SDL_GL_SwapWindow(scon->real_window);
}
+
+void sdl2_gl_scanout_dmabuf(DisplayChangeListener *dcl,
+ QemuDmaBuf *dmabuf)
+{
+ struct sdl2_console *scon =3D container_of(dcl, struct sdl2_console, d=
cl);
+
+ assert(scon->opengl);
+ SDL_GL_MakeCurrent(scon->real_window, scon->winctx);
+
+ egl_dmabuf_import_texture(dmabuf);
+ if (!qemu_dmabuf_get_texture(dmabuf)) {
+ error_report("%s: failed fd=3D%d", __func__, qemu_dmabuf_get_fd(dm=
abuf));
+ return;
+ }
+
+ sdl2_gl_scanout_texture(dcl, qemu_dmabuf_get_texture(dmabuf), false,
+ qemu_dmabuf_get_width(dmabuf),
+ qemu_dmabuf_get_height(dmabuf),
+ 0, 0,
+ qemu_dmabuf_get_width(dmabuf),
+ qemu_dmabuf_get_height(dmabuf),
+ NULL);
+
+ if (qemu_dmabuf_get_allow_fences(dmabuf)) {
+ scon->guest_fb.dmabuf =3D dmabuf;
+ }
+}
+
+void sdl2_gl_release_dmabuf(DisplayChangeListener *dcl,
+ QemuDmaBuf *dmabuf)
+{
+ egl_dmabuf_release_texture(dmabuf);
+}
+
+bool sdl2_gl_has_dmabuf(DisplayChangeListener *dcl)
+{
+ struct sdl2_console *scon =3D container_of(dcl, struct sdl2_console, d=
cl);
+
+ return scon->has_dmabuf;
+}
+
+void sdl2_gl_console_init(struct sdl2_console *scon)
+{
+ bool hidden =3D scon->hidden;
+
+ scon->hidden =3D true;
+ scon->surface =3D qemu_create_displaysurface(1, 1);
+ sdl2_window_create(scon);
+
+ /*
+ * QEMU checks whether console supports dma-buf before switching
+ * to the console. To break this chicken-egg problem we pre-check
+ * dma-buf availability beforehand using a dummy SDL window.
+ */
+ scon->has_dmabuf =3D qemu_egl_has_dmabuf();
+
+ sdl2_window_destroy(scon);
+ qemu_free_displaysurface(scon->surface);
+
+ scon->surface =3D NULL;
+ scon->hidden =3D hidden;
+}
diff --git a/ui/sdl2.c b/ui/sdl2.c
index cda4293a53e6..943974544343 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -35,6 +35,10 @@
#include "qemu/log.h"
#include "qemu-main.h"
=20
+#ifdef CONFIG_X11
+#include <X11/Xlib.h>
+#endif
+
static int sdl2_num_outputs;
static struct sdl2_console *sdl2_console;
=20
@@ -120,6 +124,9 @@ void sdl2_window_create(struct sdl2_console *scon)
/* The SDL renderer is only used by sdl2-2D, when OpenGL is disabl=
ed */
scon->real_renderer =3D SDL_CreateRenderer(scon->real_window, -1, =
0);
}
+
+ qemu_egl_display =3D eglGetCurrentDisplay();
+
sdl_update_caption(scon);
}
=20
@@ -798,6 +805,10 @@ static const DisplayChangeListenerOps dcl_gl_ops =3D {
.dpy_gl_scanout_disable =3D sdl2_gl_scanout_disable,
.dpy_gl_scanout_texture =3D sdl2_gl_scanout_texture,
.dpy_gl_update =3D sdl2_gl_scanout_flush,
+
+ .dpy_gl_scanout_dmabuf =3D sdl2_gl_scanout_dmabuf,
+ .dpy_gl_release_dmabuf =3D sdl2_gl_release_dmabuf,
+ .dpy_has_dmabuf =3D sdl2_gl_has_dmabuf,
};
=20
static bool
@@ -825,6 +836,35 @@ static void sdl2_display_early_init(DisplayOptions *o)
}
}
=20
+static void sdl2_set_hint_x11_force_egl(void)
+{
+#if defined(SDL_HINT_VIDEO_X11_FORCE_EGL) && defined(CONFIG_OPENGL) && \
+ defined(CONFIG_X11)
+ Display *x_disp =3D XOpenDisplay(NULL);
+ EGLDisplay egl_display;
+
+ if (!x_disp) {
+ return;
+ }
+
+ /* Prefer EGL over GLX to get dma-buf support. */
+ egl_display =3D eglGetDisplay((EGLNativeDisplayType)x_disp);
+
+ if (egl_display !=3D EGL_NO_DISPLAY) {
+ /*
+ * Setting X11_FORCE_EGL hint doesn't make SDL to prefer X11 over
+ * Wayland. SDL will use Wayland driver even if XWayland presents.
+ * It's always safe to set the hint even if X11 is not used by SDL.
+ * SDL will work regardless of the hint.
+ */
+ SDL_SetHint(SDL_HINT_VIDEO_X11_FORCE_EGL, "1");
+ eglTerminate(egl_display);
+ }
+
+ XCloseDisplay(x_disp);
+#endif
+}
+
static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
{
uint8_t data =3D 0;
@@ -852,6 +892,7 @@ static void sdl2_display_init(DisplayState *ds, Display=
Options *o)
SDL_SetHint(SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED, "0");
#endif
SDL_SetHint(SDL_HINT_WINDOWS_NO_CLOSE_ON_ALT_F4, "1");
+ sdl2_set_hint_x11_force_egl();
SDL_EnableScreenSaver();
memset(&info, 0, sizeof(info));
SDL_VERSION(&info.version);
@@ -898,6 +939,7 @@ static void sdl2_display_init(DisplayState *ds, Display=
Options *o)
sdl2_console[i].kbd =3D qkbd_state_init(con);
if (display_opengl) {
qemu_console_set_display_gl_ctx(con, &sdl2_console[i].dgc);
+ sdl2_gl_console_init(&sdl2_console[i]);
}
register_displaychangelistener(&sdl2_console[i].dcl);
=20
--=20
2.48.1
From nobody Fri Apr 4 04:11:18 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1741605272; cv=pass;
d=zohomail.com; s=zohoarc;
b=nZ0a+Nrcjn3+odCLzDmrxvoI4J0rkmYQHIijvFhCqEnwQKIsgRCUSphQYWNKZFudxj7Wf32nY7asHwhJJKTmvzhEsAEL5DBVcIS9h4tb6mGlIkEtaqa9QXaiEscIxd16F4WJtnqWcgDgoMrLbf4IsOzoaPi+DZMXkfvRRUTOcDk=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1741605272;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=MhKxg8KhlFdU/0zGr+2oG+QDo2bkuViXKalTtQT6/Ck=;
b=UE7S0zyPUAddCZoPR2qEmaXmj6u9oYcHTQTbAHet+4MS7TRd0BtVUQiI5U5jPTdFRdROGDvnjSPdgFMnnGyRcabN1AObv3kGZMDhkSvoHb7XlxwrrMtX3eb676uMMuU8Q84OiS3vN3c2ABFCBKPwcYl7LqIukQ6dj7woz4aLBn0=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 174160527245075.79279917902613;
Mon, 10 Mar 2025 04:14:32 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1trb5B-000560-C1; Mon, 10 Mar 2025 07:14:05 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb53-0004z5-3g
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:13:57 -0400
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb51-0001O3-75
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:13:56 -0400
Received: by mx.zohomail.com with SMTPS id 1741605217692106.84497883286292;
Mon, 10 Mar 2025 04:13:37 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1741605219; cv=none;
d=zohomail.com; s=zohoarc;
b=Yy9IIopbkqPbtgm5NzA7jG/Trg6s0W957f4zAfYiqXqWwMBFu2kGtc4TCvtkgU80KkAd17UnQ40LukT5D1mjBtoA9VFNMdUkTfdfNYG9wOc1V/UR8NAJA4NDG1x4QKRw39DbkM23FbCk2lvzFr0h+ogkyhaZ8DBmx67b1QfahGQ=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1741605219;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=MhKxg8KhlFdU/0zGr+2oG+QDo2bkuViXKalTtQT6/Ck=;
b=cMWyuntJ9mn8Id3FxAsYnWLyxvO2L6rpZ5rIVCgw7Gbee2IuI3FSg667kUgXwP5fnlODxOcS53OYJ2viDW/jeas4581mbqOKez4NGzCIvbhAu4qwvSOrzSNJ8dAWxnv/SnsJpvzFsI/KUb8iPjHdKCleMpELCnpqugF3MUtkfNs=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741605219;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=MhKxg8KhlFdU/0zGr+2oG+QDo2bkuViXKalTtQT6/Ck=;
b=XbJIxVSSlI0Pqn2aMr3OcvPPj8HD0R98TYjF7URH/Lh00vvwIhOLAE6y+7qoGiNE
OSXNWF+K8/dNc3o641LeTniaHIf53KjyG4QBvth5veVigDaiHB79z8N1uLhg6mHT7kz
4dZz2Q+svxXRytpdh2lT6Y9hOY8in5VMo79GVCZk=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v10 03/10] virtio-gpu: Handle virgl fence creation errors
Date: Mon, 10 Mar 2025 14:12:27 +0300
Message-ID: <20250310111234.145891-4-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
References: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1741605274248019000
Print out error messages when virgl fence creation fails to aid debugging
of the fence-related bugs.
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
hw/display/virtio-gpu-virgl.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c
index 145a0b387956..2eb6aaab4e84 100644
--- a/hw/display/virtio-gpu-virgl.c
+++ b/hw/display/virtio-gpu-virgl.c
@@ -872,6 +872,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
struct virtio_gpu_ctrl_command *cmd)
{
bool cmd_suspended =3D false;
+ int ret;
=20
VIRTIO_GPU_FILL_CMD(cmd->cmd_hdr);
=20
@@ -970,7 +971,17 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
}
=20
trace_virtio_gpu_fence_ctrl(cmd->cmd_hdr.fence_id, cmd->cmd_hdr.type);
- virgl_renderer_create_fence(cmd->cmd_hdr.fence_id, cmd->cmd_hdr.type);
+
+ /*
+ * Unlike other virglrenderer functions, this one returns a positive
+ * error code.
+ */
+ ret =3D virgl_renderer_create_fence(cmd->cmd_hdr.fence_id, 0);
+ if (ret) {
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "%s: virgl_renderer_create_fence error: %s",
+ __func__, strerror(ret));
+ }
}
=20
static void virgl_write_fence(void *opaque, uint32_t fence)
--=20
2.48.1
From nobody Fri Apr 4 04:11:18 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1741605289; cv=pass;
d=zohomail.com; s=zohoarc;
b=gm1pewOylNmUGONyZtyfIaXrBxaNVK5dVpRVp9KMJdvHyYA/RWdEXMnsca+mnE3rMNAGJrZ8KoNdGKVeBOF+BqODhP6mx8UdaU5eGYV+zTGPgdjRhCOQSiaEydS2sJciPwxRIvY+UaXT3S2nvURzinVS8taZ4YSUCZe6Av3dqRs=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1741605289;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=Hej6mWYgpW41fDB3UbZ/wzMu6eoGmKcFAugjQBMZPSw=;
b=eFiWABHJx5WZEN16tR7OE6MZfkqEc568D3diF4VVZgBocmcVxZZZeDkhyzWEYbJVtD5C/pu9o9hMRoWTFHOGLzUFMiJ9XXa6aJ7k1cHBCmyxvwsDaAvv/z3NsDiLI3iQRNCuN1X05VtPhZ4xd4HC8X4X12FHzFJ4Mgl6W5Nisvc=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1741605289237654.9608085606352;
Mon, 10 Mar 2025 04:14:49 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1trb5T-0005MT-04; Mon, 10 Mar 2025 07:14:23 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5M-0005CV-Ps
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:17 -0400
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5J-0001PY-Lr
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:15 -0400
Received: by mx.zohomail.com with SMTPS id 1741605223331970.7523035776438;
Mon, 10 Mar 2025 04:13:43 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1741605241; cv=none;
d=zohomail.com; s=zohoarc;
b=aHWq7ennKBdNtokRA/jKBh7WBIK2Oyh6TVPT21iJYU6lyKIjcHccyAoLSHmbzyQ4aWqcbvNdOH3AsRP6//OYJWhXdAO/xHubVh1CHckRHMQDYY1b5FraNLrtTVTI9G1jghYgl0jx1mC9rbw+yqCxzyYXT/kiWlJVH9te6ohFFmQ=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1741605241;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=Hej6mWYgpW41fDB3UbZ/wzMu6eoGmKcFAugjQBMZPSw=;
b=ZkC0f8rbKKN4rY6HgjMVwsar3GYySbRPxyJLH7fpOLFYbOYbIoORNrPHyHNLbufpeKsSjdAjsfDRPiTfD0Qdqk0it0rwr3D7P1Mi1FRL6FV3ApDRcTPKQ6mYSzj9WUNSeIQEiDBCipSrO0T/6X2/9CEeZysKMHiDWwCmrN7F4UM=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741605241;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=Hej6mWYgpW41fDB3UbZ/wzMu6eoGmKcFAugjQBMZPSw=;
b=iTaX31aunAdSaO9A96+8hIR9X3t3QQ50SJY+31m3NodEqmLrbjwtIVkjrIuI3TIO
Yf3JJbfpRQddN+QzRI1skYwy6zMA6C9tjNPasWc9vGp3PGSB7DPw79nFItn41ZGSQ3d
oopiS1fX1GivTknmCHanLHa7zhfcJCKLrbkPI1uI=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v10 04/10] virtio-gpu: Support asynchronous fencing
Date: Mon, 10 Mar 2025 14:12:28 +0300
Message-ID: <20250310111234.145891-5-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
References: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1741605291211019100
Support asynchronous fencing feature of virglrenderer. It allows Qemu to
handle fence as soon as it's signalled instead of periodically polling
the fence status. This feature is required for enabling DRM context
support in Qemu because legacy fencing mode isn't supported for DRM
contexts in virglrenderer.
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Reviewed-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
hw/display/virtio-gpu-gl.c | 3 +
hw/display/virtio-gpu-virgl.c | 147 +++++++++++++++++++++++++++++++--
include/hw/virtio/virtio-gpu.h | 13 +++
3 files changed, 154 insertions(+), 9 deletions(-)
diff --git a/hw/display/virtio-gpu-gl.c b/hw/display/virtio-gpu-gl.c
index 683fad3bf8a8..d9bb50ac1d4a 100644
--- a/hw/display/virtio-gpu-gl.c
+++ b/hw/display/virtio-gpu-gl.c
@@ -169,6 +169,9 @@ static void virtio_gpu_gl_device_unrealize(DeviceState =
*qdev)
if (gl->renderer_state >=3D RS_INITED) {
#if VIRGL_VERSION_MAJOR >=3D 1
qemu_bh_delete(gl->cmdq_resume_bh);
+
+ virtio_gpu_virgl_reset_async_fences(g);
+ qemu_bh_delete(gl->async_fence_bh);
#endif
if (virtio_gpu_stats_enabled(g->parent_obj.conf)) {
timer_free(gl->print_stats);
diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c
index 2eb6aaab4e84..ee896eced67c 100644
--- a/hw/display/virtio-gpu-virgl.c
+++ b/hw/display/virtio-gpu-virgl.c
@@ -871,6 +871,7 @@ static void virgl_cmd_set_scanout_blob(VirtIOGPU *g,
void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
struct virtio_gpu_ctrl_command *cmd)
{
+ VirtIOGPUGL *gl =3D VIRTIO_GPU_GL(g);
bool cmd_suspended =3D false;
int ret;
=20
@@ -972,15 +973,34 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
=20
trace_virtio_gpu_fence_ctrl(cmd->cmd_hdr.fence_id, cmd->cmd_hdr.type);
=20
- /*
- * Unlike other virglrenderer functions, this one returns a positive
- * error code.
- */
- ret =3D virgl_renderer_create_fence(cmd->cmd_hdr.fence_id, 0);
- if (ret) {
- qemu_log_mask(LOG_GUEST_ERROR,
- "%s: virgl_renderer_create_fence error: %s",
- __func__, strerror(ret));
+ if (gl->context_fence_enabled &&
+ (cmd->cmd_hdr.flags & VIRTIO_GPU_FLAG_INFO_RING_IDX)) {
+#if VIRGL_VERSION_MAJOR >=3D 1
+ uint32_t flags =3D 0;
+
+ ret =3D virgl_renderer_context_create_fence(cmd->cmd_hdr.ctx_id, f=
lags,
+ cmd->cmd_hdr.ring_idx,
+ cmd->cmd_hdr.fence_id);
+ if (ret) {
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "%s: virgl_renderer_context_create_fence error: =
%s",
+ __func__, strerror(-ret));
+ }
+#else
+ /* gl->context_fence_enabled cannot be set with older virglrendere=
r */
+ g_assert_not_reached();
+#endif
+ } else {
+ /*
+ * Unlike other virglrenderer functions, this one returns a positi=
ve
+ * error code.
+ */
+ ret =3D virgl_renderer_create_fence(cmd->cmd_hdr.fence_id, 0);
+ if (ret) {
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "%s: virgl_renderer_create_fence error: %s",
+ __func__, strerror(ret));
+ }
}
}
=20
@@ -1008,6 +1028,102 @@ static void virgl_write_fence(void *opaque, uint32_=
t fence)
}
}
=20
+void virtio_gpu_virgl_reset_async_fences(VirtIOGPU *g)
+{
+ struct virtio_gpu_virgl_context_fence *f;
+ VirtIOGPUGL *gl =3D VIRTIO_GPU_GL(g);
+
+ while (!QSLIST_EMPTY(&gl->async_fenceq)) {
+ f =3D QSLIST_FIRST(&gl->async_fenceq);
+
+ QSLIST_REMOVE_HEAD(&gl->async_fenceq, next);
+
+ g_free(f);
+ }
+}
+
+#if VIRGL_VERSION_MAJOR >=3D 1
+static void virtio_gpu_virgl_async_fence_bh(void *opaque)
+{
+ QSLIST_HEAD(, virtio_gpu_virgl_context_fence) async_fenceq;
+ struct virtio_gpu_ctrl_command *cmd, *tmp;
+ struct virtio_gpu_virgl_context_fence *f;
+ VirtIOGPU *g =3D opaque;
+ VirtIOGPUGL *gl =3D VIRTIO_GPU_GL(g);
+
+ QSLIST_MOVE_ATOMIC(&async_fenceq, &gl->async_fenceq);
+
+ while (!QSLIST_EMPTY(&async_fenceq)) {
+ f =3D QSLIST_FIRST(&async_fenceq);
+
+ QSLIST_REMOVE_HEAD(&async_fenceq, next);
+
+ QTAILQ_FOREACH_SAFE(cmd, &g->fenceq, next, tmp) {
+ /*
+ * the guest can end up emitting fences out of order
+ * so we should check all fenced cmds not just the first one.
+ */
+ if (cmd->cmd_hdr.fence_id > f->fence_id) {
+ continue;
+ }
+ if (cmd->cmd_hdr.flags & VIRTIO_GPU_FLAG_INFO_RING_IDX) {
+ if (cmd->cmd_hdr.ring_idx !=3D f->ring_idx) {
+ continue;
+ }
+ if (cmd->cmd_hdr.ctx_id !=3D f->ctx_id) {
+ continue;
+ }
+ } else if (f->ring_idx >=3D 0) {
+ /* ctx0 GL-query fences don't have ring info */
+ continue;
+ }
+ virtio_gpu_ctrl_response_nodata(g, cmd, VIRTIO_GPU_RESP_OK_NOD=
ATA);
+ QTAILQ_REMOVE(&g->fenceq, cmd, next);
+ g_free(cmd);
+ }
+
+ trace_virtio_gpu_fence_resp(f->fence_id);
+ g_free(f);
+ g->inflight--;
+ if (virtio_gpu_stats_enabled(g->parent_obj.conf)) {
+ trace_virtio_gpu_dec_inflight_fences(g->inflight);
+ }
+ }
+}
+
+static void
+virtio_gpu_virgl_push_async_fence(VirtIOGPU *g, uint32_t ctx_id,
+ int64_t ring_idx, uint64_t fence_id)
+{
+ struct virtio_gpu_virgl_context_fence *f;
+ VirtIOGPUGL *gl =3D VIRTIO_GPU_GL(g);
+
+ f =3D g_new(struct virtio_gpu_virgl_context_fence, 1);
+ f->ctx_id =3D ctx_id;
+ f->ring_idx =3D ring_idx;
+ f->fence_id =3D fence_id;
+
+ QSLIST_INSERT_HEAD_ATOMIC(&gl->async_fenceq, f, next);
+
+ qemu_bh_schedule(gl->async_fence_bh);
+}
+
+static void virgl_write_async_fence(void *opaque, uint32_t fence)
+{
+ VirtIOGPU *g =3D opaque;
+
+ virtio_gpu_virgl_push_async_fence(g, 0, -1, fence);
+}
+
+static void virgl_write_async_context_fence(void *opaque, uint32_t ctx_id,
+ uint32_t ring_idx, uint64_t fe=
nce)
+{
+ VirtIOGPU *g =3D opaque;
+
+ virtio_gpu_virgl_push_async_fence(g, ctx_id, ring_idx, fence);
+}
+#endif
+
static virgl_renderer_gl_context
virgl_create_context(void *opaque, int scanout_idx,
struct virgl_renderer_gl_ctx_param *params)
@@ -1095,6 +1211,8 @@ void virtio_gpu_virgl_reset_scanout(VirtIOGPU *g)
dpy_gfx_replace_surface(g->parent_obj.scanout[i].con, NULL);
dpy_gl_scanout_disable(g->parent_obj.scanout[i].con);
}
+
+ virtio_gpu_virgl_reset_async_fences(g);
}
=20
void virtio_gpu_virgl_reset(VirtIOGPU *g)
@@ -1112,6 +1230,13 @@ int virtio_gpu_virgl_init(VirtIOGPU *g)
if (qemu_egl_display) {
virtio_gpu_3d_cbs.version =3D 4;
virtio_gpu_3d_cbs.get_egl_display =3D virgl_get_egl_display;
+#if VIRGL_VERSION_MAJOR >=3D 1
+ virtio_gpu_3d_cbs.write_fence =3D virgl_write_async_fence;
+ virtio_gpu_3d_cbs.write_context_fence =3D virgl_write_async_contex=
t_fence;
+ flags |=3D VIRGL_RENDERER_ASYNC_FENCE_CB;
+ flags |=3D VIRGL_RENDERER_THREAD_SYNC;
+ gl->context_fence_enabled =3D true;
+#endif
}
#endif
#ifdef VIRGL_RENDERER_D3D11_SHARE_TEXTURE
@@ -1145,6 +1270,10 @@ int virtio_gpu_virgl_init(VirtIOGPU *g)
gl->cmdq_resume_bh =3D aio_bh_new(qemu_get_aio_context(),
virtio_gpu_virgl_resume_cmdq_bh,
g);
+
+ gl->async_fence_bh =3D aio_bh_new(qemu_get_aio_context(),
+ virtio_gpu_virgl_async_fence_bh,
+ g);
#endif
=20
return 0;
diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index a42957c4e2cc..bd2cccdc60d7 100644
--- a/include/hw/virtio/virtio-gpu.h
+++ b/include/hw/virtio/virtio-gpu.h
@@ -230,6 +230,13 @@ struct VirtIOGPUClass {
Error **errp);
};
=20
+struct virtio_gpu_virgl_context_fence {
+ uint32_t ctx_id;
+ int64_t ring_idx;
+ uint64_t fence_id;
+ QSLIST_ENTRY(virtio_gpu_virgl_context_fence) next;
+};
+
/* VirtIOGPUGL renderer states */
typedef enum {
RS_START, /* starting state */
@@ -247,6 +254,11 @@ struct VirtIOGPUGL {
QEMUTimer *print_stats;
=20
QEMUBH *cmdq_resume_bh;
+
+ QEMUBH *async_fence_bh;
+ QSLIST_HEAD(, virtio_gpu_virgl_context_fence) async_fenceq;
+
+ bool context_fence_enabled;
};
=20
struct VhostUserGPU {
@@ -376,5 +388,6 @@ void virtio_gpu_virgl_reset_scanout(VirtIOGPU *g);
void virtio_gpu_virgl_reset(VirtIOGPU *g);
int virtio_gpu_virgl_init(VirtIOGPU *g);
GArray *virtio_gpu_virgl_get_capsets(VirtIOGPU *g);
+void virtio_gpu_virgl_reset_async_fences(VirtIOGPU *g);
=20
#endif
--=20
2.48.1
From nobody Fri Apr 4 04:11:18 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1741605288; cv=pass;
d=zohomail.com; s=zohoarc;
b=L/NziUjf2rUhHnvjdhw4+RhzLMR2azWQ5oelGcD7Vexls7KBbGh1oo+GttJxs2i+vGb+uiydSIJ92gMrJnjMLJLNOs82NCpZOXy0vIt6fwnEbvyVPynyP585przMnCNJdRkvmRspqAKKs7Qp3S5zfB7CEabrywVP2G/72ADXIxM=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1741605288;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=pygFRisAQ59d6C3E1zmX+5bDnZem2wfFu0UhBK1SqvI=;
b=ioAIsizlrmfs2dx4K2PK2DZ5XxeJeg7a0Zvx+0RedKyb53170ej8oaAus+9PtdAfG8LUjW/KRUd1QB00jGLuvzuh64x6C1VzjkPrPh6d+bsTi22ZLoB8oRP+hTqBiR0FBOIFRgwFrI0/wZ+rE4mFKt1acgFvhQ62SsvTwfLt8iA=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1741605288092139.36903300038978;
Mon, 10 Mar 2025 04:14:48 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1trb5Z-0005ia-Lk; Mon, 10 Mar 2025 07:14:29 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5V-0005Yz-Ro
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:26 -0400
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5S-0001QW-H9
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:25 -0400
Received: by mx.zohomail.com with SMTPS id 1741605244180478.27510309345746;
Mon, 10 Mar 2025 04:14:04 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1741605247; cv=none;
d=zohomail.com; s=zohoarc;
b=Rx5lT/Hf0qFSmFkbaxz7+OOtray4B4SDwJxu7eKz3Z1oU3L9463fsiSqBjLHkTQk0IhQ5IotsHi+RT3+ADEl9DSlVsTyY8azNG5vWcfhOM+de+q+ojbSI22GfkkPb+4P43CdWLj7/m+0favaaZk8M6Bq0WTamE5BstBAywXu8xw=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1741605247;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=pygFRisAQ59d6C3E1zmX+5bDnZem2wfFu0UhBK1SqvI=;
b=GHQLXJQqJMdYgrul+px7pfebEAyEKp/KF2OCDfdj0EUfHjxBMPwpY6A9vKs1Vf+xrJ+IYPbtlgRfxT2ovqUGWqIBV1r8uvlkNTVgeLDTz/CMibF9Jkn7BtsVZTowLOph02KWgHSmtoqTpFVQJAnreV5EjZDCQTHe+w3KhIpBfhw=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741605247;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=pygFRisAQ59d6C3E1zmX+5bDnZem2wfFu0UhBK1SqvI=;
b=hzCtKVA0msX3lF2KO1f+6N135ZkDEBmm5BB+dA2i05HCZ7Q/wqbzDRPzmNlRAGzn
KP2W/d46ANnXebAee6BfgPoJQ71qQK6+dvTGO2dWuzVYlzoe/tUFpptI9O/VcGgj8Qo
vZqQ784UUFk2eGPQXSe9TSpHOcd154HjPUqb1Z64=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v10 05/10] virtio-gpu: Support DRM native context
Date: Mon, 10 Mar 2025 14:12:29 +0300
Message-ID: <20250310111234.145891-6-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
References: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1741605295258019100
Add support for DRM native contexts to VirtIO-GPU. DRM context is enabled
using a new virtio-gpu-gl device option "drm_native_context=3Don".
Unlike Virgl and Venus contexts that operate on application API level,
DRM native contexts work on a kernel UAPI level. This lower level results
in a lightweight context implementations that yield better performance.
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
docs/system/devices/virtio-gpu.rst | 11 +++++++++++
hw/display/virtio-gpu-gl.c | 2 ++
hw/display/virtio-gpu-virgl.c | 22 ++++++++++++++++++++++
hw/display/virtio-gpu.c | 15 +++++++++++++++
include/hw/virtio/virtio-gpu.h | 3 +++
5 files changed, 53 insertions(+)
diff --git a/docs/system/devices/virtio-gpu.rst b/docs/system/devices/virti=
o-gpu.rst
index b7eb0fc0e727..f20c60016376 100644
--- a/docs/system/devices/virtio-gpu.rst
+++ b/docs/system/devices/virtio-gpu.rst
@@ -82,6 +82,17 @@ of virtio-gpu host memory window. This is typically betw=
een 256M and 8G.
=20
.. _venus: https://gitlab.freedesktop.org/virgl/venus-protocol/
=20
+DRM native context is supported since release of `virglrenderer`_ v1.0.0
+using `drm`_ protocol. ``DRM`` virtio-gpu capability set ("capset") requi=
res
+host blob support (``hostmem`` and ``blob`` fields) and should be enabled
+using ``drm_native_context`` field. The ``hostmem`` field specifies the s=
ize
+of virtio-gpu host memory window. This is typically between 256M and 8G.
+
+.. parsed-literal::
+ -device virtio-gpu-gl,hostmem=3D8G,blob=3Don,drm_native_context=3Don
+
+.. _drm: https://gitlab.freedesktop.org/virgl/virglrenderer/-/tree/main/sr=
c/drm
+
virtio-gpu rutabaga
-------------------
=20
diff --git a/hw/display/virtio-gpu-gl.c b/hw/display/virtio-gpu-gl.c
index d9bb50ac1d4a..5f374ad56396 100644
--- a/hw/display/virtio-gpu-gl.c
+++ b/hw/display/virtio-gpu-gl.c
@@ -159,6 +159,8 @@ static const Property virtio_gpu_gl_properties[] =3D {
VIRTIO_GPU_FLAG_STATS_ENABLED, false),
DEFINE_PROP_BIT("venus", VirtIOGPU, parent_obj.conf.flags,
VIRTIO_GPU_FLAG_VENUS_ENABLED, false),
+ DEFINE_PROP_BIT("drm_native_context", VirtIOGPU, parent_obj.conf.flags,
+ VIRTIO_GPU_FLAG_DRM_ENABLED, false),
};
=20
static void virtio_gpu_gl_device_unrealize(DeviceState *qdev)
diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c
index ee896eced67c..184ad2c588f7 100644
--- a/hw/display/virtio-gpu-virgl.c
+++ b/hw/display/virtio-gpu-virgl.c
@@ -1248,6 +1248,19 @@ int virtio_gpu_virgl_init(VirtIOGPU *g)
if (virtio_gpu_venus_enabled(g->parent_obj.conf)) {
flags |=3D VIRGL_RENDERER_VENUS | VIRGL_RENDERER_RENDER_SERVER;
}
+ if (virtio_gpu_drm_enabled(g->parent_obj.conf)) {
+ flags |=3D VIRGL_RENDERER_DRM;
+
+ if (!gl->context_fence_enabled) {
+ /*
+ * Virglrenderer skips enabling DRM context support without
+ * enabled async-fence feature. VirtIO-GPU will initialize
+ * successfully, but DRM context won't be available in guest.
+ */
+ error_report("DRM native context requires EGL display");
+ return -EINVAL;
+ }
+ }
#endif
=20
ret =3D virgl_renderer_init(g, flags, &virtio_gpu_3d_cbs);
@@ -1310,5 +1323,14 @@ GArray *virtio_gpu_virgl_get_capsets(VirtIOGPU *g)
}
}
=20
+ if (virtio_gpu_drm_enabled(g->parent_obj.conf)) {
+ virgl_renderer_get_cap_set(VIRTIO_GPU_CAPSET_DRM,
+ &capset_max_ver,
+ &capset_max_size);
+ if (capset_max_size) {
+ virtio_gpu_virgl_add_capset(capset_ids, VIRTIO_GPU_CAPSET_DRM);
+ }
+ }
+
return capset_ids;
}
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 11a7a8575027..165a0976480d 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -1505,6 +1505,21 @@ void virtio_gpu_device_realize(DeviceState *qdev, Er=
ror **errp)
#endif
}
=20
+ if (virtio_gpu_drm_enabled(g->parent_obj.conf)) {
+#ifdef VIRGL_VERSION_MAJOR
+ #if VIRGL_VERSION_MAJOR >=3D 1
+ if (!virtio_gpu_blob_enabled(g->parent_obj.conf) ||
+ !virtio_gpu_hostmem_enabled(g->parent_obj.conf)) {
+ error_setg(errp, "drm requires enabled blob and hostmem option=
s");
+ return;
+ }
+ #else
+ error_setg(errp, "old virglrenderer, drm unsupported");
+ return;
+ #endif
+#endif
+ }
+
if (!virtio_gpu_base_device_realize(qdev,
virtio_gpu_handle_ctrl_cb,
virtio_gpu_handle_cursor_cb,
diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index bd2cccdc60d7..dcdf52b192b5 100644
--- a/include/hw/virtio/virtio-gpu.h
+++ b/include/hw/virtio/virtio-gpu.h
@@ -99,6 +99,7 @@ enum virtio_gpu_base_conf_flags {
VIRTIO_GPU_FLAG_RUTABAGA_ENABLED,
VIRTIO_GPU_FLAG_VENUS_ENABLED,
VIRTIO_GPU_FLAG_RESOURCE_UUID_ENABLED,
+ VIRTIO_GPU_FLAG_DRM_ENABLED,
};
=20
#define virtio_gpu_virgl_enabled(_cfg) \
@@ -121,6 +122,8 @@ enum virtio_gpu_base_conf_flags {
(_cfg.hostmem > 0)
#define virtio_gpu_venus_enabled(_cfg) \
(_cfg.flags & (1 << VIRTIO_GPU_FLAG_VENUS_ENABLED))
+#define virtio_gpu_drm_enabled(_cfg) \
+ (_cfg.flags & (1 << VIRTIO_GPU_FLAG_DRM_ENABLED))
=20
struct virtio_gpu_base_conf {
uint32_t max_outputs;
--=20
2.48.1
From nobody Fri Apr 4 04:11:18 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1741605312; cv=pass;
d=zohomail.com; s=zohoarc;
b=O9o/JP9zDuW4afhQeu9OX4hcvQ1dpI9thJQ2O4MbZ3SWAIDtg8S3O+0CZHhf+hmt+I86ZFBOEL8AqemPcRDomDnjyDFcK5MzR0IsEX5VRniR8ID6Z6r+kWydGnUeON3f4mtCGl+Bmww1OgLinFJHgpgk8ROZvYhCJgjVns3cp1w=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1741605312;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=mL6BssqBdFtVZrHDCDUqwTNdYD9EWk/2PtIpTUBDV1Q=;
b=ezZ1uLReba1uvocyzbkWQJBpX/xNpj4iJINfMQtV5vzkb0vTO3kC0VAOCvBoQZksIG7bbbe5naYH/9mnwcREPQm7xETiC/WAmErjnEWklpX6DUM+NS7I3T7iOXR9rDgdhb+w7vYSPdd/Uhbf2R9OIYQmaaykGuSgJchHb8E/+rs=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1741605312733525.8594853563183;
Mon, 10 Mar 2025 04:15:12 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1trb5c-0005tu-AZ; Mon, 10 Mar 2025 07:14:32 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5W-0005a5-GU
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:27 -0400
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5U-0001Qi-H9
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:26 -0400
Received: by mx.zohomail.com with SMTPS id 1741605250202772.1877579231893;
Mon, 10 Mar 2025 04:14:10 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1741605251; cv=none;
d=zohomail.com; s=zohoarc;
b=lC66dWWEqi/tzaJ/FpSfkBLqPXlwYsnxTg7fVdsjzv5cOjRyz2WuKKT+R6YDlU7wvW9cc6lSKQZmsvfY+3DF0DRLsmgRXy7Yqq96iuzvQcjvw5QDBLA5reCH3Dw7XmY6evOXWCyfv44Lj3CY83JaWprnZ4rrJglpTploOGkFaqI=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1741605251;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=mL6BssqBdFtVZrHDCDUqwTNdYD9EWk/2PtIpTUBDV1Q=;
b=J5HgcWx5eKc+RwebB+LY15tVCUe6bQpsXfsKFlHW0bUfuiB4q5L3vZu1J9vwgX9HzHy4wDwysO2i7kGNY2S02PeIJ2PGtpz/QxdQQyQLgFG1Axbx0sEeVy55W3vtBoloOJpc3eLUMjV9ZPUq5Z+e5qniZS9mLVv9JFl7K2+MmY8=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741605251;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=mL6BssqBdFtVZrHDCDUqwTNdYD9EWk/2PtIpTUBDV1Q=;
b=JZ141JTCVJxrcVdKhuWyGWgTJctBJhZXgChrVmX+gHotri91ZWPo2jn5KLlqk9tT
6dqYBy/GcLDU7d7xbaTPOSKnv9GHIfur+sMoXfkptuJtzJHSquDwGg4kOE2STTDMgBw
lULxfaktvC9UwqVzUJKBlK9zMkBZSVGV4sVCTyKE=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v10 06/10] ui/sdl2: Don't disable scanout when display is
refreshed
Date: Mon, 10 Mar 2025 14:12:30 +0300
Message-ID: <20250310111234.145891-7-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
References: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1741605314545019000
Display refreshment is invoked by a timer and it erroneously disables
the active scanout if it happens to be invoked after scanout has been
enabled. This offending scanout-disable race condition with a timer
can be easily hit when Qemu runs with a disabled vsync by using SDL or
GTK displays (with vblank_mode=3D0 for GTK). Refreshment of display's
content shouldn't disable the active display. Fix it by keeping the
scanout's state unchanged when display is redrawn.
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
ui/sdl2-gl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c
index 8d53e340d40d..31f8fbe03286 100644
--- a/ui/sdl2-gl.c
+++ b/ui/sdl2-gl.c
@@ -53,7 +53,6 @@ static void sdl2_gl_render_surface(struct sdl2_console *s=
con)
int ww, wh;
=20
SDL_GL_MakeCurrent(scon->real_window, scon->winctx);
- sdl2_set_scanout_mode(scon, false);
=20
SDL_GetWindowSize(scon->real_window, &ww, &wh);
surface_gl_setup_viewport(scon->gls, scon->surface, ww, wh);
--=20
2.48.1
From nobody Fri Apr 4 04:11:18 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1741605294; cv=pass;
d=zohomail.com; s=zohoarc;
b=YkqtEZGSlZXMwg60tOJD5r2MEt84ugt+17+FFDEz4S3IqI0ULzPfjd2dd1SvxxDwENnqDIWy8kXlo62U/JrV4GSgnSD1D7Vfc1EmB/LNbjKCUHWriyKl2fUqK+DGh1NEX8tzeiJCdTHHp4+fNk4X5n6s+pLk2nVHLL+QEchGEFY=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1741605294;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=09WSpJc1UTZRxFDHxkgeIPpHfI0bG12mE8DGzrr9V7U=;
b=iDqENOSFYJODDUcQAwcmb2jo66yULwrUVy4xonLxya/w/Y4N/YFPVZUbJ+pfBFfOKUPEAW5zTb2DeTTFn3/Mpw20TWZMUB1JxbMJDW/mgTwalKCNKsnCaOtpR02/jOB+KRLX21IG2MShsKl1DvQm0phl0e2GySJkmBapzxYRWnQ=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 174160529462696.74823117558606;
Mon, 10 Mar 2025 04:14:54 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1trb5e-00067s-0h; Mon, 10 Mar 2025 07:14:34 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5c-0005xx-KR
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:32 -0400
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5a-0001RI-FB
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:32 -0400
Received: by mx.zohomail.com with SMTPS id 1741605255873855.2668137917361;
Mon, 10 Mar 2025 04:14:15 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1741605257; cv=none;
d=zohomail.com; s=zohoarc;
b=XuJPpWnJJZblTMlHTx9fUYhqXw8lOGXJ+GKJIfaJOsRj2lB73rAq95j9lA+4v4EOeWPqgUoPAqd00OVZZB+dXtLIqn2J4HkrBWEKv8RB0XxdD00yTv9fOiopYLd55NXiPaQx0x6LSi6LLs+izbiMsDLI97uVWeZWR1pWlgee39g=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1741605257;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=09WSpJc1UTZRxFDHxkgeIPpHfI0bG12mE8DGzrr9V7U=;
b=FM5mXh2jFcSabdrG+eqZP9a5hdWDmOAnrivfQqQ7oJVDF3aZhYgxi76LK7s5Ekv2obYYP+mxhSjHeM0sakeHxPa2/UtHgJ2crxMhYEa+KeSeF8FJBnZjK4FGWm1SD+Ok780PwMZiyZnml3kifDF39xbKciRksZzgTAFlYqyhVxE=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741605257;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=09WSpJc1UTZRxFDHxkgeIPpHfI0bG12mE8DGzrr9V7U=;
b=S/zpsk+0rGq0lkF0iNjsj3RRZtFVs6TpAuPbDbq9meTJURj+cIguh/CbFP3a25qc
AeYHTYS7Il7poeFD/a8sjlVz23zYlPbOECYcOBQ6XgV3n1lS3Se/VacbiJSUrO9xrpw
pV381ppk6PMYdj4TziZsdeOU6QobzciUZnHJrpxY=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v10 07/10] ui/gtk: Don't disable scanout when display is
refreshed
Date: Mon, 10 Mar 2025 14:12:31 +0300
Message-ID: <20250310111234.145891-8-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
References: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1741605297129019000
Display refreshment is invoked by a timer and it erroneously disables
the active scanout if it happens to be invoked after scanout has been
enabled. This offending scanout-disable race condition with a timer
can be easily hit when Qemu runs with a disabled vsync by using SDL or
GTK displays (with vblank_mode=3D0 for GTK). Refreshment of display's
content shouldn't disable the active display. Fix it by keeping the
scanout's state unchanged when display is redrawn.
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
ui/gtk-egl.c | 1 -
ui/gtk-gl-area.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index f7a428c86a8d..0d1547d63ad0 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -179,7 +179,6 @@ void gd_egl_refresh(DisplayChangeListener *dcl)
=20
if (vc->gfx.glupdates) {
vc->gfx.glupdates =3D 0;
- gtk_egl_set_scanout_mode(vc, false);
gd_egl_draw(vc);
}
}
diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 2c9a0db42571..53d81124f211 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -148,7 +148,6 @@ void gd_gl_area_refresh(DisplayChangeListener *dcl)
=20
if (vc->gfx.glupdates) {
vc->gfx.glupdates =3D 0;
- gtk_gl_area_set_scanout_mode(vc, false);
gtk_gl_area_queue_render(GTK_GL_AREA(vc->gfx.drawing_area));
}
}
--=20
2.48.1
From nobody Fri Apr 4 04:11:18 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1741605318; cv=pass;
d=zohomail.com; s=zohoarc;
b=W1gRkV8FvLtYYgK2BLwEODCjruFltNItp+kS8dsZjHDgisxE2L4FtUhATSqkB5wnhytWc4COw+c1XeVLTV2QvP6UNRSx1suPFLG5jO/6CbMoWobVyAnRIH8WLN05IDno0eVcdC3set6kcPFZpFJmX080WjAc+xTV5LAZx9n6zKY=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1741605318;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=blb8y7Rz6b3Leso+OAXIELBML0HJvsHKGxqmnHSnGAc=;
b=dSKO7CWfA32ybytv4ovBu2inTfgzZkGHDx4S8YmxTITP93UGXTjZCUw6033/LpWqanGYHcuceKk+flhlwYX/bN7o+XNtQRrlpVz7imThazbCV089n8vKJL1+tQlIZsTgi35H8YSe0AV5Qd4SbL7Fm8Qy7sooUKNHHPb74KmMo8s=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1741605318664311.2849947319298;
Mon, 10 Mar 2025 04:15:18 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1trb5n-0006vk-HD; Mon, 10 Mar 2025 07:14:43 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5l-0006oU-A9
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:41 -0400
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5h-0001Rv-8a
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:40 -0400
Received: by mx.zohomail.com with SMTPS id 1741605261505550.55689962746;
Mon, 10 Mar 2025 04:14:21 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1741605263; cv=none;
d=zohomail.com; s=zohoarc;
b=RAJ0B2cvTMUWA51fL8lknnavfFaleDb49WI7p72ASLXCzgEKE+HTmIabdEqNNGatLXvDGntRLbosJTyaJ4ekfdWld5pzTrQaW/b1sdKTY/DuesxDeba4mC0xqxGcdvNLvUIETNFkYf+putnja53+z7ddG7xRRFfOjvH2E09zNg0=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1741605263;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=blb8y7Rz6b3Leso+OAXIELBML0HJvsHKGxqmnHSnGAc=;
b=RJwzwbQUxaPv4vkqY9Frq5QLoE/eaqeRmVAzDVAWbHadH1B/CWBiDEPUqoz7UhgiiGWvdLFMvY3ZahEt/SybHlAJzd+GxznbY6LjNNIe/9IS3hPFcHAzRrWNbAOpVU7DxB06cApORGMkQW+RMniK3wDz8aRRtuFpExezsoRnBhM=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741605263;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=blb8y7Rz6b3Leso+OAXIELBML0HJvsHKGxqmnHSnGAc=;
b=PIxN8u8dqmbgK1S95eVCdaKthGGQFxLvNt9Z2wbgCxuN8AQmLAeUMYb0Di4RbSjz
1sTeyhuZsRrLMcOebB47zQWsZ9g33ACDD8OAeOnVRHzHWXX6bxaTVIGn/c+FgkDT4M7
VtGHfIjeELDAJ1VOSe2dpvQvIXWEgKA5zw7EDOP8=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v10 08/10] docs/system: virtio-gpu: Add link to Mesa VirGL doc
Date: Mon, 10 Mar 2025 14:12:32 +0300
Message-ID: <20250310111234.145891-9-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
References: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1741605320439019000
Content-Type: text/plain; charset="utf-8"
Extend virtio-gpu documentation with a link to the Mesa VirGL
documentation.
Suggested-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
docs/system/devices/virtio-gpu.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/system/devices/virtio-gpu.rst b/docs/system/devices/virti=
o-gpu.rst
index f20c60016376..f8963c1f13cf 100644
--- a/docs/system/devices/virtio-gpu.rst
+++ b/docs/system/devices/virtio-gpu.rst
@@ -59,7 +59,7 @@ on typical modern Linux distributions.
virtio-gpu virglrenderer
------------------------
=20
-When using virgl accelerated graphics mode in the guest, OpenGL API calls
+When using `virgl`_ accelerated graphics mode in the guest, OpenGL API cal=
ls
are translated into an intermediate representation (see `Gallium3D`_). The
intermediate representation is communicated to the host and the
`virglrenderer`_ library on the host translates the intermediate
@@ -68,6 +68,7 @@ representation back to OpenGL API calls.
.. parsed-literal::
-device virtio-gpu-gl
=20
+.. _virgl: https://docs.mesa3d.org/drivers/virgl.html
.. _Gallium3D: https://www.freedesktop.org/wiki/Software/gallium/
.. _virglrenderer: https://gitlab.freedesktop.org/virgl/virglrenderer/
=20
--=20
2.48.1
From nobody Fri Apr 4 04:11:18 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1741605307; cv=pass;
d=zohomail.com; s=zohoarc;
b=leRAkPeU6naElJAqniKdaZDVU++aIu2WJFx8M8OhnfVniQNO4dtP5+32PCAY1LPqDQehEMF96+q+oQUaSQwkHHRBrpzkSqsmFviaIgsbLgzZqSatkyqf/YYBEiYPIXggRYyx01BOOpJaT/YqLLjZH79LGjkfN1KqNxGzMtBFdtA=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1741605307;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=eJrSLxjqu0HeBH1I3TSIB8+DRFiJIAdZt2l2rGiZd2w=;
b=Q3bHrImmf7VwqDh+r38Ig8z+QgHEcM+v+sysvFu4KmRk0ETpkgt8V21Lj07PlROH/LI3YCfKoy6Qu9wEMapJQT4IczyOD8ig91qKbJY32SmjyjSONUYUFgFfnJ59YP753t0JPQeXIRwhh7mCIpq/uoMmt5XFEJLaXJE8qOfrxUE=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1741605307615361.6345517786581;
Mon, 10 Mar 2025 04:15:07 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1trb5t-0007OI-GS; Mon, 10 Mar 2025 07:14:49 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5q-0007BX-Sn
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:47 -0400
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5m-0001S6-AY
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:46 -0400
Received: by mx.zohomail.com with SMTPS id 1741605267692668.406111607399;
Mon, 10 Mar 2025 04:14:27 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1741605269; cv=none;
d=zohomail.com; s=zohoarc;
b=TSBmw/cvGlcOfpULxiVMU7qbko8LQdtWwaArwZeuW3o02zpqh7ktNBbeLaRQ06KpnpQObc9qDRIvmEpJpKjWWbno4nfOw1zyD48v9PdnljHvkyVBFHP9JND8xfdvKFaakIuaRRPNYeKq0x37Znnvy0yhV96mjmfL7PPkVT5d4ck=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1741605269;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=eJrSLxjqu0HeBH1I3TSIB8+DRFiJIAdZt2l2rGiZd2w=;
b=YildGYBU2sCiCIutzp0v/eVqUgeLk4Df8e2SgYB44ovsjF8NSQeOJMYkFeiscecxcEw2/tEfl/fbSELt1qOSwSjqACPEc6hVyVbWyDV3DFRCX6m1AXtC8XdSzijFJotkAm6NfuuAdI1jvIDdpU2FtN6xaQULdmGi6Nht8doMtO0=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741605269;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=eJrSLxjqu0HeBH1I3TSIB8+DRFiJIAdZt2l2rGiZd2w=;
b=QBQQykYcHMvutyoeJA9DXffArUAS5l/3Y/tfEjmcSJux6NRjhwqewcQFA2IILf3E
8DPDBkjkdfi9dNABeJ+sYMb/Qh3G8KLE++f9+gZOT1rv1pTh8zB2dkHa+KdfyUSZVX/
9tTBPeUFQdyjGZ56mU9f1nfJfp+3I9MMz18lSsTY=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v10 09/10] docs/system: virtio-gpu: Update Venus link
Date: Mon, 10 Mar 2025 14:12:33 +0300
Message-ID: <20250310111234.145891-10-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
References: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1741605309080019100
Content-Type: text/plain; charset="utf-8"
Change virtio-gpu Venus link, pointing it at the Mesa Venus
documentation instead of the protocol. The Mesa doc provides more
information and also has a link to the protocol.
Suggested-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
docs/system/devices/virtio-gpu.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/system/devices/virtio-gpu.rst b/docs/system/devices/virti=
o-gpu.rst
index f8963c1f13cf..ea3eb052df3c 100644
--- a/docs/system/devices/virtio-gpu.rst
+++ b/docs/system/devices/virtio-gpu.rst
@@ -81,7 +81,7 @@ of virtio-gpu host memory window. This is typically betwe=
en 256M and 8G.
.. parsed-literal::
-device virtio-gpu-gl,hostmem=3D8G,blob=3Dtrue,venus=3Dtrue
=20
-.. _venus: https://gitlab.freedesktop.org/virgl/venus-protocol/
+.. _venus: https://docs.mesa3d.org/drivers/venus.html
=20
DRM native context is supported since release of `virglrenderer`_ v1.0.0
using `drm`_ protocol. ``DRM`` virtio-gpu capability set ("capset") requi=
res
--=20
2.48.1
From nobody Fri Apr 4 04:11:18 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1741605301; cv=pass;
d=zohomail.com; s=zohoarc;
b=CSgL4zisrj+zMtoScjutPiusfNyy9D7YFZmWrSqYP7RDNrPlYYTXDD087zSGU2dLE7wwGlwz+/f8J3cI/VrmcTPOwLH20+pO3EMRIfW8ry86RjGx2TEHUFO5OQLDHXBkTNonPQQgjeczbEMosdZS1F196BptRrry921n31LszmU=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1741605301;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=o0nO8wgEsy007jxFJPgqgdWru9rnWTAVfjzhQ4uSOPc=;
b=Kn8+scJjzLl18GLRvTyUmufl02X+rmiKEd/EXPS8tCGM0INO7nPnX0VvxydKgESi9Xj3Mg+chTImL5pJ3lgKRgMrHXzr4oQ4eZDIumyKXtnBqOB8QrbaQe6Sp+7lBOPZGQeB0WOB1W/ofXV5gMmLTyA4comvqlyvrglQRL0x0eA=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1741605301533613.1945315368771;
Mon, 10 Mar 2025 04:15:01 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1trb5z-0007hh-7H; Mon, 10 Mar 2025 07:14:56 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5v-0007co-GV
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:51 -0400
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1trb5s-0001T0-Vi
for qemu-devel@nongnu.org; Mon, 10 Mar 2025 07:14:51 -0400
Received: by mx.zohomail.com with SMTPS id 1741605273382226.80200354697752;
Mon, 10 Mar 2025 04:14:33 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1741605275; cv=none;
d=zohomail.com; s=zohoarc;
b=giBLIHPNcwm0QS4j6OG6W+YlrjVnjmx0K9Oo+VEU16/AEc/ek9CfYh/GvKFCeI3TeNY9+UnFtAYDAljnIZFWjolyBoegrYZR3+Tt4htBaNkOApGrP7oCKLS0vtzMzstZIq5yvA3k82ohi18XQi28wt/UAG4iI7VcaA4/tUwooPs=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1741605275;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=o0nO8wgEsy007jxFJPgqgdWru9rnWTAVfjzhQ4uSOPc=;
b=cWVKUKpgCu0b2m4lQD0ulampNLpwpD+uNTCyxDKFgwYb3BSIawLzuvNNmA8fsU0W7gn7unEWiClDQjvRwR71EocnpzANjJQhLmyN/MnLICYfSmGcO1n3kCKcXG3IEXDz5269dIrAWUOrK1KdICud++RZbthu9CGU6xXyh1OdI+k=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1741605275;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=o0nO8wgEsy007jxFJPgqgdWru9rnWTAVfjzhQ4uSOPc=;
b=CE8nwzZbRf1Pgl+UE6OMF+2rMm7xzwMghQY0k/cYl+ybWvJiquNm/twgeCt/ooM2
XgTf7bDsqzathsWdYv4iduSdOQuVw1Hh+ZI9NgZPW1xcvFLNUF5qbSiAzsMY7DygdA2
dfeakIbhf+iiS0g7yFx8h5hhHT1uYUK1oR5obaXs=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v10 10/10] docs/system: virtio-gpu: Document host/guest
requirements
Date: Mon, 10 Mar 2025 14:12:34 +0300
Message-ID: <20250310111234.145891-11-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
References: <20250310111234.145891-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1741605302409019000
From: Alex Benn=C3=A9e <alex.bennee@linaro.org>
This attempts to tidy up the VirtIO GPU documentation to make the list
of requirements clearer. There are still a lot of moving parts and the
distros have some catching up to do before this is all handled
automatically.
Signed-off-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Cc: Sergio Lopez Pascual <slp@redhat.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
[dmitry.osipenko@collabora.com: Extended and corrected doc]
---
docs/system/devices/virtio-gpu.rst | 94 +++++++++++++++++++++++++++++-
1 file changed, 91 insertions(+), 3 deletions(-)
diff --git a/docs/system/devices/virtio-gpu.rst b/docs/system/devices/virti=
o-gpu.rst
index ea3eb052df3c..3e4a1e2c87a0 100644
--- a/docs/system/devices/virtio-gpu.rst
+++ b/docs/system/devices/virtio-gpu.rst
@@ -5,14 +5,28 @@ virtio-gpu
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=20
This document explains the setup and usage of the virtio-gpu device.
-The virtio-gpu device paravirtualizes the GPU and display controller.
+The virtio-gpu device provides a GPU and display controller
+paravirtualized using VirtIO. It supports a number of different modes
+from simple 2D displays to fully accelerated 3D graphics.
=20
-Linux kernel support
---------------------
+Linux guest kernel support
+--------------------------
=20
virtio-gpu requires a guest Linux kernel built with the
``CONFIG_DRM_VIRTIO_GPU`` option.
=20
+3D acceleration
+---------------
+
+3D acceleration of a virtualized GPU is still an evolving field.
+Depending on the 3D mode you are running you may need to override
+distribution supplied libraries with more recent versions or enable
+build options. There are a number of requirements the host must meet
+to be able to be able to support guests. QEMU must be able to access the
+host's GPU and for the best performance be able to reliably share GPU
+memory with the guest. Details of 3D acceleration requirements are
+described in a further sections.
+
QEMU virtio-gpu variants
------------------------
=20
@@ -65,8 +79,14 @@ intermediate representation is communicated to the host =
and the
`virglrenderer`_ library on the host translates the intermediate
representation back to OpenGL API calls.
=20
+By default OpenGL version on guest is limited to 4.3. In order to enable
+OpenGL 4.6 support, virtio-gpu host blobs feature (``hostmem`` and ``blob=
``
+fields) should be enabled. The ``hostmem`` field specifies the size of
+virtio-gpu host memory window. This is typically between 256M and 8G.
+
.. parsed-literal::
-device virtio-gpu-gl
+ -device virtio-gpu-gl,hostmem=3D8G,blob=3Dtrue
=20
.. _virgl: https://docs.mesa3d.org/drivers/virgl.html
.. _Gallium3D: https://www.freedesktop.org/wiki/Software/gallium/
@@ -94,6 +114,56 @@ of virtio-gpu host memory window. This is typically bet=
ween 256M and 8G.
=20
.. _drm: https://gitlab.freedesktop.org/virgl/virglrenderer/-/tree/main/sr=
c/drm
=20
+.. list-table:: Linux Host Requirements
+ :header-rows: 1
+
+ * - Capability
+ - Kernel Version
+ * - OpenGL pass-through
+ - Any Linux version compatible with QEMU if not using host blobs featu=
re,
+ Linux 6.13+ otherwise
+ * - Vulkan pass-through
+ - Linux 6.13+
+ * - AMDGPU DRM native context
+ - Linux 6.13+
+ * - Freedreno DRM native context
+ - Linux 6.4+
+ * - Intel i915 DRM native context `mr1384`_
+ - Linux 6.13+
+ * - Asahi DRM native context `mr1274`_
+ - `Downstream version`_ of Asahi Linux kernel
+
+.. _mr1384: https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_req=
uests/1384
+.. _mr1274: https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_req=
uests/1274
+.. _Downstream version: https://gitlab.freedesktop.org/asahi/linux
+
+.. list-table:: Linux Guest Requirements
+ :header-rows: 1
+
+ * - Capability
+ - Kernel Version
+ - Mesa Version
+ * - OpenGL pass-through
+ - Any Linux version supporting virtio-gpu
+ - 16.0.0+
+ * - Vulkan pass-through
+ - Linux 5.16+
+ - 24.2.0+
+ * - AMDGPU DRM native context
+ - Linux 6.14+
+ - 25.0.0+
+ * - Freedreno DRM native context
+ - Linux 6.14+
+ - 23.1.0+
+ * - Intel i915 DRM native context
+ - Linux 6.14+
+ - `mr29870`_
+ * - Asahi DRM native context
+ - Linux 6.14+
+ - 24.2.0+
+
+.. _mr29870: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/298=
70
+
virtio-gpu rutabaga
-------------------
=20
@@ -133,3 +203,21 @@ Surfaceless is the default if ``wsi`` is not specified.
.. _Wayland display passthrough: https://www.youtube.com/watch?v=3DOZJiHMt=
IQ2M
.. _gfxstream-enabled rutabaga: https://crosvm.dev/book/appendix/rutabaga_=
gfx.html
.. _guest Wayland proxy: https://crosvm.dev/book/devices/wayland.html
+
+.. list-table:: Linux Host Requirements
+ :header-rows: 1
+
+ * - Capability
+ - Kernel version
+ * - Vulkan+Wayland pass-through
+ - Linux 6.13+
+
+.. list-table:: Linux Guest Requirements
+ :header-rows: 1
+
+ * - Capability
+ - Kernel Version
+ - Mesa Version
+ * - Vulkan+Wayland pass-through
+ - Linux 5.16+
+ - 24.3.0+
--=20
2.48.1