From nobody Thu Apr 3 09:58:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1741146432; cv=none; d=zohomail.com; s=zohoarc; b=IJTrHMwfHFvW9BlzrDz7iytpamsWBA5sRyV3kjt5juHP5eFVYCUA3mpR15deDXB7oXOxgVsJSnexWkjSo1Bmew721Jm2Dum3zBlhBuaADDHPjWYp2a87V6iRueAlt3vhuw7eLksrpzIn9yNYeqpxNU6ydych8UMxkYpD3qRV8uw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1741146432; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EIxtKIfXAperan5ep4E1FQ8USyNb2fZLbeC2CWp4A+k=; b=luY2hoRkto11wCXCc8REKoaZFXd9CQXx1Vf1KqHsuWbJzHvvxizkAHS3Dnr5uiMpjIlFMNFoeuFcVCMmmTKQZXLH0ZKDVhuRGv6k0R9bDyvHuP+6dBTHiOD+O8fHwT36+aYyEVq4KTBxVLodTkd9wcelKMTdy2Tdnxkp2GuSvsc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174114643241185.2951210137661; Tue, 4 Mar 2025 19:47:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tpfiI-0005Ku-S0; Tue, 04 Mar 2025 22:46:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tpfiH-0005KQ-U1 for qemu-devel@nongnu.org; Tue, 04 Mar 2025 22:46:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tpfiG-00060J-CD for qemu-devel@nongnu.org; Tue, 04 Mar 2025 22:46:29 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-7C41S4lHOHOsMFRH3qp0iw-1; Tue, 04 Mar 2025 22:46:24 -0500 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 80C8F1955D66; Wed, 5 Mar 2025 03:46:23 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.80.45]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4D8411956095; Wed, 5 Mar 2025 03:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741146386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EIxtKIfXAperan5ep4E1FQ8USyNb2fZLbeC2CWp4A+k=; b=RXpv9Ru5w/iVqXCNzugNFJDgHVDFyQLRLuKz5yRqVzqPbTplumElLiGCxnrB8S+EEDtDXq ICTP1WrAIk9ug/xOUp4NHKIUR/Ay8vRakzQo0WZ3WYmahgZ9EzJv5mJPBwQTEzcrbrwxgD nyA9h1nNanvkBA9kAyvmJNh+hwcnMIQ= X-MC-Unique: 7C41S4lHOHOsMFRH3qp0iw-1 X-Mimecast-MFC-AGG-ID: 7C41S4lHOHOsMFRH3qp0iw_1741146383 From: John Snow To: qemu-devel@nongnu.org Cc: Michael Roth , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Markus Armbruster , John Snow Subject: [PATCH 02/57] qapi: shush pylint up Date: Tue, 4 Mar 2025 22:45:11 -0500 Message-ID: <20250305034610.960147-3-jsnow@redhat.com> In-Reply-To: <20250305034610.960147-1-jsnow@redhat.com> References: <20250305034610.960147-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1741146433417019000 Content-Type: text/plain; charset="utf-8" Shhhhh! This patch is RFC quality, I wasn't in the mood to actually solve problems so much as I was in the mood to continue working on the Sphinx rework. Plus, I don't think the code I am patching has hit origin/master yet ... Signed-off-by: John Snow --- scripts/qapi/backend.py | 2 ++ scripts/qapi/main.py | 10 ++++------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/qapi/backend.py b/scripts/qapi/backend.py index 14e60aa67af..49ae6ecdd33 100644 --- a/scripts/qapi/backend.py +++ b/scripts/qapi/backend.py @@ -13,6 +13,7 @@ =20 =20 class QAPIBackend(ABC): + # pylint: disable=3Dtoo-few-public-methods =20 @abstractmethod def generate(self, @@ -36,6 +37,7 @@ def generate(self, =20 =20 class QAPICBackend(QAPIBackend): + # pylint: disable=3Dtoo-few-public-methods =20 def generate(self, schema: QAPISchema, diff --git a/scripts/qapi/main.py b/scripts/qapi/main.py index ff42b43cd68..01155373bd0 100644 --- a/scripts/qapi/main.py +++ b/scripts/qapi/main.py @@ -31,15 +31,14 @@ def create_backend(path: str) -> QAPIBackend: =20 module_path, dot, class_name =3D path.rpartition('.') if not dot: - print(f"argument of -B must be of the form MODULE.CLASS", + print("argument of -B must be of the form MODULE.CLASS", file=3Dsys.stderr) sys.exit(1) =20 try: mod =3D import_module(module_path) except Exception as ex: - print(f"unable to import '{module_path}': {ex}", file=3Dsys.stderr) - sys.exit(1) + raise QAPIError(f"unable to import '{module_path}': {ex}") from ex =20 try: klass =3D getattr(mod, class_name) @@ -51,9 +50,8 @@ def create_backend(path: str) -> QAPIBackend: try: backend =3D klass() except Exception as ex: - print(f"backend '{path}' cannot be instantiated: {ex}", - file=3Dsys.stderr) - sys.exit(1) + raise QAPIError( + f"backend '{path}' cannot be instantiated: {ex}") from ex =20 if not isinstance(backend, QAPIBackend): print(f"backend '{path}' must be an instance of QAPIBackend", --=20 2.48.1