From nobody Fri Apr 4 03:48:07 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1740643770; cv=none; d=zohomail.com; s=zohoarc; b=mE+gmKczr8x9WygV71FDPuKqeR84aZi6YGXKEuu+/6QyxZoLk8E4Cs30KOU4cZqLRQ05U3pbamIeng3BlqJCG0KVAgnhxwK6JPAEXs6b7lh/CCgSrtE2CRIDJjpzQbGYUYMUm83tbfjRTQwfmV6fjetyfoFWMu9OlWWmx+d2/xg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1740643770; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ghg1+E0JdhJabwSgZMyZsM5RpsyBKY2hMAEJeHgs3yg=; b=jKJCN6ovbnw9XDKhf2NyUyA+IqTBwNuiZ9Ok1kp0534CefYpugoVy6hx5cHXQSmqzbc9Tf8EjHE03uSZouoVDghNLGQXL/bIXB/gOlvu9LaRVQKJvTekdQpga3z48KSOGnIaR1oppH65d6AmVbajDfz/uYP9fq3KZXllpu0Ex3E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1740643770552123.99002341059918; Thu, 27 Feb 2025 00:09:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tnYwM-0008Vk-8u; Thu, 27 Feb 2025 03:08:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnYwD-0008L7-U6 for qemu-devel@nongnu.org; Thu, 27 Feb 2025 03:08:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnYwB-0001fZ-C9 for qemu-devel@nongnu.org; Thu, 27 Feb 2025 03:08:09 -0500 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-8OvbpMuFNCmhS-3E-X9GOw-1; Thu, 27 Feb 2025 03:08:01 -0500 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9F6D0193578F; Thu, 27 Feb 2025 08:08:00 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.9]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4D53619560AE; Thu, 27 Feb 2025 08:08:00 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7C7D321E65E7; Thu, 27 Feb 2025 09:07:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740643685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ghg1+E0JdhJabwSgZMyZsM5RpsyBKY2hMAEJeHgs3yg=; b=JmYnJDaBcfL0Up8otRg4BhHeoVuE4Z/nO2oevR3BVekhyRheB2pWr6o/5bcwWnwkaD6C3t G6tjye8JLlarESnyY/OdAAkXHtaak+6rDlAtSmRdVLVeEtYScunpJuU2YrjoKJb5b3hQi0 UHjXiH1k+tFmpAmPNnyMCfRAY7m5e3g= X-MC-Unique: 8OvbpMuFNCmhS-3E-X9GOw-1 X-Mimecast-MFC-AGG-ID: 8OvbpMuFNCmhS-3E-X9GOw_1740643680 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: michael.roth@amd.com, jsnow@redhat.com Subject: [PATCH 3/3] qapi/introspect: Use @dataclass to simplify Date: Thu, 27 Feb 2025 09:07:57 +0100 Message-ID: <20250227080757.3978333-4-armbru@redhat.com> In-Reply-To: <20250227080757.3978333-1-armbru@redhat.com> References: <20250227080757.3978333-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.44, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1740643772716019000 Content-Type: text/plain; charset="utf-8" A TODO comment in class Annotated reminds us to simplify it once we can use @dataclass, new in Python 3.7. We have that now, so do it. There's a similar comment in scripts/qapi/source.py, but I can't figure out how to use @dataclass there. Left for another day. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrang=C3=A9 --- scripts/qapi/introspect.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py index 42e5185c7c..89ee5d5f17 100644 --- a/scripts/qapi/introspect.py +++ b/scripts/qapi/introspect.py @@ -11,6 +11,7 @@ See the COPYING file in the top-level directory. """ =20 +from dataclasses import dataclass from typing import ( Any, Dict, @@ -79,19 +80,16 @@ _ValueT =3D TypeVar('_ValueT', bound=3D_Value) =20 =20 +@dataclass class Annotated(Generic[_ValueT]): """ Annotated generally contains a SchemaInfo-like type (as a dict), But it also used to wrap comments/ifconds around scalar leaf values, for the benefit of features and enums. """ - # TODO: Remove after Python 3.7 adds @dataclass: - # pylint: disable=3Dtoo-few-public-methods - def __init__(self, value: _ValueT, ifcond: QAPISchemaIfCond, - comment: Optional[str] =3D None): - self.value =3D value - self.comment: Optional[str] =3D comment - self.ifcond =3D ifcond + value: _ValueT + ifcond: QAPISchemaIfCond + comment: Optional[str] =3D None =20 =20 def _tree_to_qlit(obj: JSONValue, --=20 2.48.1