From nobody Sun Feb 23 05:59:28 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1740141092; cv=none; d=zohomail.com; s=zohoarc; b=WWGr+UGlYyh/nECxqsLBhfE6gr11Al8ALaBg81E5hQslclonFoOowTfhn54l9xVjzQXsW/EBXuk6e4uBDkV/sOCH84lgGwQ0X96KuAHeTrvtJ1aYv9i5R5WeFFw0HBJh3pHXNMpDelyviwLZ0+ZyoOUGWjBAHIUNinWv5X76YQU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1740141092; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CWBUtSS67oYR3l74Eped0x0Nc8HfHcVrd0NioQ2Xqss=; b=DAPqZHIVHFayva7MIRn374mA5LM2RKuebu/kQbPzMzygx5JXXEjggx0+7Lus2WHwSOGkWYmEkGUJu15G880AbEqMkqUULr2Lq742EtyYhYEO4vB9cVxDnIOsDA+adTB88S2VqQHC2o0f3M7sGDNbosjSJxHzheKIJKErPo50Ia4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1740141092219529.2840470522743; Fri, 21 Feb 2025 04:31:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tlS8b-00072F-Lk; Fri, 21 Feb 2025 07:28:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlS74-0006Dr-Ap for qemu-devel@nongnu.org; Fri, 21 Feb 2025 07:26:41 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tlS71-0007Yk-Ug for qemu-devel@nongnu.org; Fri, 21 Feb 2025 07:26:37 -0500 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-220c8eb195aso43137535ad.0 for ; Fri, 21 Feb 2025 04:26:35 -0800 (PST) Received: from grind.dc1.ventanamicro.com ([187.11.154.120]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d545e39bsm137349855ad.124.2025.02.21.04.26.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 04:26:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1740140794; x=1740745594; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CWBUtSS67oYR3l74Eped0x0Nc8HfHcVrd0NioQ2Xqss=; b=RPIb+UZsckyWQQoKfXk4tg6xbgAjDg0mkZWRmsK9ARd1X9BO65pFn41hSlGC4m6WQM qqoVdfRZulhefPGvMSM+B4s+8ld+SxNFMUJ4fbFSsFEG3DBg1aKaKx6zex195D8/PcNK dH+p8f4d7KBSQY3J/lLj/gARuR91Z6V4tfT5SqEyzAELEwMfi9MixhoKq6x8kS0VyWJC OrqTjvVat7I8Qn3oL4pIpg5F/N9cSy57Tjl6nnwBBkhHxyN37exLtfaneQMHR+8OEL8Y AzepSx2KoQvPbFSPU0kljidjJKec+AC6HmsnUYKniQMP1InXZLu9U6QHjspCrcMWdVja KPSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740140794; x=1740745594; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CWBUtSS67oYR3l74Eped0x0Nc8HfHcVrd0NioQ2Xqss=; b=eOrw6c6z8ibv7ArCmfW6lku31O3Za/wbr0OJoe9wPdMS8T28c+TKdOCv0IAfehrgKR nS+Xq0WtC7UqZaYPbidBAD0G7dBKyvH7BSO9DAlK6BQT340c9kUbko8fls8z1tTKjTHK ipdyuRpTszecjegwb71bWwHQ/REWD1cn27KQ6e5Lbdq7ufovF7mvrSjHJ3Oglq12JJSB Q8cK93doIdY5w68IO/O+4DDX9rmSTPvQSznkHHgseOXPCdqycMosNeooX0cRW+wJi0mQ RRauaCKt3rsuZ/02Amp1DpQ60vCgQZO/qaIvpobri7jrqpqZzUx2tGA8P0nFR+GWWAPm aXpA== X-Gm-Message-State: AOJu0YzxM7q01sMUz819i1do0NoxF00AVdDP/+CmjCz1GA0PPqgjCw2a GDYjai41f7zoT80CLhvH6uvF0B+XmIRP6AnA7GSCkMXVzqAy0tLOoAF1PUX2IBxazfYZjUi9NhQ c X-Gm-Gg: ASbGncvvySVJZQ8FXDR84RTRpj6zGdLLWEcZvExA07Qv0KsobTTDBmzWTmIE5yyiYy5 x98oN/5tuzot9vrUCPxejQGRWkSnaXiyNzkERmZ2ex6oJBrYYBnVn0AwwZFPH8bPVT+nzCyVO7U 0Pi5sv17p6l/m7Ivx5houRmPpkSCS3GgdVBm5upheVBxmLJx305V8njfRBpfsacyAmLs0Eb692t WPzAk7rbuwQSQeewpI0dyo8h1Yq/2FYuJC0OlNphzoHwP2pdSYDdVHQ85kTJdExfL3jjEr1MwQJ REfFTjhPDuSvDpwSz2ECAiYtBmSlW2FhCs/CQILYuUQajWTs2i5A9g== X-Google-Smtp-Source: AGHT+IHiYj/wM+pKpfvYQyLlZlxFQa12aHhGIepWYrUEIkw6t3B0qkFHpiO/R+EzBgMwK8flkLXolQ== X-Received: by 2002:a17:903:2381:b0:220:d272:534d with SMTP id d9443c01a7336-2219ff57817mr53796555ad.22.1740140794054; Fri, 21 Feb 2025 04:26:34 -0800 (PST) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, ajones@ventanamicro.com, Daniel Henrique Barboza Subject: [PATCH v2 1/3] target/riscv/cpu: ignore TCG init for KVM CPUs in reset_hold Date: Fri, 21 Feb 2025 09:26:21 -0300 Message-ID: <20250221122623.495188-2-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250221122623.495188-1-dbarboza@ventanamicro.com> References: <20250221122623.495188-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=dbarboza@ventanamicro.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ventanamicro.com) X-ZM-MESSAGEID: 1740141093611019000 Content-Type: text/plain; charset="utf-8" riscv_cpu_reset_hold() does a lot of TCG-related initializations that aren't relevant for KVM, but nevertheless are impacting the reset state of KVM vcpus. When running a KVM guest, kvm_riscv_reset_vcpu() is called at the end of reset_hold(). At that point env->mstatus is initialized to a non-zero value, and it will be use to write 'sstatus' in the vcpu (kvm_arch_put_registers() then kvm_riscv_put_regs_csr()). Do an early exit in riscv_cpu_reset_hold() if we're running KVM. All the KVM reset procedure will be centered in kvm_riscv_reset_vcpu(). While we're at it, remove the kvm_enabled() check in kvm_riscv_reset_vcpu() since it's already being gated in riscv_cpu_reset_hold(). Signed-off-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones --- target/riscv/cpu.c | 9 +++++---- target/riscv/kvm/kvm-cpu.c | 3 --- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 522d6584e4..8e6e629ec4 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -1050,6 +1050,11 @@ static void riscv_cpu_reset_hold(Object *obj, ResetT= ype type) mcc->parent_phases.hold(obj, type); } #ifndef CONFIG_USER_ONLY + if (kvm_enabled()) { + kvm_riscv_reset_vcpu(cpu); + return; + } + env->misa_mxl =3D mcc->misa_mxl_max; env->priv =3D PRV_M; env->mstatus &=3D ~(MSTATUS_MIE | MSTATUS_MPRV); @@ -1146,10 +1151,6 @@ static void riscv_cpu_reset_hold(Object *obj, ResetT= ype type) env->rnmip =3D 0; env->mnstatus =3D set_field(env->mnstatus, MNSTATUS_NMIE, false); } - - if (kvm_enabled()) { - kvm_riscv_reset_vcpu(cpu); - } #endif } =20 diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index 23ce779359..484b6afe7c 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -1603,9 +1603,6 @@ void kvm_riscv_reset_vcpu(RISCVCPU *cpu) CPURISCVState *env =3D &cpu->env; int i; =20 - if (!kvm_enabled()) { - return; - } for (i =3D 0; i < 32; i++) { env->gpr[i] =3D 0; } --=20 2.48.1 From nobody Sun Feb 23 05:59:28 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1740140946; cv=none; d=zohomail.com; s=zohoarc; b=AQ6ibT+ius7NwXLE8Pf1jqRg7tXt5gAVmz9zjqX+uJobNhU6olg36sH2xD/Nw8euAh/QegahiVLNXIYDSRsnt2+GvjJW43CSiq+PaKX/DiBsFdjNFKUfgJhwjByokg7lFWlf+stNfihfpQrJf8lIAYCul8aVKMucs9JEhqt1km0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1740140946; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RcXDBri0g1fUiIwIh0GNJUeIssgoJJnkBzPq36LziBM=; b=WuhGBvwfQxcKisgi9gPcPr9pnsEgZ0yMapWMYZ/jMDDfcSnh8feEqSKGtJaGonqutMLPSj6wSjKciX0ZmM+9WR++4BVHSMlnQR5WH0SV/SIXftQB+FkqioFH36W8r0tGjpM8aj+SDU7PAlsTD9ggIAVsGyopzQqMQKo5gyNNWyI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1740140946430413.13767882922343; Fri, 21 Feb 2025 04:29:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tlS8i-00086a-PF; Fri, 21 Feb 2025 07:28:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlS78-0006GM-53 for qemu-devel@nongnu.org; Fri, 21 Feb 2025 07:26:43 -0500 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tlS75-0007ZF-TU for qemu-devel@nongnu.org; Fri, 21 Feb 2025 07:26:41 -0500 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-220f4dd756eso39399295ad.3 for ; Fri, 21 Feb 2025 04:26:38 -0800 (PST) Received: from grind.dc1.ventanamicro.com ([187.11.154.120]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d545e39bsm137349855ad.124.2025.02.21.04.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 04:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1740140797; x=1740745597; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RcXDBri0g1fUiIwIh0GNJUeIssgoJJnkBzPq36LziBM=; b=fnhiyTEYh4WO5hP+oYnYevI6e+EM58N24CMJzarTJ0m952B0qbBEAbZtwnCWF5RI60 HFS8i98fa9haPzQpld7NLuo7R/Gl6K22CxwaIeiNvMQuf1Chk0JiSpCSz7ZLA5YUmqtJ f61LOAeP6IgVqsb87lSzA5LHe0cC0/oJiZNQnQfdxeHv8f2oOr0U+28a8mP/rQvyXM2V zTsxZcuulWU2y6z0NeAV7X7UdtNLIHN7LcaXx1X1UldhEqmdSstgwVnFhiqOzRv5qV7E /UismeJl7IfjeoGG/5Hpxb4dRLpikpozMdrVls7efO5pTsfVgqSmeAWVN/7Ye/WWtguT i99g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740140797; x=1740745597; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RcXDBri0g1fUiIwIh0GNJUeIssgoJJnkBzPq36LziBM=; b=abhghINJpKRFgy3oDT5e0+uLIvsTjXNzOMiBjNt9yExVas0SoAC9g8eSTO0XKr8Ut+ 7TYC3zbhWEPDyXS2uVfr3I/yLJUVxwoyRtS53Q/qtsUHdttaH1LypYDzciKzL2Lz0aBT Y7ThlE78BmzFRahWs1dQZW+f/4DI6r/Wve/FbYZQAiYPZA/ELVILcREpSdLKyQC8ub47 UDNOv0c3b+T4UFpn3ldSnCM8Ims0occBAXnPAZBhWZOLLFC5sjrMuQ1vQBYKqZfrl6jI t8b9UyDyRxmgzHlAka3lTem3ULsjn2Ud8ySlFwkaWogMQR5yU6TP9nUTPd7ifaj3o+Ns ebJQ== X-Gm-Message-State: AOJu0YzC+5FCCzGD8T1SA3d5tv+h2+RtYZK+/+i042HzUiN1JOKmWRTN zruj+/e8cQLbHQkXVg5ByPZH/4ZtpJ+g9KTnxkO3k5wZiOt1uke1QVqhKo6LP9VVUXpG3ey2v7H 6 X-Gm-Gg: ASbGncsajtaKTo2jcgHSWk8t/Hbr0rMsY5POcDE8DqwIKUp2trypSiAKa/ZRGZSvoLf E+FJKjLI7ghtvXPKuL+8LuBLAinNcmF9MokqhZSWx3pXFUrRQ6YxAnT2H2uYQoU0lVTh2LUCpJH pB0ZME0HpX9PlRIep/MtpQCScx40s19KShaXDHf9uk7uuGLn+O3IvzANtAv5IrdeAH7ooWMQ/nO DBqPQ83fEFMQ1rT3ek9k1dYKXn2N96wATMvFCZilZTmtXzUwIbARHARzfK8QKkqczmUIQ5FG+1F tFgPXJHkBXIulHmwt8EiGi6nXIjXisGiRwBbTpRtC99wzlKXYnZHZg== X-Google-Smtp-Source: AGHT+IFV3tYjCFqEm2Jkp3XNzl1+zGp+f3P76lLYF/zVrUOLK3V8yvV1pSnoYT1DgmfgE5yXlZwhFA== X-Received: by 2002:a17:902:e5d0:b0:21f:5cd8:c67 with SMTP id d9443c01a7336-2219ff5f44amr43503845ad.31.1740140797052; Fri, 21 Feb 2025 04:26:37 -0800 (PST) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, ajones@ventanamicro.com, Daniel Henrique Barboza Subject: [PATCH v2 2/3] target/riscv/kvm: add kvm_riscv_reset_regs_csr() Date: Fri, 21 Feb 2025 09:26:22 -0300 Message-ID: <20250221122623.495188-3-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250221122623.495188-1-dbarboza@ventanamicro.com> References: <20250221122623.495188-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=dbarboza@ventanamicro.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ventanamicro.com) X-ZM-MESSAGEID: 1740140949272019100 Content-Type: text/plain; charset="utf-8" We're setting reset vals for KVM csrs during kvm_riscv_reset_vcpu(), but in no particular order and missing some of them (like env->mstatus). Create a helper to do that, unclogging reset_vcpu(), and initialize env->mstatus as well. Keep the regs in the same order they appear in struct kvm_riscv_csr from the KVM UAPI, similar to what kvm_riscv_(get|put)_regs_csr are doing. This will make a bit easier to add new KVM CSRs and to verify which values we're writing back to KVM during vcpu reset. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones --- target/riscv/kvm/kvm-cpu.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index 484b6afe7c..f14fcc58bb 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -605,6 +605,19 @@ static int kvm_riscv_put_regs_core(CPUState *cs) return ret; } =20 +static void kvm_riscv_reset_regs_csr(CPURISCVState *env) +{ + env->mstatus =3D 0; + env->mie =3D 0; + env->stvec =3D 0; + env->sscratch =3D 0; + env->sepc =3D 0; + env->scause =3D 0; + env->stval =3D 0; + env->mip =3D 0; + env->satp =3D 0; +} + static int kvm_riscv_get_regs_csr(CPUState *cs) { CPURISCVState *env =3D &RISCV_CPU(cs)->env; @@ -1609,14 +1622,8 @@ void kvm_riscv_reset_vcpu(RISCVCPU *cpu) env->pc =3D cpu->env.kernel_addr; env->gpr[10] =3D kvm_arch_vcpu_id(CPU(cpu)); /* a0 */ env->gpr[11] =3D cpu->env.fdt_addr; /* a1 */ - env->satp =3D 0; - env->mie =3D 0; - env->stvec =3D 0; - env->sscratch =3D 0; - env->sepc =3D 0; - env->scause =3D 0; - env->stval =3D 0; - env->mip =3D 0; + + kvm_riscv_reset_regs_csr(env); } =20 void kvm_riscv_set_irq(RISCVCPU *cpu, int irq, int level) --=20 2.48.1 From nobody Sun Feb 23 05:59:28 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1740141118; cv=none; d=zohomail.com; s=zohoarc; b=G6zMg68X9bLPcXfzx8TfKWFi38zFSw+P1Hz0Z4wzgSVbjkRmJuT6Y2nFCgh9GHEOMVuO8HRZnvyi46AKotgUqz+vetplh4qpBy8miBWN/oemL1PiW1Kj/g5S7j7T+QeBkxkwUUWAutC0H5l4DAMriIiUyj9f9MBLd4FFcVn0tSQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1740141118; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/5vHs7s8IDk62c++QK817lUpigrwYrALES9gEU4BPmI=; b=Fx3CL9Lpk3xCFzK2GN9kPeUWtnUFgQlRPgzuYlhC0nj3npa24oI0m6SbVduIVT9u9Yy87yD/NkUtF7ZeZo/LcTrm14K1tG41+Zhkn+vh8OES2Vxsvc1oK6hJsQ9JidBXT3XxUEhQ/rkQjsTAw4NDEqwS59kL0uQhGlALA1JNmEQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1740141118282689.2059401924572; Fri, 21 Feb 2025 04:31:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tlS8i-00085I-Kf; Fri, 21 Feb 2025 07:28:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlS79-0006Ie-Lp for qemu-devel@nongnu.org; Fri, 21 Feb 2025 07:26:45 -0500 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tlS77-0007Zq-SF for qemu-devel@nongnu.org; Fri, 21 Feb 2025 07:26:43 -0500 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-220d601886fso30230895ad.1 for ; Fri, 21 Feb 2025 04:26:41 -0800 (PST) Received: from grind.dc1.ventanamicro.com ([187.11.154.120]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d545e39bsm137349855ad.124.2025.02.21.04.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 04:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1740140800; x=1740745600; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/5vHs7s8IDk62c++QK817lUpigrwYrALES9gEU4BPmI=; b=W4nVNOIkHyagGY4vO3jFEv7HgwA8bP3epfEEW3M2A2pTGa+q3jOIkerAQcL8MJLZwz 4cTGoQfTXgzHCCaF5ChrDWHwsy37xxQUg7s02Ub7B44bZ5gK9oW1iZQwONnZCr9zmyQT mIC/Sh3OkFgfqUqUTapzPDTzT8laJD0vhwK1CmKKFb+oT/Ha//nj2PnWxqvmuAvbfYoa VG1ZNS9pUzXhf7jReD792n3j2ymC65yBy7U8f5eBvZBtiVVoEDOyXceYoa5/KB3WeUSA IvLw0+FY8X+FbQwfUaEPhY4M0iKa3K7Gjpxf9ved5TvfVR8g28QnmBmyJbKqZMtmG0RT HQQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740140800; x=1740745600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/5vHs7s8IDk62c++QK817lUpigrwYrALES9gEU4BPmI=; b=XDQ5KxyjW3pjiqI7uKio2V3MY+sNbCizgB9zRc3y/pdmB+QDS4HF19fss/7gsNTyhQ SjlanZAIs1KKjXsvTlFhU/4lv7JpNdZkxkQfe73GaFGSyZVaoMBrtMRihzIBdf9vsLO9 dfU7yaw2qvTwNLwKSJ58g/dqZgHpXVafMlxHSPwC8Hsu/dEwz9zRS5LERAZs6VZGmaF8 Dn3Z2peMlU5PzxFCBnVmDcGx/Mlkb29S9sBdNHKdIucntIVsQoqVREQSktNp6bIgmVHb 9BlRRvLuBee6VWbTYezBQTNdfIbbZqCTQkiJ8K0kpP7pYs4K23JCTHwUZhGlUXqizcnC ihow== X-Gm-Message-State: AOJu0YySzs8WirRK7oStw/IPDDQFpgGK5eqy2j6cmncf/cr6ZD4VMrpy CVlqZKl1fOD6q8u4hyNPzhtgsNnhJuNCxjKTbVdFYZPNavQy8vNlGh89cdT5W2BojhTO7yItwEm f X-Gm-Gg: ASbGncujmfC3rQeNtkXU19Mwo1w7Umd6tCS7Wo9kWG7qgUf6FEKWmOw7Zl/XP7Ft2gx Kr89C55wSYZAM/6PlP4dTgH2e1R5E+Htj97RADz2jU5Yjzfs+es+WjTvVq65TjZrhxecNKj7Hh0 Lg8JW0YaIi7gb7sLbbwwAEAhlp42UmFlcMM3GCr02oYRha4Puxm3/iyDvoYoMqDlyayhRXZISQZ zX2M11RdznRFmAMUSDIJJQxSinsZu75kIgcqOYDTpl9fkyitUhdEb3p4k9dfCvPYzg09i4gs+1x E1wY9uCTLrwLp8OPx3fOGdF8wPtIY5tgL9gkiAtFJWV//mYpeD+JuA== X-Google-Smtp-Source: AGHT+IGxdhq7J04pllruTn2puOm3WoDedsVx72P6r2m/M4y8uZL7gZH9hOUBc0fjulX1ysaHo2OXmA== X-Received: by 2002:a17:902:db05:b0:21f:768:cced with SMTP id d9443c01a7336-2219ff30cfemr34573715ad.8.1740140800154; Fri, 21 Feb 2025 04:26:40 -0800 (PST) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, ajones@ventanamicro.com, Daniel Henrique Barboza Subject: [PATCH v2 3/3] target/riscv/kvm: add missing KVM CSRs Date: Fri, 21 Feb 2025 09:26:23 -0300 Message-ID: <20250221122623.495188-4-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250221122623.495188-1-dbarboza@ventanamicro.com> References: <20250221122623.495188-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=dbarboza@ventanamicro.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ventanamicro.com) X-ZM-MESSAGEID: 1740141119156019000 Content-Type: text/plain; charset="utf-8" We're missing scounteren and senvcfg CSRs, both already present in the KVM UAPI. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones --- target/riscv/kvm/kvm-cpu.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index f14fcc58bb..017ca82226 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -616,6 +616,8 @@ static void kvm_riscv_reset_regs_csr(CPURISCVState *env) env->stval =3D 0; env->mip =3D 0; env->satp =3D 0; + env->scounteren =3D 0; + env->senvcfg =3D 0; } =20 static int kvm_riscv_get_regs_csr(CPUState *cs) @@ -631,6 +633,8 @@ static int kvm_riscv_get_regs_csr(CPUState *cs) KVM_RISCV_GET_CSR(cs, env, stval, env->stval); KVM_RISCV_GET_CSR(cs, env, sip, env->mip); KVM_RISCV_GET_CSR(cs, env, satp, env->satp); + KVM_RISCV_GET_CSR(cs, env, scounteren, env->scounteren); + KVM_RISCV_GET_CSR(cs, env, senvcfg, env->senvcfg); =20 return 0; } @@ -648,6 +652,8 @@ static int kvm_riscv_put_regs_csr(CPUState *cs) KVM_RISCV_SET_CSR(cs, env, stval, env->stval); KVM_RISCV_SET_CSR(cs, env, sip, env->mip); KVM_RISCV_SET_CSR(cs, env, satp, env->satp); + KVM_RISCV_SET_CSR(cs, env, scounteren, env->scounteren); + KVM_RISCV_SET_CSR(cs, env, senvcfg, env->senvcfg); =20 return 0; } --=20 2.48.1