From nobody Fri Apr 4 03:48:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1739887589996584.7469396531872; Tue, 18 Feb 2025 06:06:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tkOEl-0002qD-1Y; Tue, 18 Feb 2025 09:06:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tkJT0-0002ws-8u for qemu-devel@nongnu.org; Tue, 18 Feb 2025 04:00:35 -0500 Received: from air.basealt.ru ([193.43.8.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tkJSx-0005ME-Gq for qemu-devel@nongnu.org; Tue, 18 Feb 2025 04:00:33 -0500 Received: from happy.malta.altlinux.ru (obninsk.basealt.ru [217.15.195.17]) (Authenticated sender: sergeevdv) by air.basealt.ru (Postfix) with ESMTPSA id 48904233BC; Tue, 18 Feb 2025 12:00:22 +0300 (MSK) From: zeff@altlinux.org To: qemu-devel@nongnu.org Cc: mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com, peter.maydell@linaro.org, sdl.qemu@linuxtesting.org, e.bykhanova@fobos-nt.ru, sergeevdv@basealt.ru, Denis Sergeev Subject: [sdl-qemu] [PATCH] disas/sparc: Fix integer overflow in compare_opcodes() Date: Tue, 18 Feb 2025 11:58:35 +0300 Message-ID: <20250218085835.64928-1-zeff@altlinux.org> X-Mailer: git-send-email 2.42.4 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=193.43.8.18; envelope-from=zeff@altlinux.org; helo=air.basealt.ru X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 18 Feb 2025 09:06:04 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1739887594409019000 Content-Type: text/plain; charset="utf-8" From: Denis Sergeev Fix an integer overflow issue caused by a left shift operation (1 << i) on an int literal. For i >=3D 31, this could lead to undefined behavior by exceeding the 32-bit range. To prevent this, explicitly cast the literal to an unsigned long int (1UL << i), ensuring the shift operation is performed safely. Found by Linux Verification Center (linuxtesting.org) with SVACE. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2618 Reported-by: E. Bykhanova Signed-off-by: Denis Sergeev --- disas/sparc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/disas/sparc.c b/disas/sparc.c index 5689533ce1..92b9ac754f 100644 --- a/disas/sparc.c +++ b/disas/sparc.c @@ -2515,7 +2515,7 @@ compare_opcodes (const void * a, const void * b) another, it is important to order the opcodes in the right order. */ for (i =3D 0; i < 32; ++i) { - unsigned long int x =3D 1 << i; + unsigned long int x =3D 1UL << i; int x0 =3D (match0 & x) !=3D 0; int x1 =3D (match1 & x) !=3D 0; =20 @@ -2525,7 +2525,7 @@ compare_opcodes (const void * a, const void * b) =20 for (i =3D 0; i < 32; ++i) { - unsigned long int x =3D 1 << i; + unsigned long int x =3D 1UL << i; int x0 =3D (lose0 & x) !=3D 0; int x1 =3D (lose1 & x) !=3D 0; =20 --=20 2.42.4