From nobody Fri Mar 14 13:11:41 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1738879980; cv=none; d=zohomail.com; s=zohoarc; b=bFFyHpjhoeXvfnHePf8pp8qaaRoGzlMDxkmDKp7gStrqaB5S6xv1Q2D23NKqnM4yP1D2uV+Vpnwzk1lC3yC/jt8f+0G3gLrrEVqiFWxaZ5TZ3DKTIZb1VwQHvyIIGsNU2hN/AaGURMcG0ut1jL7KElyVubQ7p0jQ+WFZOmk0UZk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1738879980; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=w+/s6arKkKf3OOpvfAG2zbpOFKr5mJjRGCLlPyZPHrU=; b=j2z2EuBo06fQmOqmiHTh5ICInlEmO/MktGXQDZw/Cdg+++pQL5PIWXbAzeqWgaaLMigf8GcVcWj27Z9Asyr5g8RbQgOV/APiENLMKN8+POXx+AwDRRoUZ37Dz78r5ZSgVWHckOMC6qXcKD6pxoASoy2ZOAXSHKQwrfDzYKmZVj8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1738879980991739.1839851785319; Thu, 6 Feb 2025 14:13:00 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tgA6p-0005lv-QZ; Thu, 06 Feb 2025 17:12:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3vzOlZwgKCv420nguzynmuumrk.iuswks0-jk1krtutmt0.uxm@flex--wuhaotsh.bounces.google.com>) id 1tgA6f-0005dM-Vq for qemu-devel@nongnu.org; Thu, 06 Feb 2025 17:12:24 -0500 Received: from mail-pj1-x1049.google.com ([2607:f8b0:4864:20::1049]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3vzOlZwgKCv420nguzynmuumrk.iuswks0-jk1krtutmt0.uxm@flex--wuhaotsh.bounces.google.com>) id 1tgA6c-0001Qj-KF for qemu-devel@nongnu.org; Thu, 06 Feb 2025 17:12:20 -0500 Received: by mail-pj1-x1049.google.com with SMTP id 98e67ed59e1d1-2f81a0d0a18so2919965a91.3 for ; Thu, 06 Feb 2025 14:12:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738879936; x=1739484736; darn=nongnu.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=w+/s6arKkKf3OOpvfAG2zbpOFKr5mJjRGCLlPyZPHrU=; b=obkBpLTc/FRs8c0LCNJicS+uGgRpVGPaotwYJUpLVNa9MtBtX2v+L/78/F2Dxd2pEy UZeeqscRPDRJFAlFw8kbeqwLgdVET5o8cr4XVYgy96kH1IwagL92twLbNXmqstEOsnnl 6B/qJc3eYCtbcRepAXxWBurqegH7eWFtI19U8e9LZPRXDyOIGWYMLDXk3eHOnnf2xcua b2q+gPGIG1VS+h8wAHFsJ+b7oAjULaUGtZGREx1POThvbzfxy3dwYsvjTlfxKqLNq0kY bjTtu/bqkLuhUTIDXU1qYPjM8d1dWL4JEjmAGdERdGV+exKiH6JiLikuOF7INC7mUVAd tpjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738879936; x=1739484736; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w+/s6arKkKf3OOpvfAG2zbpOFKr5mJjRGCLlPyZPHrU=; b=oGxq/RPoGG/KyHhVk+Gs4TAPBOyDx7x/kLt0lUq5YB6PB5/Saq76RF3e6gvj3dtLL6 OsabdcBoO8vIU7gksymC4HxMxFqDL7w3WyQruqsPhiBytnO3kNuzbN/cj1iFMmoDGtpb ZosGn8Aw6XHsf3AGDWjX7gtQ+1BqAV6IoWLHrwa/exxWVYoIaTXu6eT+sThi5Pyyf5dx fEypFbW1eFR7K0ojYAQjLnmQQmrob1I1YlXFGUtsIq/Uc2H2TS613nZc/d1uQAxIXLRu /I7zIkPs2SvOhVUafVccmS++qDJtkB5InOfbdNaK/B7ht1UTUXbw3R7PLN2knVhHyeEW HkKw== X-Forwarded-Encrypted: i=1; AJvYcCWamoL2vPfP5iSJ5XkhlrG6+yg/vQ0R5eQ1W/qgbf9DgiKfVKK/GLVpeQGGKnJDUZYghUTA89dHwSev@nongnu.org X-Gm-Message-State: AOJu0YwU/XmnHxJAAGRz1XM+amoBxGjJWkKzj2TOOJp9He+zuAxqbQkC uY0Zn7s81HaR7cRZohSsAnlnoTEcqm2HbwirC6ZSgsLewFZJGTN5lbGijKIlRq8AlUVkcJlUfei ofhZGnyFMOg== X-Google-Smtp-Source: AGHT+IFiLFV2x+DdIX606QvDdK+HPaKqCzQ30V5NjEUrBSu5lRws4pg5PQjceYnhGD7OF2Y/drPZBpecij07rA== X-Received: from pjbli13.prod.google.com ([2002:a17:90b:48cd:b0:2f5:4762:e778]) (user=wuhaotsh job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3143:b0:2ee:f22a:61dd with SMTP id 98e67ed59e1d1-2fa243eef9bmr1009421a91.32.1738879935745; Thu, 06 Feb 2025 14:12:15 -0800 (PST) Date: Thu, 6 Feb 2025 14:11:51 -0800 In-Reply-To: <20250206221203.4187217-1-wuhaotsh@google.com> Mime-Version: 1.0 References: <20250206221203.4187217-1-wuhaotsh@google.com> X-Mailer: git-send-email 2.48.1.502.g6dc24dfdaf-goog Message-ID: <20250206221203.4187217-6-wuhaotsh@google.com> Subject: [PATCH v4 05/17] hw/misc: Move NPCM7XX GCR to NPCM GCR From: Hao Wu To: peter.maydell@linaro.org Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, wuhaotsh@google.com, venture@google.com, Avi.Fishman@nuvoton.com, kfting@nuvoton.com, hskinnemoen@google.com, titusr@google.com, chli30@nuvoton.corp-partner.google.com, pbonzini@redhat.com, jasowang@redhat.com, alistair@alistair23.me, philmd@linaro.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1049; envelope-from=3vzOlZwgKCv420nguzynmuumrk.iuswks0-jk1krtutmt0.uxm@flex--wuhaotsh.bounces.google.com; helo=mail-pj1-x1049.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1738879983509019000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A lot of NPCM7XX and NPCM8XX GCR modules share the same code, this commit moves the NPCM7XX GCR to NPCM GCR for these properties. Reviewed-by: Peter Maydell Signed-off-by: Hao Wu --- hw/misc/npcm_gcr.c | 92 +++++++++++++++++++++----------------- hw/misc/trace-events | 6 +-- include/hw/arm/npcm7xx.h | 2 +- include/hw/misc/npcm_gcr.h | 7 +-- 4 files changed, 59 insertions(+), 48 deletions(-) diff --git a/hw/misc/npcm_gcr.c b/hw/misc/npcm_gcr.c index 826fd41123..0959f2e5c4 100644 --- a/hw/misc/npcm_gcr.c +++ b/hw/misc/npcm_gcr.c @@ -84,10 +84,10 @@ static const uint32_t cold_reset_values[NPCM7XX_GCR_NR_= REGS] =3D { [NPCM7XX_GCR_USB2PHYCTL] =3D 0x034730e4, }; =20 -static uint64_t npcm7xx_gcr_read(void *opaque, hwaddr offset, unsigned siz= e) +static uint64_t npcm_gcr_read(void *opaque, hwaddr offset, unsigned size) { uint32_t reg =3D offset / sizeof(uint32_t); - NPCM7xxGCRState *s =3D opaque; + NPCMGCRState *s =3D opaque; =20 if (reg >=3D NPCM7XX_GCR_NR_REGS) { qemu_log_mask(LOG_GUEST_ERROR, @@ -96,19 +96,19 @@ static uint64_t npcm7xx_gcr_read(void *opaque, hwaddr o= ffset, unsigned size) return 0; } =20 - trace_npcm7xx_gcr_read(offset, s->regs[reg]); + trace_npcm_gcr_read(offset, s->regs[reg]); =20 return s->regs[reg]; } =20 -static void npcm7xx_gcr_write(void *opaque, hwaddr offset, +static void npcm_gcr_write(void *opaque, hwaddr offset, uint64_t v, unsigned size) { uint32_t reg =3D offset / sizeof(uint32_t); - NPCM7xxGCRState *s =3D opaque; + NPCMGCRState *s =3D opaque; uint32_t value =3D v; =20 - trace_npcm7xx_gcr_write(offset, value); + trace_npcm_gcr_write(offset, value); =20 if (reg >=3D NPCM7XX_GCR_NR_REGS) { qemu_log_mask(LOG_GUEST_ERROR, @@ -142,9 +142,9 @@ static void npcm7xx_gcr_write(void *opaque, hwaddr offs= et, s->regs[reg] =3D value; } =20 -static const struct MemoryRegionOps npcm7xx_gcr_ops =3D { - .read =3D npcm7xx_gcr_read, - .write =3D npcm7xx_gcr_write, +static const struct MemoryRegionOps npcm_gcr_ops =3D { + .read =3D npcm_gcr_read, + .write =3D npcm_gcr_write, .endianness =3D DEVICE_LITTLE_ENDIAN, .valid =3D { .min_access_size =3D 4, @@ -155,7 +155,7 @@ static const struct MemoryRegionOps npcm7xx_gcr_ops =3D= { =20 static void npcm7xx_gcr_enter_reset(Object *obj, ResetType type) { - NPCM7xxGCRState *s =3D NPCM7XX_GCR(obj); + NPCMGCRState *s =3D NPCM_GCR(obj); =20 QEMU_BUILD_BUG_ON(sizeof(s->regs) !=3D sizeof(cold_reset_values)); =20 @@ -165,10 +165,10 @@ static void npcm7xx_gcr_enter_reset(Object *obj, Rese= tType type) s->regs[NPCM7XX_GCR_INTCR3] =3D s->reset_intcr3; } =20 -static void npcm7xx_gcr_realize(DeviceState *dev, Error **errp) +static void npcm_gcr_realize(DeviceState *dev, Error **errp) { ERRP_GUARD(); - NPCM7xxGCRState *s =3D NPCM7XX_GCR(dev); + NPCMGCRState *s =3D NPCM_GCR(dev); uint64_t dram_size; Object *obj; =20 @@ -210,55 +210,65 @@ static void npcm7xx_gcr_realize(DeviceState *dev, Err= or **errp) s->reset_intcr3 |=3D ctz64(dram_size / NPCM7XX_GCR_MIN_DRAM_SIZE) << 8; } =20 -static void npcm7xx_gcr_init(Object *obj) +static void npcm_gcr_init(Object *obj) { - NPCM7xxGCRState *s =3D NPCM7XX_GCR(obj); + NPCMGCRState *s =3D NPCM_GCR(obj); =20 - memory_region_init_io(&s->iomem, obj, &npcm7xx_gcr_ops, s, - TYPE_NPCM7XX_GCR, 4 * KiB); + memory_region_init_io(&s->iomem, obj, &npcm_gcr_ops, s, + TYPE_NPCM_GCR, 4 * KiB); sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->iomem); } =20 -static const VMStateDescription vmstate_npcm7xx_gcr =3D { - .name =3D "npcm7xx-gcr", - .version_id =3D 0, - .minimum_version_id =3D 0, +static const VMStateDescription vmstate_npcm_gcr =3D { + .name =3D "npcm-gcr", + .version_id =3D 1, + .minimum_version_id =3D 1, .fields =3D (const VMStateField[]) { - VMSTATE_UINT32_ARRAY(regs, NPCM7xxGCRState, NPCM7XX_GCR_NR_REGS), + VMSTATE_UINT32_ARRAY(regs, NPCMGCRState, NPCM7XX_GCR_NR_REGS), VMSTATE_END_OF_LIST(), }, }; =20 -static const Property npcm7xx_gcr_properties[] =3D { - DEFINE_PROP_UINT32("disabled-modules", NPCM7xxGCRState, reset_mdlr, 0), - DEFINE_PROP_UINT32("power-on-straps", NPCM7xxGCRState, reset_pwron, 0), +static const Property npcm_gcr_properties[] =3D { + DEFINE_PROP_UINT32("disabled-modules", NPCMGCRState, reset_mdlr, 0), + DEFINE_PROP_UINT32("power-on-straps", NPCMGCRState, reset_pwron, 0), }; =20 -static void npcm7xx_gcr_class_init(ObjectClass *klass, void *data) +static void npcm_gcr_class_init(ObjectClass *klass, void *data) { - ResettableClass *rc =3D RESETTABLE_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 QEMU_BUILD_BUG_ON(NPCM7XX_GCR_REGS_END > NPCM7XX_GCR_NR_REGS); + dc->realize =3D npcm_gcr_realize; + dc->vmsd =3D &vmstate_npcm_gcr; + + device_class_set_props(dc, npcm_gcr_properties); +} + +static void npcm7xx_gcr_class_init(ObjectClass *klass, void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + ResettableClass *rc =3D RESETTABLE_CLASS(klass); =20 + QEMU_BUILD_BUG_ON(NPCM7XX_GCR_REGS_END !=3D NPCM7XX_GCR_NR_REGS); dc->desc =3D "NPCM7xx System Global Control Registers"; - dc->realize =3D npcm7xx_gcr_realize; - dc->vmsd =3D &vmstate_npcm7xx_gcr; rc->phases.enter =3D npcm7xx_gcr_enter_reset; =20 - device_class_set_props(dc, npcm7xx_gcr_properties); } =20 -static const TypeInfo npcm7xx_gcr_info =3D { - .name =3D TYPE_NPCM7XX_GCR, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_size =3D sizeof(NPCM7xxGCRState), - .instance_init =3D npcm7xx_gcr_init, - .class_init =3D npcm7xx_gcr_class_init, +static const TypeInfo npcm_gcr_info[] =3D { + { + .name =3D TYPE_NPCM_GCR, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(NPCMGCRState), + .instance_init =3D npcm_gcr_init, + .class_init =3D npcm_gcr_class_init, + .abstract =3D true, + }, + { + .name =3D TYPE_NPCM7XX_GCR, + .parent =3D TYPE_NPCM_GCR, + .class_init =3D npcm7xx_gcr_class_init, + }, }; - -static void npcm7xx_gcr_register_type(void) -{ - type_register_static(&npcm7xx_gcr_info); -} -type_init(npcm7xx_gcr_register_type); +DEFINE_TYPES(npcm_gcr_info) diff --git a/hw/misc/trace-events b/hw/misc/trace-events index b35b0e77f7..0f7204a237 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -134,9 +134,9 @@ mos6522_read(uint64_t addr, const char *name, unsigned = val) "reg=3D0x%"PRIx64 " [% npcm7xx_clk_read(uint64_t offset, uint32_t value) " offset: 0x%04" PRIx64 = " value: 0x%08" PRIx32 npcm7xx_clk_write(uint64_t offset, uint32_t value) "offset: 0x%04" PRIx64 = " value: 0x%08" PRIx32 =20 -# npcm7xx_gcr.c -npcm7xx_gcr_read(uint64_t offset, uint32_t value) " offset: 0x%04" PRIx64 = " value: 0x%08" PRIx32 -npcm7xx_gcr_write(uint64_t offset, uint32_t value) "offset: 0x%04" PRIx64 = " value: 0x%08" PRIx32 +# npcm_gcr.c +npcm_gcr_read(uint64_t offset, uint32_t value) " offset: 0x%04" PRIx64 " v= alue: 0x%08" PRIx32 +npcm_gcr_write(uint64_t offset, uint32_t value) "offset: 0x%04" PRIx64 " v= alue: 0x%08" PRIx32 =20 # npcm7xx_mft.c npcm7xx_mft_read(const char *name, uint64_t offset, uint16_t value) "%s: o= ffset: 0x%04" PRIx64 " value: 0x%04" PRIx16 diff --git a/include/hw/arm/npcm7xx.h b/include/hw/arm/npcm7xx.h index 510170471e..2e708471ec 100644 --- a/include/hw/arm/npcm7xx.h +++ b/include/hw/arm/npcm7xx.h @@ -89,7 +89,7 @@ struct NPCM7xxState { MemoryRegion ram3; MemoryRegion *dram; =20 - NPCM7xxGCRState gcr; + NPCMGCRState gcr; NPCM7xxCLKState clk; NPCM7xxTimerCtrlState tim[3]; NPCM7xxADCState adc; diff --git a/include/hw/misc/npcm_gcr.h b/include/hw/misc/npcm_gcr.h index 9b4998950c..6d3d00d260 100644 --- a/include/hw/misc/npcm_gcr.h +++ b/include/hw/misc/npcm_gcr.h @@ -55,7 +55,7 @@ */ #define NPCM7XX_GCR_NR_REGS (0x148 / sizeof(uint32_t)) =20 -struct NPCM7xxGCRState { +typedef struct NPCMGCRState { SysBusDevice parent; =20 MemoryRegion iomem; @@ -65,9 +65,10 @@ struct NPCM7xxGCRState { uint32_t reset_pwron; uint32_t reset_mdlr; uint32_t reset_intcr3; -}; +} NPCMGCRState; =20 +#define TYPE_NPCM_GCR "npcm-gcr" #define TYPE_NPCM7XX_GCR "npcm7xx-gcr" -OBJECT_DECLARE_SIMPLE_TYPE(NPCM7xxGCRState, NPCM7XX_GCR) +OBJECT_DECLARE_SIMPLE_TYPE(NPCMGCRState, NPCM_GCR) =20 #endif /* NPCM_GCR_H */ --=20 2.48.1.502.g6dc24dfdaf-goog