From nobody Thu Apr 3 11:36:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1738603236; cv=none; d=zohomail.com; s=zohoarc; b=D6IhUloHWArzBPM1PyUDwlvcg0okMdbnfizwE9j9ZM4jsaBqhPI2o8cnqImhsq8EbAWT+77uenWKj/0FCnXGgGfYNfjPo4gZzbj6Hof50qaDeW9gem1TPHMMNFZEChyqY0AKd1a3t5q8tuncDBc/FFo07j7LQd8Q0TFoICkskV8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1738603236; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=J+zgXfsmij6i3CLkjUbWumZkTeNWh/0pkGCgM9POXrM=; b=HwYRSRJvVWN8Uo+DYJLJWcoGLs+mzbS4vUnq5HXXrvE26P/eLR3sXPKsu/Bl6oPh+WI7mgMQMy2Uc+eVLOcpXvgO/yy8Kqw1Td+wcG5YuADWCoHN7lWYeC+m7ijRn4uSiSkDHH6NW7d4HXGy75tFHUScp24m3OIZFZmOgOSKLuQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1738603236528823.9376421820559; Mon, 3 Feb 2025 09:20:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tf06f-0008A9-P8; Mon, 03 Feb 2025 12:19:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tf06d-00089M-Ax for qemu-devel@nongnu.org; Mon, 03 Feb 2025 12:19:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tf06b-0003zh-N1 for qemu-devel@nongnu.org; Mon, 03 Feb 2025 12:19:31 -0500 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-mL05zMfEP0eZscli6ue91Q-1; Mon, 03 Feb 2025 12:19:25 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B44B11955DCD; Mon, 3 Feb 2025 17:19:24 +0000 (UTC) Received: from localhost (unknown [10.39.208.25]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EC82018008C0; Mon, 3 Feb 2025 17:19:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738603169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J+zgXfsmij6i3CLkjUbWumZkTeNWh/0pkGCgM9POXrM=; b=e7nabNn9PdeB22oRhpsXYkYbXdueC1O5W/eKC8C0dJ7m6hYqIq04Z1V45sHDL6HI8B1VLt upBaT16gXym3DfaoVjjRPv0Gq0Ekuhmdfaf0z540jRJWLwCO+J/BM3TW8s1GU0rYK+J5Hk sIbSNrRCw5lXjrt+dAJ7QQTKGsCHSu4= X-MC-Unique: mL05zMfEP0eZscli6ue91Q-1 X-Mimecast-MFC-AGG-ID: mL05zMfEP0eZscli6ue91Q From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Mahmoud Mandour , Pierrick Bouvier , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Markus Armbruster , Paolo Bonzini , Gerd Hoffmann , Eric Blake , =?UTF-8?q?Alex=20Benn=C3=A9e?= , peter.maydell@linaro.org, Alexandre Iooss Subject: [PULL v2 5/8] ui/dbus: on win32, allow ANONYMOUS with p2p Date: Mon, 3 Feb 2025 21:18:45 +0400 Message-ID: <20250203171848.686582-6-marcandre.lureau@redhat.com> In-Reply-To: <20250203171848.686582-1-marcandre.lureau@redhat.com> References: <20250203171848.686582-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1738603242052019100 From: Marc-Andr=C3=A9 Lureau GLib doesn't implement EXTERNAL on win32 at the moment, and disables ANONYMOUS by default. zbus dropped support for COOKIE_SHA1 in 5.0, making it no longer possible to connect to qemu -display dbus. Since p2p connections are gated by existing QMP (or a D-Bus connection), qemu -display dbus p2p can accept authentication with ANONYMOUS. Signed-off-by: Marc-Andr=C3=A9 Lureau --- audio/dbusaudio.c | 8 +++++++- ui/dbus-console.c | 8 +++++++- ui/dbus.c | 10 ++++++++-- 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/audio/dbusaudio.c b/audio/dbusaudio.c index 095e739382..af77e7cc33 100644 --- a/audio/dbusaudio.c +++ b/audio/dbusaudio.c @@ -524,11 +524,17 @@ dbus_audio_register_listener(AudioState *s, ); } =20 + GDBusConnectionFlags flags =3D + G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_SERVER; +#ifdef WIN32 + flags |=3D G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_ALLOW_ANONYMOUS; +#endif + listener_conn =3D g_dbus_connection_new_sync( G_IO_STREAM(socket_conn), guid, - G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_SERVER, + flags, NULL, NULL, &err); if (err) { error_report("Failed to setup peer connection: %s", err->message); diff --git a/ui/dbus-console.c b/ui/dbus-console.c index 5eb1d40d16..85e215ef23 100644 --- a/ui/dbus-console.c +++ b/ui/dbus-console.c @@ -305,10 +305,16 @@ dbus_console_register_listener(DBusDisplayConsole *dd= c, #endif ); =20 + GDBusConnectionFlags flags =3D + G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_SERVER; +#ifdef WIN32 + flags |=3D G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_ALLOW_ANONYMOUS; +#endif + listener_conn =3D g_dbus_connection_new_sync( G_IO_STREAM(socket_conn), guid, - G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_SERVER, + flags, NULL, NULL, &err); if (err) { error_report("Failed to setup peer connection: %s", err->message); diff --git a/ui/dbus.c b/ui/dbus.c index 7b258c6823..2eb03aa247 100644 --- a/ui/dbus.c +++ b/ui/dbus.c @@ -317,11 +317,17 @@ dbus_display_add_client(int csock, Error **errp) conn =3D g_socket_connection_factory_create_connection(socket); =20 dbus_display->add_client_cancellable =3D g_cancellable_new(); + GDBusConnectionFlags flags =3D + G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_SERVER | + G_DBUS_CONNECTION_FLAGS_DELAY_MESSAGE_PROCESSING; + +#ifdef WIN32 + flags |=3D G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_ALLOW_ANONYMOUS; +#endif =20 g_dbus_connection_new(G_IO_STREAM(conn), guid, - G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_SERVER | - G_DBUS_CONNECTION_FLAGS_DELAY_MESSAGE_PROCESSING, + flags, NULL, dbus_display->add_client_cancellable, dbus_display_add_client_ready, --=20 2.47.0