From nobody Sun Feb 8 18:24:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=miszr.win ARC-Seal: i=1; a=rsa-sha256; t=1738596529; cv=none; d=zohomail.com; s=zohoarc; b=mDNNHlF+SXILNB+rMBwVKrATtk3c6rzFZiUVWxGKHY1rrhSInAO4dkTPRrJx20+9atphBykj148Eo/HL3Xjpn7eFHxjBvuFJMn07FkbnoL1yu9DFc2iGCrGM8nJAPwoC5IzcJkN1F6/h4mKdnr0YARNWwJha49dOU6NU3ev3xSw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1738596529; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gUvwh0RgMZ3wKSGEks8B1WfeF+2/I/pFcs/U2KBAJ00=; b=k/cixbeof/UGPazFtbWIvE/DdpHhSBQvKFk2mmqDkZsZkcWzSMPmrkVBqcD1PzpawExoCE8emDw9Wf1aJjvqSPEX6t7iXvrHCHrpcZ7fAmscKnWLIsGtSgHjrAv+HNkfbvpV546yzu4QpEm1XI+rj1I8uTd2sZhYt/3C1iMtfyY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 173859652968085.68945232168824; Mon, 3 Feb 2025 07:28:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1texnL-0003yO-Ve; Mon, 03 Feb 2025 09:51:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1texnL-0003y1-1e for qemu-devel@nongnu.org; Mon, 03 Feb 2025 09:51:27 -0500 Received: from smtp.forwardemail.net ([149.28.215.223]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1texnJ-0003ev-Co for qemu-devel@nongnu.org; Mon, 03 Feb 2025 09:51:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=miszr.win; h=Content-Transfer-Encoding: MIME-Version: Message-ID: Date: Subject: Cc: To: From; q=dns/txt; s=fe-257304d8b2; t=1738594283; bh=gUvwh0RgMZ3wKSGEks8B1WfeF+2/I/pFcs/U2KBAJ00=; b=GulDCRrW3Gnjf0vRT9i3szFAOesslg+2owSlMOI90sVPxeBsVfvUlrmFcn3MaPyIGshThU7sa Y30uEy/EYpvGcKjX6SXKk9yBgYpZODyNx6cJyBicU4BIOlNb87OTqOJvuCRN76ogDCJ0ANdzFmw 25ExuMgDn2LQmvh/KpVi5sY= X-Forward-Email-ID: 67a0d7e9514bf110fcaeeda0 X-Forward-Email-Sender: rfc822; git@miszr.win, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 0.4.40 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net From: Mikael Szreder To: qemu-devel@nongnu.org Cc: Richard Henderson , Mark Cave-Ayland , Artyom Tarasenko , Mikael Szreder Subject: [PATCH] target/sparc: Fix gdbstub incorrectly handling registers f32-f62 Date: Mon, 3 Feb 2025 15:50:56 +0100 Message-ID: <20250203145056.83567-1-git@miszr.win> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=149.28.215.223; envelope-from=SRS0=d7fa=U3=miszr.win=git@fe-bounces.miszr.win; helo=smtp.forwardemail.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_FMBLA_NEWDOM=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @miszr.win) X-ZM-MESSAGEID: 1738596531315019100 Content-Type: text/plain; charset="utf-8" The gdbstub implementation for the Sparc architecture would incorectly calculate the the floating point register offset. This would cause register pairs(eg f32,f33) to point to the same value. Fixes: 30038fd81808 ("target-sparc: Change fpr representation to doubles.") Signed-off-by: Mikael Szreder --- target/sparc/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/sparc/gdbstub.c b/target/sparc/gdbstub.c index ec0036e9ef..5578fa9813 100644 --- a/target/sparc/gdbstub.c +++ b/target/sparc/gdbstub.c @@ -80,7 +80,7 @@ int sparc_cpu_gdb_read_register(CPUState *cs, GByteArray = *mem_buf, int n) } if (n < 80) { /* f32-f62 (double width, even numbers only) */ - return gdb_get_reg64(mem_buf, env->fpr[(n - 32) / 2].ll); + return gdb_get_reg64(mem_buf, env->fpr[(n - 64) + 16].ll); } switch (n) { case 80: @@ -174,7 +174,7 @@ int sparc_cpu_gdb_write_register(CPUState *cs, uint8_t = *mem_buf, int n) return 4; } else if (n < 80) { /* f32-f62 (double width, even numbers only) */ - env->fpr[(n - 32) / 2].ll =3D tmp; + env->fpr[(n - 64) + 16].ll =3D tmp; } else { switch (n) { case 80: --=20 2.48.1