From nobody Wed Apr 30 22:17:38 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1738538894; cv=pass;
d=zohomail.com; s=zohoarc;
b=VnQQifU/Y3bNRyKolBINb73XWEg9/ar0ALPY8R/nioc7+UzXIL1KbzCuSUap/IpTkYKVAz65qXPpCQC5+2S2RuqYGXm9DeXLa0pXdM1T3NjS9Ot1qDua0udsotoiHyqhATv5yfF4iRf2f4d7ANPa+5CxJ86xEgGZqPo+wvVbRyU=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1738538894;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=6DjPZf8D+M9Sq+CuG2Gf4zXOMQo/KjX9SAibJXB048w=;
b=npzue3a4AxsX2CViedhclV7KaMQ8jVWEkThcVfPGyPsD43Ns9dVUCrr91Prjp5xY7V/JBEsKr2ih7QAwH6Lr5pRMtrc+YA6PpOSo77ycIMJSjwWrqb+GYWYnfxw34Es0xs6FAS2kdBCDXpNCtJYsk3fVGl0PTPukHA4joL/Hu2o=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1738538894494625.4290623550477;
Sun, 2 Feb 2025 15:28:14 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tejNY-00039e-92; Sun, 02 Feb 2025 18:27:52 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1tejNH-0002pd-67
for qemu-devel@nongnu.org; Sun, 02 Feb 2025 18:27:37 -0500
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1tejNF-0003WS-HM
for qemu-devel@nongnu.org; Sun, 02 Feb 2025 18:27:34 -0500
Received: by mx.zohomail.com with SMTPS id 1738538833564205.93942228990113;
Sun, 2 Feb 2025 15:27:13 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1738538839; cv=none;
d=zohomail.com; s=zohoarc;
b=N2ptjFSQWwXe6UdC5KDFcJJh4eFo/OnRtnql+DpOhSMUI05LrnHU9+wiOFnxZBq+HqdXU25Rwaj8gm785sH+cHvQvdAy4SrJPNoSeFrMgljs2xxMckPYOWLZWVue1dEX9dKArt/deY6VRNUZ0GFs4GfD1rRjKKHw+u7OwUmvFvg=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1738538839;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=6DjPZf8D+M9Sq+CuG2Gf4zXOMQo/KjX9SAibJXB048w=;
b=NXEXrK0TrBqiNDi/ncGRKmMgQHIxX+XtHCy6VWOY364g5wGHwn0krdzR3XWLQ4EMCBcj3X9u7uRb4preo8EDp7FrRW27vMairz7AwwKnSghixbrH+PARxbuk9iKF2n3CujWkWVMdtVithumaAoz7sRwhTwSMFPfrFWY2llORzak=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1738538839;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=6DjPZf8D+M9Sq+CuG2Gf4zXOMQo/KjX9SAibJXB048w=;
b=NoNEuDPZP8aoI5PhUojKZj+peASS9McEScxRo3FIqODVm8jCdgESCKVRg69HwDMs
r6r3O+7y5fBlLtRCW3059dniOTiiLb3LqGu5vlHAaxE1Q//qxgOqtiVbSvqaL/rxj6d
26iqr1WdTJn22syKB8k2up5fioCj0A3teHPbqaGg=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v7 07/10] ui/gtk: Don't disable scanout when display is
refreshed
Date: Mon, 3 Feb 2025 02:21:33 +0300
Message-ID: <20250202232136.919342-8-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.47.1
In-Reply-To: <20250202232136.919342-1-dmitry.osipenko@collabora.com>
References: <20250202232136.919342-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1738538896802019000
Display refreshment is invoked by a timer and it erroneously disables
the active scanout if it happens to be invoked after scanout has been
enabled. This offending scanout-disable race condition with a timer
can be easily hit when Qemu runs with a disabled vsync by using SDL or
GTK displays (with vblank_mode=3D0 for GTK). Refreshment of display's
content shouldn't disable the active display. Fix it by keeping the
scanout's state unchanged when display is redrawn.
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
ui/gtk-egl.c | 1 -
ui/gtk-gl-area.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index f7a428c86a8d..0d1547d63ad0 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -179,7 +179,6 @@ void gd_egl_refresh(DisplayChangeListener *dcl)
=20
if (vc->gfx.glupdates) {
vc->gfx.glupdates =3D 0;
- gtk_egl_set_scanout_mode(vc, false);
gd_egl_draw(vc);
}
}
diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 2c9a0db42571..53d81124f211 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -148,7 +148,6 @@ void gd_gl_area_refresh(DisplayChangeListener *dcl)
=20
if (vc->gfx.glupdates) {
vc->gfx.glupdates =3D 0;
- gtk_gl_area_set_scanout_mode(vc, false);
gtk_gl_area_queue_render(GTK_GL_AREA(vc->gfx.drawing_area));
}
}
--=20
2.47.1