From nobody Wed Apr 30 20:35:50 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass(p=none dis=none) header.from=collabora.com
ARC-Seal: i=2; a=rsa-sha256; t=1738538873; cv=pass;
d=zohomail.com; s=zohoarc;
b=VAdbSK9uV04HTQTQZegwsxyPl/HU6Y1FuBXVjwlBvc9FNIlfkcBE6PMlOF1E10YYmhDnluj9TsYBU8rSCYfGyGou1WuuNnO6d/6YFvQuyYk97b97luYkJ69bIAPfv4/Z/G38CztWHUWjvBwCLoDdGnPs23tkGwy8kZwCAZ8c4es=
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1738538873;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=Zi6BoQxlao1TJ4aQcA8kMHKvU8tOxvFtOjXMBQoq0kQ=;
b=XR/iDZkdK73zWO+mbCysLo8DtDj/dAnJtuhrxQZWxE6iWlSv61zp59WvCfUwoW/LtOjd06TY25m4sLpZJt4rBnAYmTVDWH+HIJRj9K9O8BhXzhZe/XvvdWuTvZ7jOHCfT9wSxKrOF/EkPgoAi5KD73/hEAZiu/aQgFEobuwiS5c=
ARC-Authentication-Results: i=2; mx.zohomail.com;
dkim=pass header.i=dmitry.osipenko@collabora.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
arc=pass (i=1 dmarc=pass fromdomain=collabora.com);
dmarc=pass header.from=<dmitry.osipenko@collabora.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1738538873595462.08082942306635;
Sun, 2 Feb 2025 15:27:53 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tejMv-0002ej-Sf; Sun, 02 Feb 2025 18:27:14 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1tejMu-0002eJ-Ax
for qemu-devel@nongnu.org; Sun, 02 Feb 2025 18:27:12 -0500
Received: from sender4-pp-f112.zoho.com ([136.143.188.112])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)
id 1tejMr-0003V0-F9
for qemu-devel@nongnu.org; Sun, 02 Feb 2025 18:27:11 -0500
Received: by mx.zohomail.com with SMTPS id 1738538803619643.7315438814163;
Sun, 2 Feb 2025 15:26:43 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1738538815; cv=none;
d=zohomail.com; s=zohoarc;
b=RC8TrPCxkCWI4RoyikjJcyAL/V7Ay7U90OyBPkOzI1ByafvYHXGvcHuQC4+sMmgbBAttJcnR+VypEviAmnkLGaX/4yjzg5P3+Z5PtJQnpNr9WmExuCfNrSUUYKwIp7gcvXKI1ZyULOdnNtPHKktfhC826+hEO+a7U3tvsu8e27g=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc; t=1738538815;
h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
bh=Zi6BoQxlao1TJ4aQcA8kMHKvU8tOxvFtOjXMBQoq0kQ=;
b=KAzeeKBMBZPwukmxT8KTWU8HwfSGMsDSpadgJ9hkFfl00kSBI5Zp+0j9Pl2mqUg30ChS0hMUzGLhQzxlnpc5DNAqjow6D6bx1exm9cSL8lVfBLn6uQuofp71+kvOYCkOheN1oOuTYH3/R5q6ATjDP7eAUWixX3nkgd9BwyTfFn8=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=collabora.com;
spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;
dmarc=pass header.from=<dmitry.osipenko@collabora.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1738538815;
s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;
h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
bh=Zi6BoQxlao1TJ4aQcA8kMHKvU8tOxvFtOjXMBQoq0kQ=;
b=NU1RL/D2iu6Ywdr9UTTYa+osa7o7yhIcC0bl81VR4oHWBHkwWcicE7/s4TOJlx2E
dytRxCzFb3uNI68liQUhCu8iDZNgxiMr/UzuYh5GKH29tgY2Z7K34EbzHk7fNLvdMlk
ih9+ycaiDWVdJ6X7ZlRNYitfJzhW3gU2HoxUAsJ0=
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, Huang Rui <ray.huang@amd.com>,
=?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,
Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,
=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
Alex Deucher <alexander.deucher@amd.com>,
Stefano Stabellini <stefano.stabellini@amd.com>,
=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,
Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,
Yiwei Zhang <zzyiwei@chromium.org>, Sergio Lopez Pascual <slp@redhat.com>
Subject: [PATCH v7 03/10] virtio-gpu: Handle virgl fence creation errors
Date: Mon, 3 Feb 2025 02:21:29 +0300
Message-ID: <20250202232136.919342-4-dmitry.osipenko@collabora.com>
X-Mailer: git-send-email 2.47.1
In-Reply-To: <20250202232136.919342-1-dmitry.osipenko@collabora.com>
References: <20250202232136.919342-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=136.143.188.112;
envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com)
X-ZM-MESSAGEID: 1738538874976019000
Print out error messages when virgl fence creation fails to aid debugging
of the fence-related bugs.
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
hw/display/virtio-gpu-virgl.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c
index 145a0b387956..2eb6aaab4e84 100644
--- a/hw/display/virtio-gpu-virgl.c
+++ b/hw/display/virtio-gpu-virgl.c
@@ -872,6 +872,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
struct virtio_gpu_ctrl_command *cmd)
{
bool cmd_suspended =3D false;
+ int ret;
=20
VIRTIO_GPU_FILL_CMD(cmd->cmd_hdr);
=20
@@ -970,7 +971,17 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
}
=20
trace_virtio_gpu_fence_ctrl(cmd->cmd_hdr.fence_id, cmd->cmd_hdr.type);
- virgl_renderer_create_fence(cmd->cmd_hdr.fence_id, cmd->cmd_hdr.type);
+
+ /*
+ * Unlike other virglrenderer functions, this one returns a positive
+ * error code.
+ */
+ ret =3D virgl_renderer_create_fence(cmd->cmd_hdr.fence_id, 0);
+ if (ret) {
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "%s: virgl_renderer_create_fence error: %s",
+ __func__, strerror(ret));
+ }
}
=20
static void virgl_write_fence(void *opaque, uint32_t fence)
--=20
2.47.1